| zigo | stephenfin: Here's my 2 patches for py3.13 : | 11:02 |
|---|---|---|
| zigo | https://salsa.debian.org/openstack-team/libs/python-openstacksdk/-/tree/debian/flamingo/debian/patches?ref_type=heads | 11:02 |
| zigo | Should I push them to gerrit then? | 11:02 |
| zigo | *3.14 I mean | 11:56 |
| stephenfin | zigo: yes please | 15:47 |
| croelandt | Hello! I see upload_image() is marked as deprecated in the SDK and that I should switch to using "create_image". I'm not sure I can use create_image to upload data to an existing image though | 15:50 |
| croelandt | Also I could use the import workflow, but I'd like for the data upload to work in an env where that is not configured | 15:50 |
| croelandt | Any idea? | 15:50 |
| stephenfin | croelandt: the issue with that method was that it was doing too much: it should have only been handling the upload step of the legacy flow but it was instead doing create (which afaik is also part of the image import flow) + upload | 15:54 |
| stephenfin | mrjoshi was working on it in the past but never got to the bottom of it https://review.opendev.org/c/openstack/openstacksdk/+/881939 | 15:54 |
| stephenfin | I still think that's the correct path to take but someone needs to pick it up again | 15:55 |
| croelandt | OK, I see she's answered comments by Artem, Maxim and yourself and then uploaded a patchset that passes the CI. Do you know whether there is something specific to change from patchset #21? | 15:56 |
| stephenfin | croelandt: It's a really hard patch to review, and I struggle each time I've to try. I think it needs to be broken up to reviewable and mergeable, if I'm being honest :( | 15:58 |
| stephenfin | For example, this could be a separate patch https://review.opendev.org/c/openstack/openstacksdk/+/881939/21/openstack/image/v2/image.py | 15:59 |
| stephenfin | I also think we'd benefit from a precursor patch that tests calling upload_image with arguments in various forms | 16:00 |
| stephenfin | e.g. upload_image('ami', None) | 16:00 |
| stephenfin | upload_image('ami', disk_format=None) | 16:00 |
| stephenfin | upload_image(container_format='ami', disk_format=None) | 16:00 |
| stephenfin | etc. etc. That would give us confidence that the code to handle the old deprecated signature works as intended and we don't break users | 16:01 |
| stephenfin | croelandt: You and I have reason to be cautious around this code too: we have made mistakes here in the recent past 😅 https://review.opendev.org/c/openstack/openstacksdk/+/910218 https://review.opendev.org/c/openstack/openstacksdk/+/960136 | 16:03 |
| croelandt | yes, this is all fairly complex | 16:04 |
| croelandt | but ok now I got an idea of what is needed to move forward | 16:05 |
| croelandt | great, thanks! | 16:05 |
| stephenfin | nw, let me know when it's good to go and I'll give it a run through 🫡 | 16:06 |
| croelandt | stephenfin: so (provided I can make this work) we'd be undeprecating upload_image? | 16:10 |
| stephenfin | yes | 16:10 |
| stephenfin | but it would be refocused purely on the legacy image upload flow | 16:11 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Implement conflict resolution https://review.opendev.org/c/openstack/python-openstackclient/+/968178 | 16:12 |
| stephenfin | fwiw I'd also like to do the same in `create_image` but I think that ship has sailed... | 16:13 |
| croelandt | does create_image do two things? | 16:14 |
| stephenfin | create_image does about 5 things | 16:14 |
| stephenfin | 😅 | 16:15 |
| croelandt | oh yeah you can have create_image(..., data='stuff') so it creates the image and uploads data to it | 16:15 |
| stephenfin | yup | 16:15 |
| stephenfin | I get why it does that but I'd much rather people manually chose between the two flows | 16:15 |
| croelandt | indeed | 16:17 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: image: Deprecate rewriting of is_public property https://review.opendev.org/c/openstack/openstacksdk/+/969964 | 16:29 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: image: Move some code around https://review.opendev.org/c/openstack/openstacksdk/+/969965 | 16:29 |
| opendevreview | cid proposed openstack/openstacksdk master: Add Node.instance_name support https://review.opendev.org/c/openstack/openstacksdk/+/955103 | 19:30 |
| opendevreview | cid proposed openstack/openstacksdk master: Add Node.instance_name support https://review.opendev.org/c/openstack/openstacksdk/+/955103 | 21:09 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!