| opendevreview | Jan-Philipp Litza proposed openstack/ansible-collections-openstack master: fix(trunk): Always add relevant sub_ports https://review.opendev.org/c/openstack/ansible-collections-openstack/+/971005 | 09:00 |
|---|---|---|
| opendevreview | Jan-Philipp Litza proposed openstack/ansible-collections-openstack master: fix(trunk): Always add relevant sub_ports https://review.opendev.org/c/openstack/ansible-collections-openstack/+/971005 | 09:02 |
| stephenfin | gtema: Could you hit https://review.opendev.org/c/openstack/releases/+/970623 and https://review.opendev.org/c/openstack/releases/+/970843 when you have a moment? | 11:16 |
| gtema | Stephenfin, you are release liaison, so my review is not technically required. Anyway I left my vote on both | 11:31 |
| stephenfin | oh yeah | 11:32 |
| stephenfin | 😅 | 11:32 |
| stephenfin | well thank you in any case :) | 11:32 |
| gtema | Wlcm | 11:33 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: typing: Fixups for typed osc-lib https://review.opendev.org/c/openstack/python-openstackclient/+/970683 | 11:39 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Run mypy from tox https://review.opendev.org/c/openstack/python-openstackclient/+/970684 | 11:39 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: identity: Use plural dest for append opts https://review.opendev.org/c/openstack/python-openstackclient/+/971023 | 11:39 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: taas: Use custom command classes https://review.opendev.org/c/openstack/python-openstackclient/+/971024 | 11:39 |
| opendevreview | Patrick Pfurtscheller proposed openstack/ansible-collections-openstack master: feat: add compute service module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/971040 | 13:14 |
| *** ralonsoh_ is now known as ralonsoh | 13:43 | |
| opendevreview | Patrick Pfurtscheller proposed openstack/ansible-collections-openstack master: feat: add compute service module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/971040 | 16:06 |
| opendevreview | Doug Goldstein proposed openstack/python-openstackclient master: fix(keystone): correct the args submitted on user creation https://review.opendev.org/c/openstack/python-openstackclient/+/971084 | 16:23 |
| cardoe | stephenfin: we conflict on ^ for your osc-lib change just fyi. | 16:25 |
| croelandt | I think the endpoint types in the SDK can be 'public', 'internal' or 'admin'. In the original clients, we had 'publicURL', 'adminURL', 'internalURL'. Am I right? I'm asking because I'm trying to replace uses of glanceclient with the SDK | 16:47 |
| stephenfin | cardoe: that's fine: bug fix takes priority | 17:08 |
| stephenfin | fwiw, I really dislike that aspect of keystone's API | 17:09 |
| cardoe | which part? | 17:13 |
| stephenfin | the non-nullability | 17:19 |
| stephenfin | For POST requests, that is | 17:20 |
| stephenfin | croelandt: tkajinam just did some oslo.limit work on this same thing | 17:26 |
| stephenfin | croelandt: Yes, SDK expects one of public, internal or admin. This is the same as what keystone v3 expects. The URL suffixed variants were a v2.0 API thing | 17:29 |
| stephenfin | https://docs.openstack.org/api-ref/identity/v3/#create-endpoint | 17:29 |
| stephenfin | gtema: can keep me honest though | 17:29 |
| stephenfin | this is also reflected in keystone code itself https://github.com/openstack/keystone/blob/bd178ee91f92f50398cf940b1db3eb2157ed7fd3/keystone/catalog/backends/base.py#L212-L267 | 17:30 |
| gtema | well, interface is an enum and checked by the jsonschema | 17:35 |
| gtema | moreover the db table column is only 8 chars wide | 17:36 |
| stephenfin | ack, so yeah, croelandt: you want the non-suffixed versions | 17:38 |
| tkajinam | https://github.com/openstack/keystoneauth/blob/0e3863577ac153ef02afaac364daf2c967a092f1/keystoneauth1/access/service_catalog.py#L632-L635 | 18:05 |
| tkajinam | afaik keystoneauth has been taken care of the conversion (It removes the URL suffix to accept v2 values for v3) but that's just a hack and we should prefer the ones without URL suffix, I agree | 18:06 |
| tkajinam | (just leaving this note hoping it is kept in logs for future reference | 18:06 |
| croelandt | stephenfin: ok I think somehow the suffixed versions were still the default when configuring some apps, so I'm gonna have to be careful there | 18:14 |
| opendevreview | Merged openstack/python-openstackclient master: identity: Use plural dest for append opts https://review.opendev.org/c/openstack/python-openstackclient/+/971023 | 18:51 |
| opendevreview | Merged openstack/python-openstackclient master: fix(keystone): correct the args submitted on user creation https://review.opendev.org/c/openstack/python-openstackclient/+/971084 | 19:56 |
| opendevreview | Doug Goldstein proposed openstack/python-openstackclient stable/2025.2: fix(keystone): correct the args submitted on user creation https://review.opendev.org/c/openstack/python-openstackclient/+/971125 | 20:33 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!