| opendevreview | James Hewitt proposed openstack/ansible-collections-openstack master: Only clear out security groups if the parameter is set https://review.opendev.org/c/openstack/ansible-collections-openstack/+/972247 | 00:27 |
|---|---|---|
| opendevreview | James Hewitt proposed openstack/ansible-collections-openstack master: Only clear out security groups if the parameter is set https://review.opendev.org/c/openstack/ansible-collections-openstack/+/972247 | 09:49 |
| stephenfin | gtema: Would appreciate your thoughts on https://review.opendev.org/c/openstack/openstacksdk/+/972237 at some point, just because you're more familiar with that stuff than I am | 10:40 |
| opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient stable/2025.1: Set NEUTRON_DEPLOY_MOD_WSGI to true for func jobs https://review.opendev.org/c/openstack/python-openstackclient/+/972272 | 11:21 |
| opendevreview | James Hewitt proposed openstack/ansible-collections-openstack master: Only clear out security groups if the parameter is set https://review.opendev.org/c/openstack/ansible-collections-openstack/+/972247 | 12:52 |
| opendevreview | Merged openstack/openstacksdk master: Do not use the global Prometheus collector registry https://review.opendev.org/c/openstack/openstacksdk/+/972237 | 14:15 |
| Callum027 | stephenfin: Thanks for reviewing 972237. Do you think it would be worth backporting to supported releases? IIRC the person who reported it is running 2024.1 so they would still be experiencing it even if they upgraded to 2025.1 | 18:34 |
| opendevreview | James Hewitt proposed openstack/ansible-collections-openstack master: Only clear out security groups if the parameter is set https://review.opendev.org/c/openstack/ansible-collections-openstack/+/972247 | 18:39 |
| opendevreview | James Hewitt proposed openstack/ansible-collections-openstack master: Only clear out security groups if the parameter is set https://review.opendev.org/c/openstack/ansible-collections-openstack/+/972247 | 18:41 |
| M0weng[m] | croelandt: croelandt: python-openstackclient has unit and functional tests, not sure if that would fit what you are looking for? | 19:03 |
| croelandt | M0weng[m]: I need to remember what I asked :D | 19:16 |
| M0weng[m] | :) | 19:16 |
| M0weng[m] | > Do you know of projects that use the SDK and run tests? Whenever I try to test something that involves the SDK, I end up pulling... basically everything and have to deal with failure in authentication, the SDK trying to discover all possible services etc. | 19:17 |
| M0weng[m] | > There must be an easy way to say "hey, here, this is a fake SDK/Auth/whatever" | 19:17 |
| M0weng[m] | > But I'm not aware of it | 19:17 |
| croelandt | yeah so I could always copy what the openstackclient does | 19:17 |
| croelandt | I just wish there were some kind of "fake SDK":D | 19:18 |
| croelandt | also I'm bad at testing | 19:18 |
| croelandt | and especially in OpenStack I always feel like I'm drowning in mocks/fixtures/fake stuff and not really testing real code :D | 19:18 |
| M0weng[m] | Yep I get that feeling too, there are so many fakes | 19:22 |
| M0weng[m] | The openstackclient unit tests do use fakes instead of the actual SDK I believe, for example see openstackclient/tests/unit/identity/v3/test_user.py | 19:26 |
| M0weng[m] | They are imported from openstack.test.fakes | 19:27 |
| croelandt | oh you can generate fake resources | 19:31 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | 21:33 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | 21:39 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | 22:57 |
| opendevreview | Ivan Anfimov proposed openstack/keystoneauth master: Remove tags from README https://review.opendev.org/c/openstack/keystoneauth/+/972415 | 23:07 |
| opendevreview | Ivan Anfimov proposed openstack/keystoneauth master: Remove tags from README https://review.opendev.org/c/openstack/keystoneauth/+/972415 | 23:09 |
| opendevreview | Ivan Anfimov proposed openstack/keystoneauth master: Remove tags from README https://review.opendev.org/c/openstack/keystoneauth/+/972415 | 23:42 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!