| opendevreview | Kyuyeong Lee proposed openstack/python-openstackclient master: Network: Show ip_availability_details in ip availability https://review.opendev.org/c/openstack/python-openstackclient/+/1000685 | 02:28 |
|---|---|---|
| opendevreview | Kyuyeong Lee proposed openstack/openstacksdk master: Network: Add ip_availability_details field https://review.opendev.org/c/openstack/openstacksdk/+/1000682 | 02:29 |
| opendevreview | yatin proposed openstack/openstacksdk master: [DNS] Increase the zones quota before creating a new one - v2 https://review.opendev.org/c/openstack/openstacksdk/+/1000933 | 06:51 |
| opendevreview | Artem Goncharov proposed openstack/codegenerator master: fix(rust_tui): delegate ConfirmableRequest through aggregate enums https://review.opendev.org/c/openstack/codegenerator/+/1000728 | 08:48 |
| opendevreview | Artem Goncharov proposed openstack/codegenerator master: fix(rust_tui): delegate ConfirmableRequest through aggregate enums https://review.opendev.org/c/openstack/codegenerator/+/1000728 | 09:42 |
| opendevreview | yatin proposed openstack/openstacksdk master: [DNS] Increase the zones quota before creating a new one - v2 https://review.opendev.org/c/openstack/openstacksdk/+/1000933 | 10:40 |
| opendevreview | Merged openstack/codegenerator master: fix(rust_tui): delegate ConfirmableRequest through aggregate enums https://review.opendev.org/c/openstack/codegenerator/+/1000728 | 13:20 |
| opendevreview | Artem Goncharov proposed openstack/codegenerator master: fix(rust-cli): Group kind-suffix response candidates by microversion https://review.opendev.org/c/openstack/codegenerator/+/1000872 | 13:26 |
| opendevreview | Artem Goncharov proposed openstack/codegenerator master: feat(rust-tui): support editor template for update operations https://review.opendev.org/c/openstack/codegenerator/+/1000885 | 13:26 |
| opendevreview | Artem Goncharov proposed openstack/codegenerator master: fix(rust-cli,rust-tui): dispatch response schema by resolved (not floor-only) microversion https://review.opendev.org/c/openstack/codegenerator/+/1000881 | 13:27 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Simplify ruff configuration https://review.opendev.org/c/openstack/openstacksdk/+/1000827 | 13:34 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Enable G, LOG ruff rules https://review.opendev.org/c/openstack/openstacksdk/+/1000828 | 13:34 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Drop setup.py, setup.cfg https://review.opendev.org/c/openstack/openstacksdk/+/1000825 | 13:34 |
| stephenfin | melwitt: Thanks, Mel. I've re-reviewed that and left a few (hopefully final) comments | 13:53 |
| stephenfin | cardoe: Yup, they're both on my list. I've started on the gophercloud one already, but will likely try merge the ksa one first. It'll be next week at least though | 13:54 |
| cardoe | stephenfin: I wanted your feedback on how we can provide a cache interface (or if we should) | 15:07 |
| cardoe | My thought was a OSC plugin that provided that interface to ksa and used the keyring library for example and then the tokens aren't cached on disk. | 15:08 |
| cardoe | We can do the cache interface as a follow on. | 15:08 |
| opendevreview | Merged openstack/codegenerator master: fix(rust-cli): Group kind-suffix response candidates by microversion https://review.opendev.org/c/openstack/codegenerator/+/1000872 | 15:44 |
| opendevreview | Merged openstack/codegenerator master: fix(rust-cli,rust-tui): dispatch response schema by resolved (not floor-only) microversion https://review.opendev.org/c/openstack/codegenerator/+/1000881 | 15:44 |
| stephenfin | cardoe: I think openstacksdk already supports caching of tokens? Or do you mean something else? | 16:11 |
| cardoe | This is something else. | 16:11 |
| cardoe | So we you are using federation, we need to mint an unscoped token for the keystone shadow user that represents your federated user. Then we use that unscoped token to scope into the project or domain or whatever you're trying to work with. | 16:13 |
| cardoe | Retrieving that unscoped token involves round-tripping the web browser. | 16:13 |
| cardoe | So we cache that unscoped token on disk with an expiration lifetime. Once that expiration is hit we delete it. | 16:14 |
| stephenfin | Gotcha | 16:14 |
| cardoe | Otherwise every invocation of the "openstack" CLI would involve opening the web browser | 16:14 |
| stephenfin | yeah, which is the issue with e.g. the totp flow at the moment, iirc | 16:15 |
| cardoe | Our internal implementation has made some modifications to allow a client (python-openstackclient for example) to provide a tokencache interface | 16:15 |
| stephenfin | I've a feeling I've mentioned this on a review somewhere (maybe your old websso patch?) but this kind of caching is something I think should live in the application (OSC) here, with only hooks in the lib where needed | 16:15 |
| cardoe | Yes you did. | 16:16 |
| cardoe | And that's what I'm wanting to discuss with you. A design for this. | 16:16 |
| stephenfin | aha, understood | 16:16 |
| cardoe | Our tokencache has a .get(cache_id) and a .set(cache_id, token) and a .delete(cache_id) | 16:16 |
| cardoe | And I'm using https://pypi.org/project/keyring/ | 16:17 |
| stephenfin | That broadly matches what I know from keyring | 16:17 |
| stephenfin | jinx 😅 | 16:17 |
| cardoe | The proper way to do it I see involves touching ksa and python-openstackclient and maybe more. | 16:17 |
| cardoe | We've also got "openstack cloud [current,list,set,show,unset,use]" commands | 16:19 |
| cardoe | Not sure if you ever heard of https://github.com/major/supernova | 16:20 |
| * stephenfin clicks | 16:20 | |
| stephenfin | I have not | 16:21 |
| stephenfin | Is that still relevant with cloud files/OS_CLOUD? | 16:21 |
| cardoe | No | 16:22 |
| cardoe | But it was something Rackspace did before that existed. | 16:22 |
| cardoe | We started a replacement that was OSC based forever ago as well. | 16:22 |
| cardoe | So the websso implementation is coming from that code base. | 16:24 |
| stephenfin | And I guess this is relevant because the caching ties into the model for those "clouds"? | 16:24 |
| cardoe | yeah | 16:25 |
| cardoe | I'm happy to show you sometime if that'd be easier. | 16:25 |
| cardoe | I've got ~30 entries in my clouds.yaml | 16:26 |
| cardoe | I've also "fixed" one of the reasons that system scope and project scope token usage failed. Which was that it was annoying to have two OS_CLOUD representations and have to switch between the two for different operations. | 16:29 |
| cardoe | Unfortunately it breaks compat with stock OSC. | 16:30 |
| cardoe | But that'd be another place I'd love to get your feedback on how I could do this in an upstreamable way. | 16:30 |
| cardoe | Whatever I change, I'm more than happy to contribute the same changes to gophercloud as well. | 16:31 |
| cardoe | Of course I realize I'm getting a bit ahead of myself here. | 16:34 |
| cardoe | So happy to just get the websso stuff done. :) | 16:34 |
| stephenfin | All sounds good. That would be interesting to see | 16:34 |
| stephenfin | But yeah, going back to the websso stuff: if we could get it in without the caching first, that would simplify the change greatly I suspect | 16:35 |
| stephenfin | Then for the caching, I would normally suggest a spec, but we don't do those in SDK. So instead, how about we get a user doc that describes how to use the caching, which we can then use to inform the code? | 16:36 |
| stephenfin | I suspect how it "feels" is more important than the code, particularly given the different types of application we've to content with (file-based caching is far more important for short-lived processes like OSC than for long-lived ones like nova, while I guess threading is a concern for the latter but not the former) | 16:38 |
| stephenfin | ...and, you know, the fact code is now cheap 😅 | 16:40 |
| opendevreview | Artem Goncharov proposed openstack/codegenerator master: fix(openapi): safely handle schemas missing 'type' field https://review.opendev.org/c/openstack/codegenerator/+/1000983 | 16:49 |
| opendevreview | Merged openstack/codegenerator master: fix(openapi): safely handle schemas missing 'type' field https://review.opendev.org/c/openstack/codegenerator/+/1000983 | 18:06 |
| opendevreview | melanie witt proposed openstack/openstacksdk master: Add functional tests and Zuul job for accelerator (Cyborg) https://review.opendev.org/c/openstack/openstacksdk/+/995851 | 18:51 |
| opendevreview | melanie witt proposed openstack/openstacksdk master: Add AGENTS.md and document functional test conventions https://review.opendev.org/c/openstack/openstacksdk/+/1000999 | 18:51 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!