| opendevreview | Kyuyeong Lee proposed openstack/python-openstackclient master: Network: Simplify ip_availability_details access https://review.opendev.org/c/openstack/python-openstackclient/+/1002713 | 00:18 |
|---|---|---|
| cardoe | stephenfin: can you workflow the patch? | 12:04 |
| stephenfin | cardoe: done. I'm off today but if you're able to propose a openstack/releases patch once your patch and TheJulia's patch have landed, I'll check in later today and +1 that also | 13:42 |
| cardoe | I will do so. | 13:43 |
| cardoe | I can review TheJulia's patch as well. | 13:43 |
| cardoe | Maybe in a cycle or two I'll propose myself as a reviewer. :-D | 13:43 |
| cardoe | stephenfin: enjoy the weekend | 13:44 |
| opendevreview | Merged openstack/keystoneauth master: Add a v3websso authentication plugin https://review.opendev.org/c/openstack/keystoneauth/+/1000759 | 14:42 |
| opendevreview | Merged openstack/keystoneauth master: Add minimum tls version and caller cipher controls https://review.opendev.org/c/openstack/keystoneauth/+/988544 | 15:13 |
| opendevreview | Merged openstack/python-openstackclient master: Network: Simplify ip_availability_details access https://review.opendev.org/c/openstack/python-openstackclient/+/1002713 | 15:18 |
| opendevreview | Merged openstack/openstacksdk master: Add a way to discard the authentication cached for a cloud https://review.opendev.org/c/openstack/openstacksdk/+/1001431 | 15:22 |
| opendevreview | Merged openstack/python-openstackclient master: Add a "cloud cache delete" command https://review.opendev.org/c/openstack/python-openstackclient/+/1001433 | 15:22 |
| opendevreview | Silvia Wachira proposed openstack/python-openstackclient master: share: Add functional tests https://review.opendev.org/c/openstack/python-openstackclient/+/994970 | 18:40 |
| opendevreview | Oria Weng proposed openstack/python-openstackclient master: Migrate 'endpoint group' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/1001447 | 21:01 |
| rm_work | opendevreview: just noticed this -- doesn't this do the opposite of what we'd want with the specific example of the websso plugin cardoe ? | 23:00 |
| rm_work | stephenfin: with the openstack in-tree stuff merging, are we closer to getting gophercloud moving? and do I need to make any adjustments on my PRs? I've done the maximum due diligence I can on those I think, TBH I do not really do Golang so they are 99% AI code really, all I could do is look at the patterns and guide it a bit <_< | 23:02 |
| cardoe | rm_work: what do you mean? | 23:08 |
| rm_work | so the issue I was raising with the re-use of the entrypoint was that if you had the old out-of-tree websso plugin installed, AND the one you are merging into keystoneauth directly, it was unclear which would load | 23:11 |
| cardoe | It prefers out of tree plugins. | 23:12 |
| rm_work | with that patch, it will DEFINITELY load the old out-of-tree plugin, which is going to be deprecated and almost certainly not the one we'd want loaded | 23:12 |
| rm_work | right | 23:12 |
| rm_work | that's bad | 23:12 |
| rm_work | in our case at least for websso | 23:12 |
| cardoe | The point was that vexxhost wants to continue to use theirs. | 23:12 |
| rm_work | ok, so then ... if the out-of-tree plugin is installed in an old env, it'll (quietly?) take over | 23:13 |
| rm_work | or will it be noisy, that would at least be good | 23:13 |
| cardoe | And in the other patch it was decided that people should be able to overload in-tree versions with out of tree. | 23:13 |
| rm_work | I guess in my case I can try to remember to make sure I remove it from my own envs, but i forsee getting support requests if it ever breaks and being very confused until I realize people still have the old one | 23:14 |
| cardoe | It’s not making any noise but we could probably do that. | 23:14 |
| rm_work | yeah the entire basis of my comments about that since the beginning has been "some people might load up the old out-of-tree plugin and that would be bad" | 23:14 |
| rm_work | so this just seems like it was "solved" by doing the opposite of what I was hoping, lol | 23:15 |
| rm_work | but I do get the point about overriding | 23:15 |
| rm_work | it just almost makes me think we SHOULDN'T have re-used the entrypoint | 23:15 |
| cardoe | Well the rule for the in-tree ones is a specific name matching the keystone side. | 23:22 |
| cardoe | Eh it helps me out cause my Python 3.10 people which is apparently what WSL has works with the same config. | 23:24 |
| rm_work | alright, my concern is ... well, i've said my piece | 23:25 |
| rm_work | i won't block on it | 23:25 |
| rm_work | happy to just have it done now | 23:26 |
| cardoe | I agree with you. I want to get my users off the out of tree as soon as I can. | 23:36 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!