| opendevreview | Merged openstack/openstacksdk master: connect_as: don't let OS_* vars override project https://review.opendev.org/c/openstack/openstacksdk/+/1009232 | 01:29 |
|---|---|---|
| deydra | Hello everyone, I recently merged a fix in python-openstackclient, including backports to stable/2026.2 and stable/2026.1: https://review.opendev.org/q/Iedf8aca33e87078557daa8de1dd7591d42a2d37a Is there already a maintenance release planned (specifically) for stable/2026.2, or if it would be possible to propose one soon to include this fix? Thanks! | 06:34 |
| opendevreview | Merged openstack/openstacksdk master: config: Pass status code retry options to adapter https://review.opendev.org/c/openstack/openstacksdk/+/1011585 | 11:28 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Accept Adapters in discover https://review.opendev.org/c/openstack/keystoneauth/+/1011642 | 12:25 |
| opendevreview | Stephen Finucane proposed openstack/cliff master: Remove setup.cfg, setup.py https://review.opendev.org/c/openstack/cliff/+/1010704 | 14:02 |
| opendevreview | Ade Lee proposed openstack/openstacksdk master: Fix Barbican key-manager microversion negotiation https://review.opendev.org/c/openstack/openstacksdk/+/1011547 | 14:17 |
| opendevreview | Ade Lee proposed openstack/openstacksdk master: Add Barbican secret store migrate helper https://review.opendev.org/c/openstack/openstacksdk/+/1002400 | 14:17 |
| opendevreview | Merged openstack/cliff master: Gracefully handle metadata https://review.opendev.org/c/openstack/cliff/+/1003514 | 14:19 |
| melwitt | stephenfin: super trivial OSC docs thing https://review.opendev.org/c/openstack/python-openstackclient/+/1011354 | 14:55 |
| stephenfin | doh. Done | 14:56 |
| stephenfin | melwitt: I assume sean-k-mooney has already mentioned the absence of a `doc/source/cli/command-objects/accelerator` directory to you? (we discussed it offline last week) | 14:57 |
| stephenfin | it appears so https://review.opendev.org/c/openstack/python-openstackclient/+/1011357 :) | 14:59 |
| melwitt | stephenfin: yes! I have that patch stacked on top of the API version one. I'm currently poking around a devstack after your comment heh | 15:00 |
| melwitt | it looks like indeed openstacksdk is already negotiating the latest API version but yet it seemed to not be the case when func tests ran in CI ... so I think I must not understanding something somewhere. still investigating | 15:03 |
| sean-k-mooney | o/ | 15:04 |
| sean-k-mooney | is ^ related to cyborg? | 15:04 |
| stephenfin | melwitt: I assumed the failues were because the Device resource was missing the `_max_microversion` field? | 15:04 |
| stephenfin | sean-k-mooney: yarp | 15:04 |
| sean-k-mooney | so i had to fix microversion in cyborg last cycle because they were entirly broken | 15:05 |
| melwitt | stephenfin: ohhh ... I dunno. I mean, why/how could it work installed in a devstack locally but then not work in upstream func test job if that's the case? | 15:05 |
| sean-k-mooney | https://github.com/openstack/cyborg/commit/7faf80e098f189e6220ccbe5bfc9d179f482fa76 | 15:06 |
| melwitt | I could also be totally wrong and remembering it wrong | 15:06 |
| sean-k-mooney | well not entirly but they were not conforment to the spec | 15:06 |
| stephenfin | yeah, that bit's the suprising bit. Have you a link to a failing build? | 15:06 |
| melwitt | not to hand. there might be a failed build somewhere in the history of the command migration patches that may have showed it. I'll look around | 15:07 |
| sean-k-mooney | is this in relateion to a particly patch | 15:07 |
| sean-k-mooney | i can take a look as well | 15:07 |
| stephenfin | sean-k-mooney: https://review.opendev.org/c/openstack/python-openstackclient/+/1011568 | 15:07 |
| stephenfin | though I think melwitt has it in hand. It's an SDK/OSC interaction thing as opposed to something cyborg specific we think | 15:08 |
| sean-k-mooney | i think i have a deployment with cyborg i can test that on one sec | 15:08 |
| stephenfin | sean-k-mooney: before you do, see my comments on same | 15:08 |
| sean-k-mooney | ah | 15:09 |
| sean-k-mooney | i see | 15:09 |
| sean-k-mooney | yes that is plasuaible | 15:10 |
| stephenfin | cardoe: jfyi I left some comments on https://review.opendev.org/c/openstack/openstacksdk/+/1011547/ so Ade has respun. I'm holding off +W'ing in case you want to take another spin through it | 15:10 |
| sean-k-mooney | melwitt: i assuem you dont have teh max api version set in your clouds.yaml or openrc | 15:10 |
| sean-k-mooney | i dont think the cybrog plugin does that but good to check in yoru devstack | 15:10 |
| melwitt | ohhhh I do have it set | 15:11 |
| stephenfin | yeah, that'd do it :) | 15:11 |
| melwitt | that must be why. argh I don't remember doing that sorry | 15:11 |
| sean-k-mooney | ok i jsut checked my devstack and they are not set by default | 15:12 |
| melwitt | ok ok. good. but yeah, I am working on this bc I was going through cyborgclient plugin <=> OSC parity and realizing that is missing still while i was working on making the docs work | 15:12 |
| melwitt | thanks sean-k-mooney you saved me a lot of time haha | 15:13 |
| sean-k-mooney | i just went throught the list of things that bit me in the past | 15:13 |
| sean-k-mooney | and it happend to be the first one | 15:13 |
| melwitt | :D | 15:14 |
| melwitt | stephenfin: ok, so what is the right way to bump the version if we want to do it for all resources under cyborg, not only Device? | 15:28 |
| melwitt | unless it's to set _max_microversion on all of them separately. I assumed that would not be the way | 15:30 |
| stephenfin | the expectation is that each Resource gets _max_microversion set to the latest version that changed something about that resource | 15:31 |
| stephenfin | is there a reason you want to use >= 2.0 for resources != Device? | 15:32 |
| melwitt | ok, I see | 15:32 |
| stephenfin | err, > 2.0 | 15:32 |
| melwitt | yes for device profile we have some capability under 2.2 for handling both name and uuid | 15:33 |
| stephenfin | right, so DeviceProfile would get 2.2 | 15:33 |
| melwitt | so I would just set that one to 2.2 according to this pattern | 15:33 |
| stephenfin | yeah | 15:34 |
| melwitt | ok got it | 15:34 |
| stephenfin | This should be documented. If it's not done, I'd be happy to review some (brief, if LLM-written) contributor docs on same | 15:38 |
| stephenfin | Only if you want to, obviously 🤷 | 15:38 |
| melwitt | sure. sorry if I missed the doc | 15:38 |
| opendevreview | Merged openstack/cliff master: Move dependencies to pyproject.toml https://review.opendev.org/c/openstack/cliff/+/1010701 | 15:51 |
| opendevreview | Merged openstack/cliff master: Add release notes build https://review.opendev.org/c/openstack/cliff/+/1010702 | 15:51 |
| opendevreview | Merged openstack/cliff master: Add ShowOneWithDetails for field-oriented tables https://review.opendev.org/c/openstack/cliff/+/1010703 | 15:55 |
| opendevreview | Merged openstack/python-openstackclient master: Fix the block storage v3 index to say v3 instead of v2 https://review.opendev.org/c/openstack/python-openstackclient/+/1011354 | 16:30 |
| cardoe | stephenfin: done going through stuff. | 22:19 |
| cardoe | stephenfin: do we have a type for UUID-like? We pass around a UUID that's really string-ified. We also need a UUID | "default" type. | 22:20 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!