| *** sjmc7_ has joined #openstack-searchlight | 00:20 | |
| *** sjmc7 has quit IRC | 00:21 | |
| *** rosmaita_ has joined #openstack-searchlight | 00:30 | |
| *** rosmaita has quit IRC | 00:35 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 01:43 | |
| *** sballe has quit IRC | 01:46 | |
| *** lakshmiS has joined #openstack-searchlight | 03:31 | |
| *** david-lyle has joined #openstack-searchlight | 03:41 | |
| *** GB21 has joined #openstack-searchlight | 04:01 | |
| *** pkarikh has quit IRC | 04:08 | |
| *** pkarikh has joined #openstack-searchlight | 04:08 | |
| *** david-lyle has quit IRC | 04:42 | |
| *** david-lyle has joined #openstack-searchlight | 04:45 | |
| *** TravT has quit IRC | 08:02 | |
| *** TravT has joined #openstack-searchlight | 08:06 | |
| *** TravT has quit IRC | 09:38 | |
| *** TravT has joined #openstack-searchlight | 09:39 | |
| *** GB21 has quit IRC | 09:42 | |
| *** lakshmiS has quit IRC | 11:11 | |
| *** lakshmiS has joined #openstack-searchlight | 11:34 | |
| *** lakshmiS has quit IRC | 11:38 | |
| *** lakshmiS has joined #openstack-searchlight | 11:38 | |
| *** nikhil_k has quit IRC | 12:31 | |
| *** lakshmiS has quit IRC | 12:50 | |
| *** TravT has quit IRC | 13:44 | |
| *** rosmaita_ is now known as rosmaita | 13:44 | |
| *** TravT has joined #openstack-searchlight | 13:45 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:47 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 13:48 | |
| *** TravT has quit IRC | 14:08 | |
| *** TravT_ has joined #openstack-searchlight | 14:08 | |
| *** GB21 has joined #openstack-searchlight | 14:09 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:11 | |
| *** sjmc7_ is now known as sjmc7 | 14:23 | |
| *** nikhil has joined #openstack-searchlight | 14:27 | |
| *** openstackgerrit has quit IRC | 14:31 | |
| *** TravT_ has quit IRC | 14:32 | |
| *** openstackgerrit has joined #openstack-searchlight | 14:32 | |
| *** TravT has joined #openstack-searchlight | 14:32 | |
| *** nikhil has quit IRC | 14:35 | |
| *** nikhil has joined #openstack-searchlight | 14:35 | |
| *** david-lyle has quit IRC | 14:37 | |
| ekarlso | sjmc7: online ? | 14:58 |
|---|---|---|
| sjmc7 | always | 14:58 |
| ekarlso | how did you mean by abstracting out the config opts ? | 14:58 |
| sjmc7 | having a default | 14:58 |
| sjmc7 | rather than having to specify index_name for every plugin | 15:00 |
| *** openstackgerrit has quit IRC | 15:01 | |
| *** openstackgerrit has joined #openstack-searchlight | 15:02 | |
| ekarlso | sjmc7: uhm, the index_name is already taken from base config ? | 15:22 |
| sjmc7 | oh... maybe i missed something then | 15:22 |
| ekarlso | https://review.openstack.org/#/c/223318/2/searchlight/elasticsearch/plugins/glance/images.py < I mean that comment sjmc7 | 15:24 |
| sjmc7 | ah, sorry | 15:24 |
| sjmc7 | what i meant was each plugin will have to copy and paste this function, but with different defaults | 15:24 |
| ekarlso | well, what if the plugin doesn'αΊ— use handlers ? | 15:25 |
| ekarlso | a'la notifications.. | 15:25 |
| ekarlso | just a theory :p | 15:25 |
| sjmc7 | yeah, that's a possibility. but there's a lot in the base class that'd need changing then | 15:25 |
| sjmc7 | get_notification_handler etc wouldn't exist | 15:25 |
| ekarlso | sjmc7: so what's your ruling then ? | 15:27 |
| sjmc7 | not a ruling, just a suggestion :) that the default values be on each plugin but the config option defined in the base class | 15:27 |
| ekarlso | fine then sjmc7 | 15:28 |
| ekarlso | i'll add it to base_opts thing | 15:28 |
| sjmc7 | feel free to disagree :) but i'm trying to keep thinking about when/if we have 20 plugins | 15:29 |
| sjmc7 | how much duplication there'll end up being | 15:29 |
| ekarlso | :P | 15:29 |
| sjmc7 | :) | 15:29 |
| *** david-ly_ has joined #openstack-searchlight | 15:35 | |
| *** david-ly_ is now known as david-lyle | 15:41 | |
| *** nikhil_ has joined #openstack-searchlight | 15:44 | |
| *** nikhil_ is now known as Guest63282 | 15:45 | |
| *** Guest63282 is now known as nikhil_k | 15:46 | |
| *** nikhil_k has quit IRC | 15:52 | |
| *** sballe has joined #openstack-searchlight | 16:06 | |
| *** TravT has quit IRC | 16:08 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: WIP Add faceting https://review.openstack.org/222388 | 16:14 |
| *** TravT has joined #openstack-searchlight | 16:14 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: WIP Add faceting https://review.openstack.org/222388 | 16:16 |
| *** GB21 has quit IRC | 16:20 | |
| *** TravT has quit IRC | 16:21 | |
| *** TravT has joined #openstack-searchlight | 16:25 | |
| *** TravT has quit IRC | 16:32 | |
| *** TravT has joined #openstack-searchlight | 16:34 | |
| openstackgerrit | Endre Karlson proposed openstack/searchlight: Make use of config options for indexer plugins https://review.openstack.org/223318 | 16:45 |
| ekarlso | ^ sjmc7 | 16:46 |
| sjmc7 | ok, will take a look | 16:46 |
| *** GB21 has joined #openstack-searchlight | 17:10 | |
| *** GB21 has quit IRC | 17:42 | |
| *** openstackgerrit has quit IRC | 18:16 | |
| *** openstackgerrit has joined #openstack-searchlight | 18:17 | |
| *** david-lyle has quit IRC | 18:30 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: WIP Add faceting https://review.openstack.org/222388 | 18:44 |
| *** TravT has quit IRC | 18:50 | |
| *** TravT has joined #openstack-searchlight | 18:54 | |
| *** thingee has joined #openstack-searchlight | 19:38 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 20:06 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 20:08 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: WIP Add faceting https://review.openstack.org/222388 | 20:19 |
| sjmc7 | TravT - looking at https://bugs.launchpad.net/searchlight/+bug/1493586; the short version is we don't really want to expose 'fields' at all? | 20:45 |
| openstack | Launchpad bug 1493586 in OpenStack Search (Searchlight) "Missing _source parameter" [High,New] | 20:45 |
| sjmc7 | and that source filtering is a better option | 20:45 |
| sjmc7 | ? | 20:45 |
| TravT | i think so, but i'm not opposed to allowing fields. if allowing fields, should allow partial_fields | 20:45 |
| TravT | but since fields is actually _source | 20:46 |
| TravT | i'd say just switch the input in 1 patch and a separate patch for allowing fields. | 20:46 |
| sjmc7 | ah, interesting... i think the python wrapper is at fault | 20:47 |
| sjmc7 | the 'fields' argument to the python wrapper maps to _source (which is kind of hints at in the docs) | 20:48 |
| TravT | yep | 20:49 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Rename 'fields' to '_source' https://review.openstack.org/224316 | 21:24 |
| ekarlso | TravT: is your horizon thing ready ? | 21:50 |
| TravT | ekarlso, no, i have run into a bug with the magic search toolbar that I've been debugging into as I can. | 21:52 |
| ekarlso | :'( | 21:52 |
| ekarlso | you have until friday :D | 21:52 |
| ekarlso | haha | 21:52 |
| TravT | did a hangout with the author of magic search toolbar today and she was a bit stumped as well. | 21:52 |
| TravT | short story is that it is doing double filtering. | 21:53 |
| TravT | searchlight queries and then client side filtering. | 21:53 |
| TravT | when you do anything fun with your query, the client side has no idea what to do and removes all results. | 21:53 |
| ekarlso | :P | 21:54 |
| TravT | but, it is coming along in raw code... needs cleanup | 21:54 |
| TravT | getting through reviews has been higher priority during the day for me. | 21:55 |
| *** david-lyle has joined #openstack-searchlight | 21:56 | |
| ekarlso | sjmc7: https://review.openstack.org/#/c/223318/3/searchlight/elasticsearch/plugins/base.py < what's the comment there about get_topic_exchanges ? | 22:00 |
| ekarlso | also regarding classmethods, it's allmost the only way you can get away with that type of thing... | 22:01 |
| openstackgerrit | Merged openstack/searchlight: Fix for updated/missing fields in python glance client for image members https://review.openstack.org/219168 | 22:04 |
| ekarlso | where's sjmc7 hiding TravT ? | 22:05 |
| TravT | he's probably working on fixing the thing i just -1'd him on | 22:05 |
| TravT | either that or dinner. | 22:05 |
| TravT | :S | 22:05 |
| TravT | i'll look over the config opt patch next, though | 22:06 |
| openstackgerrit | Merged openstack/searchlight: Fix for metadef events failing in listener service https://review.openstack.org/220149 | 22:06 |
| TravT | ekarlso: in looking at that comment | 22:09 |
| TravT | i think he mistyped | 22:09 |
| ekarlso | :p | 22:11 |
| TravT | but... i need to read through more code. | 22:12 |
| sjmc7 | working on another one of your bugs :) | 22:12 |
| TravT | i'm thinking sjmc7 was just saying don't return array of 'searchlight-indexer,glance' | 22:13 |
| TravT | but just return array of 'glance' | 22:13 |
| TravT | and make searchlight-indexer global default | 22:13 |
| sjmc7 | yeah | 22:15 |
| TravT | ok, i'm going to try out the facet api now sjmc7... wish me luck that i don't hit more magic search landmines | 22:16 |
| sjmc7 | good luck | 22:17 |
| TravT | https://www.youtube.com/watch?v=CDKVHSGS0eg | 22:19 |
| sjmc7 | i like to htink you just uploaded that | 22:26 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Raise on RBAC error https://review.openstack.org/224332 | 22:27 |
| *** david-lyle has quit IRC | 22:29 | |
| openstackgerrit | Endre Karlson proposed openstack/searchlight: Make use of config options for indexer plugins https://review.openstack.org/223318 | 22:54 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Rename 'fields' to '_source' https://review.openstack.org/224316 | 23:13 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!