| openstackgerrit | Steve McLellan proposed openstack/searchlight: Make use of config options for indexer plugins https://review.openstack.org/223318 | 00:09 |
|---|---|---|
| sjmc7 | ok, with that giant patch, i'm out | 00:11 |
| TravT | hasta | 00:17 |
| *** TravT changes topic to "OpenStack Searchlight - https://wiki.openstack.org/wiki/Searchlight" | 00:29 | |
| *** itisha has quit IRC | 01:13 | |
| *** GB21 has joined #openstack-searchlight | 05:08 | |
| *** GB21 has quit IRC | 05:14 | |
| *** lakshmiS has joined #openstack-searchlight | 05:38 | |
| *** lakshmiS has quit IRC | 05:59 | |
| *** openstackgerrit has quit IRC | 07:46 | |
| *** itisha has joined #openstack-searchlight | 07:47 | |
| *** openstackgerrit has joined #openstack-searchlight | 07:47 | |
| *** lakshmiS has joined #openstack-searchlight | 08:42 | |
| *** GB21 has joined #openstack-searchlight | 09:03 | |
| *** lakshmiS has quit IRC | 09:13 | |
| *** lakshmiS has joined #openstack-searchlight | 09:14 | |
| *** GB21 has quit IRC | 10:08 | |
| *** akanksha_ has joined #openstack-searchlight | 10:48 | |
| itisha | hey, so any ideas on how i can fix the error i was getting? | 11:22 |
| lakshmiS | itisha: which error you are referring to? | 11:23 |
| itisha | lakshmiS: I had gotten an error while running stack.sh: http://paste.openstack.org/show/474950/ | 11:23 |
| lakshmiS | ekarlso: do you know? | 11:25 |
| lakshmiS | whats the DESIGNATE_BACKEND_DRIVER in your localrc | 11:29 |
| ekarlso | sorry ? | 11:30 |
| lakshmiS | devstack install of designate gives powerDNS start error http://paste.openstack.org/show/474950/ | 11:31 |
| lakshmiS | ^ ekarlso | 11:31 |
| ekarlso | lakshmiS: not sure really.. | 11:32 |
| itisha | lakshmiS: there isn't one defined | 11:32 |
| ekarlso | try setting it to powerdns | 11:32 |
| itisha | ok, i'll try that :) | 11:35 |
| itisha | i still get the same error | 11:37 |
| lakshmiS | do you have other errors before that in devstack install | 11:39 |
| itisha | no, that's the first one | 11:41 |
| lakshmiS | ekarlso: do you have /etc/powerdns/pdns.d on your devstack install? | 11:46 |
| ekarlso | lakshmiS: dont have devstack up atm :( | 11:53 |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: Fix for Scrub references to glance in searchlight https://review.openstack.org/229842 | 11:57 |
| lakshmiS | itisha: i will retry my stack.sh to see what happens with the latest devstack | 11:57 |
| itisha | lakshmiS: ok, thanks! :) | 11:58 |
| *** GB21 has joined #openstack-searchlight | 13:06 | |
| *** GB21_ has joined #openstack-searchlight | 13:06 | |
| *** GB21_ has quit IRC | 13:06 | |
| sjmc7 | i modified ekarlso's patch last night to allow enabling/disabling plugins in config; the patch was close enough that it was as quick to modify it then start over | 14:04 |
| sjmc7 | https://review.openstack.org/#/c/223318/ | 14:04 |
| *** david-lyle has quit IRC | 14:11 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:12 | |
| *** david-lyle has joined #openstack-searchlight | 14:13 | |
| openstackgerrit | Merged openstack/searchlight: Fix for Scrub references to glance in searchlight https://review.openstack.org/229842 | 14:30 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Make use of config options for indexer plugins https://review.openstack.org/223318 | 14:35 |
| TravT | ekarlso: are you around? | 14:39 |
| TravT | could you look over Steve's changes on the above patch? https://review.openstack.org/223318 | 14:40 |
| sjmc7 | i need to change the devstack config on that, TravT | 14:50 |
| sjmc7 | to disable designate by default | 14:50 |
| TravT | ok, that makes sense. | 14:53 |
| lakshmiS | I also had other comments on that patch earlier for ekarlso: | 14:55 |
| *** TravT has quit IRC | 14:58 | |
| sjmc7 | lakshmiS i tried to take them into account, i may have missed some stuff | 15:00 |
| sjmc7 | in particular, the plugin.py file - it's necessary to avoid some weird circular imports | 15:00 |
| sjmc7 | and it also keeps a load of configuration logic out of the plugin | 15:01 |
| *** lakshmiS has quit IRC | 15:01 | |
| sjmc7 | meeting time | 15:01 |
| *** TravT has joined #openstack-searchlight | 15:01 | |
| TravT | Courtesy Searchlight meeting reminder in #openstack-meeting-4: lakshmiS, mclaren, nikhil_k, rosmaita, sigmavirus24, TravT, krykowski, david-lyle, wokuma, kragniz, sjmc7, ekarlso, abhijeetm, itisha | 15:02 |
| *** lakshmiS has joined #openstack-searchlight | 15:03 | |
| *** lakshmiS_ has joined #openstack-searchlight | 15:09 | |
| *** lakshmiS has quit IRC | 15:13 | |
| *** lakshmiS_ has quit IRC | 15:22 | |
| *** lakshmiS has joined #openstack-searchlight | 15:23 | |
| lakshmiS | sorry my netconnection is choppy today | 15:23 |
| TravT | now to get my devstack running again... | 15:50 |
| TravT | vm crashed this morning. | 15:51 |
| TravT | itisha: are you around? | 15:51 |
| itisha | TravT: hey | 15:52 |
| TravT | hey, i have a low hanging fruit bug that you could tackle... | 15:52 |
| TravT | https://bugs.launchpad.net/searchlight/+bug/1501791 | 15:52 |
| openstack | Launchpad bug 1501791 in OpenStack Search (Searchlight) "Glance Exceptions should be removed" [Low,New] | 15:52 |
| TravT | basically searchlight was separated from glance this release. | 15:53 |
| TravT | and we took a bunch of code | 15:53 |
| TravT | and i came across several exceptions that could be deleted from searchlight... | 15:53 |
| TravT | so, would just need to get through them and see which ones are actually being used in searchlight and get rid of the others. | 15:53 |
| itisha | oh ok, cool, i'll get started on this right away :) | 15:54 |
| TravT | :) | 15:54 |
| lakshmiS | by looking at it. atleast UploadException shouldn't be there | 15:54 |
| TravT | git review -d 229593 | 15:56 |
| TravT | oops wrong window | 15:56 |
| *** lakshmiS has quit IRC | 16:03 | |
| *** lakshmiS has joined #openstack-searchlight | 16:10 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add 'limit_terms' to facets https://review.openstack.org/230009 | 16:33 |
| TravT | well the tags one is an easy fix... | 16:35 |
| TravT | because it doesn't need to be fixed | 16:36 |
| TravT | must have been done already. | 16:36 |
| TravT | so, i'll close that bug as invalid. | 16:36 |
| lakshmiS | you mean dynamic mapping | 16:36 |
| TravT | well, adding and deleting tags work and it is already in the mapping | 16:36 |
| TravT | maybe we just forgot to close it | 16:37 |
| lakshmiS | cool | 16:37 |
| lakshmiS | i guess you beat me to the testing | 16:38 |
| lakshmiS | i didnt see tags in mapping | 16:38 |
| lakshmiS | https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/glance/images.py#L43 | 16:38 |
| TravT | line 55 | 16:38 |
| TravT | https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/glance/images.py#L55 | 16:38 |
| lakshmiS | oh there it is. | 16:38 |
| TravT | yeah... | 16:38 |
| lakshmiS | didnt see it hiding | 16:38 |
| TravT | one thing quite curious i did just find | 16:39 |
| TravT | why are we ignoring kernel_id and ramdisk_id? | 16:39 |
| TravT | https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/glance/__init__.py#L67 | 16:39 |
| TravT | that's not right | 16:39 |
| TravT | i think i'm going to add those back in. | 16:40 |
| TravT | i can't think of any good reason to ignore them | 16:40 |
| sjmc7 | i'm sure there was one, in the sands of time | 16:40 |
| lakshmiS | no idea | 16:40 |
| TravT | well, i'll try adding them back in and see if i encounter anything. | 16:40 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Make use of config options for indexer plugins https://review.openstack.org/223318 | 16:53 |
| lakshmiS | are we waiting for ekarlso to check the patch tomorrow - 223318 | 17:39 |
| lakshmiS | will check back tomorrow morning | 17:44 |
| *** lakshmiS has quit IRC | 17:44 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Add kernel_id and ramdisk_id to indexed images https://review.openstack.org/230044 | 17:55 |
| ekarlso | what patch ? | 18:14 |
| *** openstackgerrit has quit IRC | 18:31 | |
| *** openstackgerrit has joined #openstack-searchlight | 18:32 | |
| sjmc7 | TravT - you want me to abandon 230009 ? | 18:33 |
| sjmc7 | or at least defer it | 18:33 |
| TravT | let met see wtf you are talking about | 18:33 |
| sjmc7 | facet term limit | 18:33 |
| TravT | well, just change the facet limit default to 0 | 18:34 |
| sjmc7 | that's already the limit.. i'm not seeing the benefit of adding it | 18:35 |
| TravT | you can send it through | 18:35 |
| sjmc7 | mm. ok | 18:36 |
| TravT | the facet terms are being limited by rbac right? | 18:38 |
| sjmc7 | should be, yes | 18:38 |
| TravT | ok, it is. | 18:45 |
| TravT | just gets a little funky when logged in as admin | 18:46 |
| TravT | you get facets for other projects | 18:46 |
| TravT | running another check to see if i'm right | 18:47 |
| sjmc7 | oh, the all tenants thing maybe :( | 18:47 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add 'limit_terms' to facets https://review.openstack.org/230009 | 18:48 |
| sjmc7 | need to add all_projects to facets as well i think | 18:48 |
| TravT | yep, same thing | 18:52 |
| TravT | i do see this happening. | 18:53 |
| TravT | i create security group in demo project. add to demo instance | 18:53 |
| TravT | switch to admin project | 18:54 |
| TravT | get facet options for security group with demo security group | 18:54 |
| sjmc7 | yeah | 18:54 |
| sjmc7 | ok. (another) fairly simple fix. cramming stuff in at the end of the cycle is not a good habit :) | 18:55 |
| TravT | this is basically coming from rc1 testing. | 18:56 |
| sjmc7 | ok, another bug! :) | 18:59 |
| sjmc7 | my git branch listing almost fills the screen now | 19:00 |
| sjmc7 | lemme get a cup o tea, then i'll knock this one out. 15-20 minutes i think | 19:00 |
| TravT | git branch | grep -v "master" | sed 's/^[ *]*//' | sed 's/^/git branch -D /' | bash | 19:01 |
| TravT | deletes everything but master | 19:01 |
| sjmc7 | no fun in that! | 19:04 |
| TravT | ekarlso: any feedback on this one: 223318 | 19:09 |
| TravT | https://review.openstack.org/#/c/223318/ | 19:09 |
| openstackgerrit | Itisha Dewan proposed openstack/searchlight: Glance exceptions should be removed: https://review.openstack.org/230086 | 19:11 |
| *** david-lyle has quit IRC | 19:18 | |
| *** david-lyle has joined #openstack-searchlight | 19:27 | |
| *** GB21 has quit IRC | 19:31 | |
| openstackgerrit | Itisha Dewan proposed openstack/searchlight: Glance exceptions should be removed https://review.openstack.org/230086 | 19:48 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Apply RBAC to facets for admin unless all_projects https://review.openstack.org/230124 | 20:25 |
| itisha | sjmc7: hey, are you still working on this bug? https://bugs.launchpad.net/searchlight/+bug/1493975 | 20:39 |
| openstack | Launchpad bug 1493975 in OpenStack Search (Searchlight) "Need separate config sections for api and listener" [Medium,New] - Assigned to Steve McLellan (sjmc7) | 20:39 |
| itisha | Or can I take it? | 20:40 |
| sjmc7 | itisha - it's next on my list, but if you want to take a crack at it, be my guest. the main driver was so that log_file can be specified differently | 20:41 |
| sjmc7 | take a look at the top of https://etherpad.openstack.org/p/searchlight-plugin-config-options | 20:41 |
| sjmc7 | yeah, go for it | 20:44 |
| sjmc7 | the way configuration is handled is a bit confusing | 20:44 |
| sjmc7 | i suspect that separate configuration files might actually be the right way to do it | 20:45 |
| itisha | sjmc7: ok, great, i'll take a look at it | 20:46 |
| *** ekarlso has quit IRC | 20:55 | |
| *** ekarlso has joined #openstack-searchlight | 20:58 | |
| TravT | itisha, that bug should use this patch as a base: https://review.openstack.org/#/c/223318/ | 21:23 |
| sjmc7 | i'm not sure they're that connected | 21:23 |
| sjmc7 | it doesn't hurt, but i don't think it'll make much difference | 21:24 |
| *** david-lyle has quit IRC | 21:43 | |
| *** david-lyle has joined #openstack-searchlight | 21:56 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Make use of config options for indexer plugins https://review.openstack.org/223318 | 21:57 |
| sjmc7 | ok, last one from me on that one | 21:57 |
| TravT | sjmc7: just tried out facet all_projects. just need a doc blurb on | 21:58 |
| TravT | see comments | 21:58 |
| sjmc7 | k | 21:58 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Apply RBAC to facets for admin unless all_projects https://review.openstack.org/230124 | 22:06 |
| TravT | sjmc7: to test out the config options... | 22:06 |
| sjmc7 | yeah.. look at the devstack plugin.sh change for an example | 22:06 |
| sjmc7 | or the plugin docs | 22:06 |
| sjmc7 | you can change index_names and stuff | 22:06 |
| sjmc7 | i did just test it with a fresh devstack | 22:07 |
| TravT | yeah, i was debating whether to muck up my devstack or not... | 22:07 |
| sjmc7 | you don't need to start fresh i don't think | 22:07 |
| TravT | guess that's what snapshots are for. | 22:07 |
| TravT | i think i can just follow some of the setup instructions. | 22:08 |
| sjmc7 | i just checked the two 'enableds' (which is why i had to do the patch a few minute ago | 22:08 |
| sjmc7 | you can modify the settings file by hand | 22:08 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add 'limit_terms' to facets https://review.openstack.org/230009 | 22:09 |
| TravT | i just heckled you over whitespace | 22:11 |
| sjmc7 | :| | 22:11 |
| sjmc7 | i'm gonna add more | 22:11 |
| sjmc7 | IN A DOC FILE? | 22:11 |
| sjmc7 | i'm getting all john macenroe | 22:11 |
| TravT | -1 for you | 22:11 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Apply RBAC to facets for admin unless all_projects https://review.openstack.org/230124 | 22:13 |
| TravT | i see what you did... you made the example less valid... | 22:13 |
| TravT | accidentally trimmed the closing } | 22:13 |
| sjmc7 | when? who? what? | 22:14 |
| TravT | -1 for you | 22:15 |
| sjmc7 | STOP THAT | 22:15 |
| * TravT is glad i'm not close enough for you to through books, chairs, or raccoons at me | 22:15 | |
| TravT | (* | 22:15 |
| TravT | throw | 22:15 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Apply RBAC to facets for admin unless all_projects https://review.openstack.org/230124 | 22:16 |
| sjmc7 | i'll try | 22:16 |
| sjmc7 | right, done | 22:16 |
| TravT | :) | 22:16 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Make use of config options for indexer plugins https://review.openstack.org/223318 | 22:28 |
| TravT | sjmc7^ just updated commit message to get right tracking info | 22:28 |
| sjmc7 | ok | 22:29 |
| TravT | i just kicked off a reclone = no run with that patch applied | 22:29 |
| TravT | would rather test it more fully | 22:29 |
| sjmc7 | ok. i'm reaching the end of my productive day i think | 22:31 |
| TravT | great work today. | 22:31 |
| sjmc7 | you mean when i started removing brackets from documentation? :) | 22:32 |
| TravT | yeah, i guess you secretly like -1 | 22:32 |
| sjmc7 | i do | 22:32 |
| TravT | did you see my note about the merge conflict on the facet limits? | 22:32 |
| sjmc7 | yeah, i'll rebase | 22:34 |
| sjmc7 | i knew that'd conflict | 22:34 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:59 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add 'limit_terms' to facets https://review.openstack.org/230009 | 23:28 |
| *** TravT has quit IRC | 23:37 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!