| *** sjmc7 has joined #openstack-searchlight | 03:29 | |
| *** sjmc7 has quit IRC | 03:34 | |
| *** lakshmiS has joined #openstack-searchlight | 04:35 | |
| *** nikhil_k has joined #openstack-searchlight | 04:39 | |
| *** nikhil has quit IRC | 04:42 | |
| *** nikhil has joined #openstack-searchlight | 05:41 | |
| *** nikhil_k has quit IRC | 05:43 | |
| *** openstack has joined #openstack-searchlight | 06:30 | |
| *** itisha has quit IRC | 07:21 | |
| *** openstack has joined #openstack-searchlight | 08:49 | |
| -cameron.freenode.net- [freenode-info] if you're at a conference and other people are having trouble connecting, please mention it to staff: http://freenode.net/faq.shtml#gettinghelp | 08:49 | |
| *** openstackgerrit has quit IRC | 10:01 | |
| *** openstackgerrit has joined #openstack-searchlight | 10:02 | |
| openstackgerrit | Merged openstack/searchlight: Remove 'not_analyzed' from server.name https://review.openstack.org/233787 | 11:57 |
|---|---|---|
| *** lakshmiS_ has joined #openstack-searchlight | 11:57 | |
| *** lakshmiS has quit IRC | 11:59 | |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: Fix for no name field in metadef namespace https://review.openstack.org/234182 | 12:33 |
| *** itisha has joined #openstack-searchlight | 12:42 | |
| *** lakshmiS_ has quit IRC | 12:58 | |
| *** lei-zh has joined #openstack-searchlight | 12:58 | |
| *** lei-zh has left #openstack-searchlight | 12:58 | |
| *** lakshmiS has joined #openstack-searchlight | 13:02 | |
| *** lakshmiS has quit IRC | 13:13 | |
| *** lakshmiS has joined #openstack-searchlight | 13:33 | |
| *** lakshmiS_ has joined #openstack-searchlight | 13:58 | |
| *** lakshmiS has quit IRC | 14:01 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:01 | |
| *** sjmc7 has joined #openstack-searchlight | 14:26 | |
| *** lakshmiS_ has quit IRC | 14:32 | |
| *** lakshmiS has joined #openstack-searchlight | 14:33 | |
| *** lakshmiS_ has joined #openstack-searchlight | 14:45 | |
| *** lakshmiS has quit IRC | 14:45 | |
| sjmc7 | TravT: https://review.openstack.org/234284 for stable | 15:11 |
| TravT | ok, will look. | 15:14 |
| *** lakshmiS_ has quit IRC | 15:36 | |
| *** lakshmiS has joined #openstack-searchlight | 15:37 | |
| *** itisha has quit IRC | 15:51 | |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: Fix for no name field in metadef namespace https://review.openstack.org/234182 | 17:31 |
| *** nikhil has quit IRC | 17:39 | |
| *** nikhil has joined #openstack-searchlight | 17:40 | |
| sjmc7 | lakshmiS - is display_name always there? | 17:54 |
| sjmc7 | otherwise if document['display_name'] will raise a key error | 17:54 |
| lakshmiS | not necessarily | 17:54 |
| sjmc7 | ah, i see - we set it to none | 17:54 |
| lakshmiS | let me double check that | 17:54 |
| sjmc7 | we do that list comprehension, it's ok | 17:55 |
| lakshmiS | also in notification its set to none by glance if its not there | 17:56 |
| sjmc7 | would it be safer not to rely on that? | 17:58 |
| sjmc7 | payload['name'] = payload.get('name', payload['namespace']) ? | 17:59 |
| sjmc7 | err... 'display_name' for the second one | 17:59 |
| lakshmiS | yeah we could do that to be safer side | 17:59 |
| lakshmiS | will patch it | 17:59 |
| sjmc7 | err.. wait, that won't work | 17:59 |
| sjmc7 | you'll end up with None | 17:59 |
| lakshmiS | i get what u mean | 18:00 |
| sjmc7 | could change it to if payload.get('display_name', None) | 18:00 |
| sjmc7 | or ignore me entirely :) | 18:00 |
| lakshmiS | :) np will send another patch | 18:00 |
| *** lakshmiS has quit IRC | 18:05 | |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: Fix for no name field in metadef namespace https://review.openstack.org/234182 | 18:15 |
| sjmc7 | document['name'] = document.get('display_name', document['namespace']) won't work lakshmiS | 18:16 |
| sjmc7 | if display_name is None, that's what you'll get | 18:16 |
| sjmc7 | i was incorrect before | 18:17 |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: Fix for no name field in metadef namespace https://review.openstack.org/234182 | 18:19 |
| sjmc7 | same in notifications | 18:20 |
| sjmc7 | sorry. i will keep my mouth shut in future | 18:20 |
| *** lakshmiS has joined #openstack-searchlight | 18:26 | |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: Fix for no name field in metadef namespace https://review.openstack.org/234182 | 18:33 |
| *** lakshmiS has quit IRC | 18:36 | |
| *** sjmc7 has quit IRC | 19:08 | |
| *** sjmc7 has joined #openstack-searchlight | 19:11 | |
| *** TravT_ has joined #openstack-searchlight | 20:46 | |
| *** TravT__ has joined #openstack-searchlight | 20:48 | |
| *** TravT__ has quit IRC | 20:48 | |
| *** TravT__ has joined #openstack-searchlight | 20:48 | |
| openstackgerrit | Merged openstack/searchlight: Fix for no name field in metadef namespace https://review.openstack.org/234182 | 20:49 |
| *** TravT has quit IRC | 20:49 | |
| *** TravT__ is now known as TravT | 20:49 | |
| *** TravT_ has quit IRC | 20:51 | |
| TravT | sjmc7: Lakshmi's patch merged... can you put up a cherry pick on stable/liberty? | 20:52 |
| sjmc7 | yep | 20:52 |
| sjmc7 | done https://review.openstack.org/234432 TravT | 20:53 |
| TravT | thanks, will pull and double check again. | 20:54 |
| TravT | this patch actually makes me want to include metadefs in the horizon plugin demo. | 20:54 |
| sjmc7 | :D | 20:55 |
| TravT | give a lot of interesting sounding content anyway | 20:55 |
| *** sjmc7 has quit IRC | 21:19 | |
| *** sjmc7 has joined #openstack-searchlight | 21:25 | |
| TravT | sjmc7: anybody here, are there any more bugs being worked on for the release? | 21:41 |
| sjmc7 | not by me | 21:41 |
| sjmc7 | think we're good to go | 21:41 |
| TravT | I'll push rc3 tag soon... | 21:41 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:08 | |
| *** david-lyle has quit IRC | 22:10 | |
| *** david-lyle has joined #openstack-searchlight | 22:12 | |
| *** sjmc7 has quit IRC | 22:35 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!