| *** yingjun has joined #openstack-searchlight | 00:38 | |
| openstackgerrit | Li Yingjun proposed openstack/searchlight: Hypervisor plugin https://review.openstack.org/297586 | 01:30 |
|---|---|---|
| *** GB21 has joined #openstack-searchlight | 06:17 | |
| *** yingjun_ has joined #openstack-searchlight | 06:27 | |
| *** yingjun has quit IRC | 06:30 | |
| *** yingjun_ has quit IRC | 06:31 | |
| *** pcaruana has joined #openstack-searchlight | 06:49 | |
| *** yingjun has joined #openstack-searchlight | 06:51 | |
| *** GB21 has quit IRC | 07:43 | |
| *** GB21 has joined #openstack-searchlight | 08:36 | |
| *** GB21 has quit IRC | 09:16 | |
| *** yingjun has quit IRC | 09:35 | |
| *** pcaruana has quit IRC | 09:42 | |
| *** pcaruana has joined #openstack-searchlight | 09:55 | |
| *** GB21 has joined #openstack-searchlight | 09:59 | |
| *** GB21 has quit IRC | 10:14 | |
| *** GB21 has joined #openstack-searchlight | 10:21 | |
| *** GB21 has quit IRC | 10:54 | |
| *** pcaruana has quit IRC | 11:09 | |
| *** GB21 has joined #openstack-searchlight | 11:11 | |
| *** pcaruana has joined #openstack-searchlight | 11:23 | |
| *** GB21 has quit IRC | 11:27 | |
| *** GB21 has joined #openstack-searchlight | 11:47 | |
| *** GB21 has quit IRC | 12:34 | |
| *** pcaruana has quit IRC | 12:39 | |
| *** pcaruana has joined #openstack-searchlight | 12:52 | |
| *** yingjun has joined #openstack-searchlight | 13:07 | |
| *** openstackgerrit has quit IRC | 13:48 | |
| *** openstackgerrit has joined #openstack-searchlight | 13:49 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:59 | |
| openstackgerrit | Rick Aulino proposed openstack/searchlight: Re-indexing optimization for doc_type https://review.openstack.org/295538 | 15:15 |
| -openstackstatus- NOTICE: Gerrit is restarting on review.openstack.org in an attempt to address an issue reading an object from the ec2-api repository | 15:22 | |
| *** bpokorny has joined #openstack-searchlight | 15:26 | |
| *** TravT_ has quit IRC | 15:53 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add missing zero-downtime indexing documentation https://review.openstack.org/298315 | 16:31 |
| *** lakshmiS has joined #openstack-searchlight | 16:39 | |
| *** TravT has joined #openstack-searchlight | 16:41 | |
| *** david-lyle_ has joined #openstack-searchlight | 16:44 | |
| *** david-lyle has quit IRC | 16:44 | |
| *** david-lyle has joined #openstack-searchlight | 16:48 | |
| *** david-lyle_ has quit IRC | 16:49 | |
| *** TravT has quit IRC | 17:05 | |
| openstackgerrit | Lakshmi N Sampath proposed openstack/searchlight: Patchset for testing functional tests https://review.openstack.org/298339 | 17:17 |
| *** david-lyle has quit IRC | 17:24 | |
| *** david-lyle has joined #openstack-searchlight | 17:25 | |
| *** TravT has joined #openstack-searchlight | 17:46 | |
| *** david-lyle_ has joined #openstack-searchlight | 18:12 | |
| *** david-lyle has quit IRC | 18:14 | |
| *** pcaruana has quit IRC | 18:16 | |
| *** pcaruana has joined #openstack-searchlight | 18:30 | |
| *** preetika has joined #openstack-searchlight | 19:16 | |
| openstackgerrit | Rick Aulino proposed openstack/searchlight: Re-indexing optimization for doc_type https://review.openstack.org/295538 | 19:54 |
| *** lakshmiS has quit IRC | 20:14 | |
| *** lakshmiS has joined #openstack-searchlight | 20:18 | |
| *** lakshmiS has quit IRC | 20:23 | |
| openstackgerrit | Rick Aulino proposed openstack/searchlight: Zero Downtime Re-indexing Error Handling. https://review.openstack.org/293079 | 20:28 |
| *** lakshmiS has joined #openstack-searchlight | 20:54 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Improve install instructions https://review.openstack.org/298433 | 21:09 |
| *** lakshmiS_ has joined #openstack-searchlight | 21:20 | |
| *** lakshmiS has quit IRC | 21:23 | |
| *** bpokorny has quit IRC | 21:27 | |
| *** bpokorny has joined #openstack-searchlight | 21:30 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Fix code style (pep8 & lint) errors. https://review.openstack.org/298440 | 21:36 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Improve install instructions https://review.openstack.org/298433 | 21:38 |
| *** preetika has quit IRC | 22:07 | |
| openstackgerrit | Merged openstack/searchlight: Zero Downtime Re-indexing Error Handling. https://review.openstack.org/293079 | 22:25 |
| TravT | david-lyle_: are you around? | 22:56 |
| david-lyle_ | TravT: yup | 22:57 |
| *** david-lyle_ is now known as david-lyle | 22:57 | |
| TravT | so, i'm having trouble getting the rest api test cases to work in the repo | 22:57 |
| TravT | and i can't find any example plugins that use tox | 22:57 |
| david-lyle | well | 22:58 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Fix code style (pep8 & lint) errors. https://review.openstack.org/298440 | 22:59 |
| david-lyle | I thought I had more, but I guess I don't :P | 22:59 |
| david-lyle | tests should work, but they depend on Horizon | 22:59 |
| david-lyle | what type of errors? | 22:59 |
| TravT | well, i was getting a diff error just a minute ago, but it was an import error | 23:00 |
| david-lyle | from horizon? | 23:00 |
| TravT | so i just pushed the to the patch above ^ | 23:00 |
| TravT | now I'm getting ImproperlyConfigured: settings.DATABASES is improperly configured. Please supply the ENGINE value. Check settings documentation for more details. | 23:00 |
| TravT | but when i look at other plugins, i don't see them specifying anything there | 23:00 |
| david-lyle | what have you done ?!?!?! | 23:01 |
| david-lyle | :-D | 23:01 |
| *** bpokorny_ has joined #openstack-searchlight | 23:02 | |
| david-lyle | yeah the import would be wrong | 23:02 |
| *** bpokorny_ has quit IRC | 23:02 | |
| david-lyle | but you fixed that | 23:02 |
| TravT | i fixed the import here: https://review.openstack.org/#/c/298440/2/searchlight_ui/tests/api_tests/searchlight_rest_tests.py | 23:02 |
| david-lyle | I just said that :) | 23:03 |
| *** bpokorny_ has joined #openstack-searchlight | 23:03 | |
| TravT | repeating what you said seemed like the only thing i had to offer at this point in time. ;) | 23:03 |
| david-lyle | I would have done the same | 23:04 |
| *** bpokorny has quit IRC | 23:04 | |
| TravT | i've poked around in half a dozen other plugins and they all seem to be slightly different with what files they do and don't have | 23:05 |
| david-lyle | let me pull you patch and try it | 23:05 |
| david-lyle | *your | 23:05 |
| TravT | ok | 23:05 |
| TravT | note that this is now under https://github.com/openstack/searchlight-ui.get | 23:05 |
| TravT | note that this is now under https://github.com/openstack/searchlight-ui.git | 23:05 |
| TravT | the settings.py file i have i mimicked from lbaas | 23:06 |
| TravT | but it has WAY more than other plugins | 23:06 |
| TravT | in their settings.py | 23:06 |
| TravT | i'll look at why karma fails on zuul (npm run test) while you look at that issues. npm run test works fine locally... | 23:07 |
| david-lyle | lint fails all the f*n time | 23:08 |
| david-lyle | for horizon too | 23:08 |
| david-lyle | fix that and the world sings | 23:09 |
| *** bpokorny_ has quit IRC | 23:11 | |
| TravT | well, as far as i can see in the log, there are no failures. | 23:11 |
| TravT | i don't know if it is counting this as a failure? | 23:11 |
| TravT | http://logs.openstack.org/40/298440/1/check/gate-searchlight-ui-npm-run-test/2b0056d/console.html#_2016-03-28_21_59_04_272 | 23:11 |
| david-lyle | so DATABASES should be getting set here https://github.com/openstack/searchlight-ui/blob/master/searchlight_ui/tests/settings.py#L18 | 23:15 |
| TravT | that's what i was hoping as well | 23:16 |
| TravT | krotscheck do we have to have karma coverage configured to go to cover/ or reports/ for the npm-run-test gate jobs to work properly? | 23:19 |
| krotscheck | TravT: Yeah, either via the istanbul plugin or something similar. | 23:19 |
| TravT | i am getting: http://logs.openstack.org/40/298440/1/check/gate-searchlight-ui-npm-run-test/2b0056d/console.html#_2016-03-28_21_59_06_606 | 23:20 |
| krotscheck | The ironic webclient's got a setup that you can copy from. | 23:20 |
| TravT | is that different than ironic-ui? | 23:20 |
| TravT | right now i'm sending coverage into coverage-karma | 23:20 |
| TravT | https://github.com/openstack/searchlight-ui/blob/master/searchlight_ui/karma.conf.js#L158 | 23:20 |
| TravT | but i can change that if needed. | 23:20 |
| krotscheck | AFK, fussy baby, back in 20 or so. | 23:21 |
| TravT | okay, looking at https://github.com/openstack/ironic-webclient now | 23:22 |
| openstackgerrit | David Lyle proposed openstack/searchlight-ui: Removing oslo-incubator config file https://review.openstack.org/298468 | 23:30 |
| david-lyle | TravT: unrelated | 23:31 |
| david-lyle | just so I didn't forget | 23:31 |
| TravT | cool | 23:31 |
| TravT | that'll go nowhere until tests are fixed | 23:32 |
| TravT | though | 23:32 |
| david-lyle | yup. I would forget otherwise | 23:32 |
| david-lyle | still looking at the tests | 23:32 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Fix Zuul errors. https://review.openstack.org/298440 | 23:34 |
| TravT | david-lyle: minor adjustment for npm run test ^ (kind of a stab in the dark since I don't know why zuul fails karma) | 23:35 |
| TravT | that's the same patch you are looking at, i just gave it a broader title | 23:35 |
| david-lyle | ok, will update if I find the issue | 23:36 |
| krotscheck | OK | 23:41 |
| krotscheck | back | 23:41 |
| TravT | hey krotscheck. | 23:44 |
| krotscheck | TravT: Heya | 23:44 |
| krotscheck | Checking out your code now, gonna see what's going on. | 23:44 |
| TravT | ok | 23:45 |
| krotscheck | Full disclosure, I'm technically in daycare mode, so if Mr. Fussypants wakes up I have to disappear again | 23:45 |
| TravT | no worries | 23:46 |
| TravT | i actually have to drop shortly | 23:46 |
| TravT | but i don't know what the magic formula is for getting npm run tests to pass | 23:46 |
| krotscheck | TravT: Did you sacrifice a goat? | 23:47 |
| TravT | no, but maybe david-lyle has an extra one sitting around that i could borrow for that | 23:47 |
| david-lyle | take all you want | 23:47 |
| krotscheck | make sure to paint it blue first | 23:47 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Add missing zero-downtime indexing documentation https://review.openstack.org/298315 | 23:47 |
| david-lyle | don't tell my wife | 23:48 |
| david-lyle | you just found the goat | 23:48 |
| TravT | well, holy crap, now it is failing with a pep8 error that it didn't fail on last time and i didn't change any python files... | 23:48 |
| TravT | since last patch set. | 23:48 |
| TravT | guess i'll fix that... | 23:48 |
| david-lyle | TravT: I have your fix for python | 23:48 |
| david-lyle | just a sec | 23:49 |
| TravT | ooh | 23:49 |
| krotscheck | i did say paint it blue ;) | 23:49 |
| *** yingjun has quit IRC | 23:49 | |
| *** yingjun has joined #openstack-searchlight | 23:49 | |
| TravT | david-lyle can you include this fix in your other fix? | 23:50 |
| TravT | http://logs.openstack.org/40/298440/3/check/gate-searchlight-ui-pep8/99b2079/console.html#_2016-03-28_23_38_39_015 | 23:50 |
| david-lyle | yeah already had that one | 23:51 |
| *** yingjun has quit IRC | 23:54 | |
| openstackgerrit | David Lyle proposed openstack/searchlight-ui: Fix Zuul errors. https://review.openstack.org/298440 | 23:55 |
| TravT | thanks david-lyle | 23:56 |
| david-lyle | TravT: np | 23:56 |
| krotscheck | So, running `npm test` on my own passes like magic. | 23:57 |
| TravT | yea, same here | 23:57 |
| TravT | you mean npm run test | 23:57 |
| TravT | ? | 23:57 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:58 | |
| krotscheck | Or npm test, yeah | 23:58 |
| krotscheck | The line that says something about the xstatic packages not being found worries me a bit. What's going on there? | 23:58 |
| TravT | i have no idea | 23:58 |
| TravT | this doesn't add any xstatic packages... | 23:58 |
| TravT | but it does reference a bunch from horizon | 23:59 |
| TravT | i can try stripping that down... | 23:59 |
| TravT | here's where that comes from: | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!