*** ekarlso has quit IRC | 01:33 | |
*** ekarlso has joined #openstack-searchlight | 01:53 | |
*** itisha has joined #openstack-searchlight | 04:27 | |
*** itisha has quit IRC | 07:09 | |
*** itisha has joined #openstack-searchlight | 09:10 | |
*** sjmc7_ has joined #openstack-searchlight | 13:28 | |
*** yingjun has joined #openstack-searchlight | 13:30 | |
*** sjmc7_ has quit IRC | 13:42 | |
*** sjmc7_ has joined #openstack-searchlight | 13:53 | |
*** sjmc7_ has quit IRC | 13:54 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:54 | |
*** TravT has joined #openstack-searchlight | 14:09 | |
*** TravT has quit IRC | 14:09 | |
*** TravT has joined #openstack-searchlight | 14:14 | |
*** yingjun has quit IRC | 14:59 | |
*** yingjun has joined #openstack-searchlight | 14:59 | |
*** yingjun has quit IRC | 15:03 | |
*** itisha_ has joined #openstack-searchlight | 15:16 | |
*** itisha has quit IRC | 15:21 | |
*** briancline has quit IRC | 15:21 | |
*** briancline has joined #openstack-searchlight | 15:21 | |
*** briancline has quit IRC | 15:21 | |
*** briancline has joined #openstack-searchlight | 15:22 | |
*** itisha_ is now known as itisha | 15:23 | |
openstackgerrit | Steve McLellan proposed openstack/searchlight-specs: Cross-region search spec https://review.openstack.org/301227 | 15:23 |
---|---|---|
*** bpokorny has joined #openstack-searchlight | 15:48 | |
*** lakshmiS has joined #openstack-searchlight | 15:57 | |
*** lakshmiS has quit IRC | 16:02 | |
*** lakshmiS has joined #openstack-searchlight | 16:06 | |
*** bkeller` has joined #openstack-searchlight | 16:36 | |
*** david-lyle has joined #openstack-searchlight | 17:28 | |
*** david-lyle has quit IRC | 17:29 | |
*** david-lyle has joined #openstack-searchlight | 17:30 | |
*** TravT has quit IRC | 17:46 | |
openstackgerrit | Steve McLellan proposed openstack/searchlight: Ensure consistency in mapping field types https://review.openstack.org/307504 | 18:45 |
*** TravT has joined #openstack-searchlight | 18:51 | |
*** TravT has quit IRC | 18:53 | |
*** TravT has joined #openstack-searchlight | 18:53 | |
openstackgerrit | Merged openstack/searchlight: [Trivial] Remove unnecessary executable privilege https://review.openstack.org/311012 | 19:02 |
openstackgerrit | Steve McLellan proposed openstack/searchlight: Add totals to facets https://review.openstack.org/308582 | 19:25 |
*** itisha has quit IRC | 19:39 | |
*** TravT_ has joined #openstack-searchlight | 20:14 | |
*** TravT_ has quit IRC | 20:15 | |
*** TravT has quit IRC | 20:15 | |
*** TravT has joined #openstack-searchlight | 20:16 | |
openstackgerrit | Steve McLellan proposed openstack/searchlight: Apply query to highlight query https://review.openstack.org/311834 | 20:22 |
*** TravT_ has joined #openstack-searchlight | 20:27 | |
*** TravT has quit IRC | 20:29 | |
openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Update JS dev dependencies https://review.openstack.org/311844 | 20:38 |
openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Use Chrome for JS unit tests https://review.openstack.org/311851 | 20:46 |
openstackgerrit | Jaime Guerrero proposed openstack/searchlight: Allow limit=0 In Searches https://review.openstack.org/309594 | 21:07 |
*** lakshmiS has quit IRC | 21:29 | |
jaimguer | hi everyone | 21:46 |
sjmc7 | hello | 22:01 |
jaimguer | hey sjmc7. One day I'll catch all my typos :) | 22:07 |
sjmc7 | :) keep us on our toes | 22:07 |
sjmc7 | sorry for nitpicking; the typos bug me once i know they’re there | 22:08 |
jaimguer | no worries, i dont want the them there either | 22:08 |
jaimguer | can you please explain a bit about the rebasing? im unsure what I need to do for that | 22:08 |
sjmc7 | if you’re feeling really charitable, a search that returns just the total hits would be a good functional test too | 22:08 |
sjmc7 | yeah, sure | 22:08 |
sjmc7 | it’s normally best to work on a separate branch when you do changes | 22:09 |
sjmc7 | rather than master | 22:09 |
sjmc7 | but since your patch is on master, you can rebase it with git pull —rebase origin master | 22:09 |
jaimguer | you mean the branch on my local dev machine? | 22:10 |
sjmc7 | yep | 22:11 |
sjmc7 | gerrit normally does it itself but in this case there’s a merge conflict | 22:11 |
jaimguer | ok, cool | 22:11 |
jaimguer | and rebase is before git add/git commit? | 22:11 |
sjmc7 | yeah. rebase, fix conflicts, git add any files you had to modify, git rebase —continue then git review | 22:12 |
openstackgerrit | Jaime Guerrero proposed openstack/searchlight: Allow limit=0 In Searches https://review.openstack.org/309594 | 22:16 |
jaimguer | lets see how that one goes | 22:16 |
sjmc7 | :) | 22:16 |
*** david-lyle has quit IRC | 22:28 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!