| *** ianychoi has quit IRC | 00:10 | |
| *** ianychoi has joined #openstack-searchlight | 00:11 | |
| *** shu-mutou has joined #openstack-searchlight | 00:27 | |
| *** zhurong has joined #openstack-searchlight | 01:05 | |
| *** TravT has quit IRC | 01:21 | |
| *** lei-zh has joined #openstack-searchlight | 01:31 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/searchlight master: Updated from global requirements https://review.openstack.org/424625 | 02:06 |
|---|---|---|
| *** lei-zh1 has joined #openstack-searchlight | 03:38 | |
| *** lei-zh has quit IRC | 03:40 | |
| *** lei-zh1 has quit IRC | 04:05 | |
| *** lei-zh has joined #openstack-searchlight | 05:38 | |
| *** Jeffrey4l has quit IRC | 05:52 | |
| *** Jeffrey4l has joined #openstack-searchlight | 05:56 | |
| *** pcaruana has joined #openstack-searchlight | 07:50 | |
| *** Jeffrey4l_ has joined #openstack-searchlight | 08:30 | |
| *** Jeffrey4l has quit IRC | 08:34 | |
| *** Jeffrey4l_ has quit IRC | 08:37 | |
| *** Jeffrey4l_ has joined #openstack-searchlight | 08:38 | |
| *** shu-mutou is now known as shu-mutou-AWAY | 09:49 | |
| *** lei-zh has quit IRC | 10:07 | |
| *** openstackgerrit has quit IRC | 10:33 | |
| *** Guest6667 is now known as Guest6666 | 10:43 | |
| *** catintheroof has joined #openstack-searchlight | 12:24 | |
| *** zhurong has quit IRC | 12:45 | |
| *** zhurong has joined #openstack-searchlight | 13:35 | |
| *** yingjun has joined #openstack-searchlight | 14:03 | |
| *** zhurong has quit IRC | 14:16 | |
| *** matt-borland has joined #openstack-searchlight | 14:23 | |
| *** TravT has joined #openstack-searchlight | 15:04 | |
| *** pcaruana has quit IRC | 15:09 | |
| *** yingjun has quit IRC | 15:11 | |
| *** pcaruana has joined #openstack-searchlight | 15:23 | |
| *** pcaruana has quit IRC | 16:26 | |
| *** david-lyle_ has joined #openstack-searchlight | 17:52 | |
| *** david-lyle has quit IRC | 17:54 | |
| *** david-lyle_ is now known as david-lyle | 17:55 | |
| *** david-lyle has quit IRC | 18:04 | |
| *** david-lyle has joined #openstack-searchlight | 18:05 | |
| *** david-lyle has quit IRC | 18:23 | |
| *** david-lyle has joined #openstack-searchlight | 18:25 | |
| *** david-lyle has quit IRC | 18:29 | |
| *** david-lyle has joined #openstack-searchlight | 18:36 | |
| *** mriedem has joined #openstack-searchlight | 18:37 | |
| mriedem | sjmc7: do you know if searchlight supports / handles nova versioned notifications? | 18:38 |
| mriedem | i assumed it did when writing https://review.openstack.org/#/c/441692/ but wasn't actually sure | 18:38 |
| sjmc7 | mriedem: currently we consume the old unversioned ones. we planned to switch over to the versioned ones in ocata but mainly because of peoples’ availability we didn’t get round to it. i don’t forsee it being a huge amount of work | 18:59 |
| sjmc7 | and we need to do it anyway | 18:59 |
| mriedem | ok, do you have a blueprint or something tracking that work? | 19:00 |
| sjmc7 | yep, one sec | 19:00 |
| sjmc7 | https://blueprints.launchpad.net/searchlight/+spec/nova-versioned-notifications | 19:00 |
| *** david-lyle has quit IRC | 19:04 | |
| *** david-lyle has joined #openstack-searchlight | 19:06 | |
| mriedem | sjmc7: random question, but do you know where the "compute." prefix gets into the event type? | 19:13 |
| mriedem | i.e. compute.instance.create.start | 19:13 |
| mriedem | i see where nova emits the instance.create.start, but not what puts the compute. prefix on that | 19:14 |
| sjmc7 | no idea! possibly oslo? | 19:14 |
| sjmc7 | since it matches the service type? | 19:14 |
| sjmc7 | all the notifications seem prefixed that way (‘image’, ‘dns’ etc) | 19:15 |
| mriedem | for unversioned i think it might be this https://github.com/openstack/nova/blob/master/nova/compute/utils.py#L324 | 19:16 |
| sjmc7 | ah, that’d be it. it may not have that prefix for versioned | 19:16 |
| mriedem | for versioned it's this https://github.com/openstack/nova/blob/master/nova/compute/utils.py#L356 | 19:16 |
| mriedem | right, i think versioned doesn't have the prefix | 19:17 |
| sjmc7 | when we implemented versioned notifications for ironic it was quite different to the unversioned ones for other services | 19:17 |
| sjmc7 | lemme check to see if they have a prefix | 19:17 |
| sjmc7 | hm.. they have ‘baremetal' | 19:18 |
| mriedem | ok. i don't know if dropping the prefix for the nova versioned notifications was intentional or not. | 19:22 |
| mriedem | i can look back at the original spec | 19:22 |
| mriedem | did ironic use different notification topics? | 19:25 |
| sjmc7 | they didn’t have unversioned ones | 19:27 |
| mriedem | oh | 19:27 |
| mriedem | i found https://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/versioned-notification-transformation-newton.html#notifications-impact | 19:27 |
| mriedem | "As implemented in the versioned-notification-api bp the versioned notifications are always emitted to a different amqp topic called ‘versioned_notifications’ so the consumer can differentiate between the legacy and the new format by the topic." | 19:27 |
| mriedem | but i'm not sure that's true | 19:27 |
| sjmc7 | it’d be a bit awkward if theyt go to the same one | 19:28 |
| mriedem | well, i'm wondering if they are going to the same one and that's why the versioned notifications dropped the compute. prefix | 19:29 |
| sjmc7 | hmmm. maybe one for Balazs | 19:29 |
| mriedem | oh i see it | 19:31 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/rpc.py#L92 | 19:31 |
| sjmc7 | ok. that’s good | 19:32 |
| mriedem | so we send to different topics with different event types | 19:32 |
| mriedem | legacy has the compute. prefix, versioned doesn't | 19:32 |
| sjmc7 | that’s probably ok. the handling is sufficiently different that changing the name wouldn’t be a big deal | 19:33 |
| *** Jeffrey4l_ has quit IRC | 21:34 | |
| *** Jeffrey4l_ has joined #openstack-searchlight | 21:37 | |
| *** matt-borland has quit IRC | 22:35 | |
| *** catintheroof has quit IRC | 22:41 | |
| *** catintheroof has joined #openstack-searchlight | 22:42 | |
| *** TravT has quit IRC | 22:43 | |
| *** catintheroof has quit IRC | 22:47 | |
| *** TravT has joined #openstack-searchlight | 23:05 | |
| *** catintheroof has joined #openstack-searchlight | 23:32 | |
| *** mriedem has quit IRC | 23:36 | |
| *** yingjun has joined #openstack-searchlight | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!