| *** voodookid has joined #openstack-security | 00:01 | |
| *** voodookid has quit IRC | 00:20 | |
| *** tmcpeak has joined #openstack-security | 01:34 | |
| *** bdpayne has joined #openstack-security | 02:44 | |
| *** bdpayne has quit IRC | 03:19 | |
| *** voodookid has joined #openstack-security | 04:44 | |
| *** voodookid has quit IRC | 04:46 | |
| *** voodookid has joined #openstack-security | 04:48 | |
| *** voodookid has quit IRC | 04:49 | |
| *** voodookid has joined #openstack-security | 05:06 | |
| *** bdpayne has joined #openstack-security | 06:28 | |
| *** elo has quit IRC | 06:29 | |
| *** voodookid has quit IRC | 06:42 | |
| *** elo has joined #openstack-security | 07:11 | |
| *** bdpayne has quit IRC | 07:20 | |
| *** woaizhy has joined #openstack-security | 09:17 | |
| *** woaizhy has left #openstack-security | 09:20 | |
| *** elo has quit IRC | 11:10 | |
| *** elo has joined #openstack-security | 12:35 | |
| *** voodookid has joined #openstack-security | 13:04 | |
| *** nkinder has quit IRC | 13:16 | |
| *** bknudson has joined #openstack-security | 13:17 | |
| *** elo has quit IRC | 13:33 | |
| *** gabriela has joined #openstack-security | 13:33 | |
| *** gabriela has left #openstack-security | 13:34 | |
| *** elo has joined #openstack-security | 13:34 | |
| *** paulmo has joined #openstack-security | 13:39 | |
| *** gabriela has joined #openstack-security | 13:42 | |
| *** gabriela has left #openstack-security | 13:51 | |
| *** nkinder has joined #openstack-security | 14:10 | |
| *** voodookid has quit IRC | 14:16 | |
| *** voodookid has joined #openstack-security | 14:39 | |
| *** tmcpeak has joined #openstack-security | 14:58 | |
| *** malini1 has joined #openstack-security | 14:59 | |
| nkinder | tmcpeak: hey | 15:00 |
|---|---|---|
| nkinder | tmcpeak: I just missed your ping yesterday | 15:00 |
| tmcpeak | nkinder: oh cool | 15:01 |
| nkinder | tmcpeak: you have a tab in your glance patch | 15:01 |
| tmcpeak | nkinder: my checkin failed because of pep8 | 15:01 |
| tmcpeak | nkinder: tab? | 15:01 |
| nkinder | tmcpeak: yep, a tab instead of a space | 15:01 |
| nkinder | or 4 spaces to be exact :) | 15:02 |
| tmcpeak | nkinder: oh yeah | 15:02 |
| *** openstackgerrit has joined #openstack-security | 15:02 | |
| tmcpeak | nkinder: so I'm pretty sure I know how to fix it, and I should have run tests locally (live and learn) | 15:02 |
| nkinder | tmcpeak: line 134 | 15:02 |
| tmcpeak | nkinder: this is a gift wrapped opportunity to practice my git chops though | 15:02 |
| tmcpeak | how does this sound | 15:02 |
| tmcpeak | 'git checkout xxx' | 15:02 |
| tmcpeak | fix the file | 15:02 |
| paulmo | If you are using vim, there are some handy settings to help you be more compliant with OpenStack rules (like spaces used instead of tabs and such) | 15:02 |
| tmcpeak | 'git add file' | 15:03 |
| tmcpeak | paulmo: oh vim has some stuff? | 15:03 |
| tmcpeak | 'git commit —amend' | 15:03 |
| tmcpeak | 'git checkout master' | 15:03 |
| tmcpeak | 'git pull' | 15:03 |
| paulmo | tmcpeak: I use these settings in my ~/.vimrc: | 15:03 |
| paulmo | syntax on | 15:03 |
| paulmo | set expandtab | 15:03 |
| paulmo | set tabstop=4 | 15:03 |
| paulmo | set shiftwidth=4 | 15:03 |
| tmcpeak | 'git checkout xxx' | 15:03 |
| tmcpeak | git rebase (if necessary) | 15:04 |
| tmcpeak | 'git review' | 15:04 |
| tmcpeak | paulmo: sweet! | 15:04 |
| paulmo | Nothing fancy but very useful | 15:04 |
| tmcpeak | paulmo: thanks! | 15:04 |
| nkinder | tmcpeak: sounds like you got it! | 15:04 |
| tmcpeak | nkinder: woohoo! | 15:04 |
| tmcpeak | anybody looking at this guy yet? | 15:09 |
| tmcpeak | https://review.openstack.org/#/c/108215/ | 15:09 |
| tmcpeak | nkinder: ok, the dreaded rebase | 15:11 |
| tmcpeak | time to RTFM and see how it goes :) | 15:12 |
| tmcpeak | nkinder: around? | 15:15 |
| tmcpeak | or paulmo: you know your stuff | 15:16 |
| tmcpeak | want to double check my logic? | 15:16 |
| nkinder | tmcpeak: yeah, I'm here | 15:16 |
| tmcpeak | nkinder: ok cool | 15:16 |
| tmcpeak | so master did have some changes, which I got with pull | 15:16 |
| tmcpeak | then checkout xxx | 15:16 |
| tmcpeak | and git rebase master | 15:16 |
| paulmo | Yep, half paying attention | 15:16 |
| tmcpeak | now both branches have all the changes, right? | 15:16 |
| nkinder | tmcpeak: they should. No conflicts were found? | 15:17 |
| tmcpeak | so I can 'git review' in xxx branch | 15:17 |
| tmcpeak | nkinder: nope | 15:17 |
| tmcpeak | nkinder: just wanted to make sure that the git rebase actually pushed both changes to both branches | 15:17 |
| nkinder | tmcpeak: I like to check with 'git status' and 'git log -2' to see if everything is kosher | 15:17 |
| tmcpeak | and not only one way | 15:17 |
| nkinder | tmcpeak: your change will not be on master (which is how you want it) | 15:17 |
| tmcpeak | hmm, 'on branch fix-shell-injection' 'nothing to commit' | 15:17 |
| tmcpeak | nkinder: which I guess makes sense, it was already committed | 15:18 |
| nkinder | yeah, 'git commit --amend' committed it locally | 15:18 |
| tmcpeak | git log -2 shows my change | 15:18 |
| nkinder | git review should push it up for review then | 15:19 |
| tmcpeak | but how can I verify those changes from master made it to this branch? | 15:19 |
| nkinder | tmcpeak: 'git log -2' on master | 15:19 |
| tmcpeak | oh, check the one before in git log -2? | 15:19 |
| nkinder | tmcpeak: then go back to your branch and 'git log -3' should show your patch on top of the latest 2 from master | 15:19 |
| tmcpeak | yeah, I see | 15:19 |
| tmcpeak | nkinder: ok all good, thanks man | 15:20 |
| nkinder | tmcpeak: sure | 15:20 |
| tmcpeak | ok take two! | 15:20 |
| tmcpeak | hmm | 15:21 |
| tmcpeak | you guys see this one? | 15:21 |
| tmcpeak | Obfuscation of config options marked as secret needs to be more opaque | 15:21 |
| tmcpeak | seemed like a good security hardening | 15:21 |
| tmcpeak | wonder why they decided not to fix it? | 15:21 |
| *** elo has quit IRC | 15:25 | |
| *** elo has joined #openstack-security | 15:27 | |
| tmcpeak | guess they will fix it, just not a vulnerability per-se | 15:36 |
| tmcpeak | so in this review in the latest OpenStack security digest, it is mentioning a change in /openstac/common/processutils.py | 15:45 |
| tmcpeak | and one of the parameters here is shell for subprocess, so might be worth looking for calls of this with shell=True in addition to the ones we were already looking at | 15:46 |
| tmcpeak | nkinder: around? | 15:52 |
| tmcpeak | or paulmo | 15:53 |
| tmcpeak | trying to find this strutils.mask_password function and not seeing it | 15:53 |
| paulmo | http://docs.openstack.org/developer/oslo-incubator/sourcecode/openstack/openstack.common.strutils.html helpful? | 15:54 |
| tmcpeak | paulmo: yeah, where in the code is that? | 15:54 |
| tmcpeak | I found this | 15:54 |
| tmcpeak | https://github.com/openstack/oslo.utils/blob/master/oslo/utils/strutils.py | 15:54 |
| tmcpeak | but… the function isn't in there | 15:54 |
| tmcpeak | unless we're overloading the crap out of source names it should be in there, yeah? | 15:55 |
| paulmo | Here it is: https://github.com/openstack/oslo-incubator/blob/master/openstack/common/strutils.py | 15:57 |
| tmcpeak | paulmo: oh, it's in incubator? you know what the difference is? | 15:58 |
| paulmo | I would guess that it is new code that is trying to make it into core Oslo… but really, I'm not sure how that works exactly. | 15:58 |
| tmcpeak | ahh ok | 15:58 |
| tmcpeak | paulmo: thanks for the help! | 15:58 |
| paulmo | Anytime! :) | 15:58 |
| *** gabriela1 has joined #openstack-security | 16:13 | |
| *** elo has quit IRC | 16:14 | |
| *** gabriela1 has left #openstack-security | 16:20 | |
| tmcpeak | allright, patch went through | 16:45 |
| tmcpeak | if you guys could have a look, would appreciate it | 16:45 |
| tmcpeak | https://review.openstack.org/#/c/108127/ | 16:45 |
| *** malini1 has quit IRC | 17:05 | |
| *** nkinder has quit IRC | 18:03 | |
| *** malini1 has joined #openstack-security | 18:04 | |
| *** nkinder has joined #openstack-security | 18:15 | |
| *** ved_lad has joined #openstack-security | 18:18 | |
| openstackgerrit | A change was merged to openstack/security-doc: last section in Service Authorization is confusing https://review.openstack.org/107928 | 18:26 |
| *** elo has joined #openstack-security | 18:28 | |
| *** nkinder has quit IRC | 19:37 | |
| *** malini1 has quit IRC | 19:42 | |
| *** paulmo has quit IRC | 19:48 | |
| *** gabriela1 has joined #openstack-security | 19:49 | |
| *** malini1 has joined #openstack-security | 19:52 | |
| *** paulmo has joined #openstack-security | 19:53 | |
| gabriela1 | kio | 19:54 |
| gabriela1 | 19:56 | |
| paulmo | Can we help you gabriela1? | 19:57 |
| gabriela1 | can we help you paulumo | 20:02 |
| gabriela1 | sorry | 20:02 |
| *** gabriela1 has left #openstack-security | 20:04 | |
| *** tmcpeak has quit IRC | 20:05 | |
| *** tmcpeak has joined #openstack-security | 20:06 | |
| *** ved_lad has quit IRC | 20:23 | |
| *** nkinder has joined #openstack-security | 20:30 | |
| *** ved_lad has joined #openstack-security | 21:03 | |
| *** gabriela has joined #openstack-security | 21:08 | |
| gabriela | nbhskdg | 21:08 |
| gabriela | hello | 21:08 |
| *** gabriela has left #openstack-security | 21:08 | |
| *** tmcpeak has quit IRC | 21:11 | |
| *** malini1 has quit IRC | 21:22 | |
| *** voodookid has quit IRC | 21:34 | |
| *** ved_lad has quit IRC | 22:05 | |
| *** gmurphy has quit IRC | 22:09 | |
| *** bknudson has quit IRC | 22:20 | |
| *** ved_lad has joined #openstack-security | 22:27 | |
| *** malini1 has joined #openstack-security | 22:30 | |
| *** malini1 has quit IRC | 22:44 | |
| *** ved_lad has quit IRC | 22:54 | |
| *** nkinder has quit IRC | 23:01 | |
| *** malini1 has joined #openstack-security | 23:07 | |
| *** gmurphy has joined #openstack-security | 23:17 | |
| *** tmcpeak has joined #openstack-security | 23:27 | |
| *** bknudson has joined #openstack-security | 23:28 | |
| *** tmcpeak1 has joined #openstack-security | 23:39 | |
| *** sicarie has joined #openstack-security | 23:39 | |
| *** tmcpeak has quit IRC | 23:43 | |
| *** tmcpeak1 has quit IRC | 23:44 | |
| *** sicarie has quit IRC | 23:44 | |
| *** nkinder has joined #openstack-security | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!