*** nkinder has joined #openstack-security | 00:03 | |
tmcpeak | Mr. nkinder | 00:03 |
---|---|---|
tmcpeak | you got a minute? | 00:03 |
nkinder | tmcpeak: yeah, what's up | 00:04 |
nkinder | though the "Mr." makes me think you might be a bot... :) | 00:05 |
tmcpeak | how do you feel about this for config file format: | 00:05 |
tmcpeak | haha | 00:05 |
tmcpeak | HOLA | 00:05 |
nkinder | did I win the lottery? | 00:05 |
tmcpeak | profiles: | 00:05 |
tmcpeak | Generic: | 00:05 |
tmcpeak | include: none | 00:05 |
tmcpeak | exceptions: | 00:05 |
tmcpeak | - test_bad_names | 00:05 |
tmcpeak | - test_chmod | 00:05 |
tmcpeak | OpenStack: | 00:05 |
tmcpeak | include: all | 00:05 |
tmcpeak | so Generic just runs test_bad_names and test_chmod | 00:05 |
tmcpeak | OpenStack runs everything | 00:05 |
*** voodookid has joined #openstack-security | 00:05 | |
tmcpeak | then you could do default include or exclude | 00:05 |
nkinder | so exceptions are exceptions to what is in include? | 00:06 |
tmcpeak | yep | 00:06 |
nkinder | can include list individual tests? | 00:06 |
tmcpeak | the way I'm thinking no | 00:06 |
tmcpeak | if you want to do individual tests you either include all or exclude all and then make exceptions | 00:07 |
tmcpeak | but if that's confusing I'm down to rethink it | 00:07 |
nkinder | ok, that's slightly counter intuitive, but works | 00:07 |
tmcpeak | counter intuitive is bad, mkay? | 00:07 |
nkinder | why not "includes" and "excludes"? | 00:07 |
tmcpeak | I just don't want to get into some logic puzzle if they put both | 00:07 |
nkinder | includes is "all" if not specific, and "excludes" is "none" if not specified | 00:08 |
tmcpeak | so if they put nothing, what's the behavior | 00:08 |
nkinder | all | 00:08 |
tmcpeak | I see | 00:08 |
nkinder | and if I put one test in "includes", that's all it runs | 00:08 |
tmcpeak | so then if you only want to run 2 tests you have to specifically exclude each test? | 00:08 |
nkinder | and if I just put one test in "excludes", it runs everything but that | 00:08 |
nkinder | no, just list those two in "includes" | 00:09 |
tmcpeak | ok, what if I put one test in includes and one test in excludes | 00:09 |
nkinder | same test or different? | 00:09 |
tmcpeak | different | 00:09 |
nkinder | if different, then it only runs the one in includes | 00:09 |
nkinder | because it wasn't excluded in the first place | 00:09 |
tmcpeak | so includes runs first, makes a list | 00:09 |
nkinder | form a logic/code standpoint you build up the included tests, then subtract the excluded tests | 00:09 |
tmcpeak | and then excludes subtracts things from that list | 00:09 |
tmcpeak | ok cool | 00:10 |
tmcpeak | yeah got it | 00:10 |
tmcpeak | that makes sense | 00:10 |
nkinder | if an excluded test was never in the list, it's a no-op | 00:10 |
tmcpeak | and includes: some test | 00:10 |
tmcpeak | excludes: all | 00:10 |
tmcpeak | means nothing runs | 00:10 |
tmcpeak | because all is subtracted from the one that would have ran | 00:10 |
tmcpeak | ok, what about if nothing is listed | 00:10 |
tmcpeak | default include everything? | 00:10 |
tmcpeak | btw nkinder: new bandit up | 00:12 |
tmcpeak | https://github.com/chair6/bandit | 00:12 |
nkinder | tmcpeak: cool! in your github fork? | 00:12 |
tmcpeak | includes decorator change | 00:12 |
tmcpeak | no, Jamie's | 00:12 |
nkinder | nothing included == run everything | 00:12 |
tmcpeak | I'll forwarn you, there was some minor f'ery with my check in | 00:12 |
tmcpeak | but neither of us had the chops to instantly know how to fix it and didn't want to bother | 00:12 |
tmcpeak | hence the description 'Merge of…' in the description | 00:13 |
tmcpeak | but yeah, newest changes in :) | 00:13 |
tmcpeak | so nkinder: | 00:19 |
tmcpeak | Generic: | 00:19 |
tmcpeak | include: all | 00:19 |
tmcpeak | exclude: | 00:19 |
tmcpeak | - test_bad_names | 00:19 |
tmcpeak | - test_chmod | 00:19 |
tmcpeak | the include: all here is not even necessary | 00:19 |
*** voodookid has quit IRC | 00:19 | |
tmcpeak | since default is going to be include all | 00:19 |
tmcpeak | right? | 00:19 |
nkinder | tmcpeak: yeah, but you don't even need to specify include | 00:19 |
nkinder | "all" should be an implicit default | 00:19 |
tmcpeak | right | 00:19 |
tmcpeak | ok cool | 00:19 |
nkinder | if you want to set it explicitly, that's fine too of course | 00:19 |
tmcpeak | cool | 00:20 |
tmcpeak | what if you say | 00:20 |
tmcpeak | include: | 00:20 |
tmcpeak | - all | 00:20 |
tmcpeak | - test_bad_names | 00:20 |
tmcpeak | then it should somehow know to just do all | 00:20 |
tmcpeak | yeah, nevermind, that's easy | 00:20 |
tmcpeak | nkinder: what do you think of those newest bandit changes? | 00:20 |
tmcpeak | I think the auto discover is pretty slick ;) | 00:21 |
nkinder | tmcpeak: looks good. I'll try to give it a run through this week | 00:22 |
tmcpeak | nkinder: cool | 00:23 |
*** dmccowan has joined #openstack-security | 00:39 | |
*** dmccowan_ has joined #openstack-security | 00:43 | |
*** dmccowan has quit IRC | 00:44 | |
*** dmccowan_ is now known as dmccowan | 00:44 | |
*** tmcpeak has quit IRC | 00:46 | |
*** bknudson has joined #openstack-security | 01:18 | |
*** voodookid has joined #openstack-security | 01:38 | |
*** voodookid has quit IRC | 02:11 | |
*** voodookid has joined #openstack-security | 02:15 | |
*** bdpayne has joined #openstack-security | 02:22 | |
*** voodookid has quit IRC | 02:23 | |
*** amrith is now known as amrith__ | 02:25 | |
*** dmccowan has quit IRC | 02:37 | |
*** dmccowan has joined #openstack-security | 02:38 | |
*** dmccowan has quit IRC | 03:16 | |
*** zz_naotok is now known as naotok | 03:22 | |
*** artrex has joined #openstack-security | 03:35 | |
*** artrex has quit IRC | 03:39 | |
*** bdpayne has quit IRC | 03:53 | |
*** voodookid has joined #openstack-security | 03:53 | |
*** bdpayne has joined #openstack-security | 03:54 | |
*** bdpayne has quit IRC | 04:45 | |
*** voodookid has quit IRC | 04:45 | |
*** bdpayne has joined #openstack-security | 05:24 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/security-doc: Imported Translations from Transifex https://review.openstack.org/118540 | 06:01 |
*** bdpayne has quit IRC | 06:02 | |
openstackgerrit | A change was merged to openstack/security-doc: Imported Translations from Transifex https://review.openstack.org/118540 | 06:48 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/118488 | 07:20 |
*** salv-orlando has joined #openstack-security | 08:41 | |
openstackgerrit | A change was merged to openstack/security-doc: Add project and service names to glossary https://review.openstack.org/118412 | 09:39 |
openstackgerrit | A change was merged to openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/118488 | 09:43 |
*** amrith__ is now known as amrith | 10:17 | |
*** naotok is now known as zz_naotok | 10:41 | |
*** dmccowan has joined #openstack-security | 12:20 | |
*** amrith is now known as _amrith_ | 12:28 | |
*** dmccowan_ has joined #openstack-security | 12:30 | |
*** dmccowan has quit IRC | 12:32 | |
*** dmccowan_ is now known as dmccowan | 12:32 | |
*** _amrith_ is now known as amrith | 13:10 | |
*** nkinder has quit IRC | 13:11 | |
*** bknudson has quit IRC | 13:26 | |
*** bknudson has joined #openstack-security | 13:44 | |
*** dmccowan has quit IRC | 13:48 | |
*** nkinder has joined #openstack-security | 13:58 | |
*** dmccowan has joined #openstack-security | 14:01 | |
*** voodookid has joined #openstack-security | 14:07 | |
*** voodookid has quit IRC | 14:30 | |
*** c633 has joined #openstack-security | 14:32 | |
c633 | hello | 14:32 |
*** c633 has quit IRC | 14:43 | |
*** voodookid has joined #openstack-security | 14:51 | |
*** bdpayne has joined #openstack-security | 15:13 | |
*** dmccowan has quit IRC | 15:37 | |
*** dmccowan has joined #openstack-security | 15:43 | |
*** tmcpeak has joined #openstack-security | 15:50 | |
*** bdpayne has quit IRC | 15:57 | |
*** bdpayne has joined #openstack-security | 15:59 | |
*** sweston_ has joined #openstack-security | 16:03 | |
*** chair6_ has joined #openstack-security | 16:03 | |
*** sweston has quit IRC | 16:08 | |
*** erw has quit IRC | 16:08 | |
*** Glass_saga_ has quit IRC | 16:08 | |
*** chair6 has quit IRC | 16:08 | |
*** sweston_ is now known as sweston | 16:08 | |
*** erw_ has joined #openstack-security | 16:09 | |
*** Glass_saga_ has joined #openstack-security | 16:09 | |
*** bdpayne_ has joined #openstack-security | 16:17 | |
*** bdpayne has quit IRC | 16:21 | |
*** chair6_ has quit IRC | 16:40 | |
*** chair6 has joined #openstack-security | 16:41 | |
*** bdpayne_ has quit IRC | 16:44 | |
*** bdpayne has joined #openstack-security | 17:08 | |
*** bdpayne has quit IRC | 17:10 | |
*** bdpayne has joined #openstack-security | 17:10 | |
*** tmcpeak has quit IRC | 17:11 | |
*** tmcpeak has joined #openstack-security | 17:13 | |
tmcpeak | so bdpyane: never were we to acquire ops, huh? | 17:17 |
bdpayne | not so much | 17:38 |
bdpayne | :-( | 17:38 |
tmcpeak | bdpayne: want help? | 17:39 |
tmcpeak | bdpayne: I can try to track down somebody and wave my hands | 17:39 |
bdpayne | I think it is just a matter of me finding the right people to pester | 17:39 |
bdpayne | I appreciate the offer though | 17:39 |
paulmo | HOLA &@8! :) | 17:39 |
tmcpeak | haha | 17:40 |
tmcpeak | bdpayne: ok, let me know if you get sick of it and want me to take a turn | 17:40 |
bdpayne | ok | 17:41 |
bdpayne | I just commented on the CR again | 17:41 |
tmcpeak | bdpayne: cool | 17:52 |
tmcpeak | nkinder: you around? | 17:52 |
nkinder | tmcpeak: yep | 17:52 |
tmcpeak | nkinder: I'm wondering if it' important to support stupidity in these profiles | 17:52 |
nkinder | such as? | 17:52 |
tmcpeak | a user can say include: all | 17:52 |
tmcpeak | which includes all tests even though it isn't required, default is include | 17:53 |
tmcpeak | that's fine | 17:53 |
tmcpeak | but | 17:53 |
tmcpeak | do I need to support exclude: all | 17:53 |
tmcpeak | which makes the test do nothing | 17:53 |
nkinder | tmcpeak: probably not | 17:53 |
tmcpeak | nkinder: ok cool, I was thinking the same | 17:53 |
nkinder | there's no value in spending time on that | 17:53 |
tmcpeak | yeah, I mean it isn't much time, it just makes the code slightly less nice and doesn't add anything | 17:54 |
tmcpeak | nkinder: ok cool, was thinking the time. Just wanted validation ;) | 17:54 |
tmcpeak | thinking the *sam | 18:17 |
tmcpeak | e | 18:17 |
tmcpeak | can't type or think functionally today apparently :D | 18:17 |
*** tmcpeak has quit IRC | 18:28 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/118747 | 19:03 |
*** tmcpeak has joined #openstack-security | 19:42 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/118747 | 19:53 |
tmcpeak | nkinder: new Bandit agin | 20:03 |
tmcpeak | again | 20:03 |
tmcpeak | now with profiles and yaml config | 20:03 |
tmcpeak | in my branch | 20:03 |
tmcpeak | here's changes if you want to see them: https://github.com/mcpeak/bandit/compare/chair6:master...master | 20:03 |
tmcpeak | a little code review would be good if you've got time | 20:03 |
chair6 | looks good to me! glad somebody has time to spend on this... :) | 20:15 |
*** tmcpeak has quit IRC | 20:22 | |
*** tmcpeak has joined #openstack-security | 20:27 | |
dmccowan | Hello OSSG. I have a background in security and I'm new to OpenStack. I'd like to contribute a security related patch to OpenStack before the summit. Does anyone have a bug on their backlog that they'd be willing to hand off to a newbie? | 20:33 |
*** dmccowan has quit IRC | 20:43 | |
tmcpeak | hmm, missed him | 21:00 |
tmcpeak | I just got a fresh batch of goodness I could have sent his way | 21:00 |
*** ChanServ sets mode: +o bdpayne | 21:09 | |
* bdpayne is now an op... please be nice ya'll | 21:10 | |
tmcpeak | woah | 21:11 |
tmcpeak | bdpayne: woahhhh | 21:11 |
tmcpeak | THA POWAAAAAAA | 21:11 |
tmcpeak | bdpayne: what did you have to do (out of curiosity)? | 21:13 |
bdpayne | "chanserv op #openstack-security bdpayne" | 21:14 |
bdpayne | which... I thought we did the other day | 21:14 |
bdpayne | but it worked today | 21:14 |
tmcpeak | yeah, that looks familiar | 21:14 |
*** tmcpeak has quit IRC | 21:17 | |
*** tmcpeak has joined #openstack-security | 21:20 | |
*** gabriela2 has joined #openstack-security | 21:27 | |
*** gabriela2 has left #openstack-security | 21:28 | |
tmcpeak | woah, just in time | 21:39 |
tmcpeak | gabriela is back! | 21:39 |
tmcpeak | nkinder: around? | 21:53 |
openstackgerrit | Travis McPeak proposed a change to openstack/security-doc: Adding OSSN-0026: Unrestricted write permission to config files can allow code execution https://review.openstack.org/118910 | 21:59 |
*** tmcpeak has quit IRC | 22:05 | |
*** nkinder has quit IRC | 22:10 | |
*** openstack has joined #openstack-security | 22:11 | |
*** nkinder has joined #openstack-security | 22:26 | |
*** bknudson has quit IRC | 22:41 | |
*** nkinder has quit IRC | 22:53 | |
*** voodookid has quit IRC | 23:06 | |
*** dmccowan has joined #openstack-security | 23:18 | |
*** tmcpeak has joined #openstack-security | 23:21 | |
*** dmccowan_ has joined #openstack-security | 23:22 | |
*** dmccowan has quit IRC | 23:22 | |
*** dmccowan_ is now known as dmccowan | 23:22 | |
tmcpeak | hey dmccowan: has anybody responded to you yet? | 23:22 |
dmccowan | not yet, but I was offline for a while | 23:22 |
tmcpeak | ok, I've got to run but we can definitely get you set up for some work | 23:23 |
tmcpeak | welcome to OSSG btw | 23:23 |
dmccowan | thank you | 23:23 |
tmcpeak | cool, want to come on tomorrow during the day sometime? | 23:26 |
dmccowan | sure, i'll be logged in most of EDT hours. I'll try to remember to check. or let me know if you want to set a specific time. | 23:27 |
tmcpeak | sure, EDT is fine. Just ping me sometime you see me on and I'll get you set up with something | 23:28 |
dmccowan | that's great. thanks! | 23:29 |
tmcpeak | cool, np | 23:29 |
tmcpeak | later | 23:29 |
*** tmcpeak has quit IRC | 23:31 | |
*** nkinder has joined #openstack-security | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!