| *** voodookid has joined #openstack-security | 00:45 | |
| *** bdpayne has quit IRC | 00:48 | |
| *** voodookid has quit IRC | 00:56 | |
| *** voodookid has joined #openstack-security | 00:58 | |
| *** canaima has joined #openstack-security | 01:08 | |
| *** canaima has quit IRC | 01:08 | |
| *** voodookid has quit IRC | 01:16 | |
| *** salv-orlando has quit IRC | 01:33 | |
| *** _amrith_ is now known as amrith | 02:22 | |
| *** zz_naotok is now known as naotok | 03:03 | |
| *** bdpayne has joined #openstack-security | 03:09 | |
| *** dmccowan has quit IRC | 03:21 | |
| *** voodookid has joined #openstack-security | 04:32 | |
| *** bdpayne has quit IRC | 04:33 | |
| *** voodookid has quit IRC | 04:53 | |
| *** salv-orlando has joined #openstack-security | 05:16 | |
| *** salv-orlando has quit IRC | 05:22 | |
| *** salv-orlando has joined #openstack-security | 06:20 | |
| *** salv-orlando has quit IRC | 07:04 | |
| *** naotok is now known as zz_naotok | 07:58 | |
| *** salv-orlando has joined #openstack-security | 09:05 | |
| *** zz_naotok is now known as naotok | 09:31 | |
| *** salv-orlando has quit IRC | 10:28 | |
| *** salv-orlando has joined #openstack-security | 10:45 | |
| *** salv-orlando_ has joined #openstack-security | 10:53 | |
| *** salv-orlando_ has quit IRC | 10:53 | |
| *** salv-orlando has quit IRC | 10:55 | |
| *** amrith is now known as _amrith_ | 11:45 | |
| *** naotok is now known as zz_naotok | 11:46 | |
| openstackgerrit | Tim Kelsey proposed a change to openstack/security-doc: Adding OSSN-0027 - Neutron ARP cache poisoning vulnerability. https://review.openstack.org/119353 | 12:00 |
|---|---|---|
| *** openstackgerrit has quit IRC | 12:01 | |
| *** openstackgerrit has joined #openstack-security | 12:02 | |
| *** dmccowan has joined #openstack-security | 12:10 | |
| *** dmccowan has quit IRC | 12:17 | |
| *** dmccowan_ has joined #openstack-security | 12:18 | |
| *** _amrith_ is now known as amrith | 13:05 | |
| *** paulmo has joined #openstack-security | 13:15 | |
| *** bknudson has quit IRC | 13:30 | |
| *** bknudson has joined #openstack-security | 13:51 | |
| *** voodookid has joined #openstack-security | 14:02 | |
| *** voodookid has quit IRC | 14:24 | |
| *** salv-orlando has joined #openstack-security | 14:26 | |
| *** tmcpeak has joined #openstack-security | 14:27 | |
| tmcpeak | nkinder: you around? | 14:41 |
| *** voodookid has joined #openstack-security | 14:56 | |
| *** dmccowan_ has quit IRC | 15:11 | |
| *** bdpayne has joined #openstack-security | 15:15 | |
| tmcpeak | bdpayne: looks like OSSN-0026 has sufficient amount of love to send it off | 15:16 |
| *** bdpayne has quit IRC | 15:29 | |
| nkinder | tmcpeak: yeah | 15:31 |
| tmcpeak | ok, so for cleaning up 24 | 15:32 |
| tmcpeak | I'm going to need to do some dirt with Git | 15:32 |
| *** dmccowan has joined #openstack-security | 15:32 | |
| tmcpeak | since I have an OSSN in flight I'm thinking check out the entire security doc to a different directory | 15:32 |
| tmcpeak | then, since OSSN-0024 isn't in it, I'll use that git fetch command listed on the review | 15:32 |
| nkinder | tmcpeak: just create a separate branch | 15:32 |
| tmcpeak | mmmm | 15:33 |
| nkinder | tmcpeak: did you do your work on 0026 on a branch? | 15:33 |
| tmcpeak | yeah, I know that's the right answer | 15:33 |
| tmcpeak | but if I forget to switch back I really don't want to have to deal with any craziness | 15:33 |
| tmcpeak | no, I didn't create a branch | 15:33 |
| tmcpeak | bad habit | 15:33 |
| tmcpeak | did it all on master | 15:33 |
| nkinder | tmcpeak: well, don't forget... :) | 15:33 |
| tmcpeak | fair enough | 15:33 |
| nkinder | tmcpeak: easy to fix now.... | 15:33 |
| nkinder | tmcpeak: git log -2, then 'git reset --hard <previous commit>' | 15:34 |
| tmcpeak | there's not going to be any craziness? | 15:34 |
| tmcpeak | 26 is almost in the bag | 15:34 |
| nkinder | I'm reviewing 26 now | 15:34 |
| tmcpeak | can't take craziness, it's Friday | 15:34 |
| nkinder | so everything for 26 is up in gerrit, so you can nuke your local copy first | 15:34 |
| nkinder | which that reset will do | 15:34 |
| tmcpeak | what if I need to change it again? | 15:35 |
| nkinder | once it's reset, 'git review -d 118910' will pull down your review in a branch | 15:35 |
| tmcpeak | now I can just do git add OSSN-0026, git commit —amend, git review | 15:35 |
| tmcpeak | ahh ok | 15:35 |
| nkinder | in that new branch, you can do the same thing | 15:35 |
| tmcpeak | allright nkinder, you've never steered me wrong | 15:35 |
| nkinder | tmcpeak: if you want to work on something else, 'git checkout master', 'git pull', 'git checkout -b new_branch' | 15:36 |
| tmcpeak | nkinder: ok, now I'm on new branch OSSN-0024 | 15:37 |
| tmcpeak | how do I grab what he had | 15:37 |
| tmcpeak | is it that git fetch command listed below the review? | 15:37 |
| nkinder | tmcpeak: ah, you can take a shortcut | 15:37 |
| nkinder | tmcpeak: you don't need to create your own OSSN-0024 branch | 15:37 |
| nkinder | so let's clean that up first | 15:37 |
| tmcpeak | oops | 15:37 |
| nkinder | git checkout master, git branch -d OSSN-0024 | 15:38 |
| tmcpeak | cool | 15:38 |
| nkinder | You can pull down shohel's review with 'git review -d <review_id>' | 15:38 |
| nkinder | that will create a branch for you | 15:38 |
| tmcpeak | oh nice | 15:38 |
| nkinder | you can update 0024 there, then git review to push up a new revision | 15:38 |
| tmcpeak | that's a cool trick | 15:39 |
| tmcpeak | so from here after I modify, it will be git add ... | 15:39 |
| tmcpeak | then git commit —amend or just git commit? | 15:39 |
| nkinder | tmcpeak: the word 'arbitrary' would be good in the title of 0026, but that makes it a bit long | 15:39 |
| nkinder | git add <file>, git commit --amend, git review | 15:40 |
| tmcpeak | cool | 15:40 |
| tmcpeak | nkinder: yeah, I really prefer those to be one line | 15:41 |
| tmcpeak | nkinder: hey, so anybody can just snatch anybody else's review anytime they want? | 15:42 |
| nkinder | tmcpeak: me too. I'm happy with it as is | 15:42 |
| nkinder | tmcpeak: yep | 15:42 |
| tmcpeak | nice, I see a karma pharming opportunity | 15:42 |
| nkinder | tmcpeak: git review -d is handy for pulling down and testing others patches too | 15:42 |
| nkinder | tmcpeak: well, people might also take offense if you snatch stuff... | 15:42 |
| tmcpeak | nkinder: lol, yeah, big time | 15:42 |
| nkinder | tmcpeak: especially if you modify the "author" in the patch | 15:43 |
| tmcpeak | nkinder: oh, right | 15:44 |
| tmcpeak | btw, what's the deal with this one? I haven't seen shohel in a while | 15:44 |
| tmcpeak | is he on vacation or something? | 15:44 |
| nkinder | tmcpeak: if you do lots of work, you can at a 'Co-authored by:' tag | 15:44 |
| nkinder | tmcpeak: probably just the timezone difference with Finland | 15:44 |
| nkinder | tmcpeak: unless you're up early... :) | 15:44 |
| tmcpeak | nkinder: yeah, true | 15:45 |
| nkinder | tmcpeak: just approved 0026 | 15:45 |
| nkinder | I'll publish it shortly | 15:45 |
| tmcpeak | sweet | 15:45 |
| nkinder | Don't really need a +1 from a projet core for this since it's a more generic note | 15:46 |
| tmcpeak | nkinder: between the 18 revisions on OSSN-0017, and the 5 here, I'm averaging to something reasonable | 15:46 |
| openstackgerrit | A change was merged to openstack/security-doc: Adding OSSN-0026: Unrestricted write permission to config files can allow code execution https://review.openstack.org/118910 | 15:50 |
| tmcpeak | there it goes | 15:50 |
| openstackgerrit | Travis McPeak proposed a change to openstack/security-doc: Adds a new OpenStack Security Notes OSSN-0024: Sensitive data exposure by logging in python-keystoneclient https://review.openstack.org/114460 | 15:52 |
| tmcpeak | ^ could use some reviews on that one | 15:54 |
| *** bdpayne has joined #openstack-security | 16:04 | |
| bdpayne | tmcpeak I'll take a look | 16:06 |
| bdpayne | tmcpeak, looks like nkinder beat me to it :-) | 16:09 |
| *** amrith is now known as _amrith_ | 16:12 | |
| tmcpeak | bdpayne: not 26, | 16:12 |
| tmcpeak | 24: https://review.openstack.org/#/c/114460/ | 16:12 |
| bdpayne | but... you said 26 :-) | 16:12 |
| bdpayne | I'll take a look at 24 | 16:12 |
| tmcpeak | that one's in the bag :) | 16:12 |
| openstackgerrit | Travis McPeak proposed a change to openstack/security-doc: Adds a new OpenStack Security Notes OSSN-0024: Sensitive data exposure by logging in python-keystoneclient https://review.openstack.org/114460 | 16:13 |
| tmcpeak | hang on, still some formatting to fix | 16:13 |
| bdpayne | you're killing me here | 16:14 |
| tmcpeak | lol sh* | 16:16 |
| tmcpeak | nkinder | 16:16 |
| tmcpeak | I've screwed myself up in git again | 16:16 |
| tmcpeak | :'( | 16:16 |
| bdpayne | what have you done? | 16:17 |
| tmcpeak | lol, I screwed up the top message when doing commit —ammend so it thought I had two checkins | 16:18 |
| openstackgerrit | Travis McPeak proposed a change to openstack/security-doc: Adds a new OpenStack Security Notes OSSN-0024: Sensitive data exposure by logging in python-keystoneclient https://review.openstack.org/114460 | 16:19 |
| bdpayne | do you have two commits? | 16:19 |
| tmcpeak | bdpayne: yeah, fixed it | 16:19 |
| tmcpeak | all yours | 16:19 |
| bdpayne | yeah, it looks reasonable now :-) | 16:19 |
| bdpayne | I can review in a few | 16:19 |
| tmcpeak | sounds good | 16:19 |
| *** rlpple has joined #openstack-security | 16:26 | |
| bdpayne | but... you just -1'd it? | 16:44 |
| * bdpayne is confused | 16:44 | |
| tmcpeak | bdpayne: yeah, it's actually not mine | 16:49 |
| tmcpeak | it's shohel's | 16:49 |
| bdpayne | yeah, but I thought you were just fixing it up | 16:50 |
| tmcpeak | I just mean we need to move it along | 16:50 |
| tmcpeak | yeah, I was just formatting it | 16:50 |
| bdpayne | ahh | 16:50 |
| tmcpeak | I don't know if he'll take it over or not | 16:50 |
| tmcpeak | maybe leave comments and if it's still dead ended next week I'll just take it over | 16:50 |
| bdpayne | ok | 16:52 |
| *** openstackgerrit has quit IRC | 17:04 | |
| *** salv-orlando has quit IRC | 17:14 | |
| *** openstackgerrit has joined #openstack-security | 18:10 | |
| *** elo1 has joined #openstack-security | 18:14 | |
| nkinder | tmcpeak: your line wrapping on 0026 is incorrect :( | 18:56 |
| nkinder | tmcpeak: you wrapped at 79 instead of 72 | 18:56 |
| tmcpeak | I thought they were always wrapped at 79 | 18:57 |
| tmcpeak | nkinder: ^ | 18:58 |
| tmcpeak | how should I fix it? | 18:58 |
| nkinder | 79 is python, 72 is for PGP signing for e-mail | 18:58 |
| tmcpeak | oh crap, so it went out on the ML looking all messed up? | 18:58 |
| nkinder | tmcpeak: create a new branch, fix it, then submit it just as you would for a new note | 18:58 |
| nkinder | tmcpeak: no, I caught it when preparing the ML announcement | 18:58 |
| tmcpeak | oh awesome | 18:58 |
| nkinder | tmcpeak: so let's fix it first, then I'll send it out | 18:59 |
| nkinder | tmcpeak: can you handle that, then point me to the review? | 18:59 |
| tmcpeak | I'll have to update the wiki too | 18:59 |
| tmcpeak | forgot about that | 18:59 |
| tmcpeak | yep, will do | 18:59 |
| nkinder | tmcpeak: thanks! | 18:59 |
| nkinder | tmcpeak: I need to add a line-wrapping gate job... | 18:59 |
| tmcpeak | yeah, I totally thought it was 80 this whole time | 19:00 |
| tmcpeak | nkinder: made a new branch, how do I get 0026 in it | 19:01 |
| tmcpeak | tried git pull origin my_branch | 19:01 |
| *** openstackgerrit has quit IRC | 19:01 | |
| *** openstackgerrit has joined #openstack-security | 19:02 | |
| tmcpeak | nkinder: nvm, fixed it | 19:05 |
| *** dmccowan has quit IRC | 19:07 | |
| openstackgerrit | Travis McPeak proposed a change to openstack/security-doc: Fixing line length for OSSN-0026 to fit in mail https://review.openstack.org/119447 | 19:10 |
| tmcpeak | nkinder: ^ | 19:10 |
| tmcpeak | nkinder: if you do a gate test job for line length it has to be smart enough to ignore links | 19:11 |
| openstackgerrit | Travis McPeak proposed a change to openstack/security-doc: Adds a new OpenStack Security Notes OSSN-0024: Sensitive data exposure by logging in python-keystoneclient https://review.openstack.org/114460 | 19:21 |
| *** salv-orlando has joined #openstack-security | 19:41 | |
| openstackgerrit | A change was merged to openstack/security-doc: Fixing line length for OSSN-0026 to fit in mail https://review.openstack.org/119447 | 20:08 |
| *** gabriela2 has joined #openstack-security | 20:12 | |
| *** gabriela2 has left #openstack-security | 20:12 | |
| nkinder | tmcpeak: 0026 has left the building... | 20:17 |
| *** _amrith_ is now known as amrith | 20:20 | |
| tmcpeak | nkinder: woohoo | 20:25 |
| tmcpeak | :) | 20:25 |
| tmcpeak | I touched up 24 too | 20:25 |
| tmcpeak | nkinder: you did the wiki? | 20:28 |
| tmcpeak | nkinder: that's very… wait for it: kind(er) of you | 20:33 |
| tmcpeak | see what I did there!? :'D | 20:33 |
| nkinder | tmcpeak: yep, took care of the wiki too | 20:56 |
| nkinder | tmcpeak: I usually do that as a part of publishing in case it's not up to date | 20:56 |
| tmcpeak | nkinder: oh cool, I was going to loop around and grab it and then I saw you already did | 21:05 |
| *** nkinder has quit IRC | 21:26 | |
| *** rlpple has quit IRC | 21:26 | |
| *** openstackgerrit has quit IRC | 21:31 | |
| *** openstackgerrit has joined #openstack-security | 21:32 | |
| *** bdpayne has quit IRC | 22:20 | |
| *** bknudson has quit IRC | 22:30 | |
| *** voodookid has quit IRC | 23:08 | |
| *** bdpayne has joined #openstack-security | 23:49 | |
| *** bdpayne has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!