Wednesday, 2015-06-03

*** tmcpeak has joined #openstack-security00:01
*** browne has joined #openstack-security00:03
*** shakamunyi has joined #openstack-security00:12
*** barra204 has joined #openstack-security00:12
*** salv-orlando has joined #openstack-security00:48
*** salv-orlando has quit IRC00:55
*** superfly_ has joined #openstack-security01:12
*** bpokorny has quit IRC01:12
*** superfly_ is now known as superflyy01:14
*** barra204 has quit IRC01:24
*** shakamunyi has quit IRC01:24
*** superflyy has quit IRC01:24
*** browne has quit IRC01:31
openstackgerritEmett Speer proposed openstack/security-doc: Conslidated many of the small sections.  https://review.openstack.org/18709201:56
*** salv-orlando has joined #openstack-security02:08
*** sdake has quit IRC02:11
*** salv-orlando has quit IRC02:14
*** mohitsharma has joined #openstack-security02:20
*** tmcpeak has quit IRC02:59
*** tkelsey has joined #openstack-security03:06
*** nkinder_ has joined #openstack-security03:09
*** tkelsey has quit IRC03:10
*** mohitsharma has quit IRC03:13
*** mohitsharma has joined #openstack-security03:17
*** markvoelker has quit IRC03:44
*** browne has joined #openstack-security03:55
*** salv-orlando has joined #openstack-security04:10
*** markvoelker has joined #openstack-security04:45
*** markvoelker has quit IRC04:50
*** mohitsharma has quit IRC05:05
*** mohitsharma has joined #openstack-security05:56
*** shakamunyi has joined #openstack-security06:16
*** barra204 has joined #openstack-security06:17
openstackgerritStanislaw Pitucha proposed stackforge/anchor: Fix notBefore/notAfter handling in non-UTC time  https://review.openstack.org/18666006:23
openstackgerritStanislaw Pitucha proposed stackforge/anchor: Force pep8 to run using python2  https://review.openstack.org/18787706:29
*** mohitsharma has quit IRC06:29
*** mohitsharma has joined #openstack-security06:29
*** markvoelker has joined #openstack-security06:34
*** markvoelker has quit IRC06:38
openstackgerritStanislaw Pitucha proposed stackforge/anchor: Fix notBefore/notAfter handling in non-UTC time  https://review.openstack.org/18666006:55
*** browne has quit IRC07:02
*** alex_klimov has joined #openstack-security07:19
*** mohitsharma has quit IRC07:27
*** mohitsharma has joined #openstack-security07:27
*** markvoelker has joined #openstack-security08:22
*** markvoelker has quit IRC08:27
*** tkelsey has joined #openstack-security08:34
*** mohitsharma has quit IRC10:08
*** markvoelker has joined #openstack-security10:11
*** markvoelker has quit IRC10:15
*** sdake has joined #openstack-security11:02
*** tkelsey has quit IRC11:05
*** tkelsey has joined #openstack-security11:09
*** zul has quit IRC11:22
*** tkelsey has quit IRC11:23
*** zul has joined #openstack-security11:28
*** markvoelker has joined #openstack-security11:42
*** markvoelker has quit IRC11:46
*** tkelsey has joined #openstack-security11:50
*** tkelsey has quit IRC11:54
*** mohitsharma has joined #openstack-security11:57
*** markvoelker has joined #openstack-security12:01
*** tkelsey has joined #openstack-security12:38
openstackgerritStanislaw Pitucha proposed stackforge/anchor: Fix notBefore/notAfter handling in non-UTC time  https://review.openstack.org/18666012:48
*** bknudson has joined #openstack-security12:56
*** dave-mcc_ has joined #openstack-security13:19
*** dave-mccowan has quit IRC13:23
*** singlethink has joined #openstack-security13:31
*** sigmavirus24_awa is now known as sigmavirus2413:54
*** singleth_ has joined #openstack-security13:58
*** singlethink has quit IRC14:01
*** barra204 has quit IRC14:36
*** shakamunyi has quit IRC14:36
*** voodookid has joined #openstack-security14:45
chair6hey sigmavirus24 .. penny for your thoughts on https://review.openstack.org/#/c/186212/?14:47
sigmavirus24If that's the Py34 patch, I'm replying to everyone at once14:47
sigmavirus24:D14:47
chair6hah, cool :)14:47
sigmavirus24Just distracted by team chat asking me questions about stuff =P14:47
chair6i know that feeling..14:47
*** dwyde has joined #openstack-security14:57
sigmavirus24chair6: are you Jamie?15:11
chair6yep..15:15
*** alex_klimov has quit IRC15:23
*** tmcpeak has joined #openstack-security15:24
*** RawInfoSec has joined #openstack-security15:27
*** singlethink has joined #openstack-security15:28
sigmavirus24chair6: that's very confusing =P15:30
*** singleth_ has quit IRC15:31
*** RawInfoSec has left #openstack-security15:33
chair6haha, howso?15:34
*** mohitsharma has quit IRC15:35
sigmavirus24/whois chair6 just says you're too lazy to read the docs for BitchX15:36
sigmavirus24and I'm newish here so =P15:37
chair6oh right, i come from the bad ol' days when the name field was for anything but a real name.. :)15:41
*** bpokorny has joined #openstack-security15:42
elmikolol15:42
sigmavirus24chair6: I do too15:44
sigmavirus24But when I started working on OpenStack I decided to be nicer15:44
sigmavirus24chair6: just to be clear, the minor tweaks you were imagining were...15:45
chair6oh.. there was erics suggestion to add 3.4 to setup.cfg, and the constants.* references in jinja2_templates.py that your comment said you didn't mean to commit15:48
sigmavirus24right that's what I was thinking too15:50
sigmavirus24okay :D15:50
openstackgerritIan Cordasco proposed stackforge/bandit: Add Python 3.4 compatibility to bandit  https://review.openstack.org/18621215:50
openstackgerritIan Cordasco proposed stackforge/bandit: Update example files to work on Python 2 & 3  https://review.openstack.org/18768515:50
sigmavirus24So trivial rebases (the example files update) doesn't lose +2s but does lose +Ws. Good to know15:51
*** mohitsharma has joined #openstack-security15:52
*** singlethink has quit IRC15:58
*** tkelsey has quit IRC16:01
sigmavirus24chair6: am I missing something? Does @checks also define the name of the plugin for use in bandit.yml?16:12
sigmavirus24tmcpeak: same question ^16:14
openstackgerritMerged stackforge/anchor: Adding more docs strings  https://review.openstack.org/18718116:15
chair6@checks decorator is used to show what AST nodes a check should be executed against16:16
sigmavirus24Right, so did the exec.py check name change because the file name changed between the last release and when I started doing the compatibility work?16:16
sigmavirus24If so, Eric's comment seems tangential to the change, unless I'm missing something else16:17
sigmavirus24oh16:17
tmcpeaksigmavirus24: no, it doesn't matter about the file name change16:17
tmcpeakthe function name matters16:17
sigmavirus24I named the py3 function differently16:17
tmcpeaksigh, numbrs spamming anybody else?16:17
sigmavirus24Should I change that now, or later. I would think it should be the same but I missed that16:18
sigmavirus24tmcpeak: no but there has been a preponderence of bots sending spam links in DMs16:18
sigmavirus24tmcpeak: #freenode has IRCops that will kline them16:18
tmcpeaksigmavirus24: change now please, then we don't have to update bandit.yaml anywhere16:18
tmcpeakcool, I'll pop in there16:18
openstackgerritIan Cordasco proposed stackforge/bandit: Add Python 3.4 compatibility to bandit  https://review.openstack.org/18621216:19
sigmavirus24Fixed16:19
tmcpeakcool16:19
*** ChanServ sets mode: +o tmcpeak16:20
*** jamielennox is now known as jamielennox|away16:21
sigmavirus24oh tmcpeak they were spamming me the other day with that nick and a different one16:21
sigmavirus24I complained and the other one got klined but not nunbr\ s though16:21
*** barra204 has joined #openstack-security16:21
*** tmcpeak sets mode: +b *!nunbrs@84.78.24.23716:22
*** nunbrs was kicked by tmcpeak (NO SPAM!)16:22
*** nunbrs has joined #openstack-security16:22
tmcpeakwell that failed16:22
*** tmcpeak sets mode: +b *!~nunbrs@84.78.24.23716:24
*** nunbrs was kicked by tmcpeak (NO SPAM!)16:24
*** sriatom has joined #openstack-security16:24
tmcpeaksweet16:24
*** ChanServ sets mode: -o tmcpeak16:24
tmcpeaksigmavirus24: I think the new patch will still have the problem16:26
tmcpeakbecause exec_used changed to exec_issue16:26
tmcpeakoh I see16:26
tmcpeaknevermind16:26
tmcpeakcool16:26
tmcpeakthis looks good16:26
*** singlethink has joined #openstack-security16:27
*** barra204 has quit IRC16:28
openstackgerritIan Cordasco proposed stackforge/bandit: Update example files to work on Python 2 & 3  https://review.openstack.org/18768516:28
sigmavirus24tmcpeak: we could uncomment those Python 3 sections if we precede the statements with hasattr(_ast, 'Python3OnlyType') and isinstance(node, _ast.Python3OnlyType)16:36
tmcpeaksigmavirus24: ahh ok cool, that sounds reasonable16:37
sigmavirus24tmcpeak: alright, I'll do that in a follow-up patch16:37
sigmavirus24that also eliminates that attr check as a fallback for NamedConstant16:38
sigmavirus24Actually, I guess we could say "if six.PY3 and isinstance(..)"16:38
sigmavirus24that's probably a bit more obvious to any future readers of the code why it works that way16:38
tmcpeakyeah, that reads more clearly16:43
tmcpeakcool, sounds good16:43
tmcpeakyeah, we can get this one out for now16:44
*** dwyde has quit IRC16:48
* sigmavirus24 probably could have ordered the examples/py34 work differently but it didn't occur to me at the time16:51
openstackgerritMerged stackforge/bandit: Add Python 3.4 compatibility to bandit  https://review.openstack.org/18621216:51
openstackgerritMerged stackforge/bandit: Update example files to work on Python 2 & 3  https://review.openstack.org/18768516:51
sigmavirus24Woah16:51
sigmavirus24That was timely16:52
*** mohitsharma has quit IRC16:52
*** sriatom is now known as _sri16:53
*** kutija has joined #openstack-security16:57
chair6looks good ian, thanks for all the work on this!16:58
sigmavirus24chair6: happy to help17:00
sigmavirus24I have too much experience adding Py3 compat to things17:00
sigmavirus24Bandit was rather easy17:00
sigmavirus24Because it wasn't originally written for Py2517:00
sigmavirus24*and* we're not doing any junk with bytes that require the same str-like API from Python 2 ;)17:01
* sigmavirus24 has gripes17:01
sigmavirus24I'll address everything else after I get back from lunch17:03
*** Codeman655 has joined #openstack-security17:30
*** dwyde has joined #openstack-security17:43
*** barra204 has joined #openstack-security18:57
*** barra204 has quit IRC19:02
*** dwyde has quit IRC19:35
*** Codeman655 has quit IRC19:41
*** dwyde has joined #openstack-security19:43
*** _sri has quit IRC19:53
*** barra204 has joined #openstack-security19:58
*** dave-mcc_ has quit IRC20:02
*** barra204 has quit IRC20:03
*** dave-mccowan has joined #openstack-security20:05
*** salv-orlando has quit IRC20:09
*** salv-orlando has joined #openstack-security20:09
chair6jelle wrote a little article showing bandit/jenkins integration .. http://vdwaa.nl/bandit/python/security/jenkins/openstack-bandit-jenkins-integration/20:23
chair6another way of doing things outside of gerrit land..20:23
elmikoneat20:25
*** singleth_ has joined #openstack-security20:32
*** singlethink has quit IRC20:35
*** yusgot has joined #openstack-security20:43
*** sicarie has quit IRC21:16
*** alex_klimov has joined #openstack-security21:21
bknudson"found some issues in our code" -- that is neat21:40
*** bpokorny has quit IRC21:45
openstackgerritIan Cordasco proposed stackforge/bandit: Clean up tests and examples for Python 3.4  https://review.openstack.org/18818621:46
openstackgerritIan Cordasco proposed stackforge/bandit: Clean up tests and examples for Python 3.4  https://review.openstack.org/18818621:47
openstackgerritIan Cordasco proposed stackforge/bandit: Add notes to the README about Bandit on Python 3.4  https://review.openstack.org/18818721:54
*** bpokorny has joined #openstack-security21:55
*** erretres has joined #openstack-security22:09
*** erretres has left #openstack-security22:11
*** dwyde_ has joined #openstack-security22:15
*** dwyde has quit IRC22:17
*** dwyde_ is now known as dwyde22:17
*** singlethink has joined #openstack-security22:17
*** dave-mccowan has quit IRC22:18
*** dwyde has quit IRC22:18
*** singleth_ has quit IRC22:18
*** dave-mccowan has joined #openstack-security22:20
*** jamielennox|away is now known as jamielennox22:20
openstackgerritMerged stackforge/bandit: Clean up tests and examples for Python 3.4  https://review.openstack.org/18818622:23
*** dave-mccowan has quit IRC22:24
*** bpokorny has quit IRC22:27
*** bpokorny has joined #openstack-security22:27
*** sigmavirus24 is now known as sigmavirus24_awa22:30
*** bknudson has quit IRC22:31
*** singlethink has quit IRC22:36
*** singlethink has joined #openstack-security22:36
*** singlethink has quit IRC22:44
*** barra204 has joined #openstack-security22:48
*** barra204 has quit IRC22:53
*** bpokorny has quit IRC22:57
*** voodookid has quit IRC23:06
*** sdake has quit IRC23:35
*** bpokorny has joined #openstack-security23:40

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!