| *** jerrygb has quit IRC | 00:01 | |
| *** yuanying has quit IRC | 00:04 | |
| *** yuanying has joined #openstack-security | 00:05 | |
| tmcpeak | browne: how strongly do you feel about the gitpython stuff | 00:06 |
|---|---|---|
| tmcpeak | I'm thinking it drags in an extra dependency for all of Bandit, in a use case many might not even use | 00:07 |
| tmcpeak | and the command line parsing should work ok | 00:07 |
| browne | tmcpeak: makes sense if its not too much code to use | 00:07 |
| tmcpeak | it's mostly error code checking | 00:07 |
| browne | actually i think there's a way to do [extras] as dependencies | 00:08 |
| browne | think keystone guys did that with ldap | 00:08 |
| tmcpeak | my main beef is since I haven't used it before it seems like a fair amount of learning and I'm not sure what it gets us | 00:09 |
| browne | https://github.com/openstack/keystone/blob/master/setup.cfg#L23 | 00:09 |
| tmcpeak | shelling out and agressively checking for exit codes and errors should be equivalent functionally | 00:09 |
| browne | tmcpeak: well hopefully it would get you more reliable code. command output parsing can be error prone cause in most cases there is no guarantee the output has to stay the same from version to version | 00:10 |
| tmcpeak | yeah, I guess error codes could change too, but that seems fairly unlikely with git | 00:10 |
| tmcpeak | I dunno, maybe we can merge the first version with shelling out and introduce git API in a future commit? | 00:11 |
| browne | sometimes a CLI will specifically have a machine format output for parsing | 00:11 |
| browne | yeah, that's fine if its just me. :) | 00:11 |
| tmcpeak | ok cool, I'll do the argparse stuff and then push another change and we can see how the others feel | 00:12 |
| tmcpeak | I'm also happy to leave it for a future commit | 00:12 |
| tmcpeak | I agree you are technically right, an API is cleaner, but it's more work than I want to do for this change :) | 00:12 |
| browne | yeah, future commit sounds fine | 00:12 |
| tmcpeak | cool | 00:12 |
| *** salv-orl_ has joined #openstack-security | 00:18 | |
| *** salv-orlando has quit IRC | 00:20 | |
| *** zul has quit IRC | 00:22 | |
| *** zul has joined #openstack-security | 00:23 | |
| *** yuanying has quit IRC | 00:32 | |
| *** yuanying has joined #openstack-security | 00:34 | |
| *** austin987 has quit IRC | 00:35 | |
| openstackgerrit | Travis McPeak proposed openstack/bandit: Adding bandit-baseline tool https://review.openstack.org/254455 | 00:43 |
| *** yuanying has quit IRC | 00:44 | |
| *** yuanying has joined #openstack-security | 00:47 | |
| *** austin987 has joined #openstack-security | 00:48 | |
| *** openstack has joined #openstack-security | 00:53 | |
| openstackgerrit | Travis McPeak proposed openstack/bandit: Adding bandit-baseline tool https://review.openstack.org/254455 | 01:04 |
| openstackgerrit | Travis McPeak proposed openstack/bandit: Adding bandit-baseline tool https://review.openstack.org/254455 | 01:06 |
| *** bpokorny_ has joined #openstack-security | 01:06 | |
| *** bpokorny has quit IRC | 01:09 | |
| *** bpokorny_ has quit IRC | 01:10 | |
| tmcpeak | browne: back at you https://review.openstack.org/254455 | 01:40 |
| *** jamielennox is now known as jamielennox|away | 01:47 | |
| *** dave-mccowan has quit IRC | 02:20 | |
| *** paulbernard has joined #openstack-security | 02:24 | |
| *** jamielennox|away is now known as jamielennox | 02:50 | |
| *** jerrygb has joined #openstack-security | 02:57 | |
| *** jerrygb has quit IRC | 03:02 | |
| *** jerrygb has joined #openstack-security | 03:18 | |
| *** yuanying has quit IRC | 03:23 | |
| *** jerrygb has quit IRC | 03:48 | |
| *** jerrygb has joined #openstack-security | 03:48 | |
| *** alejandrito has quit IRC | 03:52 | |
| *** jerrygb has quit IRC | 03:52 | |
| *** jerrygb has joined #openstack-security | 04:03 | |
| *** paulbernard has quit IRC | 04:20 | |
| *** tmcpeak has quit IRC | 04:24 | |
| *** yuanying has joined #openstack-security | 04:28 | |
| *** browne has quit IRC | 04:30 | |
| *** bpokorny has joined #openstack-security | 04:44 | |
| *** yuanying has quit IRC | 04:46 | |
| *** jerrygb has quit IRC | 04:49 | |
| *** jerrygb has joined #openstack-security | 04:51 | |
| *** jerrygb has quit IRC | 04:51 | |
| *** jerrygb has joined #openstack-security | 04:51 | |
| *** bpokorny has quit IRC | 04:55 | |
| *** yuanying has joined #openstack-security | 05:00 | |
| openstackgerrit | Merged openstack/bandit: Update README with recent changes https://review.openstack.org/253723 | 05:31 |
| *** salv-orl_ has quit IRC | 06:00 | |
| *** salv-orlando has joined #openstack-security | 06:00 | |
| *** jerrygb has quit IRC | 06:17 | |
| *** jerrygb has joined #openstack-security | 06:17 | |
| *** salv-orl_ has joined #openstack-security | 06:17 | |
| *** salv-orlando has quit IRC | 06:20 | |
| *** jerrygb has quit IRC | 06:21 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/255101 | 06:48 |
| *** jerrygb has joined #openstack-security | 07:00 | |
| *** jerrygb has quit IRC | 07:06 | |
| openstackgerrit | Stanislaw Pitucha proposed openstack/anchor: Add spec for CMC / rfc5272 https://review.openstack.org/255106 | 07:09 |
| *** rcernin has joined #openstack-security | 07:20 | |
| openstackgerrit | Merged openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/255101 | 07:25 |
| *** liverpooler has joined #openstack-security | 08:15 | |
| *** salv-orl_ has quit IRC | 08:58 | |
| *** jerrygb has joined #openstack-security | 09:02 | |
| *** openstack has joined #openstack-security | 09:08 | |
| *** openstackgerrit has quit IRC | 09:32 | |
| *** openstackgerrit has joined #openstack-security | 09:32 | |
| *** shohel has joined #openstack-security | 09:48 | |
| *** salv-orlando has joined #openstack-security | 09:59 | |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit has joined #openstack-security | 10:02 | |
| *** salv-orlando has quit IRC | 10:03 | |
| *** jamielennox is now known as jamielennox|away | 10:13 | |
| *** jerrygb has joined #openstack-security | 11:04 | |
| *** yuanying has quit IRC | 11:07 | |
| *** jerrygb has quit IRC | 11:09 | |
| *** salv-orlando has joined #openstack-security | 11:10 | |
| *** salv-orl_ has joined #openstack-security | 12:17 | |
| *** salv-orlando has quit IRC | 12:20 | |
| *** alejandrito has joined #openstack-security | 12:40 | |
| *** salv-orl_ has quit IRC | 12:44 | |
| *** salv-orlando has joined #openstack-security | 12:49 | |
| *** jerrygb has joined #openstack-security | 12:53 | |
| *** edmondsw has joined #openstack-security | 13:36 | |
| *** tjt263 has quit IRC | 13:37 | |
| *** tjt263 has joined #openstack-security | 13:39 | |
| *** jerrygb_ has joined #openstack-security | 14:08 | |
| *** jerrygb has quit IRC | 14:11 | |
| *** tmcpeak has joined #openstack-security | 14:12 | |
| openstackgerrit | Travis McPeak proposed openstack/bandit: Adding bandit-baseline tool https://review.openstack.org/254455 | 14:38 |
| *** dave-mccowan has joined #openstack-security | 14:38 | |
| openstackgerrit | Travis McPeak proposed openstack/bandit: Adding bandit-baseline tool https://review.openstack.org/254455 | 14:39 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:05 | |
| *** jhfeng has joined #openstack-security | 15:08 | |
| *** noqa_v_qoovnie has quit IRC | 15:22 | |
| *** hyakuhei has joined #openstack-security | 15:32 | |
| *** liverpooler has quit IRC | 15:55 | |
| *** shohel has quit IRC | 16:09 | |
| *** jerrygb_ has quit IRC | 16:18 | |
| openstackgerrit | Michael Dong proposed openstack/syntribos: Added in issues for test results https://review.openstack.org/255357 | 16:27 |
| *** austin987 has quit IRC | 16:31 | |
| *** bpokorny has joined #openstack-security | 16:37 | |
| *** austin987 has joined #openstack-security | 16:43 | |
| *** hyakuhei has quit IRC | 16:52 | |
| *** pdesai has joined #openstack-security | 17:11 | |
| *** rcernin has quit IRC | 17:11 | |
| *** salv-orlando has quit IRC | 17:30 | |
| *** pdesai has quit IRC | 17:34 | |
| openstackgerrit | Travis McPeak proposed openstack/bandit: Adding bandit-baseline tool https://review.openstack.org/254455 | 17:36 |
| openstackgerrit | Travis McPeak proposed openstack/bandit: Adding bandit-baseline tool https://review.openstack.org/254455 | 17:42 |
| openstackgerrit | Travis McPeak proposed openstack/bandit: Adding bandit-baseline tool https://review.openstack.org/254455 | 17:44 |
| *** salv-orlando has joined #openstack-security | 17:49 | |
| *** salv-orlando has quit IRC | 17:52 | |
| *** pdesai has joined #openstack-security | 18:05 | |
| *** browne has joined #openstack-security | 18:06 | |
| *** markvoelker has quit IRC | 18:18 | |
| *** markvoelker has joined #openstack-security | 18:21 | |
| *** hyakuhei_ has joined #openstack-security | 18:26 | |
| tmcpeak | browne: check this out please - https://review.openstack.org/254455 | 18:36 |
| browne | yeah, was just looking. is there any way we can unit test it? | 18:39 |
| *** hyakuhei_ has quit IRC | 18:40 | |
| browne | tmcpeak: we have unit tests for bandit_conf_generator which kinda falls in the same category | 18:41 |
| tmcpeak | separate patch? :P | 18:41 |
| browne | you could if this is urgent | 18:42 |
| tmcpeak | yeah, you're right | 18:42 |
| tmcpeak | I'll bang up some unit tests | 18:42 |
| browne | thanks! | 18:42 |
| *** bpokorny_ has joined #openstack-security | 19:02 | |
| *** bpokorny_ has quit IRC | 19:03 | |
| *** bpokorny_ has joined #openstack-security | 19:04 | |
| *** salv-orlando has joined #openstack-security | 19:05 | |
| *** bpokorny has quit IRC | 19:06 | |
| *** bpokorny_ has quit IRC | 19:11 | |
| *** bpokorny has joined #openstack-security | 19:12 | |
| *** bpokorny_ has joined #openstack-security | 19:14 | |
| *** bpokorny has quit IRC | 19:17 | |
| *** salv-orlando has quit IRC | 19:36 | |
| *** bpokorny_ has quit IRC | 19:51 | |
| *** bpokorny has joined #openstack-security | 20:00 | |
| *** hyakuhei has joined #openstack-security | 20:02 | |
| *** hyakuhei has quit IRC | 20:08 | |
| *** salv-orlando has joined #openstack-security | 20:10 | |
| *** hyakuhei has joined #openstack-security | 20:10 | |
| *** hyakuhei has quit IRC | 20:12 | |
| *** hyakuhei_ has joined #openstack-security | 20:16 | |
| *** pdesai has quit IRC | 20:17 | |
| *** pdesai has joined #openstack-security | 20:27 | |
| *** hyakuhei_ has quit IRC | 20:35 | |
| *** pdesai has quit IRC | 20:37 | |
| *** bpokorny has quit IRC | 20:58 | |
| *** hyakuhei has joined #openstack-security | 21:09 | |
| *** hyakuhei has quit IRC | 21:15 | |
| *** pdesai has joined #openstack-security | 21:22 | |
| openstackgerrit | Travis McPeak proposed openstack/bandit: Adding bandit-baseline tool https://review.openstack.org/254455 | 21:26 |
| tmcpeak | browne: ^ | 21:27 |
| tmcpeak | browne: it's not 100% coverage but at least verifies that it works | 21:32 |
| tmcpeak | should be good enough for now | 21:32 |
| browne | tmcpeak: cool, i'll take a look today | 21:47 |
| tmcpeak | sweet, thanks man | 21:47 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/anchor: Updated from global requirements https://review.openstack.org/255546 | 21:54 |
| *** hyakuhei_ has joined #openstack-security | 22:00 | |
| *** edmondsw has quit IRC | 22:04 | |
| sigmavirus24 | o/ tmcpeak | 22:08 |
| tmcpeak | yo what's up sigmavirus24 | 22:09 |
| sigmavirus24 | going to start trying to get back into bandit again soon | 22:09 |
| tmcpeak | sweet! I was hoping you'd say so | 22:09 |
| tmcpeak | btw, you got time to check this out? https://review.openstack.org/254455 | 22:09 |
| tmcpeak | it fails in the gate but passes locally | 22:09 |
| sigmavirus24 | was just looking ;) | 22:09 |
| *** pdesai has quit IRC | 22:09 | |
| tmcpeak | I bet I know why... | 22:12 |
| tmcpeak | maybe it can't find the bandit-baseline binary? | 22:13 |
| tmcpeak | actually no, that doesn't make sense | 22:13 |
| *** hyakuhei_ has quit IRC | 22:16 | |
| *** pdesai has joined #openstack-security | 22:16 | |
| *** hyakuhei has joined #openstack-security | 22:17 | |
| *** dave-mccowan has quit IRC | 22:21 | |
| tmcpeak | hmm, looks like there is no access to /tmp in gate machine | 22:22 |
| *** alejandrito has quit IRC | 22:26 | |
| *** evand has quit IRC | 22:37 | |
| tmcpeak | take that back | 22:38 |
| tmcpeak | there is | 22:38 |
| tmcpeak | I dunno what's wrong with it | 22:38 |
| *** hyakuhei has quit IRC | 22:55 | |
| *** yuanying has joined #openstack-security | 22:56 | |
| *** jhfeng has quit IRC | 22:56 | |
| *** dave-mccowan has joined #openstack-security | 23:07 | |
| *** evand has joined #openstack-security | 23:36 | |
| *** rcernin has joined #openstack-security | 23:37 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!