Tuesday, 2016-07-19

*** deblike has quit IRC00:05
*** yuanying-afk is now known as yuanying00:06
openstackgerritMerged openstack/syntribos: Adding missing checks  https://review.openstack.org/34047300:09
*** tmcpeak1 has quit IRC00:09
*** browne has quit IRC00:13
*** austin987 has quit IRC00:14
unrahulfinally that patch got merged, thanks ccneill !00:14
ccneillnp!00:14
*** davidjd-gh has joined #openstack-security00:16
ccneillwanna +2 this one before you head out for the day? https://review.openstack.org/#/c/313190/00:16
ccneill:D00:16
davidjd-ghhello00:16
ccneillI think these unittests will help us keep from breaking master00:16
ccneillas you said00:17
ccneillunrahul: ^00:17
unrahul:D00:17
unrahulyup00:17
unrahulalready done,00:17
ccneillnice, ty00:17
unrahulsee u later ccneill00:17
ccneillhave a good night unrahul00:17
unrahul+100:19
*** davidjd-gh has left #openstack-security00:25
*** austin987 has joined #openstack-security00:27
*** markvoelker has quit IRC00:30
*** markvoelker has joined #openstack-security00:31
*** markvoelker has quit IRC00:36
*** JAHoagie has quit IRC00:40
*** davidjd-gh has joined #openstack-security00:41
*** davidjd-gh has left #openstack-security00:41
*** davidjd-gh has joined #openstack-security00:52
*** davidjd-gh has left #openstack-security00:52
*** tmcpeak has joined #openstack-security00:57
*** salv-orlando has joined #openstack-security01:00
*** salv-orlando has quit IRC01:08
*** browne has joined #openstack-security01:09
*** browne has quit IRC01:09
*** tkelsey has joined #openstack-security01:12
*** tkelsey has quit IRC01:17
*** davidjd-gh has joined #openstack-security01:18
*** zul has quit IRC01:19
*** vinaypotluri has quit IRC01:21
*** davidjd-gh has quit IRC01:22
*** zul has joined #openstack-security01:37
*** deblike has joined #openstack-security01:49
*** salv-orlando has joined #openstack-security02:07
*** salv-orlando has quit IRC02:17
*** Coleoptera has joined #openstack-security02:20
*** nkinder has quit IRC02:21
*** nkinder has joined #openstack-security02:26
*** Coleoptera has quit IRC02:28
*** eric_lopez has joined #openstack-security02:28
*** elo has quit IRC02:30
*** markvoelker has joined #openstack-security02:32
*** markvoelker has quit IRC02:38
*** Coleoptera has joined #openstack-security02:42
*** yuanying has quit IRC02:52
*** dave-mcc_ has quit IRC02:58
*** trecko1 has joined #openstack-security03:07
*** trecko1 has left #openstack-security03:07
*** elo has joined #openstack-security03:12
*** eric_lopez has quit IRC03:14
*** salv-orlando has joined #openstack-security03:16
*** salv-orlando has quit IRC03:26
*** edtubill has joined #openstack-security03:44
*** deblike has quit IRC03:45
*** deblike has joined #openstack-security03:45
*** yuanying has joined #openstack-security03:45
*** deblike has quit IRC03:45
*** Coleoptera has quit IRC04:18
*** jerrygb has joined #openstack-security04:22
*** salv-orlando has joined #openstack-security04:24
*** salv-orlando has quit IRC04:34
*** markvoelker has joined #openstack-security04:34
*** markvoelker has quit IRC04:40
*** deblike has joined #openstack-security04:46
*** deblike has quit IRC04:51
*** salv-orlando has joined #openstack-security04:56
*** tmcpeak has quit IRC05:21
*** jerrygb has quit IRC05:30
*** edtubill has quit IRC05:42
*** edtubill has joined #openstack-security05:42
openstackgerritRahul U Nair proposed openstack/syntribos: Adding unittests for checks  https://review.openstack.org/34403405:42
*** elo has quit IRC05:44
*** elo has joined #openstack-security05:46
*** edtubill has quit IRC05:47
*** deblike has joined #openstack-security05:47
openstackgerritMerged openstack/syntribos: Adding unit tests for Runner  https://review.openstack.org/31319005:49
*** deblike has quit IRC05:52
*** salv-orlando has quit IRC06:05
*** rcernin has joined #openstack-security06:10
*** eric_lopez has joined #openstack-security06:10
*** elo has quit IRC06:12
*** tkelsey has joined #openstack-security06:16
*** elo has joined #openstack-security06:17
*** eric_lopez has quit IRC06:19
*** tkelsey has quit IRC06:20
*** markvoelker has joined #openstack-security06:26
*** markvoelker has quit IRC06:32
*** pcaruana has joined #openstack-security06:36
*** salv-orlando has joined #openstack-security06:38
*** elo has quit IRC06:48
*** deblike has joined #openstack-security06:48
*** salv-orl_ has joined #openstack-security06:48
*** salv-orlando has quit IRC06:51
*** elo has joined #openstack-security06:52
*** deblike has quit IRC06:53
*** eric_lopez has joined #openstack-security06:56
*** elo has quit IRC06:58
*** tesseract- has joined #openstack-security06:58
*** liverpooler has joined #openstack-security07:03
*** elo has joined #openstack-security07:03
*** eric_lopez has quit IRC07:05
*** eric_lopez has joined #openstack-security07:07
*** elo has quit IRC07:09
*** jerrygb has joined #openstack-security07:32
*** jerrygb has quit IRC07:37
*** salv-orl_ has quit IRC07:38
*** elo has joined #openstack-security07:41
*** eric_lopez has quit IRC07:43
*** elo has quit IRC07:49
*** salv-orlando has joined #openstack-security07:58
*** tkelsey has joined #openstack-security08:02
*** jass93 has quit IRC08:26
*** markvoelker has joined #openstack-security08:29
*** unrahul has quit IRC08:42
*** salv-orlando has quit IRC08:42
*** jass93 has joined #openstack-security08:48
*** salv-orlando has joined #openstack-security09:09
*** salv-orl_ has joined #openstack-security09:16
*** salv-orlando has quit IRC09:19
*** salv-orl_ has quit IRC09:20
*** aastha has quit IRC09:49
*** markvoelker has quit IRC10:33
*** jerrygb has joined #openstack-security10:51
*** jerrygb has quit IRC10:56
*** openstackgerrit has quit IRC11:41
*** openstackgerrit has joined #openstack-security11:41
*** jerrygb has joined #openstack-security11:57
*** edmondsw has joined #openstack-security12:21
*** markvoelker has joined #openstack-security12:29
*** markvoelker has quit IRC12:35
*** markvoelker has joined #openstack-security12:44
*** kun_huang has quit IRC12:46
*** markvoelker_ has joined #openstack-security12:46
*** markvoelker has quit IRC12:46
*** kun_huang has joined #openstack-security12:46
*** deblike has joined #openstack-security13:04
*** dave-mccowan has joined #openstack-security13:11
*** d0ugal has joined #openstack-security13:19
*** salv-orlando has joined #openstack-security13:23
*** salv-orl_ has joined #openstack-security13:25
*** cleong has joined #openstack-security13:26
*** salv-or__ has joined #openstack-security13:27
*** salv-orlando has quit IRC13:29
*** salv-orlando has joined #openstack-security13:29
*** salv-orl_ has quit IRC13:30
*** salv-or__ has quit IRC13:33
*** d0ugal has quit IRC13:39
*** BigWillie has joined #openstack-security13:40
*** jmckind has joined #openstack-security13:46
*** jmckind has quit IRC13:48
*** jmckind has joined #openstack-security13:53
*** woodburn has joined #openstack-security14:02
*** liverpooler has quit IRC14:08
*** d0ugal has joined #openstack-security14:18
*** jmckind has quit IRC14:18
*** jmckind has joined #openstack-security14:21
*** d0ugal has quit IRC14:23
*** d0ugal has joined #openstack-security14:24
*** mvaldes has joined #openstack-security14:33
*** tmcpeak has joined #openstack-security14:36
*** sdake has joined #openstack-security14:39
*** zul has quit IRC14:49
*** elo has joined #openstack-security14:56
*** d0ugal has quit IRC14:59
*** vinaypotluri has joined #openstack-security15:01
*** zul has joined #openstack-security15:02
*** mvaldes1 has joined #openstack-security15:02
*** mvaldes has quit IRC15:03
*** mvaldes has joined #openstack-security15:04
*** mvaldes1 has quit IRC15:07
*** woodburn has quit IRC15:07
*** unrahul has joined #openstack-security15:08
*** jmckind has quit IRC15:12
tmcpeakgmurphy: is sicarie around?15:19
*** sdake has quit IRC15:28
*** Verofede0204 has joined #openstack-security15:31
*** jmckind has joined #openstack-security15:31
*** Verofede0204 has left #openstack-security15:32
*** d0ugal has joined #openstack-security15:35
*** salv-orlando has quit IRC15:35
gmurphytmcpeak: get a hold of him? i'll ping him15:35
*** catintheroof has joined #openstack-security15:35
tmcpeakgmurphy: awesome, please do15:36
*** sicarie has joined #openstack-security15:37
* sicarie waves15:37
gmurphytmcpeak: ==^15:38
tmcpeaksicarie: hey15:38
tmcpeakwhat's the status with the security guide checklists?15:38
tmcpeakare they finished? part way?15:38
sicariegood question, that’s on my list of stuff to call out for the list i’m making for hyakuhei15:38
sicarieafaik we have just over 515:39
sicariemajor services covered15:39
tmcpeakhow many did you want to get?15:39
sicarieideally, all the ones covered in the secguide15:39
tmcpeakis there anybody that's going to continue work or TBD?15:39
sicariehowever, i’d be willing to be more flexible on stuff like manila15:39
sicarieyes, I am going to be doing that once i get ramped back up15:39
tmcpeakawesome, and the 5 are fully completed?15:40
sicarielet me check before i stick your foot in my mouth15:40
tmcpeakhaha, ok thank you15:40
sicarie#link http://docs.openstack.org/security-guide/checklist.html15:41
sicarieThere’s definite room for improvement, but these are a solid start15:43
tmcpeakawesome, thank you sicarie15:43
sicarie6 of them, and ones for db’s etc should follow quickly15:43
sicarienp15:43
tmcpeakthanks for grabbing him gmurphy :)15:43
*** deblike has quit IRC15:49
gmurphynp15:49
*** sdake has joined #openstack-security15:50
*** salv-orlando has joined #openstack-security15:52
*** deblike has joined #openstack-security15:55
*** mdong has joined #openstack-security16:00
*** d0ugal has quit IRC16:04
openstackgerritRahul U Nair proposed openstack/syntribos: Modify auto-compelete to reflect the new CLI  https://review.openstack.org/34434716:09
*** browne has joined #openstack-security16:15
*** mvaldes has quit IRC16:17
*** mvaldes has joined #openstack-security16:19
*** mvaldes has quit IRC16:19
*** mvaldes has joined #openstack-security16:21
*** jmckind has quit IRC16:31
*** woodburn has joined #openstack-security16:32
*** austin987 has quit IRC16:33
*** d0ugal has joined #openstack-security16:38
*** austin987 has joined #openstack-security16:46
*** tesseract- has quit IRC16:47
*** rcernin has quit IRC16:49
ccneillunrahul, vinaypotluri, mdong : here's the CR I was mentioning at the end of our standup for the request object parity bug https://review.openstack.org/#/c/343953/16:52
ccneillI'll look for a better solution, but for now that will at least fix master16:53
ccneillalso, this one from mdong needs a +2: https://review.openstack.org/#/c/343098/16:53
*** salv-orlando has quit IRC16:55
*** sicarie has quit IRC16:55
ccneillunrahul: I wonder if we should make a file /tests/unit/utils.py for stuff like your FakeTestObject class16:56
ccneillsince I think it gets used in a few different files16:57
ccneillprobably handy to have for several reasons16:57
*** salv-orlando has joined #openstack-security16:58
ccneillthank you for adding unittests for these checks though! good stuff!16:58
unrahulHey ccneill yup,  I think we should17:04
unrahulI was thinking of adding unit tests for our tests also which would involve some mocking as well.. So may be I shall make a utils for all these and add all these classes in it..17:05
ccneillyep yep yep17:07
ccneillgood idea17:07
ccneillyou were up late last night! just saw the email from Jenkins at 12:40 :o17:07
openstackgerritMerged openstack/syntribos: added CLI option to exclude tests from runner  https://review.openstack.org/34309817:12
*** sdake has quit IRC17:12
openstackgerritMerged openstack/syntribos: First pass at fix for bug #1604187  https://review.openstack.org/34395317:14
openstackbug 1604187 in syntribos "Inconsistencies between requestslib PreparedRequest and syntribos' RequestObject" [Medium,New] https://launchpad.net/bugs/1604187 - Assigned to Charles Neill (charles-neill)17:14
ccneillwooot! syntribos is no longer broken in master ^^;17:18
*** sdake has joined #openstack-security17:20
unrahul😀.. Ehh mm.. When was it broken?? 😀..  I don't recollect it all..17:23
*** mvaldes has quit IRC17:26
ccneillO:-) if a fixup CR lands before anyone outside the dev team clones the broken version, did it ever break?17:31
*** zul has quit IRC17:38
*** zul has joined #openstack-security17:39
*** sdake has quit IRC17:41
ccneillhey OSSP folks, is this list for completed projects only, and if not, how do we add Syntribos to the list? https://security.openstack.org/#security-tool-development17:45
ccneill"completed" meaning "1.0/stable"17:45
unrahulHey.. :D no comments..17:45
unrahulhaha*17:45
unrahulHey ccneill my comment on that auto-completion change "I had a hunch you would say that, and I have finally transitioned to zsh so it doesn't work for me too...should we remove this all together for now as now the cafe dependencies exist.." what do you think we should do?17:48
ccneillyeah I'm good with deleting it for now17:48
ccneillif we really find it to be a must-have feature later, we can look into making it cross-compatible17:49
ccneillbut I think we have more pressing needs at the moment, and we can do without it since the params are clearer now17:49
unrahulyup! makes sense.17:51
openstackgerritRahul U Nair proposed openstack/syntribos: Modify auto-compelete to reflect the new CLI  https://review.openstack.org/34434717:52
ccneillanother thing we could probably stand to do is cleaning up our data/ dir17:54
unrahulmdong: https://review.openstack.org/#/c/344034/ could you please see if this patch is good to be merged?17:55
unrahulbufferoverflow.txt does not having anything in it.. I forgot.. why we have the file there, any reason?17:56
unrahulAlso ccneill  you have an idea on how we should do it, ? cleaning up the data dir, renaming the files and all..? or merging couple of them..?17:57
*** woodburn has quit IRC18:03
*** sdake has joined #openstack-security18:06
ccneillI have some ideas, but I don't have an answer off-hand18:06
ccneillI've never really been a fan of having to define the relevant textfile in the test that uses it18:06
*** davidjd-gh has joined #openstack-security18:07
*** davidjd-gh has left #openstack-security18:07
ccneille.g. in tests like this: https://github.com/openstack/syntribos/blob/master/syntribos/tests/fuzz/ldap.py18:07
ccneillseems like we could compact that a bit..18:08
ccneillsince it's almost all boilerplate / stuff we could derive from the main test nmae18:08
ccneillname*18:08
*** aastha has joined #openstack-security18:08
ccneill¯\_(ツ)_/¯ I suppose we might want to do something different between e.g. headers and body, but we don't really do that today (e.g. https://github.com/openstack/syntribos/blob/master/syntribos/tests/fuzz/sql.py)18:09
*** jmckind has joined #openstack-security18:09
unrahuloh.. yeah.. but then.. there wont be much to write in the testcase.. ? ,18:10
unrahulyeah.. it is pretty linear and non related..18:10
unrahulI guess when pipelining comes it would be advantageous to specifically control which part  like header body and which type of tests to be run and when..18:11
*** mvaldes has joined #openstack-security18:11
ccneillright well.. I just wonder if it would be worth it to maybe have a FullFuzzTest that inherits from BaseFuzzTestCase that just goes ahead and extends it for each type automatically (body, header, param, url)18:12
ccneillso if you want to handle things differently, you can inherit from BFTC, but if you just want a generic test like the LDAP one, you just have to inherit from FFT18:13
ccneillFFTC*18:13
ccneillmaybe similar to extend_class18:13
unrahuloh.. then we wouldnt want to repeat the header/body/params in most tests as it is the default.. behavior..?18:14
ccneillI mean, I think it's just more intuitive that way18:15
ccneillor at least to have the option to do it that way is more intuitive18:15
ccneillwe don't do anything different between body and the other classes in any of our current fuzz tests18:16
ccneillprobably not the most important thing to worry about right this minute, but I'll think about it some more18:19
*** davidjd-gh has joined #openstack-security18:22
*** davidjd-gh has left #openstack-security18:22
*** woodburn has joined #openstack-security18:29
*** mdong has quit IRC18:30
unrahulccneill: yeah.. that would remove lot of  repetitions in the code.. and may it lil bit concise.. but one thing is that, if we don't split into a different file /class, it would be like most of the logic for fuzz tests would remain in base_fuzz .. which is not that intutive.. a new user may find it difficult to use the APIs or know whats going on behind all18:30
unrahulthe magic..18:30
ccneillaww, but magic is always good :P18:30
ccneilltrue18:30
ccneillbut all the logic already kind of lives in BFTC.. :\18:32
ccneillwe should probably try to make BFTC better before we start doing anything else18:32
*** davidjd-gh1 has joined #openstack-security18:32
ccneilli.e. data_driven_pass_cases, _get_strings18:32
*** davidjd-gh1 has left #openstack-security18:32
unrahulyeah.. we need to.. sometimes.. i get all worked up.. seeing the mixins.. the fuzz base class and all.. it some how feels not so straight forward as other parts.. :/18:33
unrahulyup..18:33
*** mdong has joined #openstack-security18:43
*** catintheroof has quit IRC18:45
ccneillugh.. "mixins"18:50
ccneillv_v18:50
ccneilldefined in separate files, that really only represent functionality that should be in the main class, but that are spread out and only have fun names like "_build_str_combinations"18:51
*** sdake_ has joined #openstack-security18:55
*** sdake has quit IRC18:57
*** tkelsey has quit IRC19:00
unrahulhehe yup!.19:05
*** davidjd-gh1 has joined #openstack-security19:08
*** davidjd-gh1 has left #openstack-security19:09
*** davidjd-gh has joined #openstack-security19:10
*** salv-orlando has quit IRC19:10
*** salv-orlando has joined #openstack-security19:10
openstackgerritMerged openstack/syntribos: Modify auto-compelete to reflect the new CLI  https://review.openstack.org/34434719:16
*** davidjd-gh has quit IRC19:18
*** davidjd-gh has joined #openstack-security19:21
*** davidjd-gh has left #openstack-security19:21
unrahulvinaypotluri: https://review.openstack.org/#/c/344034/ could you kindly review this CR?19:24
*** davidjd-gh has joined #openstack-security19:32
*** davidjd-gh has left #openstack-security19:32
*** davidjd-gh has joined #openstack-security19:33
davidjd-ghChanServ lag19:34
*** davidjd-gh has left #openstack-security19:34
ccneillunrahul: looks like your auto-complete thing merged ^19:51
ccneillwonder why it took so long..19:51
openstackgerritMerged openstack/syntribos: Adding unittests for checks  https://review.openstack.org/34403419:57
*** davidjd-gh has joined #openstack-security19:57
*** davidjd-gh has left #openstack-security19:58
*** tkelsey has joined #openstack-security19:58
*** tkelsey has quit IRC20:02
*** jmckind has quit IRC20:04
*** zul has quit IRC20:09
*** mdong has quit IRC20:09
*** zul has joined #openstack-security20:11
*** davidjd-gh has joined #openstack-security20:12
unrahulvinaypotluri: check this config, https://gist.github.com/rahulunair/4066fc3212d6769d05cb389dc2fdd5c0  , it should work20:13
davidjd-ghhello20:13
*** davidjd-gh has left #openstack-security20:14
*** mdong has joined #openstack-security20:21
*** davidjd-gh has joined #openstack-security20:23
*** davidjd-gh has left #openstack-security20:23
*** davidjd-gh has joined #openstack-security20:30
*** davidjd-gh has left #openstack-security20:30
*** davidjd-gh has joined #openstack-security20:48
*** davidjd-gh has left #openstack-security20:48
*** rcernin has joined #openstack-security20:54
*** cleong has quit IRC20:59
*** _elmiko is now known as elmiko21:02
*** BigWillie has quit IRC21:05
*** mihero has quit IRC21:07
*** dave-mccowan has quit IRC21:11
*** davidjd-gh has joined #openstack-security21:12
*** davidjd-gh has left #openstack-security21:12
*** davidjd-gh has joined #openstack-security21:14
*** davidjd-gh has left #openstack-security21:14
aasthahey ccneill in the debug log we have to separate fields for response_time and test_elapsed_time, do we actually need both these fields, since I dont think think there would be much of a difference in both the times. I guess test_elapsed_time is essentially a subset(in terms of time taken) of the response_time. just wanted to check with you on that part.21:25
ccneillI think we want both. for instance, we might want to see that init_resp took 2 seconds and the test_resp took 10 seconds21:26
ccneillif we only show the time taken by the entire test, it just looks like a long test, but if you see the two pieces, you can see that we caused something to happen between init_req and test_req that made the server respond more slowly21:27
ccneillit's also helpful for tweaking the max_time and time_diff_percentage configuration options. e.g. if you have max_time set to 5, and every request takes 5.5 seconds, you might bump it to 1021:27
ccneillsound reasonable?21:30
*** woodburn has quit IRC21:40
unrahulaastha:  is the test_elapsed_time right now only checking the time taken to send the request, or is it the time to run the test..?21:42
unrahulaastha: replace the config and use syntribos --config-file <config22:01
unrahulaastha: replace the config and use syntribos --config-file <config_filename> -t CORS22:01
aasthayes ccneill that makes sense.22:06
ccneillcool cool22:06
ccneillI'm trying to figure out how to reconcile RequestObject/FuzzReqests with requests.PreparedRequest.. so many bad options lol22:07
aasthaurahul test_elapsed_time is not there right now i believe, it is the total time to run the tests22:07
unrahulaastha:  :)  okay22:07
*** mvaldes has quit IRC22:08
aasthayes i checked that too ccneill there are endless options in there..22:09
*** elmiko is now known as _elmiko22:10
ccneillif only it wasn't so hard to do a pygraph of syntribos lol22:11
unrahul:D22:11
ccneill><22:11
ccneillhmm22:11
unrahulbut now, may be things have changed22:11
ccneilllet me see what it looks like now22:11
ccneillyeah22:11
ccneillhaven't tried in a while22:11
unrahulafter adding the signals and checks..22:11
ccneillyeah at least my pycallgraph call doesn't have to include a CAFE_ env var lol22:13
ccneillwe'll see22:13
ccneillif I run it with just a few test types it's probably easier to read22:14
ccneillbut when you run it with all, it generates soooo many classes >_<22:14
unrahuloh yeah... ! I remember you had to do some hacking to make it work that time..22:15
unrahulEven if run it for one test..?22:15
ccneillshouldn't be as bad for one tets22:15
ccneilltest22:15
ccneillo_o22:16
ccneillhttp://i.imgur.com/mVwIhiW.jpg22:17
ccneillmmm those identity models..22:17
*** salv-orl_ has joined #openstack-security22:21
unrahul:o22:23
*** salv-orlando has quit IRC22:23
unrahulstill a lil crazy.. between the prepared copy call and issue.. lot of control flows..22:23
unrahuli guess if we run this against any project.. it would be a similar exp..22:24
*** mdong has quit IRC22:26
unrahulccneill: vinaypotluri aastha guys, I am  signing off lil early today, not feeling so well, catch you guys later.22:27
ccneillno worries! get feeling better unrahul22:27
*** davidjd-gh has joined #openstack-security22:28
*** davidjd-gh has left #openstack-security22:30
openstackgerritVinay Potluri proposed openstack/syntribos: Added string presence check  https://review.openstack.org/34448922:32
openstackgerritVinay Potluri proposed openstack/syntribos: Removed OpenCafe installation instructions  https://review.openstack.org/34390022:40
*** davidjd-gh has joined #openstack-security22:44
*** davidjd-gh has left #openstack-security22:44
*** mihero has joined #openstack-security22:45
vinaypotluriaastha: run this syntribos --config-file configs/vAPI.config -t CORS22:54
*** tkelsey has joined #openstack-security23:01
*** tkelsey has quit IRC23:05
*** davidjd-gh has joined #openstack-security23:17
*** davidjd-gh has left #openstack-security23:17
*** salv-orl_ has quit IRC23:19
*** edmondsw has quit IRC23:26
*** yeison has joined #openstack-security23:57
*** yeison has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!