*** agireud has quit IRC | 00:30 | |
*** agireud has joined #openstack-security | 00:37 | |
*** eric_lopez has quit IRC | 00:48 | |
*** eric_lopez has joined #openstack-security | 00:55 | |
*** aastha has joined #openstack-security | 01:06 | |
*** otto1 has joined #openstack-security | 01:06 | |
*** otto1 has quit IRC | 01:07 | |
*** eric_lopez has quit IRC | 01:20 | |
*** elo has joined #openstack-security | 01:21 | |
*** elo has quit IRC | 01:26 | |
*** elo has joined #openstack-security | 01:27 | |
*** elo has quit IRC | 01:32 | |
*** elo has joined #openstack-security | 01:34 | |
*** zhihui has joined #openstack-security | 01:40 | |
*** eric_lopez has joined #openstack-security | 01:41 | |
*** elo has quit IRC | 01:41 | |
*** eric_lopez has quit IRC | 02:05 | |
*** elo has joined #openstack-security | 02:05 | |
*** eric_lopez has joined #openstack-security | 02:31 | |
*** elo has quit IRC | 02:31 | |
*** Long_yanG has quit IRC | 02:32 | |
*** LongyanG has joined #openstack-security | 02:33 | |
*** eric_lopez has quit IRC | 02:36 | |
*** elo has joined #openstack-security | 02:36 | |
*** vinaypotluri has quit IRC | 02:41 | |
*** elo has quit IRC | 03:11 | |
*** krotscheck_ has joined #openstack-security | 03:12 | |
*** krotscheck has quit IRC | 03:13 | |
*** krotscheck_ is now known as krotscheck | 03:14 | |
*** elo has joined #openstack-security | 03:15 | |
*** elo has quit IRC | 03:22 | |
*** GoceVida has quit IRC | 03:24 | |
*** elo has joined #openstack-security | 03:25 | |
*** GoceVida has joined #openstack-security | 03:25 | |
*** dave-mccowan has quit IRC | 03:48 | |
*** elo has quit IRC | 03:52 | |
*** elo has joined #openstack-security | 04:14 | |
*** GoceVida has quit IRC | 04:20 | |
*** GoceVida has joined #openstack-security | 04:22 | |
*** dikonoor has joined #openstack-security | 05:00 | |
*** sdake has quit IRC | 05:20 | |
*** rcernin has joined #openstack-security | 05:29 | |
*** liverpooler has joined #openstack-security | 05:42 | |
*** liverpooler is now known as yrabl|WFH | 05:43 | |
*** yrabl|WFH is now known as liverpooler | 05:43 | |
*** liverpooler has quit IRC | 05:44 | |
*** serverascode_ has joined #openstack-security | 05:44 | |
*** liverpooler has joined #openstack-security | 05:44 | |
*** serverascode has quit IRC | 05:48 | |
*** liverpoo1er has joined #openstack-security | 05:49 | |
*** liverpooler has quit IRC | 05:50 | |
*** liverpooler has joined #openstack-security | 05:51 | |
*** serverascode_ is now known as serverascode | 05:51 | |
*** GoceVida has quit IRC | 06:14 | |
*** GoceVida has joined #openstack-security | 06:15 | |
*** ccneill_ has joined #openstack-security | 06:20 | |
*** ccneill has quit IRC | 06:21 | |
*** pcaruana has joined #openstack-security | 06:45 | |
*** tesseract- has joined #openstack-security | 06:53 | |
*** aastha has quit IRC | 06:57 | |
*** liverpoo1er has quit IRC | 06:58 | |
*** vir1 has joined #openstack-security | 07:25 | |
*** GoceVida has quit IRC | 07:36 | |
*** GoceVida has joined #openstack-security | 07:39 | |
*** vir1 has quit IRC | 07:45 | |
*** shohel has joined #openstack-security | 08:04 | |
*** vir1 has joined #openstack-security | 08:20 | |
*** sdake has joined #openstack-security | 08:23 | |
*** v12aml has quit IRC | 08:46 | |
*** v12aml has joined #openstack-security | 08:47 | |
*** vir1 has quit IRC | 08:54 | |
*** amitkqed has quit IRC | 09:27 | |
*** amitkqed has joined #openstack-security | 09:27 | |
*** v12aml has quit IRC | 09:52 | |
*** v12aml has joined #openstack-security | 09:53 | |
*** GoceVida has quit IRC | 10:07 | |
*** GoceVida has joined #openstack-security | 10:20 | |
*** gszafranski has quit IRC | 10:25 | |
*** Unterd0g_ is now known as Unterd0g | 10:50 | |
*** amitkqed has quit IRC | 11:28 | |
*** amitkqed has joined #openstack-security | 11:28 | |
*** dave-mccowan has joined #openstack-security | 12:15 | |
*** Trident has joined #openstack-security | 12:16 | |
*** shohel has quit IRC | 12:16 | |
*** shohel has joined #openstack-security | 12:25 | |
*** edmondsw has joined #openstack-security | 12:28 | |
*** GoceVida has quit IRC | 12:35 | |
*** GoceVida has joined #openstack-security | 12:38 | |
*** sdake has quit IRC | 12:43 | |
*** jass93 has quit IRC | 12:47 | |
*** _elmiko is now known as elmiko | 13:01 | |
*** shohel has quit IRC | 13:05 | |
*** shohel has joined #openstack-security | 13:05 | |
*** zhihui has quit IRC | 13:11 | |
*** JAHoagie has joined #openstack-security | 13:34 | |
*** singlethink has joined #openstack-security | 13:41 | |
*** sdake has joined #openstack-security | 13:47 | |
*** sdake_ has joined #openstack-security | 14:07 | |
*** sdake has quit IRC | 14:09 | |
*** edtubill has joined #openstack-security | 14:17 | |
*** JAHoagie has quit IRC | 14:19 | |
*** shohel has quit IRC | 14:23 | |
*** dave-mcc_ has joined #openstack-security | 14:35 | |
*** dave-mccowan has quit IRC | 14:36 | |
*** mvaldes has joined #openstack-security | 14:36 | |
*** JAHoagie has joined #openstack-security | 14:38 | |
*** JAHoagie has quit IRC | 14:42 | |
*** sdake has joined #openstack-security | 14:47 | |
*** sdake_ has quit IRC | 14:47 | |
*** dikonoor has quit IRC | 14:47 | |
*** JAHoagie has joined #openstack-security | 14:51 | |
*** aastha has joined #openstack-security | 14:53 | |
*** JAHoagie has quit IRC | 14:58 | |
*** tesseract- has quit IRC | 15:23 | |
*** catintheroof has joined #openstack-security | 15:27 | |
*** JAHoagie has joined #openstack-security | 15:33 | |
*** hockeynut has quit IRC | 15:34 | |
*** vinaypotluri has joined #openstack-security | 15:42 | |
*** sdake_ has joined #openstack-security | 15:49 | |
*** sdake has quit IRC | 15:51 | |
*** hockeynut has joined #openstack-security | 16:00 | |
*** hockeynut has quit IRC | 16:00 | |
*** hockeynut has joined #openstack-security | 16:00 | |
*** hockeynut has quit IRC | 16:01 | |
*** hockeynut has joined #openstack-security | 16:02 | |
openstackgerrit | Aastha Dixit proposed openstack/syntribos: Implement config loading schema https://review.openstack.org/352497 | 16:08 |
---|---|---|
*** rcernin has quit IRC | 16:15 | |
*** Oshino has quit IRC | 16:18 | |
openstackgerrit | Charles Neill proposed openstack/syntribos: Fixes a bug in "excluded tests" https://review.openstack.org/353784 | 16:29 |
*** knangia has joined #openstack-security | 16:32 | |
*** dikonoor has joined #openstack-security | 16:34 | |
*** ccneill_ is now known as ccneill | 16:38 | |
ccneill | unrahul, vinaypotluri, aastha : ping | 16:49 |
*** mdong has joined #openstack-security | 16:49 | |
*** sdake_ has quit IRC | 16:57 | |
*** dave-mcc_ has quit IRC | 16:57 | |
*** dave-mccowan has joined #openstack-security | 16:57 | |
*** tkelsey has joined #openstack-security | 17:01 | |
*** rcernin has joined #openstack-security | 17:02 | |
*** rcernin has quit IRC | 17:05 | |
*** rcernin has joined #openstack-security | 17:05 | |
vinaypotluri | hey ccneill | 17:12 |
unrahul | hey ccneill taking it off the grid for now | 17:12 |
ccneill | word | 17:12 |
ccneill | I always forget how to log into Horizon >_< | 17:12 |
*** sdake has joined #openstack-security | 17:29 | |
*** catintheroof has quit IRC | 17:30 | |
*** mvaldes has quit IRC | 17:32 | |
*** dikonoor has quit IRC | 17:40 | |
*** mvaldes has joined #openstack-security | 17:43 | |
*** tkelsey has quit IRC | 17:44 | |
*** tkelsey has joined #openstack-security | 17:44 | |
openstackgerrit | Aastha Dixit proposed openstack/syntribos: Implement config loading schema https://review.openstack.org/352497 | 17:45 |
*** ametts has joined #openstack-security | 17:57 | |
*** tkelsey has quit IRC | 18:04 | |
*** hockeynut has quit IRC | 18:09 | |
*** hockeynut has joined #openstack-security | 18:11 | |
*** mvaldes has quit IRC | 18:18 | |
*** ccneill_ has joined #openstack-security | 18:29 | |
*** ccneill has quit IRC | 18:32 | |
*** ccneill_ is now known as ccneill | 18:33 | |
*** catintheroof has joined #openstack-security | 18:34 | |
*** GoceVida has quit IRC | 19:20 | |
michaelxin | ccneill: mdong: vinaypotluri: How was yesterday's testing? | 19:28 |
ccneill | we found a lot of things to work on :) | 19:28 |
ccneill | but it went pretty well I think | 19:28 |
*** catintheroof has quit IRC | 19:28 | |
ccneill | everyone was able to test against the Keystone instance through BURP | 19:29 |
mdong | we had some notes on etherpad | 19:29 |
mdong | https://etherpad.openstack.org/p/syn-keystone-testing-notes | 19:29 |
ccneill | and we identified some changes we can make to make the tool better | 19:29 |
ccneill | bumping up the time_length_diff and percentage_length_diff numbers helped us avoid false positives, but I haven't had a chance to go through and manually verify results yet | 19:29 |
*** bknudson has left #openstack-security | 19:31 | |
*** GoceVida has joined #openstack-security | 19:33 | |
ccneill | Jenkins appears to be slacking again... | 19:37 |
michaelxin | cool. Thanks. Will take a look. | 19:48 |
michaelxin | Did you find anything worth reporting? | 19:48 |
*** GoceVida has quit IRC | 19:49 | |
*** GoceVida has joined #openstack-security | 19:50 | |
*** edtubill has quit IRC | 19:57 | |
*** edtubill has joined #openstack-security | 19:58 | |
*** catintheroof has joined #openstack-security | 20:00 | |
ccneill | not really | 20:05 |
ccneill | :\ | 20:05 |
ccneill | well, except that the server didn't like the string "..%c0%af" | 20:05 |
ccneill | not sure why | 20:05 |
ccneill | but that popped up in several places | 20:06 |
ccneill | (500 errors) | 20:06 |
*** edtubill has quit IRC | 20:21 | |
*** mvaldes has joined #openstack-security | 20:42 | |
*** ametts has quit IRC | 20:45 | |
*** sdake has quit IRC | 20:48 | |
*** ametts has joined #openstack-security | 20:51 | |
*** ametts has quit IRC | 20:56 | |
*** bknudson has joined #openstack-security | 21:14 | |
*** sdake has joined #openstack-security | 21:16 | |
michaelxin | 500 errors might be worth reporting. | 21:24 |
*** sdake has quit IRC | 21:33 | |
*** hockeynut has quit IRC | 21:38 | |
*** ddox has joined #openstack-security | 21:49 | |
*** ddox has quit IRC | 21:50 | |
*** ddox has joined #openstack-security | 21:52 | |
*** ddox has left #openstack-security | 21:56 | |
*** edmondsw has quit IRC | 22:03 | |
unrahul | Hey ccneill found a way to package the data files | 22:06 |
ccneill | nice! | 22:06 |
unrahul | so the idea is to add it to syntribos dir and modify the setup.py | 22:07 |
unrahul | so the tree would be like this | 22:07 |
unrahul | https://www.irccloud.com/pastebin/qa9mqwQF/ | 22:07 |
unrahul | https://www.irccloud.com/pastebin/RaOPar2f/ | 22:07 |
unrahul | and include package_data in setup arguments in setup.py | 22:07 |
unrahul | what do u think? | 22:08 |
ccneill | worried about this - https://github.com/openstack/syntribos/blob/master/setup.py#L16 | 22:09 |
ccneill | not sure if that will be a problem or not | 22:10 |
unrahul | yeah.. i didnt really understand that.. | 22:10 |
unrahul | is it something related to jenkins..? | 22:10 |
*** mvaldes has quit IRC | 22:10 | |
unrahul | i can try pushing a patch and see if jenkins raises any concerns.. | 22:11 |
ccneill | looks like we can specify them in setup.cfg | 22:11 |
ccneill | http://docs.openstack.org/developer/pbr/#setup-cfg | 22:11 |
unrahul | whoa.. let me try that.. then | 22:11 |
unrahul | may the whole reason that the file is setup.cfg is so that we put the config details there. | 22:11 |
unrahul | :D | 22:11 |
ccneill | yeah I think so | 22:13 |
ccneill | but I haven't dealt with it much | 22:13 |
ccneill | or at all for this project | 22:13 |
mdong | the data_files config option might be exactly what we want | 22:13 |
*** jass93 has joined #openstack-security | 22:13 | |
mdong | speaking of, our setup.cfg contains the line | 22:13 |
mdong | author-email = nathan.buckner@rackspace.com | 22:13 |
ccneill | yeah | 22:14 |
ccneill | noticed that | 22:14 |
ccneill | we should change it to OpenStack / OpenStack dev list | 22:14 |
unrahul | yeah.. | 22:14 |
mdong | is there a way to get a syntribos email list? | 22:14 |
mdong | if for no other reason than to type everyone’s email | 22:14 |
unrahul | i think that is in launchpad something | 22:14 |
mdong | than to avoid typing everyone’s email* | 22:14 |
ccneill | hmm that would be nice | 22:15 |
ccneill | found this.. https://openstack.nimeyo.com/89478/syntribos-error-attributeerror-object-attribute-headers?ModPagespeed=noscript | 22:16 |
ccneill | lol | 22:16 |
mdong | oops… | 22:16 |
mdong | should probably subscribe to the openstack mailing list huh | 22:17 |
mdong | ah yeah looks like we can request our own list | 22:19 |
mdong | https://wiki.openstack.org/wiki/Mailing_Lists | 22:19 |
unrahul | so data_files dont install into site_packages but to a dir outside of it.. depending upon what we provide, like etc/ | 22:26 |
unrahul | let me figure out how to install into site_packages using config | 22:26 |
mdong | I thought we were talking about having it install to ~/.syntribos folder or something? | 22:27 |
ccneill | hmm.. I wonder how we can reference those files if we put them in site packages | 22:27 |
unrahul | mdong: .. | 22:27 |
unrahul | no.. packaging with syntribos.. itself.. so it will be installed in the site packages.. for all the default tests | 22:28 |
unrahul | because we are not sure.. that there will always be a home dir and the package wont create any dirs outside.. ryt | 22:28 |
mdong | sorry, just going off the design day notes we had | 22:29 |
mdong | https://etherpad.openstack.org/p/syntribos-design | 22:29 |
mdong | day 7, or is that not what we’re talking about? | 22:29 |
unrahul | because then conceptually for the user it would just be like another opencafe dir structure.. which we dont want ryt..? | 22:29 |
*** edtubill has joined #openstack-security | 22:29 | |
mdong | sure, but site-packages doesn’t really feel like where data files should go | 22:31 |
*** edtubill has quit IRC | 22:31 | |
unrahul | the thought was, if syntribos is downloaded by the user from pypi then, it should work out of the box for at least the tests that we are packaging the tool with.. | 22:32 |
unrahul | without any further configuration | 22:32 |
ccneill | sooo I know I've brought this up before, but why don't we just get rid of the data files... | 22:32 |
unrahul | other than the endpoint of the users choice | 22:32 |
mdong | but if pip install puts the data files in ~/.config, it’s the same as having it put in site packages | 22:32 |
mdong | I don’t have a strong opinion either way but I thought this was the result of the discussion we had? | 22:33 |
*** singlethink has quit IRC | 22:34 | |
ccneill | so I think we interpreted it differently | 22:34 |
ccneill | but ultimately, we're putting in all this effort for 127 lines | 22:35 |
ccneill | for i in $(grep -r "\.txt" syntribos/tests/fuzz/*.py | grep -o "data_key = .*" | awk {'print $3'} | tr -d '"'); do; cat data/$i; done | wc | 22:35 |
ccneill | │ 127 408 3672 | 22:35 |
*** catintheroof has quit IRC | 22:35 | |
ccneill | (god I love hacky bash pipelines :D) | 22:35 |
mdong | O.o | 22:36 |
ccneill | I didn't want to cat all the files in that dir, just the ones that are currently used by fuzz tests | 22:36 |
unrahul | >< , | 22:37 |
ccneill | ¯\_(ツ)_/¯ I don't know that there's a good answer to packaging up those files | 22:38 |
unrahul | so should we make the re engineer the data files or package it..? | 22:38 |
unrahul | :/ | 22:38 |
unrahul | like instead of repeating aaa a 1000 times , create the strings dynamically | 22:39 |
unrahul | and stuff..? | 22:39 |
mdong | well the buffer overflow lines are dynamically generated already | 22:39 |
ccneill | right | 22:39 |
ccneill | we'd just have to include them in the fuzz tests themselves | 22:39 |
mdong | so, in the tests themselves, define the payload lines, but include the option to override those with custom data files? | 22:40 |
ccneill | yep | 22:40 |
ccneill | that's what I'm thinking | 22:40 |
mdong | I’m not sure I like that so much, because it’s less clear on how to provide the data files | 22:41 |
ccneill | as I see it, we have a few options, none of which are super appealing | 22:42 |
ccneill | 1) use ~/.syntribos, which the user will probably have to create opencafe-style | 22:42 |
ccneill | 2) somehow jam them into site-packages, which I'm not sure we'll be able to reference easily (since we can't import them like modules) | 22:42 |
ccneill | 3) put them in /etc, which means you need root | 22:43 |
mdong | we already have a default config file in ~/.config | 22:43 |
ccneill | 4) put them in the files, which means we have to come up with a way for overriding | 22:43 |
mdong | or, rather, ~/.syntribos | 22:43 |
ccneill | I'm content with the ~/.syntribos approach, but I don't think it's compatibile with "out-of-the-box pip install" | 22:44 |
ccneill | all pip install will do is follow setup.py, which we don't control | 22:44 |
ccneill | we could move off PBR and edit setup.py directly, but I'm not sure that's the right answer | 22:44 |
mdong | actually, are we doing ~/.syntribos or ~/.config/syntribos? cause the codebase has the former, and our design day notes have the other | 22:44 |
mdong | but I believe what unrahul was saying was that we could specify where we can install files? | 22:45 |
mdong | in the setup.cfg | 22:45 |
ccneill | I don't have a strong opinion.. I think both ~/.[project] and ~/.config/[project] are pretty common | 22:46 |
ccneill | http://docs.openstack.org/developer/oslo.config/builtins.html#default | 22:46 |
ccneill | oslo.config has ~/.[project]/[project].conf by default | 22:47 |
ccneill | so rather than making up our own thing, we should probably conform to that for familiarity's sake | 22:47 |
mdong | then in that case, since ~/.[project] is already openstack convention, I don’t see why we don’t just keep use it | 22:47 |
ccneill | (sorry, I know I'm the one who proposed ~/.config) | 22:47 |
mdong | and if setup.cfg can install files to ~/.syntribos folder, then that should be fine, right? | 22:48 |
ccneill | hrm.. wonder if there are any projects that we can reference doing this | 22:48 |
*** edtubill has joined #openstack-security | 22:50 | |
*** elmiko is now known as _elmiko | 22:51 | |
mdong | so it looks like neutron is installing files to etc/neutron | 22:52 |
mdong | https://github.com/openstack/neutron/blob/master/setup.cfg#L24 | 22:53 |
ccneill | right | 22:53 |
ccneill | I think most services use /etc | 22:53 |
ccneill | trying to find something similar in the various python clients | 22:53 |
mdong | so is there a way we can have it install to the virtualenv’s etc folder? | 22:54 |
mdong | because surely not all of these projects need root | 22:54 |
ccneill | yeah, I think so | 22:56 |
mdong | so maybe we install to etc/syntribos? since that also seems to be an openstack convention? | 22:57 |
ccneill | yeah it mentions the relative paths thing at the bottom of this | 22:58 |
ccneill | http://docs.openstack.org/developer/pbr/#files | 22:58 |
ccneill | Note that this behavior is relative to the effective root of the environment into which the packages are installed, so depending on available permissions this could be the actual system-wide /etc directory or just a top-level etc subdirectory of a virtualenv. | 22:58 |
*** edtubill has quit IRC | 22:59 | |
mdong | ah, ok, so installing to etc/syntribos is an option, then | 22:59 |
ccneill | https://github.com/search?q=org%3Aopenstack+data_files&ref=searchresults&type=Code&utf8=%E2%9C%93 | 22:59 |
ccneill | looks like /share is another popular one.. | 23:00 |
ccneill | maybe just for manpages | 23:01 |
mdong | config files seem to all go into etc at least | 23:01 |
mdong | speaking of which, all our config files are named .config, whereas its more openstacky to do .conf | 23:02 |
ccneill | yeah, but I don't know how happy people will be about dumping our current data dir into /etc/.. | 23:02 |
mdong | not sure how it matters | 23:02 |
mdong | and our templates, if we’re packaging those as well | 23:03 |
ccneill | well, in any case, it doesn't look like anyone is using the $HOME dir to install anything in | 23:04 |
ccneill | so etc is probably our best bet.. | 23:04 |
*** edtubill has joined #openstack-security | 23:13 | |
*** mdong has quit IRC | 23:24 | |
unrahul | well all the projects | 23:31 |
unrahul | have root access | 23:31 |
*** testing1234 has joined #openstack-security | 23:31 | |
unrahul | as we are creating users (keystone, nova, etc ) before setting up the projects | 23:31 |
*** edtubill has quit IRC | 23:31 | |
unrahul | in our case, there is no need for a user syntribos ryt.. and that wont really work in the gate also ryt..? | 23:32 |
unrahul | if we use virtualenv/ then.. it wont work for users who are trying to install it without virtualenv | 23:32 |
unrahul | so .. i am confused. :/ | 23:32 |
unrahul | either we need to tell the user to download the files(may be a sub command) to the directory then.. | 23:33 |
unrahul | w3 fuzzer packages data along with their tests/attacks i guess.. | 23:33 |
*** edtubill has joined #openstack-security | 23:41 | |
*** edtubill has quit IRC | 23:45 | |
*** knangia has quit IRC | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!