| *** sc4nx has joined #openstack-security | 00:41 | |
| *** sc4nx has quit IRC | 00:43 | |
| *** austin987 has quit IRC | 00:45 | |
| *** knangia has joined #openstack-security | 00:47 | |
| *** markvoelker has joined #openstack-security | 00:53 | |
| *** austin987 has joined #openstack-security | 00:59 | |
| *** yuanying has joined #openstack-security | 01:24 | |
| *** yuanying has quit IRC | 01:24 | |
| *** agireud has quit IRC | 02:18 | |
| *** agireud has joined #openstack-security | 02:25 | |
| *** salv-orl_ has joined #openstack-security | 02:29 | |
| *** agireud has quit IRC | 02:30 | |
| *** salv-orlando has quit IRC | 02:32 | |
| *** agireud has joined #openstack-security | 02:40 | |
| *** yuanying has joined #openstack-security | 02:52 | |
| *** markvoelker has quit IRC | 02:53 | |
| *** yuanying has quit IRC | 02:55 | |
| *** yuanying has joined #openstack-security | 02:57 | |
| *** jass93 has joined #openstack-security | 03:00 | |
| *** yuanying has quit IRC | 03:00 | |
| *** yuanying has joined #openstack-security | 03:00 | |
| *** jass93 has quit IRC | 03:04 | |
| *** jass93 has joined #openstack-security | 03:05 | |
| *** yuanying has quit IRC | 03:18 | |
| *** yuanying has joined #openstack-security | 03:20 | |
| *** yuanying has quit IRC | 04:00 | |
| *** yuanying has joined #openstack-security | 04:02 | |
| *** sdake has joined #openstack-security | 04:05 | |
| *** B_Smith has quit IRC | 04:07 | |
| *** B_Smith has joined #openstack-security | 04:14 | |
| *** sdake has quit IRC | 04:25 | |
| *** sdake has joined #openstack-security | 04:50 | |
| *** B_Smith has quit IRC | 04:55 | |
| *** dikonoor has joined #openstack-security | 04:55 | |
| *** sdake has quit IRC | 05:01 | |
| *** dikonoor has quit IRC | 05:06 | |
| *** sdake has joined #openstack-security | 05:10 | |
| *** sdake has quit IRC | 05:17 | |
| *** liverpooler has quit IRC | 05:42 | |
| *** pcaruana has joined #openstack-security | 06:48 | |
| *** markvoelker has joined #openstack-security | 06:54 | |
| *** markvoelker has quit IRC | 06:59 | |
| *** tesseract- has joined #openstack-security | 07:00 | |
| *** liverpooler has joined #openstack-security | 07:10 | |
| *** B_Smith has joined #openstack-security | 07:31 | |
| *** austin987 has quit IRC | 07:33 | |
| *** B_Smith has quit IRC | 07:45 | |
| *** tsufiev_ is now known as tsufiev | 08:13 | |
| *** jass93 has quit IRC | 08:15 | |
| *** markvoelker has joined #openstack-security | 08:19 | |
| *** jass93 has joined #openstack-security | 08:20 | |
| *** markvoelker has quit IRC | 08:24 | |
| *** salv-orlando has joined #openstack-security | 08:29 | |
| *** salv-orl_ has quit IRC | 08:32 | |
| *** sdake has joined #openstack-security | 09:45 | |
| *** sdake has quit IRC | 10:33 | |
| *** jass93 has quit IRC | 11:38 | |
| *** jass93 has joined #openstack-security | 11:42 | |
| *** salv-orl_ has joined #openstack-security | 11:52 | |
| *** salv-orlando has quit IRC | 11:52 | |
| *** edmondsw has joined #openstack-security | 12:13 | |
| *** liverpooler has quit IRC | 12:21 | |
| *** zhihui has quit IRC | 12:23 | |
| *** woodster_ has joined #openstack-security | 12:26 | |
| *** pcaruana has quit IRC | 12:50 | |
| *** dave-mccowan has joined #openstack-security | 12:58 | |
| *** _elmiko is now known as elmiko | 13:04 | |
| *** jmckind has joined #openstack-security | 13:33 | |
| *** markvoelker has joined #openstack-security | 13:36 | |
| *** woodburn has joined #openstack-security | 13:37 | |
| *** cleong has joined #openstack-security | 13:45 | |
| *** browne has joined #openstack-security | 13:57 | |
| *** ametts has joined #openstack-security | 14:06 | |
| *** singlethink has joined #openstack-security | 14:21 | |
| *** ametts has quit IRC | 14:24 | |
| *** zigo has quit IRC | 14:25 | |
| *** ametts has joined #openstack-security | 14:29 | |
| *** salv-orlando has joined #openstack-security | 14:29 | |
| *** zigo has joined #openstack-security | 14:32 | |
| *** salv-orl_ has quit IRC | 14:32 | |
| *** zigo is now known as Guest39147 | 14:33 | |
| *** Guest39147 has quit IRC | 14:39 | |
| *** vinaypotluri has joined #openstack-security | 14:42 | |
| *** zigo_ has joined #openstack-security | 14:42 | |
| *** sdake has joined #openstack-security | 14:44 | |
| *** zigo_ has quit IRC | 14:47 | |
| *** zigo_ has joined #openstack-security | 14:48 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Refactoring debug_logger https://review.openstack.org/365368 | 15:19 |
|---|---|---|
| *** zigo_ is now known as zigo | 15:20 | |
| *** diazjf has joined #openstack-security | 15:34 | |
| *** pcaruana has joined #openstack-security | 15:42 | |
| *** sdake has quit IRC | 15:44 | |
| *** diazjf has quit IRC | 15:50 | |
| *** ccneill has joined #openstack-security | 15:51 | |
| openstackgerrit | Merged openstack/syntribos: Adding config fixture https://review.openstack.org/365144 | 15:59 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Unit tests for the identity client https://review.openstack.org/365365 | 16:06 |
| *** diazjf has joined #openstack-security | 16:06 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Unit tests for the identity client https://review.openstack.org/365365 | 16:10 |
| unrahul | vinaypotluri: knangia could you please take a look at this patch https://review.openstack.org/#/c/365368/ | 16:11 |
| ccneill | unrahul, knangia, vinaypotluri: having technical issues this morning.. gonna restart my laptop and try to make it back in time for some of our standup >_< | 16:17 |
| *** ccneill has quit IRC | 16:18 | |
| *** sicarie has joined #openstack-security | 16:21 | |
| browne | Any anchor cores around? If so, can they please review https://review.openstack.org/#/c/340095/ | 16:22 |
| browne | I keep seeing duplicate reviews being put up (count is 3 so far) | 16:23 |
| *** ninag has joined #openstack-security | 16:26 | |
| *** ccneill has joined #openstack-security | 16:27 | |
| unrahul | Hey ccneill u thr? | 16:30 |
| ccneill | yep | 16:30 |
| unrahul | The stand up just got over, saw ur msg now | 16:30 |
| ccneill | np | 16:30 |
| unrahul | Michaelxin was thr | 16:30 |
| ccneill | I got on the OSIC-6 room a minute ago but didn't see anyone | 16:31 |
| unrahul | Should we start creating templates manually?, or the proxy script? | 16:31 |
| unrahul | Ohh | 16:31 |
| unrahul | For neutron that is | 16:31 |
| *** sdake has joined #openstack-security | 16:57 | |
| unrahul | hey ccneill vinaypotluri knangia , created a syntribos testing etherpad https://etherpad.openstack.org/p/syntribos-testing , kindly add further details if any. | 16:59 |
| ccneill | nice | 17:04 |
| ccneill | thanks unrahul | 17:04 |
| ccneill | created a Google Docs spreadsheet for us to track our template generation efforts | 17:04 |
| ccneill | https://docs.google.com/spreadsheets/d/1Utng17QJRW3aBIrDxu2B5oBq5jNVKewb8apj-Ztfe0s/edit#gid=0 | 17:04 |
| ccneill | we don't have to put much detail into it, just figured it would help to split it up by section like that | 17:05 |
| ccneill | just mainly so we don't miss anything | 17:05 |
| ccneill | we're looking at nearly 200 templates o_o | 17:05 |
| ccneill | and that's without LBv1.0 | 17:06 |
| unrahul | :o | 17:11 |
| unrahul | the headings tricked us.. I thought each sub heading had only one template, turns out I was wrong :/ | 17:12 |
| *** sdake_ has joined #openstack-security | 17:12 | |
| *** Gatita2016 has joined #openstack-security | 17:13 | |
| *** Gatita2016 has quit IRC | 17:13 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding templates for neutron https://review.openstack.org/366257 | 17:14 |
| *** sdake has quit IRC | 17:15 | |
| *** diazjf has quit IRC | 17:17 | |
| openstackgerrit | Merged openstack/anchor: Add Python 3.5 classifier and venv https://review.openstack.org/340095 | 17:19 |
| ccneill | unrahul: yeah.. it's a lot more than I expected :X | 17:19 |
| ccneill | I figured we should draw the line at LBaaS v1 since it's deprecated anywya.. | 17:20 |
| ccneill | anyway | 17:20 |
| unrahul | oh.. yeah..makes sense ccneill | 17:21 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding templates for neutron https://review.openstack.org/366257 | 17:27 |
| *** sdake_ has quit IRC | 17:28 | |
| *** sdake has joined #openstack-security | 17:29 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/366273 | 17:49 |
| *** sdake has quit IRC | 17:49 | |
| *** tmcpeak has joined #openstack-security | 17:53 | |
| *** sdake has joined #openstack-security | 17:56 | |
| openstackgerrit | Merged openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/366273 | 17:56 |
| *** bknudson has joined #openstack-security | 18:00 | |
| *** ccneill_ has joined #openstack-security | 18:25 | |
| *** ccneill has quit IRC | 18:25 | |
| *** ccneill_ is now known as ccneill | 18:28 | |
| *** diazjf has joined #openstack-security | 18:29 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding templates for neutron https://review.openstack.org/366257 | 18:38 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding templates for neutron https://review.openstack.org/366257 | 18:59 |
| *** pcaruana has quit IRC | 19:11 | |
| *** cleong has quit IRC | 19:15 | |
| *** tesseract- has quit IRC | 19:25 | |
| *** sicarie has quit IRC | 19:28 | |
| *** sicarie has joined #openstack-security | 19:38 | |
| *** rcernin has joined #openstack-security | 19:41 | |
| *** sdake has quit IRC | 19:46 | |
| *** rcernin has quit IRC | 19:48 | |
| ccneill | lol nice.. neutron has "lb_algorithm" on POST and "lb_method" on PUT for pools | 19:50 |
| ccneill | :| | 19:50 |
| ccneill | lol.. | 19:54 |
| ccneill | somehow I feel like their docs haven't been kept up to date very well.. | 19:55 |
| *** sdake has joined #openstack-security | 20:03 | |
| *** edmondsw has quit IRC | 20:13 | |
| *** diazjf has quit IRC | 20:15 | |
| *** tmcpeak has quit IRC | 20:16 | |
| unrahul | :|.. | 20:23 |
| *** jass93 has quit IRC | 20:28 | |
| *** diazjf has joined #openstack-security | 20:28 | |
| ccneill | eh, we'll find out I suppose haha | 20:30 |
| ccneill | I thought one of their request examples was off, but it made more sense as I looked at it more | 20:30 |
| *** salv-orl_ has joined #openstack-security | 20:30 | |
| ccneill | it might be off on the lb_algorithm/lb_method thing though | 20:33 |
| ccneill | http://developer.openstack.org/api-ref/networking/v2/?expanded=list-load-balancers-detail,create-load-balancer-detail,show-load-balancer-details-detail,update-load-balancer-detail,remove-load-balancer-detail,show-load-balancer-status-tree-detail,create-listener-detail,update-listener-detail,create-pool-detail,show-details-for-a-network-with-multiple-segments-detail,list-networks-with-multiple-segm | 20:33 |
| ccneill | ent-mappings-detail,create-network-with-multiple-segment-mappings-detail,create-network-detail,create-vlan-transparent-network-detail,update-pool-detail,list-pool-members-detail,add-member-to-pool-detail,show-pool-member-details-detail#create-pool | 20:33 |
| ccneill | whoa | 20:33 |
| ccneill | :| | 20:33 |
| *** salv-orlando has quit IRC | 20:33 | |
| ccneill | sorry | 20:33 |
| ccneill | http://developer.openstack.org/api-ref/networking/v2/?expanded=create-pool-detail#create-pool | 20:34 |
| ccneill | http://developer.openstack.org/api-ref/networking/v2/?expanded=update-pool-detail#update-pool | 20:34 |
| *** jass93 has joined #openstack-security | 20:39 | |
| *** ayoung has quit IRC | 20:41 | |
| *** agireud has quit IRC | 20:52 | |
| unrahul | oh yeah.. I guess.. it is lb_method for all rather than lb_algorithm.. | 20:52 |
| unrahul | what do u suppose it is? | 20:53 |
| unrahul | may be we should try with both :D | 20:53 |
| *** diazjf has quit IRC | 20:57 | |
| ccneill | ¯\_(ツ)_/¯ I'm gonna follow what the docs say lol | 20:58 |
| *** agireud has joined #openstack-security | 20:59 | |
| *** sdake has quit IRC | 21:02 | |
| *** diazjf has joined #openstack-security | 21:08 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding templates for neutron https://review.openstack.org/366257 | 21:20 |
| unrahul | :D // | 21:21 |
| *** diazjf has quit IRC | 21:26 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Fixing tiny nit in keystone templates https://review.openstack.org/366350 | 21:29 |
| *** ametts has quit IRC | 21:30 | |
| *** diazjf has joined #openstack-security | 21:38 | |
| *** diazjf has quit IRC | 21:40 | |
| openstackgerrit | Merged openstack/syntribos: Fixing tiny nit in keystone templates https://review.openstack.org/366350 | 21:47 |
| *** diazjf has joined #openstack-security | 21:48 | |
| openstackgerrit | Charles Neill proposed openstack/syntribos: Neutron LBaaS and FWaaS templates https://review.openstack.org/366357 | 21:54 |
| *** diazjf has quit IRC | 21:55 | |
| ccneill | unrahul: just realized, I chose v3 for tokens and you chose v2 lol >_< | 21:56 |
| ccneill | should we go with v3 since v2 is technically deprecated? | 21:56 |
| unrahul | we shall go for v3 then ccneill , that makes more sense :) | 22:00 |
| ccneill | argh... | 22:01 |
| ccneill | I got my file names backwards >_< | 22:01 |
| unrahul | file names matter :0 ?? | 22:02 |
| *** johnsom has joined #openstack-security | 22:06 | |
| johnsom | Hi folks. Is this the best channel to ask bandit questions? | 22:07 |
| unrahul | hey johnsom , yup | 22:07 |
| johnsom | We recently merged our non-voting bandit gate into our pep8 gate (making it voting). This has gone just fine. However, we are seeing a side effect. | 22:08 |
| unrahul | any bandit cores around ? ccneill ? | 22:10 |
| johnsom | When we run our pep8 test on local changes, that have not been committed yet, we get an error | 22:10 |
| johnsom | https://gist.github.com/johnsom/0c1553682f592aa23a248132d3328bc3 | 22:10 |
| johnsom | I'm wondering if we are running it wrong. | 22:10 |
| ccneill | elmiko: any ideas re: johnsom's question above? | 22:15 |
| ccneill | I'm not too familiar with bandit-baseline, but did find this: https://github.com/openstack/bandit/blob/master/bandit/cli/baseline.py#L199-L203 | 22:17 |
| ccneill | so I think you want to set the baseline from a non-dirty repo, and then run "bandit" against the dirty repo to test the difference | 22:18 |
| *** ninag has quit IRC | 22:18 | |
| ccneill | (though I'm not a bandit expert and don't play one on the internet) | 22:18 |
| johnsom | lol | 22:18 |
| ccneill | O:-) | 22:19 |
| *** jmckind has quit IRC | 22:21 | |
| johnsom | Hmm, I thought there was magic in the bandit code to handle that, but I am far from a bandit expert either. Comparing the example here: https://wiki.openstack.org/wiki/Security/Projects/Bandit#Bandit_Baseline_Gate we are doing the right thing. | 22:28 |
| johnsom | Well, I will keep an eye on the channel in case an expert happens to wander by | 22:28 |
| ccneill | any of these folks ought to be able to help https://wiki.openstack.org/wiki/Security/Projects/Bandit#Team | 22:33 |
| ccneill | sigmavirus: you around by chance? | 22:33 |
| ccneill | browne ? | 22:33 |
| browne | hi | 22:34 |
| browne | tmcpeak is the baseline expert | 22:34 |
| ccneill | ah, and I see he's gone for the day | 22:35 |
| browne | but yes, bandit will fail if changes on a patch are not commited. it can be annoying | 22:35 |
| browne | patch set changes i should say | 22:36 |
| johnsom | Yep, it is driving our devs a bit batty | 22:36 |
| *** jass93 has quit IRC | 22:37 | |
| browne | i don't like it much either, but have been working around it by commit the changes | 22:37 |
| johnsom | So, maybe this is a bug? I just thought we were running it wrong | 22:37 |
| browne | i think it would be good to take that feedback to tmcpeak and open a bug | 22:37 |
| *** tmcpeak has joined #openstack-security | 22:38 | |
| tmcpeak | o/ | 22:38 |
| sicarie | johnsom ^ | 22:38 |
| johnsom | Hi tmcpeak, not sure if you have scroll back, but we are seeing this https://gist.github.com/johnsom/0c1553682f592aa23a248132d3328bc3 | 22:39 |
| tmcpeak | no scrollback, but looking at the issue now | 22:40 |
| johnsom | We merged our bandit gate into the pep8 (infra request) to make it voting. | 22:40 |
| tmcpeak | are you running this locally? | 22:40 |
| openstackgerrit | Eric Brown proposed openstack/syntribos: Add man page for syntribos command https://review.openstack.org/327305 | 22:40 |
| johnsom | Now when devs run our tox pep8, and they have uncommitted changes, they get this error | 22:40 |
| johnsom | Yeah, that was a local run | 22:41 |
| tmcpeak | johnsom: the reason it's doing that is because we actually check out the previous branch | 22:41 |
| tmcpeak | so uncommited changes would be wiped away | 22:41 |
| tmcpeak | we could stash them and unstash, but then it's really unclear which version you want to compare against | 22:41 |
| tmcpeak | so we just bail if there are uncommited changes | 22:42 |
| johnsom | Yeah, I was just thinking about the stash/unstash | 22:42 |
| tmcpeak | so you have version A and B. You want to compare results of those two. Should we assume uncommited changes go with B? | 22:43 |
| tmcpeak | so run B + new changes and compare against A? | 22:43 |
| johnsom | This is just making an unpleasant experience for the devs that want to cycle on the linters with new code. I.e. dealing with spacing issues so running pep8 a bunch. | 22:43 |
| tmcpeak | johnsom: totally, I've been there | 22:43 |
| tmcpeak | I'm happy to work with you on any fix | 22:43 |
| *** singlethink has quit IRC | 22:44 | |
| tmcpeak | easiest would probably be, just stash/unstash prior to pep8 regardless of whether there are changes | 22:44 |
| johnsom | Yeah, cool. I was hoping there was magic that we just weren't using.... grin | 22:44 |
| tmcpeak | if this is a repeated pain point for people I'm happy to just build that into Bandit too | 22:44 |
| tmcpeak | johnsom: fair enough :) if that doesn't work for some reason or it sucks let me know | 22:44 |
| tmcpeak | should work fine though | 22:44 |
| tmcpeak | johnsom: good work on putting Bandit voting too :) | 22:45 |
| openstackgerrit | Vinay Potluri proposed openstack/syntribos: Added neutron templates https://review.openstack.org/366410 | 22:46 |
| johnsom | Thanks | 22:47 |
| johnsom | If I stash/unstash bandit just won't get run on those changes, right? Or is there a sequence of bandit commands I should be running in tox? | 22:48 |
| tmcpeak | hmm, actually | 22:49 |
| tmcpeak | johnsom: interesting question… if you stash does that show up like another commit? | 22:49 |
| johnsom | I am so rust on the bandit stuff at this point | 22:50 |
| tmcpeak | it's more of a git question | 22:50 |
| tmcpeak | johnsom: let me do a quick experiment | 22:50 |
| tmcpeak | johnsom: yeah, git stash is fine | 22:52 |
| tmcpeak | so you'll get a baseline of B (without stashed contents) compared to A | 22:53 |
| tmcpeak | which should be what you want | 22:53 |
| tmcpeak | although if you want bandit to run against the uncommited changes, it won't do that | 22:54 |
| johnsom | Right, I think running in pep8 task, but ignoring the uncommitted changes would give devs the wrong idea. | 22:55 |
| johnsom | Or at least be confusing | 22:55 |
| tmcpeak | could put a message to make it clear | 22:55 |
| tmcpeak | I could see it the other way too though, automatically assuming that I want to run Bandit baseline with uncommited stuff vs. commit prior to last commit could also be confusing | 22:56 |
| johnsom | Yep | 22:56 |
| tmcpeak | for Bandit basleine they realistically want one of two things — to make some fixes to what they had last, in which case they probably want 'git commit —amend' | 22:57 |
| tmcpeak | or to run baseline while ignoring some changes I've started doing | 22:57 |
| tmcpeak | either way, I think telling the developer what's going on, stashing, then running baseline is probably the right course | 22:57 |
| johnsom | I am starting to think I liked this outside of the linters... | 22:58 |
| tmcpeak | the reason we included it with linters is to cut down job time, realistically pep8 and Bandit need the same env. So spinning up two is un-needed time and resources in infra | 22:59 |
| tmcpeak | to be fair though, I advocated for keeping them separate too. Then jobs promote Bandit to voting as a separate decision | 22:59 |
| johnsom | Yeah, I know | 22:59 |
| johnsom | Ok. I am going to think about this for a bit and probably put a patch up and see what the other cores think. | 23:00 |
| tmcpeak | johnsom: sounds reasonable, let me know how I can help | 23:00 |
| johnsom | tmcpeak Thanks for the help/time! | 23:00 |
| tmcpeak | if we have to I can add a flag in bandit-baseline that explicitly says use/don't use unstashed changes, but that feels overboard :D | 23:00 |
| openstackgerrit | Charles Neill proposed openstack/syntribos: Neutron LBaaS and FWaaS templates https://review.openstack.org/366357 | 23:01 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding templates for neutron https://review.openstack.org/366257 | 23:01 |
| tmcpeak | johnsom: sure, anytime | 23:02 |
| *** ayoung has joined #openstack-security | 23:10 | |
| *** sdake has joined #openstack-security | 23:10 | |
| *** markvoelker has quit IRC | 23:19 | |
| *** jass93 has joined #openstack-security | 23:26 | |
| *** sicarie has quit IRC | 23:28 | |
| *** jass93 has quit IRC | 23:31 | |
| openstackgerrit | Charles Neill proposed openstack/syntribos: Neutron LBaaS and FWaaS templates https://review.openstack.org/366357 | 23:31 |
| *** jass93 has joined #openstack-security | 23:31 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Refactoring debug_logger https://review.openstack.org/365368 | 23:42 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Refactoring debug_logger https://review.openstack.org/365368 | 23:43 |
| johnsom | tmcpeak FYI, this is getting a bit uglier. git isn't configured inside the tox environment. It's telling me I need to set my ident name even though it's set in my global and user env | 23:49 |
| tmcpeak | set your ident name? | 23:49 |
| tmcpeak | how does bandit baseline even work without git… | 23:50 |
| tmcpeak | johnsom: ^ | 23:50 |
| johnsom | https://gist.github.com/johnsom/3aa846d6701c76f8044b00926e154d6e | 23:50 |
| johnsom | Yeah, a bit puzzled by that as well | 23:50 |
| openstackgerrit | Merged openstack/syntribos: Add man page for syntribos command https://review.openstack.org/327305 | 23:51 |
| tmcpeak | johnsom: I'm looking at this: http://stackoverflow.com/questions/14662526/why-git-is-not-allowing-me-to-commit-even-after-configuration | 23:52 |
| tmcpeak | so in that case it was a typo, but you're validating the config is there with 'git config —global' and everything looks good? | 23:53 |
| tmcpeak | so 'git config —global -l' gives expected info? | 23:54 |
| tmcpeak | do other git commands blow up on you? | 23:54 |
| johnsom | yeah, it's good. (I use it all the time) | 23:54 |
| johnsom | if I remove the stash line and the pop line, bandit runs as long as I don't have uncommitted code. | 23:55 |
| johnsom | The tox environment must override this stuff and maybe it is only required for creating the stash.... | 23:56 |
| elmiko | saw a ping from earlier, i'm gonna guess you guys have it all sorted? | 23:56 |
| tmcpeak | elmiko: yeah, thanks | 23:56 |
| elmiko | cool =) | 23:56 |
| tmcpeak | johnsom: so git log and other commands work? | 23:56 |
| tmcpeak | (I'm about to try with octavia too) | 23:56 |
| johnsom | Yes, git log runs | 23:57 |
| *** markvoelker has joined #openstack-security | 23:57 | |
| tmcpeak | ok, I'm almost caught up to you | 23:58 |
| johnsom | git stash | 23:59 |
| johnsom | bandit-baseline -r octavia -ll -ii | 23:59 |
| johnsom | git stash pop | 23:59 |
| tmcpeak | it worked when I did it manually | 23:59 |
| tmcpeak | trying to add relevant lines in tox now | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!