*** openstack has joined #openstack-shade | 10:13 | |
*** openstackstatus has joined #openstack-shade | 10:15 | |
mordred | GheRivero: that's a good question. we currently should be assuming that all ipv6 networks are external (hadn't found anyone who is ipv6 aware doing internal-only ipv6) | 12:12 |
---|---|---|
mordred | Shrews: ok. I figured out the issue with the nodepool test | 12:27 |
mordred | and it's an actual issue - but one I think we can ignore for a few patches | 12:27 |
mordred | the long and short of it is that nodepool uses TaskManager that runs with a single queue of operations - meaning only one task can run at a time | 12:28 |
mordred | with the patches to start moving over to rest - the explicit Task objects get queued, and then the rest task that runs inside of them also gets queued | 12:29 |
mordred | but the inner task can't run because the outer task is the active task in the queue | 12:29 |
mordred | SO - nodepool isn't going to work until all of the tasks nodepool does are converted to pure-rests | 12:30 |
mordred | that is a good color on which calls to conver tnext though | 12:30 |
mordred | so what I'm going to do, instead of organizing by client library (do all the tasks for a client library so we cna remove it from requirements) | 12:31 |
mordred | I'll get the nodepool tasks done first - there arne't that many of them | 12:31 |
mordred | then we should be in a fairly safe place - I'm pretty sure that nobody in the world other than nodepool is actually passing in such a specific TaskManager :) | 12:32 |
*** openstackstatus has quit IRC | 12:43 | |
*** openstack has joined #openstack-shade | 12:43 | |
*** openstackstatus has joined #openstack-shade | 12:45 | |
Shrews | mordred: then we should probably hold off on approving the stack until your theory is confirmed, yeah? | 13:20 |
mordred | Shrews: yes. | 13:23 |
mordred | Shrews: otherwise we'll get caught not being able to make emergency releases for nodepool if necessary | 13:24 |
mordred | GheRivero: nice patch - one thing in it | 13:24 |
GheRivero | mordred: still working on it. I just wanted it to go thorigh the gate to have a first pass | 13:25 |
*** abregman has joined #openstack-shade | 13:28 | |
Shrews | mordred: https://review.openstack.org/#/c/386586/1/shade/openstackcloud.py 0 vs. 0.1 ... don't think that will make much difference. i use 0.1 that in np-builder and the cpu goes mega-hot | 13:29 |
Shrews | so i'm not convinced that is an improvement | 13:30 |
Shrews | but i also don't think it hurts, fwiw | 13:32 |
mordred | GheRivero: cool. thanks! it's looking good | 13:36 |
mordred | Shrews: harrumph. I wonder if there is a decent point which doesn't burn CPU but also isn't highly end-user noticable | 13:37 |
Shrews | mordred: probably the _right_ way to correct that is go back to the drawing board and consider other mechanisms (signal timers, thread conditionals, whateva). but who has time for that | 13:43 |
Shrews | mordred: also, should we consider creating a v2 branch in shade for your rest changes? | 13:44 |
Shrews | i sort of feel like that might be a good idea, but i've also only had 1 cup of coffee | 13:44 |
mordred | Shrews: maybe so, yeah | 13:47 |
mordred | Shrews: and I think the idea of releasing that as v2 - even if we still don't break backwards compat - is a good way to signal that there is a rather large change to the backend internals that one might want to test for a second | 13:48 |
mordred | Shrews: btw - I accelerated working on this because our centos friends reported that shade was a hardship on them because it requires all the client libs - at potentially different versions than openstack itself needs | 13:50 |
*** abregman has quit IRC | 13:50 | |
*** abregman has joined #openstack-shade | 13:50 | |
Shrews | yeah. everyone i've seen using centos+shade is pretty unhappy | 14:01 |
Shrews | mordred: and your 0.1 change has raised some interesting errors for some reason | 14:01 |
Shrews | fascinating | 14:01 |
*** abregman has quit IRC | 14:46 | |
*** abregman has joined #openstack-shade | 14:53 | |
mordred | Shrews: neat! | 16:31 |
*** kamsz has quit IRC | 16:55 | |
*** kamsz has joined #openstack-shade | 16:58 | |
mordred | Shrews: ok - so the failure makes some sense looking at the test ... the get after the metadata set doesn't have any concept that it could be getting old data. I'm going to remove that patch - I think the test shows us that the knock-on effects are too complex to deal with in this context | 17:01 |
mordred | Shrews: that said - I do think it's a worthwhile endeavor at some point to go through the entire api and make sure it behaves as expected when that wait time is not zero | 17:02 |
mordred | but not today or tomorrow | 17:02 |
*** jlk is now known as omgwtfjlk | 17:06 | |
*** abregman is now known as abregman|afk | 17:12 | |
*** olaph is now known as beefboymatface | 18:30 | |
*** jlk has joined #openstack-shade | 18:48 | |
*** jlk has quit IRC | 18:48 | |
*** jlk has joined #openstack-shade | 18:48 | |
*** omgwtfjlk has quit IRC | 18:51 | |
*** yolanda has quit IRC | 19:16 | |
*** yolanda has joined #openstack-shade | 19:51 | |
*** abregman|afk is now known as abregman | 21:43 | |
*** mgagne_ is now known as mgagne | 23:12 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!