| *** yolanda has quit IRC | 04:18 | |
| *** abregman has joined #openstack-shade | 06:05 | |
| *** yolanda has joined #openstack-shade | 07:33 | |
| *** abregman_ has joined #openstack-shade | 08:37 | |
| *** abregman has quit IRC | 08:39 | |
| *** abregman_ has quit IRC | 08:47 | |
| *** abregman has joined #openstack-shade | 08:47 | |
| *** abregman has quit IRC | 09:12 | |
| *** abregman has joined #openstack-shade | 09:18 | |
| *** openstackgerrit has quit IRC | 09:47 | |
| *** openstackgerrit has joined #openstack-shade | 09:48 | |
| openstackgerrit | Monty Taylor proposed openstack/oaktree: Rename Search to List https://review.openstack.org/397167 | 12:32 |
|---|---|---|
| openstackgerrit | Merged openstack/oaktreemodel: Rename search methods to list https://review.openstack.org/396936 | 12:32 |
| openstackgerrit | Monty Taylor proposed openstack/oaktreemodel: Update generated code https://review.openstack.org/397180 | 13:13 |
| openstackgerrit | Monty Taylor proposed openstack/oaktreemodel: Add tarball to .gitignore https://review.openstack.org/397181 | 13:13 |
| openstackgerrit | Merged openstack/oaktree: Rename Search to List https://review.openstack.org/397167 | 13:38 |
| Shrews | jlk: i think we have an issue (discovered by shade tests) for your os_user change: https://github.com/ansible/ansible-modules-core/pull/5219 | 13:59 |
| Shrews | jlk: http://logs.openstack.org/53/396953/1/check/gate-shade-dsvm-ansible-dev-nv/6c2097d/console.html#_2016-11-13_18_08_55_603966 | 13:59 |
| Shrews | jlk: basically, when state=absent, it's expecting a password, which is a backward incompatible change | 14:00 |
| Shrews | and forcing playbooks to now set update_password=on_create to delete a user is not really a good option | 14:02 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Collapse list/search for networks, users and keypairs https://review.openstack.org/397208 | 14:18 |
| mordred | Shrews: ^^ that's going to take a smidge longer than I originally anticipated | 14:18 |
| mordred | Shrews: (that said, poking at it continues to find little tiny bits of poo - so I think it's not unworth it) | 14:23 |
| *** edtubill has joined #openstack-shade | 15:14 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Collapse list/search for networks, users and keypairs https://review.openstack.org/397208 | 15:36 |
| *** abregman is now known as abregman|mtg | 15:44 | |
| *** edtubill has quit IRC | 16:12 | |
| *** edtubill has joined #openstack-shade | 16:13 | |
| *** abregman|mtg is now known as abregman | 16:27 | |
| *** abregman has quit IRC | 17:08 | |
| openstackgerrit | Monty Taylor proposed openstack/oaktreemodel: Add dict mapping for searching for things https://review.openstack.org/396937 | 17:10 |
| jlk | Shrews: oops, okay good catch. Want me to work a patch? | 17:25 |
| jlk | ugh, I don't think our module utils has a built in for this. We only need this IF state = present. | 17:28 |
| mordred | jlk: I thought there was a module_utils thing that would do required if a value ... | 17:29 |
| jlk | well | 17:30 |
| jlk | here's the scenario | 17:30 |
| jlk | update_password defaults to "always" for backwards compat. | 17:30 |
| jlk | if update_password is always, THEN a "password" argument is also required. | 17:30 |
| jlk | BUT only if state = present | 17:30 |
| mordred | ah - yes. I grok | 17:31 |
| mordred | jlk: the argument processing in ansible is amazing ... until it can't handle something | 17:33 |
| jlk | lol yes | 17:33 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Collapse list/search for networks, users and keypairs https://review.openstack.org/397208 | 17:40 |
| jlk | Shrews: I think https://github.com/ansible/ansible-modules-core/pull/5601 will fix it, I haven't tested yet, just tossed that change together. | 17:42 |
| openstackgerrit | Merged openstack/oaktreemodel: Update generated code https://review.openstack.org/397180 | 17:43 |
| openstackgerrit | Merged openstack/oaktreemodel: Add tarball to .gitignore https://review.openstack.org/397181 | 17:43 |
| jlk | ugh, did Canonical do something with launchpad logins recently? | 17:47 |
| Shrews | jlk: ok. let me know if testing looks good | 17:49 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Be specific about protected being bool https://review.openstack.org/397323 | 18:01 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Be specific about protected being bool https://review.openstack.org/397323 | 18:09 |
| thingee | doh | 18:57 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Be specific about protected being bool https://review.openstack.org/397323 | 19:12 |
| openstackgerrit | Monty Taylor proposed openstack/os-client-config: Revert "Remove validate_auth_ksc" https://review.openstack.org/397343 | 19:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Be specific about protected being bool https://review.openstack.org/397323 | 19:29 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Make unittest resilient against occ internals https://review.openstack.org/397345 | 19:29 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Remove pointless and fragile unittest https://review.openstack.org/397345 | 19:34 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade: Be specific about protected being bool https://review.openstack.org/397323 | 19:38 |
| *** abregman has joined #openstack-shade | 19:38 | |
| mordred | thingee: ikr? | 19:38 |
| Shrews | mordred: was i not supposed to +A that protected change? | 19:47 |
| clarkb | Shrews: it was fine it just didn't pass tests | 19:47 |
| clarkb | Shrews: hence the rebasing madness | 19:47 |
| mordred | Shrews: yah - what clarkb said | 19:48 |
| openstackgerrit | Merged openstack/os-client-config: Revert "Remove validate_auth_ksc" https://review.openstack.org/397343 | 20:48 |
| *** abregman has quit IRC | 20:55 | |
| thingee | mordred where can I read about the generated tags in structs here? (assuming I'm saying that right) https://review.openstack.org/#/c/396937/2/oaktreemodel/common.pb.go | 21:24 |
| mordred | thingee: I'm not sure - much of the content of that file is blackmagic to me | 21:25 |
| mordred | thingee: s/much of the content of that file/pretty much all of the content of the go files/ ... also I feel totally dirty committing generated code | 21:42 |
| thingee | mordred I'm just trying to find any documentation about it | 21:43 |
| clarkb | mordred: there is protobuf support for compiling things at python package build time iirc (though not sure if you can trigger the asme compiles for go things) | 21:46 |
| clarkb | oh readme calls that out | 21:46 |
| clarkb | yay go? | 21:46 |
| mordred | clarkb: yah | 21:46 |
| mordred | clarkb: I looked at some of the other folks doing it more deeply - like etcd3 and whatnot - and they all seem to take the same approach | 21:47 |
| mordred | I'm just about to put up a project-config patch to add a test to make sure people don't forget to add their generated go code | 21:47 |
| mordred | clarkb, thingee: https://review.openstack.org/397385 | 21:48 |
| clarkb | mordred: I especially like that the code generated code has whitespace edits | 21:50 |
| clarkb | (I am guessing because gofmt, but still ) | 21:50 |
| thingee | what is the difference with json: and json= | 21:51 |
| thingee | the syntax is interesting :) | 21:52 |
| thingee | well I couldn't find any documentation on the generated stuff | 21:53 |
| mordred | that is a truly fascinating question | 21:54 |
| mordred | thingee: maybe it's documented in the generator code | 21:54 |
| thingee | I was reading that omitentry is just hardcoded in the source code, so that's always a thing. | 21:55 |
| mordred | yah - I believe that's always the protobuf-json mapping behavior | 21:56 |
| mordred | https://github.com/golang/protobuf/tree/master/protoc-gen-go is the generator, fwiw | 21:56 |
| *** edtubill has quit IRC | 22:40 | |
| *** edtubill has joined #openstack-shade | 22:56 | |
| *** edtubill has quit IRC | 23:11 | |
| openstackgerrit | Merged openstack/oaktreemodel: Add dict mapping for searching for things https://review.openstack.org/396937 | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!