| Shrews | mordred: was only a nit, but if you want to pad your review stats... | 00:19 |
|---|---|---|
| Shrews | +A'd | 00:19 |
| hoolio | I'm just curious about the process; when would that patch be merged, and is there some latency before it appears as an update for the pip package? | 00:31 |
| mordred | hoolio: the patch will be merged soon - but I probably won't cut a new release til next week (what with US thanksgiving this week and all) | 00:40 |
| hoolio | so the merge and release are both manually triggered? | 00:42 |
| openstackgerrit | Merged openstack-infra/shade: Add docstring for create_image_snapshot https://review.openstack.org/400446 | 01:26 |
| hoolio | I'm writing a patch do document the delete_image function, but i'm just wondering what the delete_objects parameter does? | 05:01 |
| hoolio | also i expect won't have permission to push the review | 05:01 |
| openstackgerrit | Hoolio Wobbits proposed openstack-infra/shade: Added documentation for delete_image() https://review.openstack.org/400519 | 05:33 |
| hoolio | ooh look at that :) | 05:33 |
| openstackgerrit | Hoolio Wobbits proposed openstack-infra/shade: Added documentation for delete_image() https://review.openstack.org/400519 | 05:44 |
| openstackgerrit | Hoolio Wobbits proposed openstack-infra/shade: Added documentation for delete_image() https://review.openstack.org/400519 | 05:46 |
| hoolio | soz n00b | 05:47 |
| openstackgerrit | Hoolio Wobbits proposed openstack-infra/shade: Added documentation for delete_image() https://review.openstack.org/400519 | 05:51 |
| hoolio | .. | 05:51 |
| *** abregman has joined #openstack-shade | 06:23 | |
| *** gouthamr has joined #openstack-shade | 08:12 | |
| *** rcarrillocruz has quit IRC | 09:29 | |
| *** yolanda has quit IRC | 10:35 | |
| *** yolanda has joined #openstack-shade | 10:38 | |
| *** gouthamr has quit IRC | 10:49 | |
| *** rcarrillocruz has joined #openstack-shade | 11:46 | |
| *** gouthamr has joined #openstack-shade | 12:30 | |
| *** abregman is now known as abregman|mtg | 12:57 | |
| *** yolanda has quit IRC | 12:58 | |
| *** abregman|mtg has quit IRC | 13:02 | |
| Shrews | hoolio: see commit 502a4b for a description of the delete_objects param (git show 502a4b) | 13:17 |
| Shrews | hoolio: and we welcome n00bz :) | 13:17 |
| openstackgerrit | Merged openstack-infra/shade: Allow server to be snapshot to be name, id or dict https://review.openstack.org/400447 | 13:47 |
| openstackgerrit | Merged openstack-infra/shade: Add an e to the word therefore https://review.openstack.org/400450 | 13:59 |
| *** abregman has joined #openstack-shade | 14:12 | |
| *** yolanda has joined #openstack-shade | 14:17 | |
| *** gouthamr has quit IRC | 14:30 | |
| *** gouthamr has joined #openstack-shade | 14:32 | |
| *** yolanda has quit IRC | 14:36 | |
| *** yolanda has joined #openstack-shade | 14:43 | |
| *** yolanda has quit IRC | 15:12 | |
| mordred | hoolio: I added a note in the review about what delete_objects does | 15:30 |
| *** yolanda has joined #openstack-shade | 15:52 | |
| *** yolanda has quit IRC | 16:04 | |
| *** yolanda has joined #openstack-shade | 16:29 | |
| *** abregman has quit IRC | 16:33 | |
| *** abregman has joined #openstack-shade | 16:33 | |
| *** yolanda has quit IRC | 16:42 | |
| *** yolanda has joined #openstack-shade | 16:51 | |
| *** yolanda has quit IRC | 17:40 | |
| *** abregman is now known as abregman|afk | 17:59 | |
| *** yolanda has joined #openstack-shade | 18:20 | |
| *** yolanda has quit IRC | 18:23 | |
| *** yolanda has joined #openstack-shade | 18:23 | |
| *** yolanda has quit IRC | 18:34 | |
| *** yolanda has joined #openstack-shade | 18:55 | |
| *** yolanda has quit IRC | 18:59 | |
| *** yolanda has joined #openstack-shade | 19:16 | |
| *** yolanda has quit IRC | 19:32 | |
| *** yolanda has joined #openstack-shade | 19:42 | |
| *** yolanda has quit IRC | 19:54 | |
| mordred | Shrews: https://review.openstack.org/#/c/390144 - responded to your question | 20:18 |
| Shrews | i had a question? | 20:19 |
| Shrews | oh, that was some time ago | 20:20 |
| Shrews | mordred: that makes me sad | 20:20 |
| mordred | Shrews: tell me about it | 20:20 |
| Shrews | mordred: thanks for the explanation | 20:21 |
| Shrews | mordred: i only -1'd it b/c you will never see my question if i didn't :) | 20:22 |
| Shrews | +A'd | 20:22 |
| mordred | Shrews: bah. I read everything you ever say | 20:23 |
| Shrews | riiiiiight | 20:23 |
| *** abregman|afk has quit IRC | 20:40 | |
| openstackgerrit | Julius Roberts proposed openstack-infra/shade: Added documentation for delete_image() https://review.openstack.org/400519 | 20:41 |
| mordred | Shrews: ^^ easy +A btw | 20:43 |
| hoolio | what's +A? | 20:45 |
| mordred | hoolio: "approve" | 20:53 |
| mordred | hoolio: we have a general policy of 2 +2 votes before a patch is approved. the approval vote we sometimes refer to as +A | 20:54 |
| mordred | hoolio: although technically it's Code-Review=+2 and Workflow=+1 - but those aren't as easy to type :) | 20:54 |
| openstackgerrit | Merged openstack-infra/shade: Try to return working IP if we get more than one https://review.openstack.org/390144 | 20:55 |
| clarkb | you'll also see +3 | 20:56 |
| hoolio | k | 20:57 |
| -openstackstatus- NOTICE: Gerrit is offline until 21:30 UTC for scheduled maintenance: http://lists.openstack.org/pipermail/openstack-dev/2016-November/107379.html | 21:10 | |
| *** gouthamr has quit IRC | 21:49 | |
| *** yolanda has joined #openstack-shade | 21:57 | |
| *** yolanda has quit IRC | 22:58 | |
| openstackgerrit | Merged openstack-infra/shade: Added documentation for delete_image() https://review.openstack.org/400519 | 23:12 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!