Thursday, 2016-12-01

« Wednesday, 2016-11-30 Index Friday, 2016-12-02 »
*** cdent has quit IRC00:10
mordredmorgan: how are your eyes?01:54
morganmordred: lol01:54
morgani guess i can still see01:54
mordredmorgan: but do you want to? after the horrors you've witnessed?01:55
morgannot really01:55
mordred:)01:55
* morgan goes back to making TaskContextManager a thing in KSA now that MFA spec is proposed01:56
morganhmm.01:57
morganshould this be a wrap of requests.session?01:57
morgani'm thinking the answer is... yes?01:57
mordredmaybe?01:57
morganor should it be a requests adapter?01:58
morganthat seems incorrect.01:58
mordredI _think_ honestly the ksa.session code can be as simple as01:59
mordredwith self._context_manager(**request_args):\n    self._session.request(**request_args)01:59
mordredand then TaskContextManager just needs to feed that into a submitTask call, no?02:00
morganright.02:05
morganthat is probably fine.02:06
morgani was just wondering if we should make it a wrap of requests.session02:06
morganand i think that is too much mechanical work02:06
morganand makes it *hard* to maintain02:06
*** rcarrillocruz has quit IRC02:12
*** rcarrillocruz has joined #openstack-shade02:16
morganmordred: https://review.openstack.org/#/c/362473/ something like this (missing tests)02:49
morganmordred: i might need to adjust how the context manager works to cover passing **kwargs and the like iun02:56
morganallowing for a pre-instantiated version for the session allowing clear serialization02:56
morganinstead of the instaniate on-demand02:56
*** gouthamr has joined #openstack-shade05:33
*** abregman has joined #openstack-shade07:27
*** cdent has joined #openstack-shade09:17
*** openstack has joined #openstack-shade10:03
*** gouthamr has quit IRC11:35
*** cdent has quit IRC11:35
*** abregman has quit IRC12:53
*** gouthamr has joined #openstack-shade14:17
*** abregman has joined #openstack-shade14:18
*** gouthamr_ has joined #openstack-shade14:22
*** gouthamr has quit IRC14:22
*** abregman has quit IRC14:23
*** abregman has joined #openstack-shade14:23
*** abregman has quit IRC14:25
*** abregman has joined #openstack-shade14:25
*** larainema has quit IRC14:32
*** gouthamr has joined #openstack-shade14:34
*** larainema has joined #openstack-shade14:35
*** gouthamr_ has quit IRC14:36
*** stevemar has joined #openstack-shade15:14
*** stevemar_znc has joined #openstack-shade15:29
*** cdent has joined #openstack-shade15:53
*** larainema has quit IRC15:54
openstackgerritMonty Taylor proposed openstack-infra/shade: Replace Image Create/Delete v2 PUT with REST calls  https://review.openstack.org/38518915:55
*** larainema has joined #openstack-shade15:56
*** abregman has quit IRC16:01
*** stevemar_znc is now known as topol_16:12
*** topol_ is now known as topol16:20
openstackgerritMonty Taylor proposed openstack-infra/shade: Replace Image Create/Delete v2 PUT with REST calls  https://review.openstack.org/38518916:38
openstackgerritMonty Taylor proposed openstack-infra/shade: Move image tasks to REST  https://review.openstack.org/38519016:38
openstackgerritMonty Taylor proposed openstack-infra/shade: Remove a few glance client mocks we missed  https://review.openstack.org/38519116:55
openstackgerritMonty Taylor proposed openstack-infra/shade: Change image update to REST and remove glanceclient  https://review.openstack.org/38519316:55
mordredShrews: ^^ booyah16:55
openstackgerritMonty Taylor proposed openstack-infra/shade: Remove glanceclient and warlock from shade  https://review.openstack.org/38519417:04
openstackgerritMonty Taylor proposed openstack-infra/shade: Remove a few glance client mocks we missed  https://review.openstack.org/38519117:12
openstackgerritMonty Taylor proposed openstack-infra/shade: Update image downloads to use direct REST  https://review.openstack.org/38519217:12
openstackgerritMonty Taylor proposed openstack-infra/shade: Change image update to REST and remove glanceclient  https://review.openstack.org/38519317:12
openstackgerritMonty Taylor proposed openstack-infra/shade: Remove glanceclient and warlock from shade  https://review.openstack.org/38519417:12
mordredok. I think that's all of it - now let's see what jenkins things17:18
mordreds/jenkins things/zuul thinks/17:18
olaphI hate it when jenkins things17:22
stevemarmordred: shade and os-client-config gates are fine? devstack moved to keystone v3 (finally)17:36
mordredstevemar: yup!17:45
mordredstevemar: and congrats!!!17:45
mordredstevemar: we have an explicit v2 test: http://logs.openstack.org/81/385981/4/gate/gate-shade-dsvm-functional-keystone2/46b0a3b/17:46
mordredstevemar: although I think that just tells shade to override what it detects and pretend v3 isn't there17:47
openstackgerritMonty Taylor proposed openstack-infra/shade: Replace Image Create/Delete v2 PUT with REST calls  https://review.openstack.org/38518918:17
*** morgan is now known as morgred18:20
*** morgred is now known as morgan18:21
morganmordred: so, did you take a look at the context manager version of ksa?18:23
morgantask manager18:23
morgani need your feedback as well before i finalize it. i think it needs one more pass honestly to make it not instantiate-on-demand the contextmanager18:23
mordredmorgan: I did! I even commented18:24
morganaha cool18:24
morganwill circle back on it this morning then18:24
mordredmorgan: but I may be smoking crack18:24
morganlol18:24
morganas long as you're sharing... it's all good >.>18:24
mordredbtw - this:18:24
mordredshade.exc.OpenStackCloudHTTPError: (400) Client Error: Bad Request for url: http://10.12.191.73:9292/v2/images18:24
mordredis the worst error18:24
mordredWHAT'S BAD ABOUT THE REQUEST????18:25
mordredthat's ok - I've enabled http_debugging for the next run, so we'll get ALL of the http interactionsin the log :)18:25
morganugh18:26
morgani hate writing functools.partials :P18:26
morganbut it makes a ton of sense btw.18:26
morganthnx for reminding me about it18:26
morganthat should absolutly solve the concern.18:26
morgan*i think*18:27
morganmordred: no. a partial doesn't really solve the issue... if we want to pass instantiated objects18:28
morganmordred: i could just say screw it and not have the pre-run post-run stuff, and have all the logic wedged into the main function18:28
morganthat way we circumvent __enter__ __exit__'s very limited argument passing18:29
morganand don't run into instance-attribute bugs18:29
mordredmorgan: lemme re-read18:29
morganthe issue is we can't pass anything to __enter__, and pre-run pulls method, url, **kwargs fom instance variables in __enter__18:29
morganso you have to use __init__ to pass data that is processed on __enter__18:30
*** abregman has joined #openstack-shade18:30
mordredmorgan: brain can't process - must eat lunch18:34
morganlol go eat lunch18:34
morgani have a fix.18:34
morganit'll just remove some code.18:35
morganand we'll convince stevemar to do a release once this lands ;)18:35
mordredmorgan: stevemar is a friendly fellow18:45
stevemarmordred: lies18:46
*** cdent has quit IRC18:50
*** abregman has quit IRC19:07
SamYaplestevemar: you cant fool me!19:14
stevemarSamYaple: see, you know the truth19:15
*** openstackgerrit has quit IRC19:32
*** openstackgerrit has joined #openstack-shade19:33
*** openstackgerrit has quit IRC19:36
*** openstack has joined #openstack-shade20:43
*** rcarrillocruz has quit IRC21:12
*** rcarrillocruz has joined #openstack-shade21:28
*** abregman has joined #openstack-shade21:38
*** cdent has joined #openstack-shade21:51
*** gouthamr has quit IRC22:17
*** cdent has quit IRC23:03
*** abregman has quit IRC23:03
*** openstackgerrit has joined #openstack-shade23:04
openstackgerritMonty Taylor proposed openstack-infra/shade: Replace Image Create/Delete v2 PUT with REST calls  https://review.openstack.org/38518923:04
openstackgerritMonty Taylor proposed openstack-infra/shade: Pull service_type directly off of the Adapter  https://review.openstack.org/40567423:04
openstackgerritMonty Taylor proposed openstack-infra/shade: Replace Image Create/Delete v2 PUT with REST calls  https://review.openstack.org/38518923:19
morganmordred: need to sync up on REST... APIs ... etc soon23:46
morganmordred: but i'm fooding and beering for a late lunch23:46
morgan(and enjoying the rain)23:46
mordredmorgan: yes!23:51
« Wednesday, 2016-11-30 Index Friday, 2016-12-02 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!