Wednesday, 2017-02-01

openstackgerritMerged openstack/os-client-config: Update reno for stable/ocata  https://review.openstack.org/42745400:06
openstackgerritMerged openstack/os-client-config: fix location of team tags in README  https://review.openstack.org/42745100:06
openstackgerritMonty Taylor proposed openstack-infra/shade: Stop spamming logs with unreachable address message  https://review.openstack.org/42751900:17
mordredShrews: that ^^ _might_ get rid of a bunch of those annoying log messages00:18
*** gouthamr has joined #openstack-shade00:46
mordredjeblair, Shrews: in other news - today I wrote an entire shade feature, complete with unit test and functional tests for a feature I've never seen in a cloud before AND that is not documented - and the functional tests worked the first time00:47
mordredmy favorite part is that it's not documented in the API docs, but it IS implemented in both python-cinderclient and in python-openstackclient00:47
jeblairmordred: i'm happy, but i'm not sure which part of that i'm happy about00:48
mordredjeblair: me either. I'm both happy and sad simultaneous00:48
mordredly00:48
mordredShrews, jeblair: the most reacent patch passed with all green!!!01:09
Shrewsmordred: omg omg omg01:10
Shrewsmordred: can we freeze everything for all eternity now?01:10
stevemarmordred: oh whats not documented but implemented in cinderclient and osc?01:50
stevemarmordred: i've been bugging the cinder team to document their APIs for a few weeks now01:51
stevemarmordred: the only way we could get parity between osc and cinderCLI was by looking at the client and server code01:51
stevemarthey have quite a few undocumented APIs :(01:51
stevemarmordred: refer to my snark here: https://bugs.launchpad.net/cinder/+bug/1562043/comments/1 :)01:52
openstackLaunchpad bug 1562043 in Cinder "[api-ref]API doc reference missing "volume type encryption create"" [Medium,Fix released] - Assigned to wangxiyuan (wangxiyuan)01:52
openstackgerritMerged openstack-infra/shade: Process json based on content-type  https://review.openstack.org/42570601:56
openstackgerritMonty Taylor proposed openstack-infra/shade: Move flavor cache tests to requests_mock  https://review.openstack.org/42732402:57
openstackgerritMonty Taylor proposed openstack-infra/shade: Migrate final flavor tests to requests_mock  https://review.openstack.org/42732502:57
openstackgerritMonty Taylor proposed openstack-infra/shade: Migrate flavor usage in test_create_server to request_mock  https://review.openstack.org/42732602:57
openstackgerritMonty Taylor proposed openstack-infra/shade: Move nova flavor interactions to REST  https://review.openstack.org/42732702:58
openstackgerritMonty Taylor proposed openstack-infra/shade: Remove troveclient from the direct dependency list  https://review.openstack.org/42737702:58
mordredstevemar: https://review.openstack.org/#/c/427338/02:59
mordredstevemar: Create Image from Volume02:59
mordredstevemar: only place to figure out the structure of the return value is by looking in the cinder server tests :)02:59
mordredstevemar: and yeha02:59
dtroyeryeah, I think we implemented that in OSC based directly off cinderclient since we still call the python api03:09
mordreddtroyer: yes you did. (I started with reading your implementation in OSC and then wound my way down the rabbit hole)03:15
SamYaplewin 2404:37
openstackgerritMerged openstack-infra/shade: Use port list to find missing floating ips  https://review.openstack.org/42408704:44
*** gouthamr has quit IRC05:21
*** abregman has joined #openstack-shade06:20
*** yolanda has quit IRC06:23
*** abregman has quit IRC06:53
*** abregman has joined #openstack-shade06:55
*** yfried has joined #openstack-shade07:24
*** yolanda has joined #openstack-shade08:04
*** abregman has quit IRC08:46
*** cdent has joined #openstack-shade10:11
*** yfried has quit IRC10:28
*** yfried has joined #openstack-shade10:31
*** yfried has quit IRC10:38
*** cdent has quit IRC10:48
*** jamielennox is now known as jamielennox|away11:25
*** Matias has quit IRC13:09
*** mordred has quit IRC13:10
*** dct360 has joined #openstack-shade13:15
*** mordred has joined #openstack-shade13:18
*** gouthamr has joined #openstack-shade13:34
*** Matias has joined #openstack-shade13:36
mordredShrews: if you have a sec - https://review.openstack.org/#/c/427519/ will clean up our logs a bit and has another +2 already13:46
*** yfried has joined #openstack-shade13:59
Shrewsmordred: lemme get another cup o' coffee first14:19
Shrewsi suck at reviewing until at least the 2nd cup14:20
mordredShrews: coffee is super important14:25
Shrewsmordred: don't we want to set public=True in get_server_external_ipv6?14:30
Shrewsit calls find_best_address14:31
*** dct360_ has joined #openstack-shade14:32
*** dct360 has quit IRC14:32
Shrewscomment left inline14:33
mordredShrews: public defaults to True14:35
Shrewsmordred: i highly disagree14:35
Shrewsdef find_best_address(addresses, family, public=False):14:35
mordredShrews: oh. you're right14:35
dct360_Hello. shade no longer works for me. Has anyone seen this issue? If not, i'll submit a bug report. >>> from shade import * >>> cloud = openstack_cloud() >>> images = cloud.list_images() Traceback (most recent call last):14:37
openstackgerritMonty Taylor proposed openstack-infra/shade: Stop spamming logs with unreachable address message  https://review.openstack.org/42751914:37
dct360_  File "<stdin>", line 1, in <module>   File "/apps/shade-test/.venv/lib/python2.7/site-packages/shade/openstackcloud.py", line 1790, in list_images     response = self._image_client.get(endpoint)   File "/apps/shade-test/.venv/lib/python2.7/site-packages/shade/openstackcloud.py", line 402, in _image_client     image_client = self._get_raw_client('image')   File "/apps/shade-test/.venv/lib/python2.7/site-packages/shade/openst14:38
mordredShrews: there you go14:38
mordreddct360_: could you try pasting your traceback in to paste.openstack.org and then giving us a link?14:38
dct360_sure14:38
Shrewsmordred: also, there are calls to get_server_ip from openstackcloud.py that need modifying now i think14:39
dct360_http://paste.openstack.org/show/597195/14:40
mordredShrews: jeez - we still call it from there? you're right - lemme take another pass at this one14:40
mordreddct360_: and it worked previously with the same clouds.yaml ?14:41
dct360_yes14:41
mordredhrm14:41
Shrewsmordred: i -1'd it with a comment just so i'd remember what was the issue14:42
dct360_this still works - $ python -m os_client_config.config14:42
mordreddct360_: can you do [cloud.name for cloud in os_client_config.OpenStackConfig().get_all_clouds()]14:43
mordredand show that to me?14:43
dct360_>>> [cloud.name for cloud in os_client_config.OpenStackConfig().get_all_clouds()] ['testing']14:47
mordreddct360_: k. I expect that to work. can you try openstack_cloud(cloud='testing') ; images = cloud.list_images() and see if that works? if it does, I can go digging to see why returning a single cloud isn't working right14:48
mordred(and also just to verify - cloud = openstack_cloud() ; cloud.name  ... I believe you'll see cloud.name as '' when we should see it as 'testing' in your setup)14:49
dct360_>>> openstack_cloud(cloud='testing')14:53
dct360_<shade.openstackcloud.OpenStackCloud object at 0x7f37b7ac1750>14:53
dct360_>>> images = cloud.list_images()14:54
dct360_Traceback (most recent call last):14:54
mordred(you didn't do cloud=openstack_cloud in your first line - so you're still making that call on your old instance)14:54
dct360_Traceback (most recent call last):14:54
dct360_TypeError: 'NoneType' object is not callable14:54
dct360_ok let me get that14:55
dct360_ok i tried cloud=openstack_cloud in your first line and got TypeError: 'NoneType' object is not callable14:59
mordredhrm. just to be sure ... (communication in irc can suck) - run this: http://paste.openstack.org/show/597198/ ?15:02
dct360_thanks mordred http://paste.openstack.org/show/597199/15:05
yfriedmordred: hi, good morning15:07
yfriedmordred: saw port list merged15:07
mordreddct360_: excellent. so for now you should be able to do cloud='testing' as an argument to openstack_cloud - OR you can set the environment variable OS_CLOUD='testing' - and I'll look in to why the behavior changed and see if I can figure that part out15:08
mordredyfried: yes! I'm just about to cut a release15:08
openstackgerritMonty Taylor proposed openstack-infra/shade: Stop spamming logs with unreachable address message  https://review.openstack.org/42751915:08
openstackgerritMonty Taylor proposed openstack-infra/shade: Honor cloud.private in the check for public connectivity  https://review.openstack.org/42775515:08
mordredShrews: fixed up the first patch, added a second to handle the case where someone set the cloud to prefer private addresses15:08
dct360_Thanks again Monty!15:08
mordreddct360_: sure thing! thanks for letting us know15:09
mordredyfried: is it easy for you to verify that the current tip of master still works for you? (I'd hate it if somewhere in the process we accidentally re-broke it)15:09
yfriedmordred: sorry. not atm15:10
mordredok. I'll just trust our original testing :)15:10
yfriedmordred: I've verified the original patch with a targeted test15:10
mordredif it doesn't work, I'll allow you to shoot me15:10
yfriedmordred: when will I see this in pypi?15:10
mordredin about 10 minutes15:10
yfriedmordred: w00t15:10
*** sigmavirus has quit IRC15:14
*** yfried has quit IRC16:04
*** yfried has joined #openstack-shade16:04
*** yfried has quit IRC16:22
*** yolanda has quit IRC17:01
openstackgerritMonty Taylor proposed openstack-infra/shade: Support globbing in name or id checks  https://review.openstack.org/42781617:12
*** yolanda has joined #openstack-shade18:39
*** cdent has joined #openstack-shade19:47
*** cdent has quit IRC19:55
*** gouthamr has quit IRC20:03
*** jamielennox|away is now known as jamielennox20:30
*** yfried has joined #openstack-shade20:49
*** gouthamr has joined #openstack-shade21:02
*** yfried has quit IRC21:37
*** gouthamr has quit IRC22:07
*** gouthamr has joined #openstack-shade22:33
*** dct360_ has quit IRC23:16

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!