openstackgerrit | Merged openstack/os-client-config: Update reno for stable/ocata https://review.openstack.org/427454 | 00:06 |
---|---|---|
openstackgerrit | Merged openstack/os-client-config: fix location of team tags in README https://review.openstack.org/427451 | 00:06 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Stop spamming logs with unreachable address message https://review.openstack.org/427519 | 00:17 |
mordred | Shrews: that ^^ _might_ get rid of a bunch of those annoying log messages | 00:18 |
*** gouthamr has joined #openstack-shade | 00:46 | |
mordred | jeblair, Shrews: in other news - today I wrote an entire shade feature, complete with unit test and functional tests for a feature I've never seen in a cloud before AND that is not documented - and the functional tests worked the first time | 00:47 |
mordred | my favorite part is that it's not documented in the API docs, but it IS implemented in both python-cinderclient and in python-openstackclient | 00:47 |
jeblair | mordred: i'm happy, but i'm not sure which part of that i'm happy about | 00:48 |
mordred | jeblair: me either. I'm both happy and sad simultaneous | 00:48 |
mordred | ly | 00:48 |
mordred | Shrews, jeblair: the most reacent patch passed with all green!!! | 01:09 |
Shrews | mordred: omg omg omg | 01:10 |
Shrews | mordred: can we freeze everything for all eternity now? | 01:10 |
stevemar | mordred: oh whats not documented but implemented in cinderclient and osc? | 01:50 |
stevemar | mordred: i've been bugging the cinder team to document their APIs for a few weeks now | 01:51 |
stevemar | mordred: the only way we could get parity between osc and cinderCLI was by looking at the client and server code | 01:51 |
stevemar | they have quite a few undocumented APIs :( | 01:51 |
stevemar | mordred: refer to my snark here: https://bugs.launchpad.net/cinder/+bug/1562043/comments/1 :) | 01:52 |
openstack | Launchpad bug 1562043 in Cinder "[api-ref]API doc reference missing "volume type encryption create"" [Medium,Fix released] - Assigned to wangxiyuan (wangxiyuan) | 01:52 |
openstackgerrit | Merged openstack-infra/shade: Process json based on content-type https://review.openstack.org/425706 | 01:56 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Move flavor cache tests to requests_mock https://review.openstack.org/427324 | 02:57 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Migrate final flavor tests to requests_mock https://review.openstack.org/427325 | 02:57 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Migrate flavor usage in test_create_server to request_mock https://review.openstack.org/427326 | 02:57 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Move nova flavor interactions to REST https://review.openstack.org/427327 | 02:58 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Remove troveclient from the direct dependency list https://review.openstack.org/427377 | 02:58 |
mordred | stevemar: https://review.openstack.org/#/c/427338/ | 02:59 |
mordred | stevemar: Create Image from Volume | 02:59 |
mordred | stevemar: only place to figure out the structure of the return value is by looking in the cinder server tests :) | 02:59 |
mordred | stevemar: and yeha | 02:59 |
dtroyer | yeah, I think we implemented that in OSC based directly off cinderclient since we still call the python api | 03:09 |
mordred | dtroyer: yes you did. (I started with reading your implementation in OSC and then wound my way down the rabbit hole) | 03:15 |
SamYaple | win 24 | 04:37 |
openstackgerrit | Merged openstack-infra/shade: Use port list to find missing floating ips https://review.openstack.org/424087 | 04:44 |
*** gouthamr has quit IRC | 05:21 | |
*** abregman has joined #openstack-shade | 06:20 | |
*** yolanda has quit IRC | 06:23 | |
*** abregman has quit IRC | 06:53 | |
*** abregman has joined #openstack-shade | 06:55 | |
*** yfried has joined #openstack-shade | 07:24 | |
*** yolanda has joined #openstack-shade | 08:04 | |
*** abregman has quit IRC | 08:46 | |
*** cdent has joined #openstack-shade | 10:11 | |
*** yfried has quit IRC | 10:28 | |
*** yfried has joined #openstack-shade | 10:31 | |
*** yfried has quit IRC | 10:38 | |
*** cdent has quit IRC | 10:48 | |
*** jamielennox is now known as jamielennox|away | 11:25 | |
*** Matias has quit IRC | 13:09 | |
*** mordred has quit IRC | 13:10 | |
*** dct360 has joined #openstack-shade | 13:15 | |
*** mordred has joined #openstack-shade | 13:18 | |
*** gouthamr has joined #openstack-shade | 13:34 | |
*** Matias has joined #openstack-shade | 13:36 | |
mordred | Shrews: if you have a sec - https://review.openstack.org/#/c/427519/ will clean up our logs a bit and has another +2 already | 13:46 |
*** yfried has joined #openstack-shade | 13:59 | |
Shrews | mordred: lemme get another cup o' coffee first | 14:19 |
Shrews | i suck at reviewing until at least the 2nd cup | 14:20 |
mordred | Shrews: coffee is super important | 14:25 |
Shrews | mordred: don't we want to set public=True in get_server_external_ipv6? | 14:30 |
Shrews | it calls find_best_address | 14:31 |
*** dct360_ has joined #openstack-shade | 14:32 | |
*** dct360 has quit IRC | 14:32 | |
Shrews | comment left inline | 14:33 |
mordred | Shrews: public defaults to True | 14:35 |
Shrews | mordred: i highly disagree | 14:35 |
Shrews | def find_best_address(addresses, family, public=False): | 14:35 |
mordred | Shrews: oh. you're right | 14:35 |
dct360_ | Hello. shade no longer works for me. Has anyone seen this issue? If not, i'll submit a bug report. >>> from shade import * >>> cloud = openstack_cloud() >>> images = cloud.list_images() Traceback (most recent call last): | 14:37 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Stop spamming logs with unreachable address message https://review.openstack.org/427519 | 14:37 |
dct360_ | File "<stdin>", line 1, in <module> File "/apps/shade-test/.venv/lib/python2.7/site-packages/shade/openstackcloud.py", line 1790, in list_images response = self._image_client.get(endpoint) File "/apps/shade-test/.venv/lib/python2.7/site-packages/shade/openstackcloud.py", line 402, in _image_client image_client = self._get_raw_client('image') File "/apps/shade-test/.venv/lib/python2.7/site-packages/shade/openst | 14:38 |
mordred | Shrews: there you go | 14:38 |
mordred | dct360_: could you try pasting your traceback in to paste.openstack.org and then giving us a link? | 14:38 |
dct360_ | sure | 14:38 |
Shrews | mordred: also, there are calls to get_server_ip from openstackcloud.py that need modifying now i think | 14:39 |
dct360_ | http://paste.openstack.org/show/597195/ | 14:40 |
mordred | Shrews: jeez - we still call it from there? you're right - lemme take another pass at this one | 14:40 |
mordred | dct360_: and it worked previously with the same clouds.yaml ? | 14:41 |
dct360_ | yes | 14:41 |
mordred | hrm | 14:41 |
Shrews | mordred: i -1'd it with a comment just so i'd remember what was the issue | 14:42 |
dct360_ | this still works - $ python -m os_client_config.config | 14:42 |
mordred | dct360_: can you do [cloud.name for cloud in os_client_config.OpenStackConfig().get_all_clouds()] | 14:43 |
mordred | and show that to me? | 14:43 |
dct360_ | >>> [cloud.name for cloud in os_client_config.OpenStackConfig().get_all_clouds()] ['testing'] | 14:47 |
mordred | dct360_: k. I expect that to work. can you try openstack_cloud(cloud='testing') ; images = cloud.list_images() and see if that works? if it does, I can go digging to see why returning a single cloud isn't working right | 14:48 |
mordred | (and also just to verify - cloud = openstack_cloud() ; cloud.name ... I believe you'll see cloud.name as '' when we should see it as 'testing' in your setup) | 14:49 |
dct360_ | >>> openstack_cloud(cloud='testing') | 14:53 |
dct360_ | <shade.openstackcloud.OpenStackCloud object at 0x7f37b7ac1750> | 14:53 |
dct360_ | >>> images = cloud.list_images() | 14:54 |
dct360_ | Traceback (most recent call last): | 14:54 |
mordred | (you didn't do cloud=openstack_cloud in your first line - so you're still making that call on your old instance) | 14:54 |
dct360_ | Traceback (most recent call last): | 14:54 |
dct360_ | TypeError: 'NoneType' object is not callable | 14:54 |
dct360_ | ok let me get that | 14:55 |
dct360_ | ok i tried cloud=openstack_cloud in your first line and got TypeError: 'NoneType' object is not callable | 14:59 |
mordred | hrm. just to be sure ... (communication in irc can suck) - run this: http://paste.openstack.org/show/597198/ ? | 15:02 |
dct360_ | thanks mordred http://paste.openstack.org/show/597199/ | 15:05 |
yfried | mordred: hi, good morning | 15:07 |
yfried | mordred: saw port list merged | 15:07 |
mordred | dct360_: excellent. so for now you should be able to do cloud='testing' as an argument to openstack_cloud - OR you can set the environment variable OS_CLOUD='testing' - and I'll look in to why the behavior changed and see if I can figure that part out | 15:08 |
mordred | yfried: yes! I'm just about to cut a release | 15:08 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Stop spamming logs with unreachable address message https://review.openstack.org/427519 | 15:08 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Honor cloud.private in the check for public connectivity https://review.openstack.org/427755 | 15:08 |
mordred | Shrews: fixed up the first patch, added a second to handle the case where someone set the cloud to prefer private addresses | 15:08 |
dct360_ | Thanks again Monty! | 15:08 |
mordred | dct360_: sure thing! thanks for letting us know | 15:09 |
mordred | yfried: is it easy for you to verify that the current tip of master still works for you? (I'd hate it if somewhere in the process we accidentally re-broke it) | 15:09 |
yfried | mordred: sorry. not atm | 15:10 |
mordred | ok. I'll just trust our original testing :) | 15:10 |
yfried | mordred: I've verified the original patch with a targeted test | 15:10 |
mordred | if it doesn't work, I'll allow you to shoot me | 15:10 |
yfried | mordred: when will I see this in pypi? | 15:10 |
mordred | in about 10 minutes | 15:10 |
yfried | mordred: w00t | 15:10 |
*** sigmavirus has quit IRC | 15:14 | |
*** yfried has quit IRC | 16:04 | |
*** yfried has joined #openstack-shade | 16:04 | |
*** yfried has quit IRC | 16:22 | |
*** yolanda has quit IRC | 17:01 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade: Support globbing in name or id checks https://review.openstack.org/427816 | 17:12 |
*** yolanda has joined #openstack-shade | 18:39 | |
*** cdent has joined #openstack-shade | 19:47 | |
*** cdent has quit IRC | 19:55 | |
*** gouthamr has quit IRC | 20:03 | |
*** jamielennox|away is now known as jamielennox | 20:30 | |
*** yfried has joined #openstack-shade | 20:49 | |
*** gouthamr has joined #openstack-shade | 21:02 | |
*** yfried has quit IRC | 21:37 | |
*** gouthamr has quit IRC | 22:07 | |
*** gouthamr has joined #openstack-shade | 22:33 | |
*** dct360_ has quit IRC | 23:16 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!