| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: DNM - Patch to verify 2.0 usage payload behavior https://review.openstack.org/434482 | 00:00 |
|---|---|---|
| *** gouthamr has joined #openstack-shade | 00:39 | |
| *** jamielennox is now known as jamielennox|away | 01:18 | |
| *** jamielennox|away is now known as jamielennox | 01:25 | |
| *** dct360 has quit IRC | 03:18 | |
| *** deepbook5broo has joined #openstack-shade | 04:19 | |
| *** deepbook5broo has left #openstack-shade | 04:19 | |
| *** gouthamr has quit IRC | 04:38 | |
| morgan | mordred: oh man... complete_qs doesn't do exactly what I expected | 04:41 |
| morgan | mordred: this is a bigger issue with just plain query_string matching not even complete_qs | 04:41 |
| morgan | mordred: oh found the issue | 04:50 |
| morgan | sigh | 04:50 |
| morgan | i can fix it. | 04:51 |
| morgan | it is a bug in register_uris... but also because i was assuming order didn't matter... and it doesn't... somewhat | 04:51 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade master: Require `complete_qs` if a query_string is in the mocked uri https://review.openstack.org/435127 | 05:05 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade master: Convert use of .register_uri to .register_uris https://review.openstack.org/434516 | 05:05 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade master: Convert test_object to use .register_uris https://review.openstack.org/434532 | 05:05 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade master: Convert test_object to use .register_uris https://review.openstack.org/434532 | 05:06 |
| morgan | mordred: ^ should fix all of our issues | 05:06 |
| morgan | wrt .register_uris | 05:06 |
| morgan | jamielennox: i made some assumptions about order that were incorrect | 05:06 |
| jamielennox | morgan: order of what? | 05:07 |
| morgan | jamielennox: the order we register the uris in | 05:08 |
| jamielennox | oh, you override the same url | 05:08 |
| jamielennox | try not to :) | 05:08 |
| morgan | in the case of something like images?next=<blah> | 05:08 |
| morgan | i don't have a choice | 05:08 |
| morgan | unless i want to rip the qs off the uri before passing it to register_uri because of the tracking we do to bundle things into a response_list | 05:09 |
| morgan | instead of overriding things a ton | 05:09 |
| jamielennox | oh, i see - tricky | 05:10 |
| morgan | yeah | 05:10 |
| jamielennox | i mean you can always do a callback and do responses that way | 05:10 |
| morgan | we don't do it except in the case of query_strings | 05:10 |
| morgan | now | 05:10 |
| morgan | jamielennox: i don't feel like the callback is warranted here in shade | 05:11 |
| jamielennox | morgan: yea, i try not to use them if possible | 05:11 |
| jamielennox | morgan: so is there something that needs fixing in requests-mock/ | 05:12 |
| morgan | jamielennox: it is a lot more moving bits. i already eliminated 90% of the URI duplicates | 05:12 |
| morgan | there is something that could be more explicit | 05:12 |
| morgan | like complete_qs is not super explicit | 05:12 |
| morgan | and not intuative | 05:13 |
| morgan | i'd like to add an "ignore_qs" option as well | 05:13 |
| morgan | that is mutually exclusive to complete_qs | 05:13 |
| morgan | so we can say doesn't matter if I mock with a QS or not | 05:14 |
| morgan | because we might be mirroring some real-responses/requests but not care qs wise | 05:14 |
| morgan | it's not a big deal | 05:14 |
| morgan | the QS-case sensitivity is... also not really na issue here | 05:14 |
| morgan | so, meh we're all good | 05:14 |
| jamielennox | what do you mean ignore_qs? | 05:15 |
| jamielennox | complete_qs means match the entire qs | 05:15 |
| jamielennox | ignore would just seem to be the oposite | 05:15 |
| jamielennox | and complete_qs should be false by default | 05:15 |
| morgan | yes i would like the opposite ability | 05:17 |
| morgan | or... actually | 05:17 |
| morgan | take that back | 05:17 |
| morgan | i would like to explicitly be able to pass a QS into .register_uri vs it being part of the uri... or store it as part of the response list somehow | 05:18 |
| morgan | none of this is super important | 05:18 |
| * morgan goes back to... not digging into the depths of request_mock | 05:19 | |
| jamielennox | :) | 05:19 |
| jamielennox | i was thinking i'd like some way of overriding the mocker or something to let people set their own values for this sort of thing | 05:20 |
| jamielennox | but i don't know who cares | 05:20 |
| morgan | i do... but i'm kindof an edge case | 05:21 |
| morgan | yanno | 05:21 |
| morgan | :P | 05:21 |
| jamielennox | morgan: if you have an idea of how let me know | 05:24 |
| jamielennox | if it doesn't mess with the core i don't have an objection | 05:24 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade master: Convert test_object to use .register_uris https://review.openstack.org/434532 | 05:44 |
| *** jordanP has joined #openstack-shade | 08:49 | |
| *** cdent has joined #openstack-shade | 09:50 | |
| *** yolanda has quit IRC | 11:36 | |
| *** yolanda has joined #openstack-shade | 11:39 | |
| *** abregman has joined #openstack-shade | 13:59 | |
| *** gouthamr has joined #openstack-shade | 14:01 | |
| *** abregman has quit IRC | 14:05 | |
| *** dct360 has joined #openstack-shade | 15:17 | |
| openstackgerrit | Merged openstack-infra/shade master: Convert use of .register_uri to .register_uris https://review.openstack.org/434516 | 15:17 |
| openstackgerrit | Merged openstack-infra/shade master: Convert test_object to use .register_uris https://review.openstack.org/434532 | 15:21 |
| mordred | Shrews, rcarrillocruz: this old PR is ready to land: https://github.com/ansible/ansible/pull/18648 - we released a new occ with the needed patch ages ago | 16:45 |
| Shrews | mordred: i'm not certain if that's considered part of ansible core or not so i'm hesitant to merge it (see https://groups.google.com/forum/#!topic/ansible-devel/S3DAPlqMIk0) | 16:51 |
| mordred | hrm. lemme go ask folks- it's also a bug fix rather than a feature ... | 16:55 |
| rcarrillocruz | Ah, thought it was your mega change switching constructor | 16:58 |
| rcarrillocruz | Lgtm | 16:58 |
| rcarrillocruz | I think is simple enough and is a bugfix, thus we could merge | 17:00 |
| *** jordanP has quit IRC | 17:07 | |
| mordred | bcoca has merged for us | 17:09 |
| mordred | rcarrillocruz: also - I think https://github.com/ansible/ansible/pull/21540 is safe - the CI failure is not related | 17:12 |
| mordred | the cloud constructor one is definitely a post-release sort of thing | 17:12 |
| *** cdent has quit IRC | 17:47 | |
| morgan | mordred: ok i'm packing and travelling | 17:52 |
| morgan | mordred: see you next week | 17:53 |
| mordred | morgan: see you then! | 17:59 |
| -openstackstatus- NOTICE: Restarting gerrit due to performance problems | 19:04 | |
| rcarrillocruz | mordred: merged | 20:49 |
| *** gouthamr has quit IRC | 22:11 | |
| *** dct360 has quit IRC | 22:28 | |
| *** gouthamr has joined #openstack-shade | 22:34 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!