notmorgan | this one is particularly slow because the responses are fairly complex | 00:00 |
---|---|---|
notmorgan | it's going to be another absolutely beastly patch =/ | 00:00 |
notmorgan | but on the plus side it means all mocks of keystone_client will be gone | 00:00 |
notmorgan | and we can start going with pure rest | 00:01 |
mordred | notmorgan: yay! | 00:04 |
mordred | notmorgan: happily, the restification patches should be much smaller and easier | 00:04 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Get rid of magnumclient dependency https://review.openstack.org/447578 | 00:09 |
mordred | it helps when you delete all of the lines ... | 00:09 |
notmorgan | mordred: https://review.openstack.org/#/c/439119/ going to push that through unless you think someone is going to complain | 00:10 |
notmorgan | it's been sitting for quite a while | 00:10 |
mordred | notmorgan: do it | 00:21 |
openstackgerrit | Merged openstack/os-client-config master: Add support for bailing on invalid service versions https://review.openstack.org/439119 | 01:22 |
*** gouthamr has joined #openstack-shade | 01:32 | |
*** gouthamr has quit IRC | 02:45 | |
*** gouthamr has joined #openstack-shade | 04:25 | |
*** gouthamr has quit IRC | 05:02 | |
*** yfried has joined #openstack-shade | 09:39 | |
*** cdent has joined #openstack-shade | 09:43 | |
openstackgerrit | Merged openstack-infra/shade master: attach_volume should always return a vol attachment. https://review.openstack.org/434964 | 11:45 |
openstackgerrit | Merged openstack-infra/shade master: delete_server: make sure we sleep a bit when waiting for server deletion https://review.openstack.org/448215 | 11:45 |
openstackgerrit | Merged openstack-infra/shade master: wait_for_server: ensure we sleep a bit when waiting for server https://review.openstack.org/448220 | 11:45 |
*** gouthamr has joined #openstack-shade | 13:21 | |
*** yfried has quit IRC | 13:30 | |
openstackgerrit | Merged openstack-infra/shade master: Cleanup some workarounds for old OCC versions https://review.openstack.org/447542 | 15:16 |
openstackgerrit | Merged openstack-infra/shade master: Get the ball rolling on magnumclient https://review.openstack.org/447543 | 15:21 |
openstackgerrit | Merged openstack-infra/shade master: Add normalization for cluster templates https://review.openstack.org/447544 | 15:22 |
openstackgerrit | Merged openstack-infra/shade master: RESTify cluster template tests https://review.openstack.org/447545 | 15:22 |
openstackgerrit | Merged openstack-infra/shade master: Convert magnum service to requests_mock https://review.openstack.org/447546 | 15:26 |
openstackgerrit | Merged openstack-infra/shade master: Get rid of magnumclient dependency https://review.openstack.org/447578 | 15:27 |
openstackgerrit | Merged openstack-infra/shade master: Use data when the request has a non-json content type https://review.openstack.org/447581 | 15:29 |
*** cdent has quit IRC | 17:27 | |
*** cdent has joined #openstack-shade | 17:29 | |
*** yfried has joined #openstack-shade | 19:57 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Accept device_id for update_port https://review.openstack.org/448781 | 20:38 |
mordred | Shrews, clarkb: if you have a sec, could you rubberstamp that ^^ ? it's a simple bugfix for an upstream ansible bug | 20:42 |
mordred | I lifted it from a gh pr - but since it's a one-word change I am not worried about proper attribution/cla | 20:42 |
clarkb | mordred: would it be terrible to update the docstring too? | 20:42 |
clarkb | looks like the other valid kwargs have docstring entries | 20:43 |
mordred | clarkb: nope - can do real quick | 20:43 |
clarkb | cool thanks | 20:43 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Accept device_id for update_port https://review.openstack.org/448781 | 20:43 |
mordred | wow. I knew the docstring answer without referring to upstream docs. that's scary | 20:44 |
notmorgan | mordred: thats... | 21:04 |
*** gouthamr has quit IRC | 21:26 | |
*** yfried has quit IRC | 21:35 | |
*** yfried has joined #openstack-shade | 21:36 | |
*** cdent has quit IRC | 21:54 | |
mordred | notmorgan: ikr? | 22:13 |
*** yfried has quit IRC | 22:32 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!