| *** jamielennox is now known as jamielennox|away | 01:39 | |
| *** jamielennox|away is now known as jamielennox | 01:48 | |
| *** ioggstream has joined #openstack-shade | 01:51 | |
| *** ioggstream has quit IRC | 02:26 | |
| *** larainema has quit IRC | 02:32 | |
| *** Matias has quit IRC | 03:44 | |
| *** Matias has joined #openstack-shade | 03:45 | |
| *** yfried has joined #openstack-shade | 06:10 | |
| *** yfried has quit IRC | 06:24 | |
| *** gouthamr has joined #openstack-shade | 06:44 | |
| *** gouthamr has quit IRC | 07:12 | |
| *** ioggstream has joined #openstack-shade | 08:49 | |
| *** yfried has joined #openstack-shade | 09:44 | |
| *** yfried has quit IRC | 09:48 | |
| *** cdent has joined #openstack-shade | 10:52 | |
| *** Matias has quit IRC | 11:27 | |
| *** Matias has joined #openstack-shade | 11:39 | |
| mordred | notmorgan, jamielennox: could one or both of you take a look at the email to the dev list with the subject "[openstack-dev] [os-client-config] get_session_endpoint() and Keystone admin endpoint" | 11:58 |
|---|---|---|
| mordred | I _think_ looking at the code that y'all have cleaned up the ksc code at this point and the "if identity ignore interface" workaround can go away. or? | 11:59 |
| *** Matias has quit IRC | 12:00 | |
| *** Matias has joined #openstack-shade | 12:01 | |
| *** ioggstream has quit IRC | 12:59 | |
| *** cdent has quit IRC | 13:02 | |
| *** gouthamr has joined #openstack-shade | 13:08 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Fix old-style mocking of nova_client https://review.openstack.org/449645 | 14:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Migrate server console tests to requests_mock https://review.openstack.org/449646 | 14:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Migrate get_server_console to REST https://review.openstack.org/449647 | 14:23 |
| mordred | Shrews: ^^ the first patch there is the bad version of mocking I mentioned earlier | 14:24 |
| Shrews | mordred: so, using @mock.patch.object persists across all tests? | 14:25 |
| Shrews | oh, no | 14:26 |
| Shrews | the with patch() does | 14:26 |
| mordred | Shrews: it's actually the nova_client = Mock( thing | 14:27 |
| Shrews | wait... why the "with patch()" with the "nova_client = Mock()"? | 14:27 |
| Shrews | that's... weird | 14:27 |
| mordred | the with patch() also _would_ be fine - but the direct assignment borks | 14:27 |
| mordred | Shrews: yuah | 14:27 |
| mordred | I mean - it's just a thing we shouldn't have anyway | 14:27 |
| Shrews | yeah | 14:27 |
| mordred | that is all of the instances of that pattern that I can see though, so that's good | 14:28 |
| *** cdent has joined #openstack-shade | 14:57 | |
| *** gouthamr has quit IRC | 16:23 | |
| *** gouthamr has joined #openstack-shade | 16:33 | |
| *** gouthamr has quit IRC | 17:01 | |
| *** gouthamr has joined #openstack-shade | 17:05 | |
| *** cdent has quit IRC | 18:15 | |
| *** gouthamr has quit IRC | 20:23 | |
| *** yolanda has quit IRC | 20:54 | |
| *** yolanda has joined #openstack-shade | 20:56 | |
| *** yolanda has quit IRC | 21:04 | |
| *** yolanda has joined #openstack-shade | 21:05 | |
| *** yolanda has quit IRC | 21:17 | |
| *** yolanda has joined #openstack-shade | 21:19 | |
| *** yolanda has quit IRC | 21:26 | |
| *** yolanda has joined #openstack-shade | 21:32 | |
| *** yolanda has quit IRC | 21:39 | |
| *** yolanda has joined #openstack-shade | 21:39 | |
| *** yolanda has quit IRC | 23:17 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!