openstackgerrit | Merged openstack-infra/shade master: Add bare parameter to get/list/search server https://review.openstack.org/451264 | 00:13 |
---|---|---|
pabelanger | mordred: yes, I'd like to poke at it, but I also don't want to be a blocker | 01:32 |
*** gouthamr has quit IRC | 03:55 | |
*** ianw has quit IRC | 04:43 | |
*** ianw has joined #openstack-shade | 04:43 | |
*** dhellmann has quit IRC | 05:13 | |
*** pabelanger has quit IRC | 05:14 | |
*** dhellmann has joined #openstack-shade | 05:16 | |
*** pabelanger has joined #openstack-shade | 05:20 | |
*** yfried has joined #openstack-shade | 06:23 | |
openstackgerrit | Merged openstack-infra/shade master: Change metadata to align with team affiliation https://review.openstack.org/450981 | 06:38 |
*** openstackgerrit has quit IRC | 08:03 | |
*** ioggstream has joined #openstack-shade | 08:32 | |
*** iogg has joined #openstack-shade | 09:26 | |
*** ioggstream has quit IRC | 09:26 | |
*** iogg has quit IRC | 11:28 | |
*** yfried has quit IRC | 11:33 | |
*** gouthamr has joined #openstack-shade | 13:01 | |
*** iogg has joined #openstack-shade | 13:05 | |
*** openstackgerrit has joined #openstack-shade | 14:03 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/451835 | 14:03 |
openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/requestsexceptions master: Updated from global requirements https://review.openstack.org/451836 | 14:03 |
openstackgerrit | Merged openstack-infra/requestsexceptions master: Update tox for OpenStack https://review.openstack.org/451306 | 14:12 |
openstackgerrit | Merged openstack-infra/requestsexceptions master: Remove runtime depend on pbr https://review.openstack.org/451307 | 14:13 |
openstackgerrit | Merged openstack-infra/shade master: Fix a few minor annoyances that snuck in https://review.openstack.org/451276 | 15:22 |
openstackgerrit | Merged openstack-infra/shade master: Enable H238 - classes should be subclasses of object https://review.openstack.org/451277 | 15:22 |
openstackgerrit | Merged openstack-infra/shade master: Enable H201 - don't throw bare exceptions https://review.openstack.org/451278 | 15:23 |
openstackgerrit | Merged openstack-infra/shade master: Reenable hacking tests that already pass https://review.openstack.org/451279 | 15:26 |
openstackgerrit | Merged openstack-infra/shade master: Take care of multiple imports and update explanation https://review.openstack.org/451280 | 15:26 |
openstackgerrit | Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/451835 | 15:26 |
notmorgan | TheJulia: have I mentioned how much I dislike microversions | 15:27 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Do not install test-requirements for ansible test https://review.openstack.org/450803 | 15:35 |
TheJulia | notmorgan: not recently :) | 16:31 |
notmorgan | :) | 16:51 |
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted briefly to relieve performance issues, and should return to service again momentarily. | 17:04 | |
*** iogg has quit IRC | 17:29 | |
*** TheJulia_ has joined #openstack-shade | 17:56 | |
*** SamYaple_ has joined #openstack-shade | 17:57 | |
*** TheJulia has quit IRC | 17:59 | |
*** clarkb has quit IRC | 17:59 | |
*** jlk has quit IRC | 17:59 | |
*** mordred has quit IRC | 17:59 | |
*** SamYaple has quit IRC | 17:59 | |
*** jlk has joined #openstack-shade | 18:00 | |
*** jlk has joined #openstack-shade | 18:00 | |
*** clarkb has joined #openstack-shade | 18:01 | |
notmorgan | oooh netsplit? | 18:01 |
*** mordred has joined #openstack-shade | 18:02 | |
*** SamYaple_ has quit IRC | 18:03 | |
*** SamYaple has joined #openstack-shade | 18:03 | |
openstackgerrit | Merged openstack-infra/shade master: Update tox build settings https://review.openstack.org/451312 | 18:05 |
clarkb | notmorgan: certainly appears so | 18:08 |
notmorgan | mininetsplit it appears | 18:09 |
notmorgan | anyway | 18:09 |
*** TheJulia_ is now known as TheJulia | 18:56 | |
*** yolanda has quit IRC | 19:47 | |
mordred | notmorgan: oh - I actually don't dislike microversions anymore | 21:00 |
mordred | notmorgan: I used to - but I grok them differently now - and I think in new rest-based shade they'll actually be pleasant | 21:00 |
mordred | TheJulia, notmorgan: I think of the big yucks with them is actually that with the python libs the microversion essentially gets negotiated at the Client constructor time, which is the wrong level of granularity | 21:02 |
mordred | but - the way they're implemented is actually to allow specific version PER CALL - which is where I think they're going to be really nice for shade | 21:02 |
mordred | because for any given call, it's most frequently the case that the call in question has one and only one microversion that matters for it - then for some calls, there may be 2 or maybe even 3 different microversions affecting its behavior | 21:03 |
mordred | but we already have that sort of branching logic in shade | 21:03 |
mordred | so I _think_ (but have not yet proven) that we're actually going to like them in practice | 21:03 |
TheJulia | mordred: I've been thinking the exact same thing | 21:18 |
openstackgerrit | Jamie Lennox proposed openstack-infra/shade master: Add server security groups to shade https://review.openstack.org/451183 | 22:24 |
*** gouthamr has quit IRC | 22:30 | |
mordred | jamielennox: thanks - that looks great! Shrews, clarkb either of you want to take a peek? ^^ (jamie is adding this to be able to add it to the ansible modules) | 22:31 |
clarkb | currently watching rockets fly into space | 22:31 |
clarkb | beacuse space | 22:31 |
mordred | clarkb: yah. good call | 22:32 |
mordred | clarkb: it would have been neat if the video feed hadn't gone out | 22:37 |
clarkb | ya | 22:38 |
clarkb | usually they get video out the next day or two | 22:38 |
clarkb | ok space things happened successfully I can review code now | 22:42 |
*** jlk has quit IRC | 22:43 | |
*** jlk has joined #openstack-shade | 22:44 | |
*** jlk has quit IRC | 22:44 | |
*** jlk has joined #openstack-shade | 22:44 | |
*** gouthamr has joined #openstack-shade | 22:52 | |
clarkb | mordred: jamielennox I left some comments, not sure if they make sense as I don't know if that is possible with neutron api, it is general possible with nova apis though and I am fairly certian you could do it with nvoa net | 22:59 |
jamielennox | clarkb: oh, is adding a security group to a server a neutron call? | 23:02 |
clarkb | jamielennox: its proxied by nova | 23:02 |
jamielennox | for nova i was following https://developer.openstack.org/api-ref/compute/?expanded=add-security-group-to-a-server-addsecuritygroup-action-detail | 23:02 |
jamielennox | which doesn't mention that using the id is even possible | 23:02 |
clarkb | jamielennox: so if you have neutron it depends on neutron backend details I think, but if using nova net then its what nova allows which definitely allows shared names | 23:02 |
clarkb | oh neat | 23:03 |
jamielennox | and OSC has made the same assumption | 23:03 |
jamielennox | clarkb: yea i assumed there had to be some neutron communication there, but i just assumed it was a host based operation and i wouuld be talking to nova | 23:04 |
clarkb | jamielennox: I just checked nova source name is the only valid field there so your code is fine | 23:06 |
clarkb | (this is one of those api inconsistencies where most other apis require an id..) | 23:06 |
clarkb | also nova api masks the python reserved word "id" | 23:06 |
clarkb | just because you know | 23:06 |
jamielennox | ah.. i mean it's annoying that id is a reserved word, but it's kind of hard to just ignore it when doing apis | 23:07 |
clarkb | I mean you should use rid or something | 23:08 |
clarkb | but ya | 23:08 |
clarkb | I will go approve change now that I know thinsg about api around security groups | 23:08 |
*** openstack has joined #openstack-shade | 23:42 | |
openstackgerrit | Merged openstack-infra/shade master: Add server security groups to shade https://review.openstack.org/451183 | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!