| *** gouthamr has quit IRC | 03:01 | |
| *** jamielennox is now known as jamielennox|away | 04:18 | |
| *** cdent has joined #openstack-shade | 08:42 | |
| *** yolanda has quit IRC | 09:19 | |
| *** yolanda has joined #openstack-shade | 09:19 | |
| *** cdent has quit IRC | 10:38 | |
| *** openstackgerrit has quit IRC | 11:18 | |
| *** iogg has joined #openstack-shade | 11:29 | |
| *** cdent has joined #openstack-shade | 11:50 | |
| *** iogg has quit IRC | 11:57 | |
| *** gouthamr has joined #openstack-shade | 12:18 | |
| Shrews | mordred: i disagree with the unit test removal there in 454382, but the rest lgtm | 13:30 |
|---|---|---|
| mordred | Shrews: I could not figure out anything that unit test did | 13:34 |
| mordred | Shrews: I mean, it seemed to be testing that get_server called search_servers with a certain set of parameter | 13:35 |
| mordred | s | 13:35 |
| Shrews | mordred: it was more about testing the name match | 13:36 |
| Shrews | search_servers returns a list, get_servers should find a match within that list and return it | 13:37 |
| Shrews | that's the whole reason for get_server | 13:37 |
| Shrews | well, not reason, but function | 13:38 |
| mordred | Shrews: ah - gotcha. I'll re-look at that | 13:40 |
| Shrews | mordred: the test would probably make more sense if we had the search_servers return value contain other things that did not match the server name | 13:42 |
| Shrews | but meh | 13:42 |
| *** cdent has quit IRC | 13:43 | |
| *** cdent has joined #openstack-shade | 13:43 | |
| mordred | Shrews: kk | 13:51 |
| *** openstackgerrit has joined #openstack-shade | 14:03 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Don't run extra server info on every server in list https://review.openstack.org/454382 | 14:03 |
| mordred | Shrews: that look better? | 14:03 |
| Shrews | mordred: yah | 14:05 |
| mordred | woot | 14:05 |
| mordred | Shrews: thanks for the +A on 454382 - it's stack on top of 454212 - mind popping that too? | 14:16 |
| *** cdent has quit IRC | 14:29 | |
| Shrews | mordred: done | 14:42 |
| *** cdent has joined #openstack-shade | 14:52 | |
| *** cdent has quit IRC | 15:17 | |
| *** cdent has joined #openstack-shade | 15:17 | |
| openstackgerrit | Merged openstack-infra/shade master: Use REST for neutron floating IP list https://review.openstack.org/454212 | 15:26 |
| SamYaple | mordred: are the shade commit messages being mirrored here and infra? | 15:28 |
| mordred | SamYaple: yup | 15:32 |
| *** cdent has quit IRC | 15:59 | |
| *** cdent has joined #openstack-shade | 17:05 | |
| *** rcarrill1 has joined #openstack-shade | 18:05 | |
| *** rcarrillocruz has quit IRC | 18:06 | |
| *** openstackgerrit has quit IRC | 19:19 | |
| *** cdent has quit IRC | 19:52 | |
| *** rcarrill1 is now known as rcarrillocruz | 20:23 | |
| *** gouthamr has quit IRC | 20:26 | |
| *** rcarrillocruz has quit IRC | 20:31 | |
| *** rcarrillocruz has joined #openstack-shade | 20:32 | |
| *** gouthamr has joined #openstack-shade | 20:53 | |
| *** gouthamr has quit IRC | 21:28 | |
| *** SamYaple has quit IRC | 22:01 | |
| *** SamYaple has joined #openstack-shade | 22:01 | |
| *** SamYaple has quit IRC | 22:06 | |
| *** SamYaple has joined #openstack-shade | 22:06 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!