| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use requests-mock for the volume backup tests https://review.openstack.org/459898 | 00:39 |
|---|---|---|
| rods | ^^ last tests remained for cinder :) | 00:40 |
| *** gkadam has joined #openstack-shade | 03:19 | |
| *** gouthamr has quit IRC | 04:02 | |
| *** slaweq has joined #openstack-shade | 05:01 | |
| *** slaweq has quit IRC | 05:02 | |
| *** slaweq has joined #openstack-shade | 05:26 | |
| *** yolanda has quit IRC | 05:28 | |
| *** slaweq has quit IRC | 05:28 | |
| *** gouthamr has joined #openstack-shade | 05:36 | |
| *** yolanda has joined #openstack-shade | 06:49 | |
| *** yolanda has quit IRC | 07:25 | |
| *** yolanda has joined #openstack-shade | 07:41 | |
| *** gouthamr has quit IRC | 07:47 | |
| *** yolanda has quit IRC | 08:24 | |
| *** gkadam is now known as gkadam-afk | 08:33 | |
| *** yolanda has joined #openstack-shade | 08:41 | |
| *** cdent has joined #openstack-shade | 09:20 | |
| *** yolanda has quit IRC | 09:26 | |
| *** yolanda has joined #openstack-shade | 09:43 | |
| *** slaweq has joined #openstack-shade | 10:29 | |
| *** gkadam-afk is now known as gkadam | 10:30 | |
| *** gkadam has quit IRC | 10:31 | |
| *** gkadam has joined #openstack-shade | 10:31 | |
| *** gkadam is now known as gkadam-afk | 10:31 | |
| *** slaweq has quit IRC | 10:34 | |
| *** yolanda has quit IRC | 11:19 | |
| *** gkadam-afk is now known as gkadam | 11:23 | |
| *** yolanda has joined #openstack-shade | 11:34 | |
| *** cdent has quit IRC | 11:45 | |
| *** yfried has joined #openstack-shade | 12:14 | |
| *** ioggstream has joined #openstack-shade | 12:55 | |
| mordred | rods: awesome. while we're looking at that one, we should go ahead and make a _normalize_volume_backups method that we call from list_volume_backups | 13:06 |
| *** yolanda has quit IRC | 13:06 | |
| rods | mordred ya, I'll fix it in a minute | 13:07 |
| *** gkadam has quit IRC | 13:12 | |
| *** gouthamr has joined #openstack-shade | 13:22 | |
| *** yolanda has joined #openstack-shade | 13:23 | |
| openstackgerrit | Merged openstack-infra/shade master: Use requests-mock for the volume backup tests https://review.openstack.org/459898 | 13:48 |
| openstackgerrit | Merged openstack-infra/shade master: Remove neutronclient mocks from router tests https://review.openstack.org/459872 | 13:49 |
| openstackgerrit | Merged openstack-infra/shade master: Replace neutronclient with REST API calls in subnet commands https://review.openstack.org/459653 | 13:58 |
| slaweq_ | mordred: ^^ neutronclient in subnet actions is now replaced with keystonauth1 | 14:00 |
| slaweq_ | so neutron is moving forward slowly :) | 14:00 |
| mordred | :) | 14:00 |
| mordred | I was just looking to see how many neutronclient commands there are left ... it's getting closer! | 14:00 |
| slaweq_ | there is still router, ports, floating_ips and security groups | 14:01 |
| slaweq_ | I think that will be all | 14:01 |
| slaweq_ | but I can be wrong | 14:01 |
| mordred | yup. I believe you're right - oh, and quota | 14:01 |
| slaweq_ | yes, I have quota on my list also :) | 14:03 |
| slaweq_ | but I forgot to mention it now | 14:03 |
| *** slaweq has joined #openstack-shade | 14:30 | |
| *** iogg has joined #openstack-shade | 14:33 | |
| *** slaweq has quit IRC | 14:34 | |
| *** ioggstream has quit IRC | 14:34 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Add a _normalize_volume_backups method https://review.openstack.org/460127 | 14:48 |
| rods | mordred ^^ that should do it :) | 14:49 |
| mordred | rods: awesome - thanks. noted in review - but I think we can remove that whole line now actually | 14:52 |
| *** yolanda has quit IRC | 15:31 | |
| *** slaweq has joined #openstack-shade | 15:32 | |
| *** jlk has quit IRC | 16:01 | |
| *** jlk has joined #openstack-shade | 16:02 | |
| *** jlk has quit IRC | 16:02 | |
| *** jlk has joined #openstack-shade | 16:02 | |
| *** slaweq has quit IRC | 16:04 | |
| *** yfried has quit IRC | 16:14 | |
| rods | mordred looks like list_volume_backups is returning a list of Munch objects, that's way I was using the object_to_dict for the assertEqual | 16:14 |
| rods | dropping a pdb into the test looks like the conversion from BackupVolume to Munch happens here https://github.com/openstack-infra/shade/blob/master/shade/task_manager.py#L131 | 16:15 |
| *** jamielennox is now known as jamielennox|away | 16:31 | |
| mordred | rods: yes - this is correct - so, what I think would be more correct is to call meta.obj_list_to_dict on [vol1, vol2] in your assertEqual - we should not need to transform the result from search_volume_backups - but transforming the raw fake dict for the equal check is definitely needed | 16:41 |
| mordred | (the thing you have there is technically correct, I just worry that it might mask list_volume_backups not performing the _normalize call | 16:42 |
| rods | mordred yeah, I see | 16:55 |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Add a _normalize_volume_backups method https://review.openstack.org/460127 | 17:17 |
| *** slaweq has joined #openstack-shade | 17:37 | |
| *** slaweq has quit IRC | 17:40 | |
| mordred | rods: yes - looks perfect - thank you! | 17:57 |
| rods | :) | 17:58 |
| openstackgerrit | Morgan Fainberg proposed openstack-infra/shade master: Convert test_role_assignments to requests mock https://review.openstack.org/448313 | 18:00 |
| mordred | morgan: nice on the query string matching | 18:02 |
| *** slaweq has joined #openstack-shade | 18:11 | |
| *** slaweq has quit IRC | 18:17 | |
| *** slaweq has joined #openstack-shade | 18:18 | |
| *** slaweq has quit IRC | 18:22 | |
| *** iogg has quit IRC | 18:53 | |
| openstackgerrit | Merged openstack-infra/shade master: Add a _normalize_volume_backups method https://review.openstack.org/460127 | 18:58 |
| *** slaweq has joined #openstack-shade | 19:23 | |
| *** slaweq has quit IRC | 19:28 | |
| *** iogg has joined #openstack-shade | 19:28 | |
| *** jamielennox|away is now known as jamielennox | 19:52 | |
| *** iogg has quit IRC | 20:43 | |
| *** slaweq has joined #openstack-shade | 21:16 | |
| *** yolanda has joined #openstack-shade | 21:25 | |
| *** slaweq has quit IRC | 21:30 | |
| *** gouthamr has quit IRC | 21:59 | |
| *** slaweq has joined #openstack-shade | 22:31 | |
| rods | mordred you around? | 22:34 |
| *** slaweq has quit IRC | 22:35 | |
| rods | looks like this GET here https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_caching.py#L275 is an artifact of the cinder client which is not going to be needed once we switch to the REST api call. | 22:37 |
| rods | create_volume is making this POST here https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_caching.py#L271 but then is calling get_volume(since wait=True) which in turn is calling search_volumes that calls list_volume | 22:40 |
| rods | list_volume is making this GET https://github.com/openstack-infra/shade/blob/master/shade/tests/unit/test_caching.py#L279 skipping the GET on line 275 | 22:42 |
| rods | don't love the idea to change a test while I'm changing the implementation but seems like in this case might be needed | 22:44 |
| mordred | rods: looking | 22:57 |
| mordred | oh - because cinder_client on the backend is just doing an extra get, but then we in our wait loop also do a get | 22:59 |
| mordred | yah - this has happened in a few other places too - there are these nice extra calls the client libs make for us that we don't need | 23:00 |
| rods | I guess is fine changing the tests in this case, what do you think? | 23:00 |
| mordred | I think it's ok to remove the call in the case - I agree it's a thing we should always be careful about - but I do believe we can agree that the extra get is an impl detail of cinderclient | 23:00 |
| mordred | yah | 23:00 |
| rods | cool, thx | 23:01 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!