| *** slaweq has joined #openstack-shade | 00:10 | |
| *** slaweq has quit IRC | 00:15 | |
| *** purplerbot has quit IRC | 00:48 | |
| *** purplerbot has joined #openstack-shade | 00:48 | |
| *** slaweq has joined #openstack-shade | 01:11 | |
| *** slaweq has quit IRC | 01:17 | |
| *** rcarrillocruz has quit IRC | 01:20 | |
| *** slaweq has joined #openstack-shade | 02:13 | |
| *** slaweq has quit IRC | 02:18 | |
| *** slaweq has joined #openstack-shade | 03:14 | |
| *** slaweq has quit IRC | 03:19 | |
| *** slaweq has joined #openstack-shade | 04:15 | |
| *** slaweq has quit IRC | 04:20 | |
| *** slaweq has joined #openstack-shade | 05:16 | |
| *** slaweq has quit IRC | 05:21 | |
| *** yfried has joined #openstack-shade | 05:44 | |
| *** slaweq has joined #openstack-shade | 06:17 | |
| *** slaweq has quit IRC | 06:21 | |
| *** slaweq has joined #openstack-shade | 06:35 | |
| *** slaweq has quit IRC | 06:36 | |
| *** slaweq has joined #openstack-shade | 07:36 | |
| *** slaweq has quit IRC | 07:38 | |
| *** slaweq has joined #openstack-shade | 07:38 | |
| *** slaweq has quit IRC | 10:04 | |
| *** slaweq has joined #openstack-shade | 10:04 | |
| *** slaweq has quit IRC | 10:09 | |
| *** yfried has quit IRC | 10:20 | |
| *** slaweq has joined #openstack-shade | 11:05 | |
| *** slaweq has quit IRC | 11:10 | |
| *** slaweq has joined #openstack-shade | 11:55 | |
| *** slaweq has quit IRC | 11:59 | |
| *** slaweq has joined #openstack-shade | 12:04 | |
| *** slaweq has quit IRC | 12:10 | |
| *** larainema has quit IRC | 12:29 | |
| *** RuiChen has quit IRC | 12:29 | |
| *** larainema has joined #openstack-shade | 12:51 | |
| *** RuiChen has joined #openstack-shade | 12:52 | |
| *** slaweq has joined #openstack-shade | 12:58 | |
| *** slaweq has quit IRC | 13:07 | |
| *** slaweq has joined #openstack-shade | 13:35 | |
| *** cdent has joined #openstack-shade | 13:48 | |
| mordred | morgan: yay!!! | 14:28 |
|---|---|---|
| * mordred hands morgan a pie he may or may not have found sitting over in the corner | 14:37 | |
| mordred | morgan: also, for the record, it's not unreviewable at all - it's actually very nice | 14:39 |
| mordred | I don't need to review each of the call sequences - but the structure is super understandable and I believe by reading each test I gain a better understanding of the REST sequence involved - so yay | 14:40 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some more debugging to the post_test_hook https://review.openstack.org/460779 | 14:42 |
| rods | mordred I'm updating https://review.openstack.org/#/c/460357/1 to use changes in https://review.openstack.org/#/c/461025/3 and looks like the error_message attribute passing fails in the keystoneauth1 library | 15:00 |
| rods | while both post and request accept **kwargs, looks like since the error_message attribute is not passed here https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L600 | 15:02 |
| rods | keystoneauth1 fails here https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L616 with a TypeError: request() got an unexpected keyword argument 'error_message' | 15:03 |
| rods | http://paste.openstack.org/show/608438/ | 15:04 |
| *** slaweq has quit IRC | 15:09 | |
| mordred | oh - you know what -... | 15:10 |
| mordred | rods: hrm. my first thought was wrong. that's weird - I'd expect ShadeAdapter.request to intercept error_message and not pass it further | 15:12 |
| mordred | rods: it works for me live ... | 15:16 |
| mordred | c._compute_client.get('/', error_message='foo') | 15:17 |
| mordred | shade.exc.OpenStackCloudURINotFound: foo. (404) Client Error: Not Found for https://compute-ca-ymq-1.vexxhost.net/v2.1/db92b20496ae4fbda850a689ea9d563f/ | 15:17 |
| mordred | rods: I wonder if it's something to do with how requests_mock is working? | 15:17 |
| openstackgerrit | Merged openstack-infra/shade master: Convert test_role_assignments to requests mock https://review.openstack.org/448313 | 15:17 |
| openstackgerrit | Merged openstack-infra/shade master: Add optional error_message to adapter.request https://review.openstack.org/461025 | 15:17 |
| rods | weird, I'm running this test locally and and looks like error_message is getting to the keystoneauth1 request call | 15:19 |
| rods | https://github.com/openstack-infra/shade/blob/master/shade/_adapter.py#L157 | 15:19 |
| mordred | rods: are you sure you have 461025 in your history? | 15:20 |
| rods | mordred doh! stupid me I deleted the branch with that change and forgot to pull it again :( | 15:22 |
| rods | sorry | 15:22 |
| mordred | whoops! | 15:22 |
| mordred | (well, I did find a bug though - so that's good :) ) | 15:23 |
| rods | :) | 15:23 |
| openstackgerrit | Merged openstack-infra/shade master: Remove neutronclient mocks from sec groups tests https://review.openstack.org/461238 | 15:28 |
| openstackgerrit | Merged openstack-infra/shade master: Remove neutronclient mocks from quotas tests https://review.openstack.org/461150 | 15:29 |
| openstackgerrit | Merged openstack-infra/shade master: Remove neutronclient mocks from ports tests https://review.openstack.org/461149 | 15:29 |
| rods | mordred were you talking about the "global name '_' is not defined" issue before? | 15:29 |
| mordred | yup. | 15:30 |
| mordred | patching coming :) | 15:30 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove two lines that are leftover and broken https://review.openstack.org/461288 | 15:31 |
| *** cdent has quit IRC | 15:37 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Move REST error_messages to error_message argument https://review.openstack.org/461290 | 15:37 |
| mordred | rods: and there's fixing a bunch of the calls that had already been translated - great catch on this whole topic | 15:37 |
| rods | mordred thank you for jumping on it :) | 15:38 |
| mordred | wow. we had a unit tests mocking out a rest client | 16:15 |
| * mordred is ashamed | 16:15 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Move REST error_messages to error_message argument https://review.openstack.org/461290 | 16:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some more debugging to the post_test_hook https://review.openstack.org/460779 | 16:31 |
| *** slaweq has joined #openstack-shade | 17:00 | |
| *** slaweq has quit IRC | 17:02 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some more debugging to the post_test_hook https://review.openstack.org/460779 | 17:39 |
| openstackgerrit | Merged openstack-infra/shade master: Remove two lines that are leftover and broken https://review.openstack.org/461288 | 18:04 |
| *** slaweq has joined #openstack-shade | 18:33 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some more debugging to the post_test_hook https://review.openstack.org/460779 | 18:39 |
| *** slaweq has quit IRC | 18:57 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use REST API for volume type_access and volume create https://review.openstack.org/460357 | 19:05 |
| mordred | rods: great. left a -1/comment on it - but looks great mostly | 19:22 |
| *** slaweq has joined #openstack-shade | 19:25 | |
| rods | mordred yah, splitting it in two makes a lot of sense. I'll fix it | 19:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some more debugging to the post_test_hook https://review.openstack.org/460779 | 19:34 |
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Replace neutronclient with REST API calls in router commands https://review.openstack.org/460518 | 19:35 |
| *** pleia2 has quit IRC | 19:42 | |
| *** pleia2 has joined #openstack-shade | 19:44 | |
| *** slaweq has quit IRC | 20:11 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some more debugging to the post_test_hook https://review.openstack.org/460779 | 20:17 |
| openstackgerrit | Merged openstack-infra/shade master: Replace neutronclient with REST API calls in router commands https://review.openstack.org/460518 | 20:44 |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Refactor the test_create_volume_invalidates test https://review.openstack.org/460357 | 20:44 |
| rods | mordred ^^ first commit with the refactoring | 20:45 |
| mordred | rods: looks great! | 21:15 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some more debugging to the post_test_hook https://review.openstack.org/460779 | 21:15 |
| mordred | maybe one day I'll be able to write 4 lines of shell and have them work | 21:16 |
| openstackgerrit | Merged openstack-infra/shade master: Refactor the test_create_volume_invalidates test https://review.openstack.org/460357 | 22:05 |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Use REST API for volume type_access and volume create https://review.openstack.org/461312 | 22:16 |
| *** zigo has joined #openstack-shade | 22:22 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Fix tips jobs to do what we think they do https://review.openstack.org/460779 | 22:49 |
| openstackgerrit | Merged openstack-infra/shade master: Use REST API for volume type_access and volume create https://review.openstack.org/461312 | 23:23 |
| Shrews | mordred: yeah, i was fine with the approach on 461025, but looks like you already self approved | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!