| *** jamielennox|away is now known as jamielennox | 00:02 | |
| *** slaweq has quit IRC | 00:02 | |
| rods | mordred this test might be broken https://github.com/openstack-infra/shade/blob/master/shade/tests/functional/test_floating_ip.py#L169 | 00:16 |
|---|---|---|
| rods | nets comes from a REST call so the result should a list of dict, how does nets[0].id works | 00:17 |
| rods | *work | 00:17 |
| rods | I mean the tests that use that function :) | 00:26 |
| *** yfried has joined #openstack-shade | 00:47 | |
| *** jamielennox is now known as jamielennox|away | 01:00 | |
| *** jamielennox|away is now known as jamielennox | 01:10 | |
| *** yfried has quit IRC | 01:12 | |
| mordred | rods: nets = self.user_cloud._compute_client.get('/os-tenant-networks') should be returning a Munch (the adapter does a conversion at the end of the function - meta.obj_to_dict call) | 01:18 |
| mordred | or obj_list_to_dict | 01:19 |
| rods | mordred ah, I guess this patch we merged is wrong then https://review.openstack.org/#/c/472268/1/shade/_adapter.py | 01:23 |
| rods | we are just returning json | 01:23 |
| rods | and not all the call in openstackcloud are normalizing the result | 01:25 |
| rods | *calls | 01:25 |
| *** slaweq has joined #openstack-shade | 01:59 | |
| *** slaweq has quit IRC | 02:04 | |
| *** larainema has quit IRC | 03:02 | |
| *** larainema has joined #openstack-shade | 03:13 | |
| *** gkadam has joined #openstack-shade | 03:38 | |
| *** slaweq has joined #openstack-shade | 04:01 | |
| *** slaweq has quit IRC | 04:06 | |
| *** slaweq has joined #openstack-shade | 05:02 | |
| *** slaweq has quit IRC | 05:06 | |
| calebb | mordred: hey, figured out the ansible thing, looks like because im using a public ip and "auto_ip" defaults to true, each time ansible runs, it sees that my instance doesnt have a floating ip and so it tries to add one and sets changed to true, although I'm not sure why it doesnt fail when trying to add a floating IP to my instance, you probably have more insight into how OpenStack/Shade/Ansible | 05:34 |
| calebb | deals with that | 05:34 |
| calebb | so just setting "auto_ip" to false fixes it, although it probably makes sense to find some way to fix this, not entirely sure how, but I'll poke it, ansible can probably just check if the instance has a public ip or floating ip instead of just floating | 05:35 |
| *** iogg has joined #openstack-shade | 06:24 | |
| *** noshankus has joined #openstack-shade | 08:36 | |
| *** cdent has joined #openstack-shade | 08:43 | |
| *** noshankus has quit IRC | 10:05 | |
| *** nokes has joined #openstack-shade | 10:06 | |
| *** nokes is now known as noshankus | 10:06 | |
| *** cdent has quit IRC | 10:29 | |
| *** cdent has joined #openstack-shade | 10:58 | |
| *** iogg has quit IRC | 11:30 | |
| *** iogg has joined #openstack-shade | 11:30 | |
| *** yfried has joined #openstack-shade | 12:05 | |
| *** yfried has quit IRC | 12:24 | |
| mordred | rods: oh - whoops. yah - we should run those through meta.obj_to_dict | 12:48 |
| mordred | calebb: ah. | 12:48 |
| mordred | calebb: looking real quick | 12:48 |
| mordred | calebb: bug in module | 12:50 |
| mordred | calebb: https://github.com/ansible/ansible/pull/25540 | 13:00 |
| *** purplerbot has quit IRC | 13:16 | |
| *** purplerbot has joined #openstack-shade | 13:16 | |
| rods | mordred patch is on the way :) | 13:18 |
| rods | just out of curiosity once we moved everything to REST API call, do we still need to convert everything to Munch objects? | 13:20 |
| rods | *calls | 13:20 |
| rods | we are already getting dictionary from the raw clients | 13:21 |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Convert data from raw clients to dict or list of dicts https://review.openstack.org/472690 | 13:53 |
| rods | ^^ what about something like this? | 13:54 |
| *** cdent has quit IRC | 14:23 | |
| mordred | rods: we do - because it's part of the API we're giving to users - so they may have code that does "server cloud.get_server('foo') ; server.id" and if we stopped converting we might break those users | 14:23 |
| mordred | rods: yes - that patch looks great. however, maybe just for clarify we should call th emethod "get_and_munchify" | 14:25 |
| mordred | rods: and, in fact, we could also rename obj_to_dict to obj_to_munch and obj_list_to_dict to obj_list_to_munch - but then follow with obj_to_dict = obj_to_munch for backwards compat) | 14:26 |
| *** gkadam_ has joined #openstack-shade | 14:26 | |
| *** gkadam has quit IRC | 14:26 | |
| mordred | I don't think the second thing is as important- but if we're adding a new thing it might help developer clarity | 14:27 |
| *** gkadam_ has quit IRC | 14:31 | |
| rods | mordred ya, I can take care of it | 14:31 |
| rods | I'm renaming get_and_dictify in the current patch and make a new one for the obj_to_dict and obj_list_to_dict | 14:33 |
| mordred | woot. thanks! | 14:37 |
| *** yfried has joined #openstack-shade | 14:52 | |
| *** cdent has joined #openstack-shade | 14:53 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted now to clear an issue arising from an unanticipated SSH API connection flood | 14:57 | |
| *** yfried has quit IRC | 15:13 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Convert data from raw clients to dict or list of dicts https://review.openstack.org/472690 | 15:25 |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Convert data from raw clients to Munch objects https://review.openstack.org/472690 | 15:31 |
| calebb | mordred: sweet, I'll check and test in a bit, thanks! | 16:37 |
| calebb | works for me! | 17:13 |
| *** iogg has quit IRC | 18:07 | |
| *** yolanda has quit IRC | 18:43 | |
| *** yolanda has joined #openstack-shade | 18:45 | |
| *** slaweq has joined #openstack-shade | 19:04 | |
| *** slaweq has quit IRC | 19:20 | |
| *** slaweq has joined #openstack-shade | 19:35 | |
| samueldmq | mordred: can you tell me what piece of code is doing the version discovery properly ? | 20:08 |
| samueldmq | so that I will be able to restify things for keystone | 20:08 |
| mordred | samueldmq: yes! | 20:17 |
| mordred | samueldmq: https://github.com/openstack-infra/shade/blob/master/shade/openstackcloud.py#L414 calls https://github.com/openstack-infra/shade/blob/master/shade/openstackcloud.py#L452 | 20:17 |
| mordred | samueldmq: so as long as you use _identity_client - it should all just work | 20:17 |
| mordred | samueldmq: here's an example: https://review.openstack.org/#/c/467784/ | 20:18 |
| samueldmq | mordred: ah so you've fixed the _identity_client for me too | 20:21 |
| samueldmq | I thought I was supposed to that on the top of what you had built | 20:21 |
| samueldmq | but anyways, thanks! | 20:21 |
| *** slaweq has quit IRC | 20:55 | |
| *** slaweq has joined #openstack-shade | 20:56 | |
| *** slaweq has quit IRC | 21:22 | |
| *** slaweq has joined #openstack-shade | 21:22 | |
| *** slaweq has quit IRC | 21:27 | |
| *** slaweq has joined #openstack-shade | 21:43 | |
| rods | mordred when you have a sec, this should be ready to go https://review.openstack.org/#/c/472690/ | 21:45 |
| *** slaweq has quit IRC | 21:47 | |
| *** slaweq has joined #openstack-shade | 22:03 | |
| *** slaweq has quit IRC | 22:05 | |
| *** cdent has quit IRC | 23:44 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!