| *** slaweq has joined #openstack-shade | 00:22 | |
| *** slaweq has quit IRC | 00:26 | |
| *** slaweq has joined #openstack-shade | 00:58 | |
| *** slaweq has quit IRC | 01:03 | |
| *** larainema has quit IRC | 02:02 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some release notes we forgot to add https://review.openstack.org/474385 | 02:27 |
|---|---|---|
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Go back to deleting volumes serially https://review.openstack.org/474783 | 02:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Properly expand server dicts after rebuild and update https://review.openstack.org/473972 | 02:36 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Break early from volume cleanup loop https://review.openstack.org/474027 | 02:36 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Migrate non-list server interactions to REST https://review.openstack.org/473971 | 02:36 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove some unused mocks https://review.openstack.org/474840 | 03:41 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert list servers tests to requests_mock https://review.openstack.org/474841 | 03:41 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert list_servers to REST https://review.openstack.org/474842 | 03:41 |
| *** slaweq has joined #openstack-shade | 03:46 | |
| *** slaweq has quit IRC | 03:50 | |
| *** gkadam has joined #openstack-shade | 03:55 | |
| *** larainema has joined #openstack-shade | 04:33 | |
| *** gkadam is now known as gkadam-brb | 04:46 | |
| *** gkadam-brb is now known as gkadam | 05:20 | |
| *** gouthamr has quit IRC | 05:25 | |
| *** ioggstream has joined #openstack-shade | 07:19 | |
| *** ioggstream has quit IRC | 09:13 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack-infra/shade master: docs: make the first example easier to understand https://review.openstack.org/474920 | 09:22 |
| *** ioggstream has joined #openstack-shade | 10:25 | |
| *** gkadam has quit IRC | 10:40 | |
| *** slaweq has joined #openstack-shade | 11:09 | |
| *** slaweq has quit IRC | 11:14 | |
| *** ioggstream has quit IRC | 11:37 | |
| *** ioggstream has joined #openstack-shade | 11:38 | |
| *** cdent has joined #openstack-shade | 11:43 | |
| *** cdent has quit IRC | 12:01 | |
| *** cdent has joined #openstack-shade | 12:04 | |
| *** yfried has joined #openstack-shade | 12:17 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Go back to deleting volumes serially https://review.openstack.org/474783 | 12:29 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some release notes we forgot to add https://review.openstack.org/474385 | 12:30 |
| *** yfried has quit IRC | 12:34 | |
| rods | mordred is the test_list_volumes_pagination test still giving problem? | 12:45 |
| rods | :( | 12:45 |
| rods | is because of the timeout or the 404 issue? | 12:47 |
| rods | I'm working on the 404 right now should have a patch up for review in a few | 12:47 |
| *** gouthamr has joined #openstack-shade | 13:04 | |
| mordred | rods: both just a little - the 404 issue makes the test still a little flaky with the list-based-delete, so I turned that back off and raised the timeout | 13:05 |
| mordred | rods: this is a run one isn't it? | 13:05 |
| mordred | fun | 13:05 |
| mordred | not run | 13:05 |
| openstackgerrit | Merged openstack-infra/shade master: docs: make the first example easier to understand https://review.openstack.org/474920 | 13:08 |
| openstackgerrit | Merged openstack-infra/shade master: Migrate non-list server interactions to REST https://review.openstack.org/473971 | 13:08 |
| rods | mordred ya :) | 13:16 |
| openstackgerrit | Merged openstack-infra/shade master: Properly expand server dicts after rebuild and update https://review.openstack.org/473972 | 13:16 |
| rods | mordred still no joy http://logs.openstack.org/83/474783/3/check/gate-shade-functional-legacy/70ae8a0/logs/testr_results.html.gz, related to https://review.openstack.org/#/c/474783/ | 13:19 |
| *** cdent has quit IRC | 13:30 | |
| *** cdent has joined #openstack-shade | 13:32 | |
| rods | I'm wondering if deleting all the 8 volumes together is killing the vm, should we try raising the timeout and maybe deleting two volumes at the time? | 13:46 |
| mordred | rods: well, at least all the other patches are landing :) | 14:36 |
| mordred | rods: the release-notes patch just isn't giving me love :) | 14:37 |
| *** cdent has quit IRC | 15:00 | |
| *** cdent has joined #openstack-shade | 15:02 | |
| *** slaweq has joined #openstack-shade | 15:09 | |
| *** slaweq has quit IRC | 15:14 | |
| morgan | mordred: because releasenotes knows it's you | 15:44 |
| morgan | :P | 15:44 |
| mordred | morgan: IT DOES | 15:44 |
| mordred | morgan, samueldmq: the API-WG specs on discovery actually landed | 15:44 |
| *** cdent has left #openstack-shade | 16:03 | |
| *** slaweq has joined #openstack-shade | 16:36 | |
| *** jamielennox has quit IRC | 17:03 | |
| *** jamielennox has joined #openstack-shade | 17:03 | |
| *** ioggstream has quit IRC | 17:12 | |
| *** jlk has quit IRC | 17:23 | |
| *** jlk has joined #openstack-shade | 17:23 | |
| *** jlk has quit IRC | 17:24 | |
| *** jlk has joined #openstack-shade | 17:24 | |
| *** slaweq has quit IRC | 17:59 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Retry to fetch paginated volumes if we get 404 for next link https://review.openstack.org/475049 | 18:19 |
| rods | morgan what about something like ^^ | 18:19 |
| mordred | rods: I like it - with one thought ... | 18:29 |
| mordred | rods: if the initial list fails, I don't think we should retry 5 times | 18:29 |
| morgan | also the retry logic looks off some how | 18:38 |
| morgan | not sure how | 18:38 |
| morgan | ah i was missing things | 18:39 |
| morgan | if anything we should allow for a retry to be passed in | 18:39 |
| morgan | i don't see the need to explicitly retry 5 times | 18:39 |
| morgan | rods: ^ | 18:39 |
| morgan | rods: also you're not breaking after success. meaning that if you get volumes set and subsequent attempts fail, you're going to have bad results | 18:41 |
| morgan | oh wait, nvm you have a return in there | 18:41 |
| morgan | ugh | 18:41 |
| morgan | hard to follow :P | 18:41 |
| morgan | suggest single exit for that method vs multiple return points. | 18:41 |
| *** slaweq has joined #openstack-shade | 19:00 | |
| *** slaweq has quit IRC | 19:05 | |
| rods | mordred mordred thx, fixing it | 19:17 |
| rods | morgan ^^ | 19:19 |
| morgan | rods: cool | 19:20 |
| *** slaweq has joined #openstack-shade | 20:01 | |
| *** slaweq has quit IRC | 20:06 | |
| *** slaweq has joined #openstack-shade | 20:24 | |
| *** gouthamr has quit IRC | 20:28 | |
| *** gouthamr has joined #openstack-shade | 21:08 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Retry to fetch paginated volumes if we get 404 for next link https://review.openstack.org/475049 | 21:21 |
| *** slaweq has quit IRC | 21:23 | |
| rods | mordred morgan ^^ hope I got what you guys where talking about, feel free to leave comments if you have any other suggestion, I'll address them over the weekend | 21:26 |
| rods | have a good weekend :) | 21:26 |
| *** slaweq has joined #openstack-shade | 21:43 | |
| morgan | rods: looks pretty good | 21:53 |
| *** slaweq has quit IRC | 22:13 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Retry to fetch paginated volumes if we get 404 for next link https://review.openstack.org/475049 | 22:29 |
| rods | ^^ small fix | 22:29 |
| mordred | woot | 22:30 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add some release notes we forgot to add https://review.openstack.org/474385 | 22:31 |
| mordred | rods: I rebased the release notes patch on top of it | 22:32 |
| mordred | rods: yah - that looks good | 22:33 |
| mordred | rods: let's see how it does in the gate - thanks for working on it! | 22:34 |
| rods | shade is fun, I like to work on it :) | 22:36 |
| mordred | \o/ | 22:38 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Break early from volume cleanup loop https://review.openstack.org/474027 | 22:40 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove some unused mocks https://review.openstack.org/474840 | 22:40 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert list servers tests to requests_mock https://review.openstack.org/474841 | 22:40 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert list_servers to REST https://review.openstack.org/474842 | 22:40 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert list_servers to REST https://review.openstack.org/474842 | 23:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert keypairs tests to requests_mock https://review.openstack.org/475090 | 23:23 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert keypairs calls to REST https://review.openstack.org/475091 | 23:23 |
| mordred | rods: woot. your patch looks happier | 23:26 |
| rods | cool | 23:29 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!