*** gkadam has joined #openstack-shade | 03:02 | |
*** gouthamr has quit IRC | 03:17 | |
*** gouthamr has joined #openstack-shade | 03:58 | |
*** gkadam has quit IRC | 04:01 | |
*** gouthamr has quit IRC | 04:02 | |
*** gkadam has joined #openstack-shade | 04:03 | |
*** gkadam has quit IRC | 04:06 | |
*** gkadam has joined #openstack-shade | 04:06 | |
*** gkadam has quit IRC | 04:09 | |
*** gkadam has joined #openstack-shade | 04:10 | |
*** gkadam_ has joined #openstack-shade | 04:23 | |
*** gkadam has quit IRC | 04:26 | |
*** yfried has joined #openstack-shade | 05:57 | |
*** gkadam_ is now known as gkadam | 06:44 | |
*** openstackgerrit has quit IRC | 07:48 | |
*** nokes has joined #openstack-shade | 09:29 | |
*** noshankus has quit IRC | 09:29 | |
*** nokes is now known as noshankus | 09:29 | |
*** ioggstream has joined #openstack-shade | 09:33 | |
*** gkadam has quit IRC | 10:28 | |
*** frickler has quit IRC | 10:30 | |
*** frickler has joined #openstack-shade | 10:30 | |
*** gkadam has joined #openstack-shade | 10:30 | |
*** noshankus has quit IRC | 11:17 | |
lastmikoi | mordred: hello ! I'm still running on the development branch of shade pending release, and I would like to report that cloudinit user_data format on server creation is broken since I04c3b08d80cf496dabec8ce7000ca5fb679fe3b9 "RESTify create_server" | 11:33 |
---|---|---|
lastmikoi | Indeed, it's no longer base64-encoded, hence the virtual machine becomes unable to parse that data | 11:34 |
lastmikoi | I've used git bisect to single out the commit, so there's a good chance the bug was introduced then | 11:34 |
lastmikoi | make that 36b659eed403aea3ecf8666a68524b8e0f8ef494, I don't know what I pasted earlier but that's no git commit hash... | 12:02 |
*** gkadam has quit IRC | 12:31 | |
*** gouthamr has joined #openstack-shade | 12:53 | |
mordred | lastmikoi: oh - thank you! | 12:57 |
*** openstackgerrit has joined #openstack-shade | 13:18 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: base64 encode user_data sent to create server https://review.openstack.org/475385 | 13:18 |
mordred | lastmikoi: ^^ I think that should fix you - and should also be the last patch we need before releasing your other fix (sorry for the delay on that, we had some gate issues last week) | 13:21 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: base64 encode user_data sent to create server https://review.openstack.org/475385 | 13:44 |
mordred | lastmikoi: this time with a test :) | 13:44 |
*** yfried has quit IRC | 14:00 | |
lastmikoi | mordred: great to hear :) No worries on my end about the delay, I still have a fair bit of work before the playbook I'm working on would expect a released shade to be installed | 14:05 |
mordred | lastmikoi: ok good - and thankfully you found a good bug :) | 14:05 |
*** yfried has joined #openstack-shade | 14:07 | |
rods | mordred just wondering if there's a mistake or something here https://github.com/openstack-infra/shade/blob/master/shade/openstackcloud.py#L2802 | 14:12 |
rods | seems a little weird to have a `get_server_by_id` method that calls `meta.add_server_interfaces` | 14:12 |
lastmikoi | mordred: cherry-picked the commit on top of the current master branch and the issue seems indeed fixed, thanks again ! | 14:14 |
rods | mordred nm, I see the reason here https://github.com/openstack-infra/shade/commit/060ce2e055cfceabd22a97801f4cf33c227aa6a2 | 14:21 |
*** gouthamr has quit IRC | 14:26 | |
*** gouthamr has joined #openstack-shade | 14:28 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: base64 encode user_data sent to create server https://review.openstack.org/475385 | 14:48 |
samueldmq | morning shade | 14:58 |
mordred | morning samueldmq ! | 14:58 |
samueldmq | mordred: o/ | 14:58 |
samueldmq | mordred: is all the code in https://review.openstack.org/#/c/475385 copied over from novaclient | 15:00 |
samueldmq | ? | 15:00 |
mordred | samueldmq: well - half from novaclient and half from oslo.utils | 15:08 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: base64 encode user_data sent to create server https://review.openstack.org/475385 | 15:13 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Try all the detected encodings, not just one https://review.openstack.org/475424 | 15:13 |
mordred | samueldmq: renamed the method - good point | 15:14 |
*** yfried has quit IRC | 15:18 | |
*** slaweq has joined #openstack-shade | 15:37 | |
*** slaweq has quit IRC | 16:03 | |
*** slaweq has joined #openstack-shade | 16:52 | |
*** slaweq has quit IRC | 16:54 | |
*** slaweq has joined #openstack-shade | 16:56 | |
*** slaweq has quit IRC | 17:00 | |
*** slaweq has joined #openstack-shade | 17:01 | |
*** slaweq has quit IRC | 17:07 | |
openstackgerrit | Merged openstack-infra/shade master: Convert remaining nova tests to requests_mock https://review.openstack.org/475190 | 17:08 |
openstackgerrit | Merged openstack-infra/shade master: Translate final nova calls to REST https://review.openstack.org/475191 | 17:09 |
openstackgerrit | Merged openstack-infra/shade master: Remove novaclient from shade's dependencies https://review.openstack.org/475192 | 17:09 |
*** slaweq has joined #openstack-shade | 17:55 | |
*** zigo has quit IRC | 18:05 | |
*** zigo has joined #openstack-shade | 18:09 | |
*** slaweq has quit IRC | 18:16 | |
*** jamielennox has quit IRC | 18:19 | |
*** jamielennox has joined #openstack-shade | 18:21 | |
*** slaweq has joined #openstack-shade | 18:27 | |
*** purplerbot has quit IRC | 18:27 | |
*** slaweq has quit IRC | 18:31 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Try all the detected encodings, not just one https://review.openstack.org/475424 | 18:43 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: base64 encode user_data sent to create server https://review.openstack.org/475385 | 18:43 |
*** ioggstream has quit IRC | 18:50 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Try all the detected encodings, not just one https://review.openstack.org/475424 | 18:53 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: base64 encode user_data sent to create server https://review.openstack.org/475385 | 18:53 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Try all the detected encodings, not just one https://review.openstack.org/475424 | 19:01 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: base64 encode user_data sent to create server https://review.openstack.org/475385 | 19:21 |
mordred | Shrews: so - did you see I 86'd novaclient over the weekend? | 19:29 |
Shrews | mordred: i did not, buy \o/ | 19:31 |
Shrews | s/buy/but/ | 19:32 |
*** slaweq has joined #openstack-shade | 19:35 | |
openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Don't remove top-container element for server REST API calls https://review.openstack.org/475501 | 19:39 |
mordred | Shrews: if you hav ea sec, https://review.openstack.org/#/c/475385/ could use another bump | 19:41 |
*** gouthamr has quit IRC | 20:15 | |
*** gouthamr has joined #openstack-shade | 20:43 | |
openstackgerrit | Merged openstack-infra/shade master: base64 encode user_data sent to create server https://review.openstack.org/475385 | 20:55 |
*** mgagne has quit IRC | 21:21 | |
*** mgagne has joined #openstack-shade | 21:22 | |
*** slaweq has quit IRC | 22:31 | |
*** slaweq has joined #openstack-shade | 22:34 | |
*** slaweq has quit IRC | 22:35 | |
openstackgerrit | Merged openstack-infra/shade master: Don't remove top-container element for server REST API calls https://review.openstack.org/475501 | 22:43 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!