| *** slaweq has joined #openstack-shade | 03:32 | |
| *** slaweq has quit IRC | 03:37 | |
| *** gkadam has joined #openstack-shade | 03:44 | |
| *** gkadam has quit IRC | 03:48 | |
| *** gkadam has joined #openstack-shade | 04:27 | |
| *** jlk` has joined #openstack-shade | 05:12 | |
| *** jlk has quit IRC | 05:13 | |
| *** ianw_ has joined #openstack-shade | 05:36 | |
| *** ianw has quit IRC | 05:39 | |
| *** ianw_ is now known as ianw | 05:39 | |
| *** yfried has joined #openstack-shade | 05:55 | |
| *** slaweq has joined #openstack-shade | 07:33 | |
| *** slaweq has quit IRC | 07:37 | |
| *** ioggstream has joined #openstack-shade | 08:01 | |
| *** iogg has joined #openstack-shade | 09:27 | |
| *** slaweq has joined #openstack-shade | 09:30 | |
| *** rods has joined #openstack-shade | 09:33 | |
| *** ioggstream has quit IRC | 09:34 | |
| *** rods_ has quit IRC | 09:34 | |
| *** slaweq__ has quit IRC | 09:35 | |
| *** mgagne has quit IRC | 09:35 | |
| *** mgagne has joined #openstack-shade | 09:37 | |
| *** mgagne is now known as Guest28796 | 09:37 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Don't remove top-container element for flavors and clusters https://review.openstack.org/477708 | 11:14 |
|---|---|---|
| samueldmq | morning | 11:17 |
| *** yfried has quit IRC | 11:35 | |
| *** yfried has joined #openstack-shade | 12:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/477910 | 12:07 |
| *** yfried has quit IRC | 12:18 | |
| *** gkadam has quit IRC | 12:33 | |
| *** iogg is now known as ioggstream | 13:47 | |
| *** gkadam has joined #openstack-shade | 14:52 | |
| *** gkadam has quit IRC | 14:59 | |
| samueldmq | mordred: I need to talk to you about Oaktree, I wanna restore development there | 15:17 |
| *** slaweq_ has joined #openstack-shade | 16:21 | |
| *** slaweq_ has quit IRC | 16:26 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Domain Create https://review.openstack.org/478225 | 17:37 |
| *** jlk` is now known as jlk | 17:43 | |
| *** jlk has quit IRC | 17:44 | |
| *** jlk has joined #openstack-shade | 17:44 | |
| *** ioggstream has quit IRC | 18:22 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Deal with revision_number in neutron update_port tests https://review.openstack.org/477175 | 18:38 |
| *** slaweq_ has joined #openstack-shade | 19:15 | |
| *** ioggstream has joined #openstack-shade | 20:18 | |
| *** rcarrill1 has joined #openstack-shade | 20:33 | |
| *** rcarrillocruz has quit IRC | 20:34 | |
| mordred | samueldmq: in https://review.openstack.org/478225 - you can also put enabled into the valid_kwargs decorator | 21:10 |
| mordred | samueldmq: your patch looks fine as is - just letting you know | 21:11 |
| samueldmq | mordred: kk I will try that | 21:11 |
| samueldmq | mordred: did you see my comments there? | 21:11 |
| samueldmq | I'd like to get your view on the best way to fix them | 21:11 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Deal with revision_number in neutron update_port tests https://review.openstack.org/477175 | 21:13 |
| mordred | samueldmq: you'll need to add domains to the list of keys in shade/_adapter.py | 21:14 |
| mordred | samueldmq: in munch_response | 21:14 |
| mordred | or 'domain' rather | 21:14 |
| samueldmq | mordred: so that it won't munch the response automatically? | 21:15 |
| mordred | samueldmq: we're halfway in the middle of a transition away from having the shade adapter do the get_and_munchfiy part | 21:15 |
| mordred | yes - well, and so that it won't return response['domain'] | 21:15 |
| *** ioggstream has quit IRC | 21:15 | |
| samueldmq | mordred: but it's also returning an object of type munch.Munch | 21:15 |
| rods | mordred I'm very close to it, just need to fix like 20 more tests | 21:15 |
| mordred | right now, adapter looks for a single key in the return json, and if it finds only one, it returns munchify(response[key]) | 21:15 |
| samueldmq | not just getting the domain out of the 'domain' key | 21:16 |
| mordred | samueldmq: yes - this is what rods is fixing | 21:16 |
| mordred | samueldmq: same thing - adding 'domain' to that list will do both things | 21:16 |
| samueldmq | ok I thought I was doing something really wrong, or being dumb. or both | 21:16 |
| mordred | nope - just in the middle of a transition | 21:16 |
| mordred | rods: \o/ | 21:16 |
| samueldmq | nice | 21:16 |
| mordred | yah - it seemed like a good idea to do it in the adapter - but then it turns out pagination breaks that pretty badly | 21:17 |
| samueldmq | mordred: that one passed. there is still my comment in https://review.openstack.org/#/c/478225/1/shade/tests/unit/test_domains.py | 21:17 |
| mordred | samueldmq: oh - in test_domains ... | 21:17 |
| mordred | yah | 21:17 |
| mordred | it's ok to change the exceptoin type there | 21:17 |
| mordred | OpenStackCloudHTTPError is a subclass of OpenStackCloudException | 21:18 |
| mordred | but the test suite is strict | 21:18 |
| samueldmq | mordred: but that leads me to think we don;t need those with exception.blah clauses in the create_thing calls | 21:18 |
| mordred | so in the real world it's not breaking an interface, but in our tests we must match exactly | 21:18 |
| samueldmq | because HTTP exceptions will never be wrapped in those cases | 21:18 |
| mordred | samueldmq: that is correct- actually, you should remove the with shade_exceptions piece and instead pass a user-friendly error message to the _identity_client.post call in the error_message parameter | 21:19 |
| samueldmq | sweet! | 21:19 |
| samueldmq | I will do that for the other keystone calls to. and look back at the ones we've already converted | 21:20 |
| samueldmq | mordred: also, we are not translating those messages, dont we want to? | 21:22 |
| mordred | samueldmq: we're not set up for translation at the moment - and we haven't gotten any requests for it - I don't want to assume the translation team can handle more strings unless someone asks for them | 21:22 |
| mordred | samueldmq: and awesome - I left the same comments on the review in case they're helpulf | 21:23 |
| * samueldmq nods | 21:23 | |
| samueldmq | mordred: thanks. I want to finish the retification thing, and start OAKTREE!! | 21:23 |
| samueldmq | it'd be great to have a version of it soon. should be doable | 21:24 |
| mordred | samueldmq: ++ | 21:24 |
| rods | mordred question: the openstackcloud file is like more than 7k lines of code, do we have any plan to split it into multiple modules? | 21:25 |
| samueldmq | mordred: actually ... description has default None. as it can be provided as a "bare" (I dont have a better name) argument | 21:26 |
| mordred | rods: we haven't made a plan for that yet -but I don't think it's a bad idea. once we're done with this restification effort the codebase should be stable enough that reorganzing wouldn't be super disruptive | 21:27 |
| samueldmq | if I use @valid_kwargs, they will need to be passed as named arguments | 21:27 |
| samueldmq | like description='whatever' | 21:27 |
| mordred | samueldmq: good point to both | 21:27 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Domain Create https://review.openstack.org/478225 | 21:38 |
| *** slaweq_ has quit IRC | 21:48 | |
| *** slaweq_ has joined #openstack-shade | 21:49 | |
| openstackgerrit | Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/477910 | 21:51 |
| openstackgerrit | Merged openstack-infra/shade master: Don't remove top-container element for flavors and clusters https://review.openstack.org/477708 | 21:51 |
| *** slaweq_ has quit IRC | 21:53 | |
| *** ioggstream has joined #openstack-shade | 21:54 | |
| openstackgerrit | Merged openstack-infra/shade master: Project update to change enabled only when provided https://review.openstack.org/476914 | 21:55 |
| *** slaweq_ has joined #openstack-shade | 22:20 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Don't remove top-container element for flavor, zones and server groups https://review.openstack.org/478308 | 22:24 |
| rods | ^^ another small step, getting closer :) | 22:25 |
| *** slaweq_ has quit IRC | 22:25 | |
| mordred | \o/ | 22:33 |
| *** slaweq_ has joined #openstack-shade | 22:34 | |
| *** slaweq_ has quit IRC | 22:34 | |
| *** ioggstream has quit IRC | 23:04 | |
| *** slaweq_ has joined #openstack-shade | 23:35 | |
| *** slaweq_ has quit IRC | 23:41 | |
| openstackgerrit | Rosario Di Somma proposed openstack-infra/shade master: Don't remove top-container element for flavor, zones and server groups https://review.openstack.org/478308 | 23:45 |
| rods | ^^ so glad we have functional tests | 23:45 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Domain Create https://review.openstack.org/478225 | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!