morgan | mordred: ^ wtf... | 00:05 |
---|---|---|
morgan | mordred: that patch missed on a test that I couldn't repro locally | 00:06 |
morgan | *blink* wut | 00:06 |
morgan | http://logs.openstack.org/82/478582/3/check/gate-shade-python35/a85aa0c/console.html#_2017-07-07_22_38_38_190429 | 00:06 |
morgan | ugh... this is non-deterministiv | 00:18 |
morgan | aha | 00:21 |
morgan | found it | 00:21 |
morgan | create_endpoint is busted | 00:21 |
mordred | morgan: uhm. ... | 00:28 |
morgan | we are creating things based upon an order of the items in a dict | 00:28 |
morgan | and we cannot reliably test that | 00:28 |
morgan | since seed will change that order | 00:29 |
morgan | it is non-deterministic in the order we create 2-on-3 for endpoints, it could be public, admin, internal, or internal,public,admin or.... | 00:29 |
morgan | so trying to make sure we do a fixed ordering | 00:29 |
morgan | https://www.irccloud.com/pastebin/SrGtNsfb/ | 00:30 |
morgan | ^ that is the code that is causing the issue with the test | 00:31 |
openstackgerrit | Morgan Fainberg proposed openstack-infra/shade master: Make sure we pass propert dicts to validate https://review.openstack.org/478582 | 00:34 |
morgan | ^ there. fixed | 00:34 |
mordred | morgan: ahhhhhhhh | 00:37 |
mordred | morgan: yes- that change makes total sense | 00:37 |
mordred | wow. well done | 00:37 |
*** slaweq has joined #openstack-shade | 00:50 | |
*** slaweq has quit IRC | 00:56 | |
openstackgerrit | Morgan Fainberg proposed openstack-infra/shade master: Make sure we don't fail open on bad input to validate https://review.openstack.org/478589 | 01:13 |
morgan | ^simple rebase | 01:13 |
openstackgerrit | Morgan Fainberg proposed openstack-infra/shade master: Make sure we don't fail open on bad input to validate https://review.openstack.org/478589 | 01:37 |
morgan | mordred: ^ missed one | 01:38 |
morgan | fixed there | 01:38 |
openstackgerrit | Merged openstack-infra/shade master: Make sure we pass propert dicts to validate https://review.openstack.org/478582 | 02:01 |
*** slaweq has joined #openstack-shade | 02:52 | |
*** slaweq has quit IRC | 02:57 | |
*** gouthamr has quit IRC | 03:13 | |
*** gouthamr has joined #openstack-shade | 03:14 | |
*** gouthamr has quit IRC | 04:38 | |
*** slaweq has joined #openstack-shade | 04:50 | |
*** slaweq has quit IRC | 04:54 | |
*** slaweq_ has joined #openstack-shade | 04:54 | |
*** slaweq_ has quit IRC | 05:00 | |
*** slaweq has joined #openstack-shade | 07:58 | |
*** slaweq has quit IRC | 08:03 | |
*** slaweq has joined #openstack-shade | 08:54 | |
*** slaweq has quit IRC | 09:53 | |
*** slaweq has joined #openstack-shade | 09:53 | |
*** slaweq_ has joined #openstack-shade | 09:55 | |
*** slaweq has quit IRC | 09:55 | |
*** ioggstream has joined #openstack-shade | 10:12 | |
*** ioggstream has quit IRC | 10:53 | |
*** slaweq_ has quit IRC | 11:18 | |
*** slaweq has joined #openstack-shade | 11:19 | |
*** slaweq has quit IRC | 11:23 | |
*** slaweq has joined #openstack-shade | 11:45 | |
openstackgerrit | Merged openstack-infra/shade master: Make sure we don't fail open on bad input to validate https://review.openstack.org/478589 | 11:55 |
*** slaweq has quit IRC | 12:01 | |
*** slaweq has joined #openstack-shade | 12:01 | |
*** slaweq has quit IRC | 12:06 | |
*** ioggstream has joined #openstack-shade | 12:24 | |
*** slaweq has joined #openstack-shade | 13:16 | |
mordred | morgan: ^^ woot! | 13:17 |
*** slaweq has quit IRC | 13:30 | |
*** ioggstream has quit IRC | 15:30 | |
*** openstackgerrit has quit IRC | 16:17 | |
*** yfried has joined #openstack-shade | 19:28 | |
*** slaweq has joined #openstack-shade | 19:43 | |
*** slaweq has quit IRC | 19:56 | |
*** gouthamr has joined #openstack-shade | 21:19 | |
*** slaweq has joined #openstack-shade | 21:27 | |
*** gouthamr has quit IRC | 21:32 | |
*** gouthamr has joined #openstack-shade | 21:33 | |
*** slaweq has quit IRC | 21:43 | |
*** slaweq has joined #openstack-shade | 21:44 | |
*** slaweq has quit IRC | 21:48 | |
*** gouthamr has quit IRC | 22:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!