| *** gouthamr has quit IRC | 02:07 | |
| *** gkadam has joined #openstack-shade | 03:35 | |
| *** kong has left #openstack-shade | 03:39 | |
| *** iogg has joined #openstack-shade | 07:53 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** yfried has joined #openstack-shade | 09:41 | |
| *** iogg has quit IRC | 11:40 | |
| *** iogg has joined #openstack-shade | 12:27 | |
| *** gkadam has quit IRC | 12:36 | |
| *** frickler has joined #openstack-shade | 12:46 | |
| Shrews | mordred: should we still merge this? https://github.com/ansible/ansible/pull/20974 toshio is asking about it | 12:52 |
|---|---|---|
| *** yfried has quit IRC | 12:58 | |
| mordred | Shrews: yah - we probably should - although maybe we shoudl also go ahead and add "allow cloud parameter to be a full cloud config dict" to it before we do | 13:52 |
| mordred | Shrews: he's suggesting we merge right after stable-2.4 is branched, yeah? | 13:52 |
| Shrews | mordred: i think that's what he's asking about, but I think he's leaving it up to us. At this point, I'll +2 whatever you'd like on that | 13:54 |
| Shrews | probably safer to do as he suggests and merge after 2.4 is branched | 13:55 |
| samueldmq | good morning shade | 13:57 |
| samueldmq | mordred: what do I need to do to enforce interface=admin in the adapter call ? | 13:58 |
| samueldmq | I am willign to address https://review.openstack.org/#/c/482195/1/shade/operatorcloud.py | 13:58 |
| samueldmq | much of the remaining work is depending on that | 13:58 |
| *** gouthamr has joined #openstack-shade | 14:02 | |
| mordred | samueldmq: ++ | 14:05 |
| mordred | samueldmq: ah - that's a GREAT question - and unfortunately it opens a little bit of a rathole ... | 14:10 |
| samueldmq | why? it should be doable with those patches we got merged in ksa, correct? | 14:11 |
| mordred | samueldmq: gimme a minute and let me write something down for you ... the short version is that we need to be able to stop doing the endpoint_override thing we're currently doing in _identity_client - which means we need to get the new work we just did in ksa exposed in os-client-config | 14:11 |
| mordred | samueldmq: yup! the ksa patches totally make this possible - we just need to be able to make use of them | 14:11 |
| mordred | which means a patch or two to os-client-config that I think I have mostly written locally | 14:12 |
| *** openstackgerrit has joined #openstack-shade | 14:12 | |
| openstackgerrit | Eric Fried proposed openstack/os-service-types master: Support secondary services https://review.openstack.org/493325 | 14:12 |
| samueldmq | mordred: why os-client-config? don't we use the ksa adapter into the shade code directly? | 14:13 |
| *** noshankus has quit IRC | 14:25 | |
| *** noshankus has joined #openstack-shade | 14:26 | |
| mordred | samueldmq: oh- duh. so we do. you are very correct | 14:35 |
| mordred | samueldmq: SO - what we need to do instead is, I think, pass a min_version and max_version to the adapter (to use the new ksa feature) - then change the code where we do: | 14:36 |
| mordred | samueldmq: self.cloud_config.get_api_version('identity') | 14:37 |
| mordred | samueldmq: in methods to instead do self._identity_client.get_endpoint_data().version | 14:37 |
| samueldmq | mordred: how would it be used in the operatorcloud methods ? | 14:38 |
| samueldmq | I was imagining something like : self._identity_client.get('/servicesurl, | 14:39 |
| mordred | samueldmq: we might need to do one more thing in def _identity_client - because in shade we have a thing where we try to get the configured version and fallback to what we find with a warning if we can't find it | 14:39 |
| samueldmq | self._identity_client.get('/service', endpoint='admin') | 14:39 |
| mordred | samueldmq: so we should ACTUALLY probably just update _discover_endpoint to be _discover_version - and then call the adapter constructor with what we find | 14:39 |
| mordred | samueldmq: yes - similar - it'll then be self._identity_client.get('/service', endpoint_filters={'interface': 'admin'}) | 14:40 |
| samueldmq | mordred: aha so the cache will be in the ksa code itself I assume | 14:40 |
| mordred | samueldmq: let me make you a quick patch for the version thing I'm talking about - I'm right in the code anyway | 14:41 |
| mordred | samueldmq: yes! | 14:41 |
| samueldmq | as we might enforce admin interface for some ops and not for others | 14:41 |
| samueldmq | mordred: sure, looking forward to that patch. it will ease things | 14:42 |
| *** rods has joined #openstack-shade | 15:06 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: WIP use new keystoneauth version discovery https://review.openstack.org/493582 | 15:06 |
| mordred | samueldmq: ^^ not quite done - and I need to jump on a call real quick - I think the hard part is done and what needs to be done now is the note I left in the commit message | 15:07 |
| mordred | samueldmq: if you feel like working further on that while I'm on my call, go for it - otherwise I can finish it in a little bit | 15:07 |
| samueldmq | mordred: I will work on that right now, thanks | 15:19 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: WIP use new keystoneauth version discovery https://review.openstack.org/493582 | 15:38 |
| *** noshankus has quit IRC | 16:12 | |
| *** noshankus has joined #openstack-shade | 16:12 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Consolidate client version checks in an utility method https://review.openstack.org/493598 | 16:26 |
| samueldmq | mordred: ^ this should help getting us to replace the client version checks | 16:26 |
| *** iogg has quit IRC | 16:28 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Consolidate client version checks in an utility method https://review.openstack.org/493598 | 16:38 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: WIP use new keystoneauth version discovery https://review.openstack.org/493582 | 16:45 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: WIP use new keystoneauth version discovery https://review.openstack.org/493582 | 16:47 |
| *** gkadam has joined #openstack-shade | 16:53 | |
| samueldmq | mordred: I think we're closer now. see ^ and my questions there whenever you have time | 16:55 |
| *** yfried has joined #openstack-shade | 17:23 | |
| mordred | samueldmq: kk. running to a meeting - you're first up when I get back | 17:28 |
| * samueldmq nods | 17:29 | |
| *** yfried has quit IRC | 17:30 | |
| *** gkadam has quit IRC | 17:35 | |
| *** yfried has joined #openstack-shade | 17:56 | |
| openstackgerrit | Merged openstack/os-client-config master: Updated from global requirements https://review.openstack.org/491294 | 18:08 |
| *** iogg has joined #openstack-shade | 18:39 | |
| *** iogg has quit IRC | 18:52 | |
| *** yfried has quit IRC | 19:22 | |
| *** slaweq has joined #openstack-shade | 19:25 | |
| slaweq | mordred: hello, can You take a look at https://review.openstack.org/#/c/491248/ once again? qos is now enabled in neutron so those new tests are running (and passing) in gate :) | 19:40 |
| slaweq | thx in advance | 19:40 |
| *** slaweq has quit IRC | 20:08 | |
| Shrews | slaweq: mordred: where is "port_securrity" (obviously misspelled) neutron extension getting set? I noticed that in the log from the above referenced change: http://logs.openstack.org/48/491248/2/check/gate-shade-functional/ce96cd1/logs/screen-q-svc.txt.gz#_Aug_12_17_33_24_535530 | 20:19 |
| * Shrews got distracted by the squirrel and probably should return to more useful things | 20:22 | |
| mordred | Shrews: project_config in jenkins/jobs/shade.yaml ... we should fix that :) | 20:25 |
| Shrews | my "git grep" failed on that project | 20:25 |
| Shrews | oh, perhaps i should have pulled first | 20:25 |
| Shrews | ah, yep | 20:26 |
| Shrews | mordred: i hope that means that we don't have functional tests for that extension yet. if so, they aren't doing what they're supposed to be doing! :) | 20:27 |
| mordred | Shrews: I used codesearch.openstack.org fwiw | 20:28 |
| Shrews | mordred: i keep forgetting that's a thing | 20:30 |
| kmalloc | Shrews: i used it to find all uses of the positional library | 20:34 |
| kmalloc | whiiiiich..... i am trying to delete from openstack | 20:34 |
| Shrews | kmalloc: wrong target. delete openstack first | 20:34 |
| kmalloc | i wish i could. | 20:35 |
| kmalloc | right now i wish i could rm -rf keystone | 20:35 |
| mordred | kmalloc: ah - so you recommend not using positional any more? | 20:50 |
| kmalloc | it makes the code harder to read/maintain | 20:50 |
| kmalloc | if you want that py3-kwarg-only like thing, write py3 only code | 20:51 |
| *** gouthamr has quit IRC | 20:51 | |
| kmalloc | it is much more readable and less things to go wrong. | 20:51 |
| kmalloc | i have patches up to drop positioonal from all projects using it *and* from g-r | 20:51 |
| kmalloc | comes out to being ksm, ksa, ksc, and oslo.context | 20:52 |
| mordred | kmalloc: cool. I was just about to add it to something because I got used to it in ksa - I will cease being about to do that | 21:02 |
| kmalloc | mordred: yeah after using it a bit more you'll just be like "oh why ... why did i deal with this" | 21:03 |
| mordred | :) | 21:03 |
| openstackgerrit | Merged openstack-infra/shade master: Add functional tests for Neutron QoS policies and rules https://review.openstack.org/491248 | 21:06 |
| mordred | samueldmq: poking at the patch again | 21:17 |
| openstackgerrit | Merged openstack-infra/shade master: Consolidate client version checks in an utility method https://review.openstack.org/493598 | 21:42 |
| *** gouthamr has joined #openstack-shade | 22:39 | |
| *** rods has quit IRC | 23:05 | |
| *** rods has joined #openstack-shade | 23:09 | |
| *** gouthamr has quit IRC | 23:51 | |
| *** calebb has quit IRC | 23:51 | |
| *** thingee has quit IRC | 23:51 | |
| *** Shrews has quit IRC | 23:51 | |
| *** spredzy has quit IRC | 23:51 | |
| *** larainema has quit IRC | 23:51 | |
| *** jamielennox has quit IRC | 23:51 | |
| *** noshankus has quit IRC | 23:51 | |
| *** olaph has quit IRC | 23:51 | |
| *** zigo has quit IRC | 23:51 | |
| *** openstackgerrit has quit IRC | 23:51 | |
| *** yolanda has quit IRC | 23:51 | |
| *** DuncanT has quit IRC | 23:51 | |
| *** lastmikoi has quit IRC | 23:51 | |
| *** jeblair has quit IRC | 23:51 | |
| *** jlk has quit IRC | 23:51 | |
| *** dhellmann has quit IRC | 23:51 | |
| *** rods has quit IRC | 23:51 | |
| *** ianw has quit IRC | 23:51 | |
| *** TheJulia has quit IRC | 23:51 | |
| *** samueldmq has quit IRC | 23:51 | |
| *** mgagne has quit IRC | 23:51 | |
| *** mrhillsman has quit IRC | 23:51 | |
| *** pabelanger has quit IRC | 23:51 | |
| *** rcarrillocruz has quit IRC | 23:51 | |
| *** ChanServ has quit IRC | 23:51 | |
| *** cmurphy has quit IRC | 23:51 | |
| *** melwitt has quit IRC | 23:51 | |
| *** dtroyer has quit IRC | 23:51 | |
| *** mordred has quit IRC | 23:51 | |
| *** kmalloc has quit IRC | 23:51 | |
| *** GheRivero has quit IRC | 23:51 | |
| *** kmalloc has joined #openstack-shade | 23:55 | |
| *** DuncanT has joined #openstack-shade | 23:55 | |
| *** mordred has joined #openstack-shade | 23:55 | |
| *** dtroyer has joined #openstack-shade | 23:55 | |
| *** rods has joined #openstack-shade | 23:55 | |
| *** gouthamr has joined #openstack-shade | 23:55 | |
| *** noshankus has joined #openstack-shade | 23:55 | |
| *** spredzy has joined #openstack-shade | 23:55 | |
| *** calebb has joined #openstack-shade | 23:55 | |
| *** TheJulia has joined #openstack-shade | 23:55 | |
| *** jeblair has joined #openstack-shade | 23:55 | |
| *** ianw has joined #openstack-shade | 23:55 | |
| *** larainema has joined #openstack-shade | 23:55 | |
| *** olaph has joined #openstack-shade | 23:55 | |
| *** thingee has joined #openstack-shade | 23:55 | |
| *** dhellmann has joined #openstack-shade | 23:55 | |
| *** jamielennox has joined #openstack-shade | 23:55 | |
| *** Shrews has joined #openstack-shade | 23:55 | |
| *** samueldmq has joined #openstack-shade | 23:55 | |
| *** cmurphy has joined #openstack-shade | 23:55 | |
| *** melwitt has joined #openstack-shade | 23:55 | |
| *** jlk has joined #openstack-shade | 23:55 | |
| *** mgagne has joined #openstack-shade | 23:55 | |
| *** zigo has joined #openstack-shade | 23:55 | |
| *** mrhillsman has joined #openstack-shade | 23:55 | |
| *** GheRivero has joined #openstack-shade | 23:55 | |
| *** ChanServ has joined #openstack-shade | 23:56 | |
| *** tepper.freenode.net sets mode: +o ChanServ | 23:56 | |
| *** openstackgerrit has joined #openstack-shade | 23:56 | |
| *** yolanda has joined #openstack-shade | 23:56 | |
| *** lastmikoi has joined #openstack-shade | 23:56 | |
| *** pabelanger has joined #openstack-shade | 23:56 | |
| *** rcarrillocruz has joined #openstack-shade | 23:56 | |
| *** ChanServ has quit IRC | 23:56 | |
| *** lastmikoi has quit IRC | 23:57 | |
| *** rods has quit IRC | 23:57 | |
| *** ianw has quit IRC | 23:57 | |
| *** pabelanger has quit IRC | 23:57 | |
| *** rcarrillocruz has quit IRC | 23:57 | |
| *** openstackgerrit has quit IRC | 23:57 | |
| *** yolanda has quit IRC | 23:57 | |
| *** kmalloc has quit IRC | 23:57 | |
| *** DuncanT has quit IRC | 23:57 | |
| *** gouthamr has quit IRC | 23:57 | |
| *** calebb has quit IRC | 23:57 | |
| *** thingee has quit IRC | 23:57 | |
| *** Shrews has quit IRC | 23:57 | |
| *** GheRivero has quit IRC | 23:57 | |
| *** dtroyer has quit IRC | 23:57 | |
| *** spredzy has quit IRC | 23:57 | |
| *** larainema has quit IRC | 23:57 | |
| *** jamielennox has quit IRC | 23:57 | |
| *** noshankus has quit IRC | 23:57 | |
| *** olaph has quit IRC | 23:57 | |
| *** zigo has quit IRC | 23:57 | |
| *** jeblair has quit IRC | 23:57 | |
| *** jlk has quit IRC | 23:57 | |
| *** mordred has quit IRC | 23:57 | |
| *** dhellmann has quit IRC | 23:57 | |
| *** TheJulia has quit IRC | 23:57 | |
| *** samueldmq has quit IRC | 23:57 | |
| *** mgagne has quit IRC | 23:57 | |
| *** mrhillsman has quit IRC | 23:57 | |
| *** cmurphy has quit IRC | 23:57 | |
| *** melwitt has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!