*** rods has quit IRC | 00:18 | |
openstackgerrit | Sam Yaple proposed openstack-infra/shade master: Allow domain_id for roles https://review.openstack.org/496992 | 00:32 |
---|---|---|
*** olaph1 has joined #openstack-shade | 00:38 | |
*** olaph has quit IRC | 00:38 | |
SamYaple | mordred: ok. patches are now passing the gate. the highest priority ones for me are https://review.openstack.org/#/c/497483/ https://review.openstack.org/#/c/497537/ | 00:38 |
SamYaple | i abandonded that user_domain/project_domain/group_domain patch for now, ill also have to include role_domain and i dont absolutely need it right this second. ill circle back around to it | 00:39 |
*** olaph1 is now known as olaf | 00:45 | |
*** olaf is now known as olaph | 00:45 | |
htaccess | having only used shade via ansible (a lot) and using per project libs or the unified client from python | 01:56 |
htaccess | i am now using shade directly in python | 01:56 |
htaccess | and i have to say I'm liking it a _lot_ | 01:57 |
htaccess | would be nice if list_keypairs() supported filters to be consistent with other list_ methods | 02:02 |
openstackgerrit | Merged openstack-infra/shade master: Fix switched params https://review.openstack.org/498132 | 02:16 |
*** gouthamr has quit IRC | 02:46 | |
*** gkadam_ has joined #openstack-shade | 03:33 | |
openstackgerrit | Merged openstack-infra/shade master: De-client-ify Service Delete https://review.openstack.org/482197 | 05:01 |
*** yolanda has quit IRC | 05:21 | |
*** yfried has joined #openstack-shade | 06:44 | |
*** slaweq has joined #openstack-shade | 06:50 | |
*** slaweq has quit IRC | 06:55 | |
*** yolanda has joined #openstack-shade | 06:57 | |
*** jamielennox has quit IRC | 07:09 | |
*** jamielennox has joined #openstack-shade | 07:14 | |
*** ioggstream has joined #openstack-shade | 07:44 | |
*** thrash|g0ne is now known as thrash | 10:42 | |
*** rods_ has joined #openstack-shade | 11:50 | |
*** gkadam_ has quit IRC | 11:54 | |
*** olaph has quit IRC | 12:07 | |
*** Shrews has quit IRC | 12:07 | |
*** thrash has quit IRC | 12:07 | |
*** mrhillsman has quit IRC | 12:07 | |
*** olaph has joined #openstack-shade | 12:22 | |
*** Shrews has joined #openstack-shade | 12:22 | |
*** thrash has joined #openstack-shade | 12:22 | |
*** mrhillsman has joined #openstack-shade | 12:22 | |
openstackgerrit | Monty Taylor proposed openstack/oaktree master: Add zuul v3 job to trigger readthedocs https://review.openstack.org/498905 | 12:37 |
mordred | htaccess: yay glad to hear that! | 12:38 |
mordred | htaccess: give search_keypairs a shot | 12:39 |
*** slaweq has joined #openstack-shade | 12:41 | |
*** gouthamr has joined #openstack-shade | 13:19 | |
openstackgerrit | Merged openstack-infra/shade master: Support domain_id for user operations https://review.openstack.org/497483 | 13:27 |
openstackgerrit | Merged openstack-infra/shade master: Add domain_id to groups https://review.openstack.org/497537 | 13:28 |
*** rods_ has quit IRC | 14:21 | |
*** rods has joined #openstack-shade | 14:21 | |
*** rods has quit IRC | 14:22 | |
*** rods has joined #openstack-shade | 14:22 | |
*** rods has quit IRC | 14:31 | |
*** olaph1 has joined #openstack-shade | 14:31 | |
*** olaph has quit IRC | 14:32 | |
*** rods has joined #openstack-shade | 14:32 | |
*** rods has quit IRC | 14:41 | |
*** slaweq has quit IRC | 14:55 | |
*** slaweq has joined #openstack-shade | 14:55 | |
*** slaweq has quit IRC | 15:00 | |
SamYaple | w00t. mordred im ready for a tag on shade if you are. the search users in domains was the biggest blocker | 15:07 |
*** slaweq has joined #openstack-shade | 15:19 | |
*** slaweq has quit IRC | 15:23 | |
*** olaph has joined #openstack-shade | 15:26 | |
*** olaph1 has quit IRC | 15:27 | |
*** gouthamr has quit IRC | 15:53 | |
*** gouthamr has joined #openstack-shade | 16:16 | |
*** rods has joined #openstack-shade | 16:35 | |
*** gkadam_ has joined #openstack-shade | 16:57 | |
openstackgerrit | Merged openstack-infra/shade master: Switch to _is_client_version in list_services https://review.openstack.org/497171 | 17:17 |
SamYaple | w00t | 17:17 |
*** ioggstream has quit IRC | 17:28 | |
*** gkadam_ has quit IRC | 18:01 | |
*** gouthamr has quit IRC | 18:28 | |
*** yfried has quit IRC | 18:32 | |
*** gouthamr has joined #openstack-shade | 18:44 | |
*** slaweq has joined #openstack-shade | 19:31 | |
*** slaweq has quit IRC | 19:31 | |
*** slaweq has joined #openstack-shade | 19:32 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify User Update https://review.openstack.org/499284 | 19:55 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify User Update https://review.openstack.org/499284 | 19:57 |
*** slaweq has quit IRC | 20:50 | |
*** slaweq has joined #openstack-shade | 20:52 | |
*** gouthamr has quit IRC | 20:54 | |
slaweq | mordred: hello | 21:10 |
slaweq | mordred: how are You? | 21:10 |
slaweq | mordred: can You maybe take a look on https://review.openstack.org/#/c/498918/ and https://review.openstack.org/#/c/498925/ and check if those patches makes sense for You? | 21:10 |
*** gouthamr has joined #openstack-shade | 21:10 | |
mordred | slaweq: hello! yes - those both look great - although the gate is unhappy with the compute one | 21:12 |
slaweq | yes, I'm rechecking it now | 21:13 |
slaweq | yesterday it failed because some volume was not removed but it was in test, not in cleanup so I can't do anything with that | 21:13 |
slaweq | and now it failed because of reason which should be fixed by second patch :) | 21:13 |
mordred | :) | 21:14 |
slaweq | mordred: but I will try to keep looking on such errors and fix some of them if it will be possible | 21:15 |
mordred | sweet - I appreciate that a lot - flaky test runs that are just due to the cloud not being able to delete a volume are no good | 21:17 |
slaweq | yes, I agree :) | 21:18 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Add User to Group https://review.openstack.org/499345 | 21:28 |
mordred | samueldmq: ksa 3.2.0 has been released and is working its way through requirements/constraints - as soon as that lands, we should be able to land the 'use ksa 3.2 version discovery' patch | 21:38 |
samueldmq | mordred: that's great!! | 21:39 |
samueldmq | meanwhile I am working on the rest of those keystone patches (restification) | 21:39 |
samueldmq | I'm pretty sure those are finite :-) | 21:40 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Check User in Group https://review.openstack.org/499357 | 21:47 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Remove User from Group https://review.openstack.org/499360 | 21:50 |
openstackgerrit | Merged openstack-infra/shade master: Fix handling timeouts in volume functional tests cleanup https://review.openstack.org/498918 | 21:55 |
samueldmq | mordred: I'm having a hard time understanding the endpoint crud in shade | 22:03 |
samueldmq | :( | 22:03 |
slaweq | mordred: https://review.openstack.org/#/c/498925/ <-- not jenkins is happy with it :) | 22:04 |
slaweq | *now | 22:04 |
mordred | samueldmq: oh. yeah. ... I think you can blame SamYaple forthat, but it's actually my fault - at this point I believe that the decision to try to make endpoints look the same between v2 and v3 was a mistake, but it's one we're stuck with | 22:05 |
mordred | slaweq: woot1 | 22:05 |
mordred | samueldmq: the short version is - because we want to keep the interface the same, we accept both v2 and v3 style arguments | 22:06 |
mordred | samueldmq: if you give us v2 style arguments but the cloud is v3, we will make 3 calls to keystone one for each type of endpoint | 22:06 |
samueldmq | mordred: and what if I give v3 args and cloud is v2? | 22:07 |
mordred | samueldmq: if you use v3 style arguments on a v2 cloud for anyhting other than public url you get an error | 22:07 |
mordred | because v2 can't update an endpoint | 22:07 |
mordred | so you need to use all three arguments at one time | 22:07 |
samueldmq | mordred: since v2 doesn't have interface, you assume public for that? | 22:08 |
SamYaple | samueldmq: keystone requires public | 22:08 |
SamYaple | admin and internal are optional | 22:08 |
SamYaple | a single endpoint id can have all three | 22:08 |
SamYaple | (in v2) | 22:08 |
mordred | well - if you want to use v3 arguments on a v2 cloud, you basically must pass 'public' to the interface argument | 22:08 |
mordred | https://github.com/openstack-infra/shade/blob/master/shade/operatorcloud.py#L923 | 22:08 |
mordred | SamYaple: yah | 22:08 |
mordred | the short version is - as a user you should really use the arguments for your keystone version - which is MUCH more reasonable for endpoint because as an operator it's totally reasonable to know which version you are running | 22:09 |
SamYaple | yea i regret the endpoint stuff | 22:09 |
mordred | (this is an area where I pushed too far for consistency and the end result was, I think, not good) | 22:09 |
SamYaple | but meh | 22:09 |
mordred | yup | 22:10 |
mordred | I believe I have learned something from it | 22:10 |
SamYaple | its the reason we still dont have an ansible_endpoint module | 22:10 |
SamYaple | plus im kinda lazy | 22:10 |
mordred | yah | 22:10 |
mordred | SamYaple: you know - what we should do is make an os_keystone_endpoint and an os_keystone_v2_endpoint module | 22:11 |
mordred | SamYaple: and NOT expose this interface through to ansible | 22:11 |
samueldmq | keystone v2 endpoint create already does "Create three v3 endpoint refs based on a legacy ref." | 22:11 |
mordred | SamYaple: and you should either do the same in salt, or just ignore v2 altogether | 22:11 |
SamYaple | mordred: salt is **kwargs heavy, they get everything! | 22:12 |
mordred | SamYaple: nice | 22:12 |
SamYaple | but i only plan on documenting v3 | 22:12 |
mordred | samueldmq: yes- the complexity here comes from shade allowing both styles of arguments no matter which version you have on the backend | 22:12 |
mordred | SamYaple: yes please | 22:12 |
mordred | samueldmq: so you can have a v2 service, and pass url=example.com, interface=public and it will work | 22:13 |
mordred | samueldmq: you can have a v2 service and pass public_url, internal_url and admin_url and it will work | 22:13 |
mordred | SamYaple: you can hav ea v3 service and pass public_url, internal_url and admin_url and it will work by making three calls to keystone service for interface=public, interface=internal and interface=admin | 22:14 |
mordred | gah | 22:14 |
samueldmq | :-) | 22:14 |
mordred | samueldmq: andyou can have a v3 service and use url, interface and it will work | 22:14 |
mordred | the only uthing you cannot do is have a v2 service and make multiple calls to create_endpoint with the url, interface syntax | 22:14 |
samueldmq | mordred: why? | 22:15 |
samueldmq | no updates? for the other *_url? | 22:16 |
samueldmq | the endpoint compatibility code in keystone itself is not easy either | 22:19 |
SamYaple | samueldmq: because using interface= url= can only specify a single type at a time, and v2 requires public | 22:23 |
SamYaple | so you can only create the public endpoint on v2 with the v3 syntax | 22:23 |
samueldmq | SamYaple: ah, and if you do call it agai nwith interface=another_one url=the_same | 22:24 |
SamYaple | the keystone v2.0 api will yell at you in that case | 22:25 |
samueldmq | it wouldnt know if you want to create another endpoint or add info to the existing one | 22:25 |
samueldmq | hmm ok | 22:25 |
SamYaple | samueldmq: you can't update keystone v2 enpoints at all | 22:25 |
SamYaple | i dont think there were any 'updates' to anything in v2 keystone (but i could be wrong) | 22:26 |
samueldmq | SamYaple: aha, that's what I thought. otherwise you could update and just add the other *_url | 22:26 |
samueldmq | interface=public url=xpto; interface=admin url=xpto; interface=internal url=xpto | 22:27 |
samueldmq | those 3 calls could result in a single v2 endpoint, but that's not possible at all (without updates) | 22:27 |
SamYaple | i think we are on the same page, yes | 22:28 |
samueldmq | kk nice thanks | 22:28 |
SamYaple | i almost want a create_endpoint_2() shade function :( | 22:29 |
*** slaweq has quit IRC | 22:30 | |
*** rods has quit IRC | 22:31 | |
SamYaple | actually. you know its not that bad. | 22:32 |
SamYaple | if using it with v3, you get a list with one element | 22:32 |
SamYaple | thats ok | 22:32 |
*** rods has joined #openstack-shade | 22:34 | |
openstackgerrit | Merged openstack-infra/shade master: Add handling timeout in servers cleanup function https://review.openstack.org/498925 | 22:49 |
*** thrash is now known as thrash|g0ne | 23:11 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!