| *** gouthamr has quit IRC | 02:08 | |
| *** gkadam has joined #openstack-shade | 02:15 | |
| *** gkadam has quit IRC | 02:17 | |
| *** gkadam has joined #openstack-shade | 02:18 | |
| TheJulia | mordred: two questions: If I'm creating discovery fixture data, is it just the main version, or should there be a version for relevant microversions to match (mainly asking because the context gain seems to be huge otherwise). Second question, any hints on getting all of the required fixture data in-place. As far as I can tell I have everything in place based on the example, and a few other examples, but yet | 02:41 |
|---|---|---|
| TheJulia | requests_mock.exceptions.NoMockAddress is all I seem to get back when I call something like op_cloud.list_machines (hence the feeling I'm missing something, somewhere....). | 02:41 |
| *** slaweq has joined #openstack-shade | 04:03 | |
| *** slaweq has quit IRC | 04:08 | |
| *** ioggstream has joined #openstack-shade | 07:18 | |
| *** slaweq has joined #openstack-shade | 07:29 | |
| *** slaweq_ has joined #openstack-shade | 08:04 | |
| *** slaweq_ has quit IRC | 08:08 | |
| *** ioggstream has quit IRC | 09:38 | |
| *** Shrews has quit IRC | 10:16 | |
| *** ioggstream has joined #openstack-shade | 10:29 | |
| *** Shrews has joined #openstack-shade | 10:43 | |
| *** gkadam has quit IRC | 10:57 | |
| *** ioggstream has quit IRC | 11:09 | |
| *** thrash|g0ne is now known as thrash | 11:39 | |
| *** ioggstream has joined #openstack-shade | 12:29 | |
| *** thrash is now known as thrash|biab | 12:50 | |
| *** gouthamr has joined #openstack-shade | 13:13 | |
| *** thrash|biab is now known as thrash | 13:22 | |
| mordred | TheJulia: good questions ... we haven't done a microversion test yet - so I think for now just main version | 14:16 |
| mordred | TheJulia: can you push up what you've got re: fixture data? | 14:16 |
| TheJulia | well, not even that far yet :( | 14:16 |
| TheJulia | yeah, give me a couple to clean it up and I'll push it | 14:17 |
| TheJulia | actually, fixture data is already there unless discovery is in use | 14:20 |
| TheJulia | anyway, pushing tests in a minute | 14:20 |
| mordred | indeed - but discovery will pretty much always need to be there for ironic since microversions - I've got a patch to add the plumbing for that | 14:24 |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: Correct baremetal fake data model https://review.openstack.org/500846 | 14:28 |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: WIP: Begin converting baremetal node tests https://review.openstack.org/500847 | 14:28 |
| TheJulia | mordred: agreed, but not needed to start out updating the testing at the moment | 14:30 |
| mordred | TheJulia: oh - interesting ... I think I see what you're hitting ... | 14:34 |
| TheJulia | Good, or bad? | 14:36 |
| mordred | TheJulia: ok - several things, one of which makes me mildly stabby | 14:48 |
| TheJulia | rutro | 14:49 |
| mordred | but lemme finish a patch real quick, then I'll rant for a sec | 14:49 |
| TheJulia | okay | 14:49 |
| mordred | TheJulia: SO ... there are two interelated issues so far | 15:09 |
| mordred | TheJulia: the first is that ironicclient just appends a /v1 to the end of the endpoint from the catalog, which we copy for parity sake in baremetal_client | 15:09 |
| mordred | itdoes this to avoid discovery calls, since there is only one major version of ironic anyway | 15:09 |
| mordred | that would be mostly fine ... | 15:10 |
| mordred | EXCEPT - Ihave just discovered that the versioned discovery doc (the thing returned by GET /v1) does look like any of the rest of the versioned discovery docs in openstack, so the discovery support we just added to ksa will break if we do this how we're doing it | 15:11 |
| mordred | since what we've been doing is passing in urljoin(catalog_endpoint, '/v1') to endpoint_override in the constructor | 15:11 |
| mordred | the reason that will break is that when ksa does go to do discovery to find microversion information, it'll do a GET on the URL that we gave it for endpoint_override | 15:11 |
| mordred | and it won't find a version discovery document there | 15:12 |
| mordred | SO ... we have to approach the "make baremetal_client and ironic_client do the same thing WRT discovery" slightly differently | 15:12 |
| mordred | also - I think we need to add a couple of patches to ksa to handle what ironic does pass back, for completeness | 15:12 |
| mordred | patch for that coming in a sec | 15:14 |
| TheJulia | ugh | 15:17 |
| TheJulia | no wonder stabby/ranty :( | 15:17 |
| mordred | yah | 15:24 |
| *** thrash is now known as thrash|biab | 16:04 | |
| mordred | TheJulia: k. I have working updated patch - update coming in just a sec | 16:12 |
| *** ioggstream has quit IRC | 16:22 | |
| * TheJulia is in no rush, ERRTOOMANYDISCUSSIONS | 16:41 | |
| SamYaple | sooo not to bug. but any chance of getting a shade tag? i am stalled at work until i have a new tag | 16:43 |
| SamYaple | ok maybe i mean to bug a little bit | 16:44 |
| openstackgerrit | Merged openstack-infra/shade master: Correct baremetal fake data model https://review.openstack.org/500846 | 16:45 |
| *** thrash|biab is now known as thrash | 17:00 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Remove User from Group https://review.openstack.org/499360 | 17:10 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Remove improper exc handling in is_user_in_group https://review.openstack.org/500560 | 17:10 |
| *** thrash is now known as thrash|bbl | 17:10 | |
| samueldmq | mordred: ^ rebasing to see if jenkins get happier | 17:11 |
| samueldmq | not conflict. not sure what the merging issue was | 17:11 |
| mordred | samueldmq: yah - there was an issue with zuulv3 that was my fault | 17:11 |
| samueldmq | mordred: is it all fixed now ? | 17:12 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify User Password Update https://review.openstack.org/500930 | 17:19 |
| *** gouthamr has quit IRC | 17:32 | |
| samueldmq | mordred: when you say | 17:34 |
| samueldmq | "When this changes to REST, force interface=admin in the adapter call" | 17:34 |
| samueldmq | are you referring to identity v2.0 calls only ? | 17:34 |
| samueldmq | or is there a reasoning to force admin interface in v3 calls as well? | 17:34 |
| SamYaple | in v3 the 5000 and 35357 provide the same funcationlity (i actually only run v3 and only run one service on port 5000) | 17:36 |
| SamYaple | is that refering to the endpoint to choose? | 17:36 |
| SamYaple | because i use internal and public differently. i thought that info was pulled through OSCC | 17:36 |
| samueldmq | SamYaple: that's a good question. I guess 35357 is what we refer to when enforcing admin interface in v2.0 | 17:40 |
| samueldmq | they even had different behaviors depending on the admin vs "normal" endpoint | 17:41 |
| SamYaple | afaik only keystone v2.0 is like that. definetely not keystone v3, and i dont think any other service acts like that | 17:41 |
| samueldmq | so I think forcing admin in the adapter call is for v2.0 only, so we make sure to use the right endpoint (with that specific port) | 17:41 |
| samueldmq | SamYaple: I agree | 17:42 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint Delete https://review.openstack.org/500943 | 17:51 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint Delete https://review.openstack.org/500943 | 17:56 |
| *** thrash|bbl is now known as thrash | 17:57 | |
| *** gouthamr has joined #openstack-shade | 17:59 | |
| mordred | samueldmq: v2 only | 18:19 |
| mordred | samueldmq: and for the reason samueldmq mentioned | 18:19 |
| mordred | gah | 18:19 |
| mordred | SamYaple: | 18:19 |
| * mordred gives up typing | 18:20 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Begin converting baremetal node tests https://review.openstack.org/500847 | 18:43 |
| mordred | TheJulia: ^^ that fixes the things that needed to be fixed and adds a base class for you that might reduce typing just a smidge | 18:44 |
| SamYaple | am i the only one that likes mindless typing from time to time? | 18:44 |
| TheJulia | mordred: ooohhh! thanks! | 18:44 |
| mordred | SamYaple: oh - I LOVE mindless typing from time to time :) | 18:44 |
| SamYaple | niiice | 18:45 |
| mordred | TheJulia: I also found a bug in ksa around version discovery which is sadmaking for ironic/bifrost, as both the shiny new 'none' plugin and the old hack we used of 'admin_token' are both missing methods | 18:45 |
| mordred | TheJulia: I have a patch to ksa to fix it, and the shade patch above works both with patched and unpatched | 18:45 |
| *** dtroyer has quit IRC | 19:00 | |
| *** dtroyer has joined #openstack-shade | 19:01 | |
| TheJulia | sigh | 19:04 |
| TheJulia | again thanks! | 19:04 |
| *** slaweq_ has joined #openstack-shade | 19:21 | |
| *** slaweq_ has quit IRC | 19:34 | |
| *** slaweq_ has joined #openstack-shade | 19:35 | |
| *** ioggstream has joined #openstack-shade | 19:38 | |
| *** slaweq_ has quit IRC | 20:57 | |
| *** slaweq_ has joined #openstack-shade | 20:58 | |
| *** gouthamr has quit IRC | 21:05 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify User Password Update https://review.openstack.org/500930 | 21:23 |
| samueldmq | mordred: ^ I was getting a pep8 error on that | 21:23 |
| samueldmq | "_tasks imported but not used" in openstackcloud | 21:23 |
| samueldmq | that's a good error to see isn't it? | 21:24 |
| SamYaple | yes! | 21:24 |
| samueldmq | :) | 21:24 |
| mordred | samueldmq: \o/ | 21:24 |
| samueldmq | we still need to get rid of it in operatorcloud | 21:25 |
| samueldmq | but that's some progress, yes | 21:25 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint Delete https://review.openstack.org/500943 | 21:27 |
| SamYaple | good progress | 21:27 |
| SamYaple | for sure | 21:27 |
| *** slaweq_ has quit IRC | 21:57 | |
| openstackgerrit | Merged openstack-infra/shade master: De-client-ify Remove User from Group https://review.openstack.org/499360 | 22:16 |
| *** gouthamr has joined #openstack-shade | 23:16 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Role Grant and Revoke https://review.openstack.org/501039 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!