| *** slaweq has joined #openstack-shade | 00:39 | |
| *** slaweq has quit IRC | 00:44 | |
| *** rods has quit IRC | 01:16 | |
| *** thrash is now known as thrash|g0ne | 01:27 | |
| *** slaweq has joined #openstack-shade | 01:40 | |
| *** slaweq has quit IRC | 01:45 | |
| *** slaweq has joined #openstack-shade | 02:41 | |
| *** slaweq has quit IRC | 02:46 | |
| *** slaweq has joined #openstack-shade | 03:42 | |
| *** slaweq has quit IRC | 03:47 | |
| *** gkadam has joined #openstack-shade | 03:49 | |
| *** yolanda has quit IRC | 04:15 | |
| *** gouthamr has quit IRC | 04:31 | |
| *** slaweq has joined #openstack-shade | 05:44 | |
| *** slaweq has quit IRC | 05:49 | |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: Migrate additional machine tests https://review.openstack.org/501576 | 06:16 |
|---|---|---|
| *** yfried has joined #openstack-shade | 06:42 | |
| *** slaweq has joined #openstack-shade | 06:45 | |
| *** slaweq has quit IRC | 06:50 | |
| *** umbSublime has left #openstack-shade | 06:56 | |
| *** gkadam is now known as gkadam-afk | 07:03 | |
| *** slaweq has joined #openstack-shade | 07:11 | |
| *** slaweq has quit IRC | 07:16 | |
| *** ioggstream has joined #openstack-shade | 07:54 | |
| *** rods has joined #openstack-shade | 08:08 | |
| *** slaweq has joined #openstack-shade | 08:12 | |
| *** slaweq has quit IRC | 08:17 | |
| *** slaweq has joined #openstack-shade | 09:13 | |
| *** rods has quit IRC | 09:15 | |
| *** slaweq has quit IRC | 09:18 | |
| *** gkadam_ has joined #openstack-shade | 09:34 | |
| *** gkadam-afk has quit IRC | 09:36 | |
| *** rods has joined #openstack-shade | 10:01 | |
| *** slaweq has joined #openstack-shade | 10:14 | |
| *** slaweq has quit IRC | 10:19 | |
| *** gkadam__ has joined #openstack-shade | 11:05 | |
| *** gkadam_ has quit IRC | 11:07 | |
| *** slaweq has joined #openstack-shade | 11:15 | |
| *** ioggstream has quit IRC | 11:17 | |
| *** slaweq has quit IRC | 11:20 | |
| *** rods has quit IRC | 11:23 | |
| *** rods has joined #openstack-shade | 11:23 | |
| *** rods has quit IRC | 11:24 | |
| *** rods has joined #openstack-shade | 11:24 | |
| *** rods has quit IRC | 11:25 | |
| *** rods has joined #openstack-shade | 11:25 | |
| *** thrash|g0ne is now known as thrash | 11:40 | |
| *** slaweq has joined #openstack-shade | 12:16 | |
| *** slaweq has quit IRC | 12:21 | |
| *** rods has quit IRC | 12:23 | |
| *** rods has joined #openstack-shade | 12:23 | |
| *** rods has quit IRC | 12:28 | |
| *** gkadam__ has quit IRC | 12:40 | |
| *** slaweq has joined #openstack-shade | 13:17 | |
| *** slaweq has quit IRC | 13:22 | |
| *** gouthamr has joined #openstack-shade | 13:30 | |
| *** slaweq has joined #openstack-shade | 13:33 | |
| *** slaweq has quit IRC | 13:33 | |
| *** yfried has quit IRC | 14:18 | |
| *** slaweq has joined #openstack-shade | 14:34 | |
| *** slaweq has quit IRC | 14:39 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Convert test_baremetal_machine_patch to testscenarios https://review.openstack.org/501768 | 15:19 |
| mordred | TheJulia: your patch looks great - I made this ^^ just to illustrate use of testscenarios for such a thing, in case that was a thing you weren't aware of | 15:19 |
| TheJulia | mordred: oohhhhh | 15:21 |
| TheJulia | mordred: although some of those fields are not changable, nor even exist if I think | 15:22 |
| TheJulia | oh wait | 15:23 |
| TheJulia | I get it | 15:23 |
| mordred | it's a magic thing- the first param in the list is what gets appended to the test method name - the other things are added to the test as self attributes | 15:24 |
| mordred | pile of black magic | 15:24 |
| TheJulia | I was just about to say it looks like a pile of black magic | 15:25 |
| mordred | :) | 15:25 |
| mordred | it can be handy for cases like this where it's one test with a pile of different options | 15:26 |
| TheJulia | yeah, it makes ton of sense | 15:26 |
| mordred | TheJulia: I'm happy to either land it if it reads well to you or abandon it and keep the tests as you had them - whichever works for me | 15:26 |
| TheJulia | it reads really well to me, I do feel like putting a note in describing what is occurring, but it just my habit to be verbose for context. I can do that in a later rev | 15:27 |
| *** slaweq has joined #openstack-shade | 15:35 | |
| mordred | kk cool | 15:38 |
| *** slaweq has quit IRC | 15:40 | |
| openstackgerrit | Merged openstack-infra/shade master: Migrate additional machine tests https://review.openstack.org/501576 | 16:18 |
| *** slaweq has joined #openstack-shade | 16:37 | |
| *** slaweq has quit IRC | 16:41 | |
| TheJulia | out of curiosity, anything shade specific discussions at the ptg? | 16:44 |
| TheJulia | s/anything/any/ | 16:44 |
| mordred | TheJulia: there's gonna be some discussions on tuesday I tihnk in the OSC room with dtroyer | 16:47 |
| mordred | TheJulia: main topic up for in-person discussion for htat is, I believe, my proposal to merge openstacksdk and shade :) | 16:48 |
| mordred | TheJulia: I also expect to sit down with samueldmq and chat about oaktree at some point | 16:48 |
| TheJulia | mordred: I just noticed the etherpad was empty :\ hence why I asked | 16:49 |
| SamYaple | mordred: ive been telling people to use shade over openstacksdk for quite a while now. so +2 to that | 16:52 |
| samueldmq | mordred: o/ | 16:55 |
| samueldmq | that'd be great | 16:55 |
| mordred | SamYaple: dunno if you saw my mailng list post froma while back, but basic issue is that openstacksdk isn't even an official project, but its name makes people think it is - plus the folks who were funding the devs to work on it have a much lower level of interest in funding that now | 16:55 |
| mordred | SamYaple: otoh - there actually IS some good stuff in there that I think can improve some of what we're doing at the shade level | 16:56 |
| SamYaple | i did not see that ML post, but i can believe that | 16:56 |
| SamYaple | it shocks alot of people coming into openstack that there is no one-true SDK for it | 16:56 |
| mordred | and - if we made a new object like "openstack.cloud.OpenStackCloud" that had all the methods we have in shade - but with the various lessons we've learned but can't fix because of backwards compat fixed | 16:57 |
| SamYaple | i normally point them at shade and they are happy | 16:57 |
| SamYaple | .... would that mean scraping shade? | 16:57 |
| mordred | then we couldmake shade.OpenStackCloud a thin-wrapper around that objet that just swaps defaults and whatnot to keep people using it through the shade namespace from breaking | 16:57 |
| SamYaple | oh i see. hmmm | 16:58 |
| SamYaple | i mean i would like to learn from shade mistakes for sure... | 16:58 |
| mordred | SamYaple: it's a question - do we take it over as a low-level library and make the needed changes so that it could essentially take th eplace of shade/_adapter.py but keep the two separate libs with a requirements relationship | 16:58 |
| mordred | or do we merge the two but make sure we provide a seamless upgrade path for shade users | 16:59 |
| SamYaple | i like the idea of being able to rework shade as openstacksdk and then provide a shade compat lib for openstacksdk | 16:59 |
| mordred | with a shim layer that does argument default or argument order translations but otherwise is passthrough | 16:59 |
| SamYaple | fix "endpoints", have a more unified way to pass context and objects, etc | 16:59 |
| mordred | exactly | 16:59 |
| mordred | we learned a LOT in the last few years | 17:00 |
| SamYaple | indeed | 17:00 |
| mordred | but also not breaking existing users is VERY important | 17:00 |
| SamYaple | that was the whole shade mission, yea | 17:00 |
| samueldmq | mordred: quick question on the create endpoint sorcery | 17:01 |
| * SamYaple hides | 17:01 | |
| mordred | if shade.OpenStackCloud continues to exist and work as today, and we make a new thing called openstack.cloud.OpenStackCloud() that, once you have it is almost identical to shade.OpenStackCloud but has a few diferent defaults or argument orders | 17:01 |
| samueldmq | does EndpointCreate task get args on both v2.0 or v3 format and do the calls accordingly? | 17:01 |
| mordred | then we can make a doc which is "if you want to migrate to use the new namespace, make these 12 changes" | 17:01 |
| SamYaple | samueldmq: it recieves v2 OR v3 args, if its v2 on v3 it will make 3 calls | 17:02 |
| mordred | yes. that's right | 17:02 |
| samueldmq | SamYaple: yeah, but the 3 calls is in the for loop | 17:02 |
| samueldmq | for args in endpoint_args: | 17:03 |
| samueldmq | so EndpointCreate is called 3 times anyways | 17:03 |
| SamYaple | yea good point | 17:03 |
| mordred | oh - yes | 17:03 |
| samueldmq | so it gets args in either v2.0 or v3 formats | 17:03 |
| mordred | sorry - misunderstood the question - yes - if the backend is v3, EndpointCreate will be called 3 times | 17:03 |
| mordred | if the backend is v2 it will only be called once | 17:03 |
| samueldmq | it can get things like 'adminurl': 'https://4560aab8be50452994939569b92d80d7.example.com/' | 17:03 |
| samueldmq | and also 'interface': 'public', 'url': 'https://3d42226d149e41b38b12b036cd937093.example.com/' | 17:04 |
| SamYaple | mordred: if backend is v3 it will be called 4 times, once with the v2 args then three times with the v3 args | 17:04 |
| mordred | SamYaple: wow. that's amazing | 17:04 |
| samueldmq | EndpointCreate is the cherry on the cake :-) | 17:04 |
| SamYaple | i could be wrong, its been a while since i looked at it | 17:04 |
| SamYaple | all i hear is "openstacksdk" | 17:05 |
| samueldmq | SamYaple: mordred: thanks I will take a deeper look at it (again) | 17:05 |
| samueldmq | need to be careful when touching catalog code | 17:06 |
| mordred | SamYaple: yah - unfortunately the way its structured makes it unsuitable for being used as the rest layer for either shade or python-openstackclient | 17:06 |
| SamYaple | yup | 17:07 |
| SamYaple | i say screw v2! let it burn! | 17:07 |
| mordred | SamYaple: which is one of the other reasons for proposing merging the efforts -so that we can go in and make a few invasive breaking changes but do so in a way that makes it VERY suitable for shade/osc | 17:07 |
| *** thrash is now known as thrash|biab | 17:07 | |
| mordred | which, from my pov, is 'ok' as there is not yet a v1 of sdk | 17:08 |
| SamYaple | yea ive been wanting a way to do some breaking shade changes that didnt involve create_endpoint2() | 17:08 |
| mordred | SamYaple: https://review.openstack.org/#/c/501438/1/SHADE-MERGE-TODO.rst is what I've written up so far - that's also at the end of a long stack of non-functional patches that make most of the needed sdk changes | 17:09 |
| SamYaple | +1 | 17:11 |
| SamYaple | you know, even with the mistakes that are being carried forward.... shade is pretty clean still | 17:11 |
| mordred | SamYaple: one of the wins is that sdk has a much richer system availble for doing what we do in shade/_normalization.py - and I think theirs allows de-normalizing back to the parameters the cloud knows about | 17:12 |
| SamYaple | if we could button up a few of the glaring ones, it would be really nice | 17:12 |
| mordred | yup | 17:12 |
| SamYaple | i would like to see an improvement and standardization on how we pass objects around. if i want to create a user and have a domain and project objects then it should be a single PUT, all operations should be like that | 17:13 |
| SamYaple | we have patchy support for that right now | 17:13 |
| SamYaple | im getting kind of excited | 17:14 |
| *** gouthamr has quit IRC | 17:33 | |
| *** slaweq has joined #openstack-shade | 17:38 | |
| SamYaple | mordred: just promise me in openstacksdshade we are going to disable v2 syntax on v3 api | 17:41 |
| SamYaple | i would even opt for entirely diffrent functions | 17:42 |
| *** slaweq has quit IRC | 17:43 | |
| samueldmq | SamYaple: mordred: our code is weird for endpoints | 17:45 |
| samueldmq | see https://github.com/openstack-infra/shade/blob/master/shade/operatorcloud.py#L921 | 17:46 |
| samueldmq | then L937, then L948 | 17:46 |
| samueldmq | L948 will never evaluate to true | 17:46 |
| SamYaple | samueldmq: not true! | 17:47 |
| SamYaple | see L947 | 17:47 |
| samueldmq | SamYaple: aha! | 17:48 |
| SamYaple | youre welcome | 17:48 |
| samueldmq | SamYaple: thanks :) | 17:48 |
| SamYaple | variable reuse ftw! | 17:48 |
| SamYaple | (sorry bout that) | 17:48 |
| samueldmq | I'm getting old maybe | 17:48 |
| samueldmq | no worries | 17:48 |
| SamYaple | no its shitty code | 17:48 |
| SamYaple | im sorry iwrote it | 17:48 |
| *** thrash|biab is now known as thrash | 17:57 | |
| *** gouthamr has joined #openstack-shade | 18:01 | |
| *** slaweq has joined #openstack-shade | 18:39 | |
| *** olaph has quit IRC | 18:40 | |
| *** olaph has joined #openstack-shade | 18:41 | |
| *** slaweq has quit IRC | 18:43 | |
| *** slaweq has joined #openstack-shade | 19:12 | |
| mordred | SamYaple: I'm sorry I asked you to write it too | 19:36 |
| *** olaph1 has joined #openstack-shade | 19:40 | |
| *** olaph has quit IRC | 19:42 | |
| SamYaple | mordred: are you trying to say you should have asked someone else to write it instead of me? | 21:09 |
| SamYaple | do you think youre better than me? NOBODY IS BETTER THAN ME | 21:09 |
| mordred | :) | 21:12 |
| *** slaweq has quit IRC | 21:27 | |
| *** slaweq has joined #openstack-shade | 21:27 | |
| *** slaweq has quit IRC | 21:32 | |
| *** slaweq has joined #openstack-shade | 21:41 | |
| *** slaweq has quit IRC | 21:43 | |
| *** slaweq has joined #openstack-shade | 21:44 | |
| *** slaweq has quit IRC | 21:44 | |
| *** slaweq has joined #openstack-shade | 21:46 | |
| *** slaweq has quit IRC | 21:56 | |
| *** gouthamr has quit IRC | 23:09 | |
| *** slaweq has joined #openstack-shade | 23:58 | |
| *** gouthamr has joined #openstack-shade | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!