openstackgerrit | Merged openstack-infra/shade master: De-client-ify Role Grant and Revoke https://review.openstack.org/501039 | 00:47 |
---|---|---|
*** gouthamr has joined #openstack-shade | 02:49 | |
*** gkadam has joined #openstack-shade | 03:24 | |
*** gouthamr has quit IRC | 03:54 | |
*** gouthamr has joined #openstack-shade | 03:54 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add devstack jobs for zuul v3 https://review.openstack.org/500365 | 05:06 |
*** gkadam is now known as gkadam-afk | 05:55 | |
*** ioggstream has joined #openstack-shade | 07:12 | |
*** gouthamr has quit IRC | 07:15 | |
*** gkadam-afk is now known as gkadam | 07:46 | |
*** fbaca_ has joined #openstack-shade | 08:13 | |
*** fbaca_ is now known as fbaca | 08:13 | |
*** noshankus has quit IRC | 08:22 | |
*** yolanda has joined #openstack-shade | 11:50 | |
*** gkadam has quit IRC | 12:36 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add devstack jobs for zuul v3 https://review.openstack.org/500365 | 13:12 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add method to set bootable flag on volumes https://review.openstack.org/502479 | 14:27 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add method to set bootable flag on volumes https://review.openstack.org/502479 | 14:32 |
openstackgerrit | Merged openstack-infra/shade master: De-client-ify List Roles for User in v2.0 https://review.openstack.org/501186 | 14:41 |
openstackgerrit | Merged openstack-infra/shade master: De-client-ify Endpoint List https://review.openstack.org/501200 | 14:41 |
*** slaweq has joined #openstack-shade | 14:52 | |
*** slaweq_ has joined #openstack-shade | 14:54 | |
*** slaweq has quit IRC | 14:56 | |
*** rods has joined #openstack-shade | 14:57 | |
*** slaweq_ has quit IRC | 15:07 | |
*** yolanda has quit IRC | 15:11 | |
*** slaweq has joined #openstack-shade | 15:13 | |
*** yolanda has joined #openstack-shade | 15:16 | |
*** yolanda has quit IRC | 15:16 | |
*** yolanda has joined #openstack-shade | 15:16 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add method to set bootable flag on volumes https://review.openstack.org/502479 | 15:19 |
*** gouthamr has joined #openstack-shade | 15:42 | |
*** gouthamr has quit IRC | 15:46 | |
*** squid is now known as calebb | 15:47 | |
*** gouthamr has joined #openstack-shade | 15:48 | |
*** gouthamr has quit IRC | 15:49 | |
*** gouthamr has joined #openstack-shade | 15:52 | |
*** yolanda has quit IRC | 15:55 | |
*** gouthamr has quit IRC | 16:11 | |
*** yolanda has joined #openstack-shade | 16:13 | |
samueldmq | mordred: can we get rid of https://github.com/openstack-infra/shade/blob/3e07162bfff5b7c397500422ffb8690649a78135/shade/_legacy_clients.py#L92-L110 ? | 16:16 |
samueldmq | so we'd be able to remove keystoneclient as a dependency | 16:17 |
*** gouthamr has joined #openstack-shade | 16:22 | |
*** rods has quit IRC | 16:22 | |
*** rods has joined #openstack-shade | 16:45 | |
*** slaweq has quit IRC | 16:52 | |
*** slaweq has joined #openstack-shade | 16:56 | |
*** slaweq has quit IRC | 16:56 | |
*** slaweq has joined #openstack-shade | 17:08 | |
mordred | samueldmq: just add a call to self._deprecated_import_check at the top of it | 17:17 |
mordred | samueldmq: so self._deprecated_import_check('keystone') | 17:17 |
mordred | samueldmq: oh - sorry, ignore me | 17:17 |
samueldmq | :-) | 17:17 |
mordred | samueldmq: in the call to "_create_legacy_client( that's already there, add deprecated=True to the call | 17:18 |
openstackgerrit | Merged openstack-infra/shade master: De-client-ify List Role Assignments https://review.openstack.org/501268 | 17:20 |
*** slaweq has quit IRC | 17:25 | |
mordred | 999098 | 17:28 |
samueldmq | mordred: and then when will we be able to get rid of it? next release/cycle? | 17:33 |
*** slaweq has joined #openstack-shade | 17:36 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Deprecate legacy keystone client creation https://review.openstack.org/502518 | 17:37 |
*** slaweq has quit IRC | 17:38 | |
mordred | samueldmq: in that patch! go ahead and delete it :) | 17:40 |
mordred | oh - I mean | 17:41 |
mordred | samueldmq: lemme re-state | 17:41 |
mordred | samueldmq: you can go ahead and remove keystoneclient from requirements.txt | 17:41 |
*** slaweq has joined #openstack-shade | 17:42 | |
*** slaweq has quit IRC | 17:46 | |
samueldmq | mordred: but but ... how is it going to work if I remove it all of a sudden? | 17:51 |
samueldmq | and what is the deprecation thing for in that case (if I'm removing anyways) | 17:51 |
mordred | samueldmq: well - the deprecation thing tells people if they try to use cloud.keystone_client directly (unlikley, but _possible_) that they need to pip install python-keystoneclient themselves | 17:52 |
mordred | samueldmq: people who have already installed shade won't be broken, because upgrading shade won't uninstall keystoneclient all of a sudden | 17:52 |
samueldmq | mordred: aha that's a bit different from what we typically call deprecation but ok | 17:52 |
mordred | but we keep the keystone_client function so that if someone has written something that uses it they can keep using it - they just may need to pip install something first | 17:54 |
mordred | samueldmq: yah - it's maybe using that word strangely :) | 17:54 |
*** gouthamr has quit IRC | 17:54 | |
mordred | samueldmq: do you wanna remove python-keystoneclient in https://review.openstack.org/502518 ? | 17:56 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: Remove keystoneclient dependency https://review.openstack.org/502518 | 17:57 |
samueldmq | mordred: ^ there it is :-) | 17:57 |
samueldmq | yes I do | 17:57 |
*** yolanda has quit IRC | 18:07 | |
* mordred hands samueldmq a large pie | 18:15 | |
*** slaweq has joined #openstack-shade | 18:25 | |
*** slaweq_ has joined #openstack-shade | 18:27 | |
*** slaweq has quit IRC | 18:29 | |
*** slaweq_ has quit IRC | 18:31 | |
*** slaweq has joined #openstack-shade | 18:32 | |
*** slaweq_ has joined #openstack-shade | 18:33 | |
*** slaweq_ has quit IRC | 18:35 | |
*** slaweq has quit IRC | 18:37 | |
*** slaweq_ has joined #openstack-shade | 18:45 | |
*** slaweq has joined #openstack-shade | 18:48 | |
*** slaweq_ has quit IRC | 18:49 | |
*** thrash|g0ne is now known as thrash|ptg | 18:50 | |
*** slaweq_ has joined #openstack-shade | 18:52 | |
*** slaweq has quit IRC | 18:52 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add devstack jobs for zuul v3 https://review.openstack.org/500365 | 18:53 |
*** slaweq_ has quit IRC | 18:53 | |
*** slaweq has joined #openstack-shade | 18:57 | |
*** gouthamr has joined #openstack-shade | 18:59 | |
*** rods has quit IRC | 19:08 | |
*** rods has joined #openstack-shade | 19:09 | |
*** slaweq has quit IRC | 19:21 | |
samueldmq | mordred: \o/ and with that we finish the ksc -> rest bits | 19:25 |
*** yolanda has joined #openstack-shade | 19:28 | |
*** slaweq has joined #openstack-shade | 19:34 | |
*** yolanda has quit IRC | 19:43 | |
*** yolanda_ has joined #openstack-shade | 19:49 | |
*** yolanda_ is now known as yolanda | 19:49 | |
*** kmalloc_ has joined #openstack-shade | 20:16 | |
*** ianw has quit IRC | 20:18 | |
*** kmalloc has quit IRC | 20:24 | |
*** larainema has quit IRC | 20:24 | |
*** kmalloc_ is now known as kmalloc | 20:24 | |
*** openstackgerrit has quit IRC | 20:48 | |
*** slaweq has quit IRC | 20:51 | |
*** ioggstream has quit IRC | 20:51 | |
*** slaweq has joined #openstack-shade | 20:51 | |
*** slaweq has quit IRC | 20:56 | |
*** gouthamr has quit IRC | 21:03 | |
*** slaweq has joined #openstack-shade | 21:17 | |
*** openstackgerrit has joined #openstack-shade | 21:34 | |
*** gouthamr has joined #openstack-shade | 21:42 | |
*** yolanda has quit IRC | 21:57 | |
*** thrash|ptg is now known as thrash|g0ne | 22:07 | |
*** larainema has joined #openstack-shade | 22:13 | |
*** yolanda has joined #openstack-shade | 22:22 | |
*** slaweq has quit IRC | 22:22 | |
*** slaweq has joined #openstack-shade | 22:23 | |
*** slaweq has quit IRC | 22:27 | |
*** slaweq has joined #openstack-shade | 22:29 | |
*** gouthamr has quit IRC | 22:29 | |
*** slaweq has quit IRC | 22:34 | |
*** slaweq has joined #openstack-shade | 22:34 | |
*** slaweq_ has joined #openstack-shade | 22:37 | |
*** slaweq_ has quit IRC | 22:37 | |
*** slaweq has quit IRC | 22:39 | |
*** slaweq has joined #openstack-shade | 23:52 | |
*** slaweq has quit IRC | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!