| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add ability to work in other auth contexts https://review.openstack.org/519394 | 00:13 |
|---|---|---|
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add helper property to get the current user id https://review.openstack.org/519511 | 00:13 |
| *** ioggstream has joined #openstack-shade | 07:35 | |
| *** slaweq has joined #openstack-shade | 09:31 | |
| *** ioggstream has quit IRC | 10:32 | |
| *** gouthamr has joined #openstack-shade | 11:10 | |
| *** gouthamr has quit IRC | 12:05 | |
| *** gouthamr has joined #openstack-shade | 12:20 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add ability to work in other auth contexts https://review.openstack.org/519394 | 12:31 |
| *** gouthamr has quit IRC | 12:53 | |
| *** gouthamr has joined #openstack-shade | 13:02 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add helper property to get the current user id https://review.openstack.org/519511 | 13:19 |
| *** gouthamr has quit IRC | 13:38 | |
| *** gouthamr has joined #openstack-shade | 13:54 | |
| openstackgerrit | Merged openstack/os-client-config master: Add shade-functional-tips jobs https://review.openstack.org/514067 | 14:43 |
| *** gouthamr has quit IRC | 15:13 | |
| *** gouthamr has joined #openstack-shade | 15:15 | |
| *** slaweq has quit IRC | 17:02 | |
| openstackgerrit | Christian Groschupp proposed openstack-infra/shade master: Creating a server and specifying scheduler_hints fails https://review.openstack.org/519705 | 17:20 |
| openstackgerrit | Christian Groschupp proposed openstack-infra/shade master: Fix creating a server with specifying scheduler_hints https://review.openstack.org/519705 | 17:40 |
| Shrews | mordred: Is the old 'internal_network' value on the fip object supposed to be the same as the 'network_id' we now have? | 17:59 |
| Shrews | FIPs give me such headaches | 17:59 |
| Shrews | i guess we just return 'network', not 'network_id' | 18:00 |
| Shrews | hrm, i wonder if that was coming back from neutron as part of 'properties' dict | 18:01 |
| Shrews | don't see that in the api docs | 18:06 |
| Shrews | ok, so 'network' is the external network the fip is on | 18:10 |
| Shrews | i guess we'll have to use the port or the fixed IP to identify the internal net? don't see any direct path to it | 18:12 |
| mordred | Shrews: yah- I believe you have to get the fixed ip from the fip object, then look for a port with that fixed ip, then see what network the port is on | 18:15 |
| mordred | Shrews: grabbing a vm with fip real quick | 18:16 |
| Shrews | (nat_destination and f_ip.internal_network == fixed_address) | 18:19 |
| Shrews | wth was that doing? | 18:19 |
| mordred | Shrews: the port entry on the fip is the port for the fixed address | 18:19 |
| Shrews | comparing a network name to an IP? | 18:19 |
| mordred | god only konws - it certainly doesn't seem like a thing that would have ever worked | 18:19 |
| Shrews | that makes me think that internal_network is not a name | 18:20 |
| Shrews | jeebus | 18:20 |
| Shrews | i'm a bit confused on what the fix is | 18:20 |
| mordred | Shrews: fip dicts shouldn't even have an internal_network property | 18:23 |
| mordred | Shrews: I have no clue how that EVER worked | 18:24 |
| mordred | Shrews: it's not a part of the neutron api, nor the old nova fip api - nor is it a thing we add in normalize | 18:26 |
| Shrews | ok, so the fix should be ansible module side then. | 18:26 |
| mordred | Shrews: so I think that code has just quite literally never worked | 18:26 |
| Shrews | mordred: that at least explains a few things | 18:26 |
| Shrews | but adds more questions about what we must have been drinking | 18:26 |
| mordred | Shrews: yah | 18:28 |
| Shrews | mordred: so maybe the propose fix is ok? | 18:29 |
| Shrews | proposed* | 18:29 |
| mordred | Shrews: yah- I think so. it's at the very least certianly not worse | 18:29 |
| mordred | Shrews: I left a shipit - it seems more correct than what's there now at least | 18:32 |
| Shrews | mordred: agreed | 18:33 |
| Shrews | i left a second shipit | 18:34 |
| mordred | Shrews: should we just merge it? or does the bot merge it now? | 18:38 |
| Shrews | mordred: i think the bot does with 2 shipits | 18:38 |
| Shrews | not sure about the backporting | 18:38 |
| mordred | nod | 18:39 |
| Shrews | mordred: https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md#when-will-your-pull-request-be-merged | 18:39 |
| mordred | Shrews: cool | 18:40 |
| SamYaple | it turns out i have shipit abilities too | 18:42 |
| SamYaple | looks like the opened it up to anyone thats authored a module inthe same sphere ofmodules | 18:42 |
| *** gouthamr has quit IRC | 20:53 | |
| *** gouthamr has joined #openstack-shade | 21:23 | |
| *** slaweq has joined #openstack-shade | 21:25 | |
| *** gouthamr has quit IRC | 21:49 | |
| *** zigo has quit IRC | 21:59 | |
| *** zigo has joined #openstack-shade | 22:01 | |
| mordred | Shrews: btw - https://review.openstack.org/#/c/519394/ and https://review.openstack.org/#/c/519511/2 are green now | 22:21 |
| mordred | oh - piddle. the release note is bong - I'm just going to do a followup | 22:22 |
| mordred | Shrews: remote: https://review.openstack.org/519784 Remove reference to context-managers from release note | 22:23 |
| *** gouthamr has joined #openstack-shade | 22:26 | |
| *** thrash is now known as thrash|g0ne | 22:34 | |
| *** slaweq has quit IRC | 23:41 | |
| *** slaweq has joined #openstack-shade | 23:42 | |
| *** slaweq has quit IRC | 23:46 | |
| *** gouthamr has quit IRC | 23:52 | |
| openstackgerrit | Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/519785 | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!