openstackgerrit | chenying proposed openstack/smaug: Add fullstack test to smaug https://review.openstack.org/306996 | 01:53 |
---|---|---|
openstackgerrit | smile-luobin proposed openstack/smaug: The resource graph walker listener https://review.openstack.org/287572 | 02:51 |
openstackgerrit | chenying proposed openstack/smaug: Add name property to protectable instances model https://review.openstack.org/302086 | 03:18 |
openstackgerrit | smile-luobin proposed openstack/smaug: Implement HeatTemplate for restore https://review.openstack.org/307549 | 03:37 |
openstackgerrit | xiangxinyong proposed openstack/smaug-dashboard: [Checkpoints] Submit index view function https://review.openstack.org/307571 | 06:18 |
openstackgerrit | chenying proposed openstack/smaug: Add show protectables instance endpoint https://review.openstack.org/302144 | 06:19 |
openstackgerrit | xiangxinyong proposed openstack/smaug-dashboard: [Checkpoints] Submit index view function https://review.openstack.org/307572 | 06:22 |
*** yinweiishere has quit IRC | 06:22 | |
*** yinweiishere has joined #openstack-smaug | 06:23 | |
*** yuval has joined #openstack-smaug | 06:38 | |
*** yuval is now known as Guest60635 | 06:38 | |
*** Guest60635 has quit IRC | 06:38 | |
*** yuval_ has joined #openstack-smaug | 06:39 | |
*** yuval_ is now known as yuval | 06:40 | |
openstackgerrit | chenying proposed openstack/smaug: Add a field parameters to resource plans https://review.openstack.org/302730 | 06:47 |
*** saggi has joined #openstack-smaug | 08:34 | |
chenzeng | yuval:are you there? how are you? | 08:38 |
chenzeng | yuval:if you have time, please review my patche:https://review.openstack.org/#/c/282263/, i hope it can be merged this week. thanks. | 08:41 |
openstackgerrit | smile-luobin proposed openstack/smaug: Enable lease checking for checkpoint https://review.openstack.org/299228 | 11:49 |
openstackgerrit | xiangxinyong proposed openstack/smaug-dashboard: [Operation Logs] Submit index view function https://review.openstack.org/307729 | 11:52 |
openstackgerrit | chenying proposed openstack/python-smaugclient: Add a field parameters to resource plans https://review.openstack.org/307736 | 11:58 |
openstackgerrit | smile-luobin proposed openstack/smaug: Store ResourceGraph and Plan in checkpoint https://review.openstack.org/307737 | 12:00 |
yuval | ping yinweiishere yinwei_computer | 12:28 |
*** zengchen has joined #openstack-smaug | 13:51 | |
*** chenying_ has joined #openstack-smaug | 13:55 | |
zengchen | yuval:are you there? | 13:56 |
*** yinweimac has joined #openstack-smaug | 13:57 | |
*** xiangxinyong456 has joined #openstack-smaug | 13:58 | |
yuval | zengchen: yes | 13:59 |
*** pzchen has joined #openstack-smaug | 14:00 | |
*** zhonghua-lee has joined #openstack-smaug | 14:00 | |
zengchen | i have seen you comments. thanks. | 14:01 |
yuval | :) | 14:01 |
zengchen | but i think we have not reached an agreements about the logs. | 14:01 |
zengchen | Why should write log before sending it to thread pool. Because we don't want to lose the operations which are still in the queue when the Operation Engine service crashes. we will resume them when the service restarts | 14:02 |
yuval | let discuss that after the meeting? | 14:02 |
yuval | (in #openstack-meeting) | 14:02 |
zengchen | ok | 14:03 |
zengchen | yuval:can we discuss about the logs now? | 14:10 |
yuval | in the meeting channel or here? | 14:10 |
yuval | zengchen: ? | 14:11 |
zengchen | here | 14:11 |
yuval | one second | 14:11 |
zengchen | ok | 14:11 |
yuval | item in meeting is important | 14:11 |
zengchen | ok | 14:11 |
*** pzchen has quit IRC | 14:22 | |
*** pzchen has joined #openstack-smaug | 14:40 | |
zengchen | yuval:can we talk now? | 14:48 |
yuval | yes | 14:48 |
zengchen | Why should write log before sending it to thread pool. Because we don't want to lose the operations which are still in the queue when the Operation Engine service crashes. we will resume them when the service restarts | 14:49 |
zengchen | the logs are used to resume the operations. | 14:49 |
zengchen | we can not ignore any operations. | 14:50 |
yuval | I agree that we need to update the scheduled operation log to 'started' only when the actual operation has begun | 14:52 |
yuval | But I think executors is not the right place for it | 14:53 |
*** yinweimac has quit IRC | 14:54 | |
zengchen | we have only two component, one is trigger, the other is executor. | 14:54 |
yuval | maybe we can create the log when the scheduled operation is created, with a state of 'waiting for run' (or something like that), and have the operation itself update to 'started' when the it begins | 14:54 |
yuval | All: you can join the Trello board: https://trello.com/invite/b/Sudr4fKT/826e3dcffc7259b1447d4ecc448c1a45/smaug | 14:56 |
zengchen | i think it is a litle complex. when the operation is triggered, one log is generated. | 14:57 |
zengchen | i think the design now is more clear. | 14:57 |
yuval | I take back what I said. If we create a log when the scheduled operation is registerd, once it is triggered, we will have to create another one. not good. | 14:59 |
*** dell_ has joined #openstack-smaug | 15:01 | |
xiangxinyong | yuval: i join it | 15:01 |
xiangxinyong | yuval: the trello | 15:01 |
yuval | xiangxinyong: great :) | 15:01 |
*** dell_ is now known as zengchenn | 15:02 | |
yuval | zengchen: here is another idea | 15:03 |
zengchenn | yuval:yes | 15:04 |
*** zengchen has quit IRC | 15:04 | |
yuval | zengchenn: 1 sec | 15:04 |
zengchenn | yuval:ok | 15:04 |
yuval | how about creating the log in the beginning of the Operation.execute method? | 15:05 |
yuval | Operation.execute will be something like: | 15:05 |
yuval | 1. create log | 15:06 |
yuval | 2. call self._execute (which every operation implements) | 15:06 |
yuval | 3. set log as finished | 15:06 |
yuval | ----- | 15:06 |
zengchenn | we have stored the operations in the queue, so there is the risk to lose the operation if we don't write log first. | 15:08 |
yuval | I'll be back in a few minutes | 15:08 |
*** chenying_ has quit IRC | 15:09 | |
yuval | (about 10-15) | 15:09 |
*** yuval has quit IRC | 15:09 | |
*** xiangxinyong456 has quit IRC | 15:09 | |
zengchenn | yuval:sorry, i will go to sleep. if you have any good ideas, please leave message to me. thanks. | 15:12 |
*** zengchenn has quit IRC | 15:12 | |
*** yuval has joined #openstack-smaug | 15:25 | |
yuval | ping ChanServ | 15:25 |
yuval | ping chenzeng | 15:25 |
yuval | ping chenzeng | 15:26 |
*** yuval has quit IRC | 15:28 | |
*** pzchen has quit IRC | 15:29 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!