Thursday, 2016-04-21

*** mingyu has joined #openstack-smaug01:04
*** mingyu has quit IRC01:08
*** mingyu has joined #openstack-smaug02:39
*** mingyu has quit IRC02:43
*** mingyu has joined #openstack-smaug03:14
*** mingyu has quit IRC03:15
*** mingyu has joined #openstack-smaug05:05
*** mingyu has quit IRC05:11
*** mingyu has joined #openstack-smaug05:48
*** WANGFeng has joined #openstack-smaug05:55
*** mingyu has quit IRC06:03
*** mingyu has joined #openstack-smaug06:07
*** mingyu has quit IRC06:16
*** mingyu has joined #openstack-smaug06:22
*** mingyu_ has joined #openstack-smaug06:24
*** mingyu has quit IRC06:24
*** yuval has joined #openstack-smaug06:43
*** yuval is now known as Guest8104906:44
*** Guest81049 has quit IRC06:51
*** yuval_ has joined #openstack-smaug06:51
*** yuval_ is now known as yuval06:51
openstackgerritzengchen proposed openstack/smaug: Implement restart of Operation Engine service  https://review.openstack.org/30404806:52
chenzengyuval:good morning! can you see the updates in https://review.openstack.org/304048. i have one question to confirm with you. thanks.06:53
*** mingyu_ has quit IRC06:59
*** mingyu has joined #openstack-smaug07:01
chenzengyuval:ping07:06
*** mingyu has quit IRC07:14
yuvalchenzeng: hey07:33
chenzengyuval:hi07:33
chenzengyuval:do you see the updates?07:33
yuvalchenzeng: yes, +1 it now07:33
chenzeng            for state in states:07:34
chenzeng                resume = (state.state in resume_states)07:34
chenzeng                self._trigger_manager.register_operation(07:34
chenzeng                    state.operation.trigger_id, state.operation.id,07:34
chenzeng                    resume=resume, end_time_for_run=state.end_time_for_run)07:34
chenzengdo you see the last line?07:34
chenzengi prepare to add one more attribute 'end_time_for_run' to ScheduledOpertionState.07:35
chenzengend_time_for_run = expected_time + window.07:36
yuvalwait, what?07:36
yuvaloh07:36
yuvaland who is reponsible for updating this field?07:37
chenzengi want to use it to check whether can resume the operation. if time.nowutc() > end_time_for_run. i will not resume it.07:38
yuvalyes, I understand. Who sets the time into ScheduledOperationState?07:38
chenzengwhen invoke execute_operation of Executor, i will update the ScheduledOpertionState and set state to 'triggered' and end_time_for_run = expected_time + window.07:39
chenzengi mean i will not write/read ScheduledOperationLog in executor class, but i have to update ScheduledOpertionState.07:40
yuvaland we will use this parameter only if resume=True ?07:41
chenzengyes.07:41
yuvalok :)07:41
chenzengok, thank you.07:42
chenzengone more question.07:42
yuvalsure07:42
chenzengi prepare to fix the bug that we have discussed maney days ago. https://bugs.launchpad.net/smaug/+bug/157286507:43
openstackLaunchpad bug 1572865 in Smaug "Fix the way of send the rpc requests to OperationEngine service" [Undecided,New]07:43
yuvalsounds good07:43
chenzengi remember you said you will check the cast interface of rpc.07:44
chenzenghave you finished?07:44
yuvalI thoght we spoke about it, my bad. By default, cast() doesn't broadcast. In order for it to send a broadcast, you need to use a target with the 'fanout' parameter turned to True07:46
yuvalYou can add a fanout parameter to an existing target07:46
chenzengok, thank you.07:48
yuvalfanout_target = target(fanout=True)07:48
yuvalsee:07:49
yuvalhttp://docs.openstack.org/developer/oslo.messaging/target.html07:49
yuval(btw, you can't use a Target with 'fanout' for call(), only cast() )07:49
chenzengyou mean i have to create two instance of Target. one with 'fanout=None' for call(), other with 'fanout=True' for call()07:51
yuvalThat is one option. Another one is to take an existing target, and add the fanout parameter:07:52
yuvalfanout_target = target(fanout=True)07:52
chenzeng    def __call__(self, **kwargs):07:53
chenzeng        for a in ('exchange', 'topic', 'namespace',07:53
chenzeng                  'version', 'server', 'fanout'):07:53
chenzeng            kwargs.setdefault(a, getattr(self, a))07:53
chenzeng        return Target(**kwargs)07:53
chenzengyes, i understand.07:53
chenzengthanks.07:53
openstackgerritMerged openstack/smaug: Implement the workflow  https://review.openstack.org/28514907:55
yuvalchenzeng: :)07:56
xiangxinyonghttp://www.cnblogs.com/edisonxiang/p/5051666.html08:01
*** WANGFeng has quit IRC08:02
yuvalIf anybody wants, we have a vagrant script which sets up a libvirt vm and install devstack. It includes a smaug local.conf08:03
yuvalhttps://github.com/omeranson/openstack-vagrant08:03
*** yinweimac has joined #openstack-smaug08:12
*** yinweimac has quit IRC08:17
openstackgerritMerged openstack/smaug: Implement restart of Operation Engine service  https://review.openstack.org/30404809:11
openstackgerritMerged openstack/python-smaugclient: Add show protectables instance endpoint  https://review.openstack.org/30259709:26
chenzengyuval:good job. it is great!09:27
yuvalit is oanson job :)10:14
openstackgerritYuval Brik proposed openstack/smaug: Move swift client to be created by ClientFactory  https://review.openstack.org/30085410:49
yuvalping yinwei_computer11:22
yuvalping yinweiishere11:22
openstackgerritzengchen proposed openstack/smaug: Fix the way of sending the rpc requests to OperationEngine service  https://review.openstack.org/30892911:26
openstackgerritzengchen proposed openstack/smaug: Fix the way of sending the rpc requests to OperationEngine service  https://review.openstack.org/30892911:36
chenzengyuval:if you have time, please review this patch. thanks.   https://review.openstack.org/30892911:37
yuvalchenzeng: sure. did you see it failed CI?11:45
chenzengyuval:i will update. thaks for you remiding.11:49
chenzengyuval:i have to add one more patch to encapsulate the operation. i heard you will have a holiday next week, do you?11:52
yuvalchenzeng: the holiday is in weekend, we work during the work week11:53
chenzengyuval:great. i hope you can review my patches to make the work perfect.11:55
chenzengyuval::)11:55
openstackgerritchenying proposed openstack/smaug: Fix the wrong calling list_protectable_dependents  https://review.openstack.org/30895812:44
openstackgerritxiangxinyong proposed openstack/smaug-dashboard: Add the project id and version for smaugclient  https://review.openstack.org/30896012:46
openstackgerritMerged openstack/smaug: Fix serialized_meta in SwiftBankPlugin  https://review.openstack.org/30142713:52
*** saggi has quit IRC15:11
openstackgerritMerged openstack/smaug: Fix the wrong calling list_protectable_dependents  https://review.openstack.org/30895815:13
*** openstackgerrit has quit IRC15:48
*** openstackgerrit has joined #openstack-smaug15:48
*** yuval has quit IRC16:29
*** zhonghua has joined #openstack-smaug17:01
*** zhonghua-lee has quit IRC17:02

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!