Tuesday, 2016-05-24

*** zhangshuai has joined #openstack-smaug01:24
*** pzchen has joined #openstack-smaug01:31
*** pzchen has quit IRC01:53
*** pzchen has joined #openstack-smaug01:54
*** chenhuayi has joined #openstack-smaug02:07
*** chenhuayi has quit IRC02:07
*** chenhuayi has joined #openstack-smaug02:08
openstackgerritchenying proposed openstack/smaug: Fix the format of restores parameters  https://review.openstack.org/32019503:13
yinwei_computerping chenying03:21
chenyingHi03:21
yinwei_computerthis patch is to support parameters in protection service?\03:21
chenyingNo this patch just fix the data stored in db.03:21
yinwei_computerok03:22
yinwei_computergot it.03:22
yinwei_computerthen I will have wangliuan to fix protection service03:22
*** pzchen has quit IRC03:23
chenyingxiangxinyong have submitted the patch about supporting  parameters in horizon.03:24
*** zhangshuai_ has joined #openstack-smaug03:38
*** zhangshuai has quit IRC03:42
*** yuval has joined #openstack-smaug03:42
*** yuval has left #openstack-smaug03:42
*** zhangshuai_ has quit IRC03:47
*** zhangshuai_ has joined #openstack-smaug03:47
xiangxinyongchenying is right .https://review.openstack.org/#/c/318396/03:50
xiangxinyongThis patch is about the parameters03:50
*** zhangshuai_ has quit IRC03:58
*** zhangshuai_ has joined #openstack-smaug04:02
*** zhangshuai_ has quit IRC04:24
*** zhangshuai_ has joined #openstack-smaug04:24
*** zhangshuai_ has quit IRC04:35
*** chenying has quit IRC05:37
*** chenying has joined #openstack-smaug05:38
yinwei_computerping saggi06:15
*** pzchen has joined #openstack-smaug06:42
chenyingping gampel06:43
*** yuval has joined #openstack-smaug06:44
yinwei_computerhi, yuval06:47
yuvalyinwei_computer: hey, how are you?06:48
yinwei_computergood06:48
yinwei_computerhow are you doing?06:48
yuvalwell :)06:49
yinwei_computerhmm, will Saggi come today?06:49
yuvalyes, I guess he will be here soon06:50
yinwei_computerI have some problem about this merged patch06:50
yinwei_computerhttps://review.openstack.org/#/c/319672/06:50
yinwei_computerif he's not there, could you pls. check it with me?06:51
yuvalsure06:51
yuvalwhat is the issue?06:51
yinwei_computerI see the point this patch wants to address06:51
yinwei_computerbut the issue it brings is, there's nothing to indicate the restore status06:52
yinwei_computerdo you guys already get a plan to fix this issue?06:52
yuvalthere is the restore object and api06:54
yuvalyinwei_computer: ?06:56
yinwei_computer?06:57
yinwei_computersorry, I don't get it06:57
yinwei_computerI mean the status to restore the whole checkpoint06:58
yuvala Checkpoint can not hold the restore status, as it can be restored more than once, in the same time06:59
yuval(for example)06:59
yinwei_computeruser who is using smaug to restore, it's not reasonable to have user to check resource restore status one by one06:59
yinwei_computerI see the point06:59
yinwei_computerbut the requirement is very reasonable06:59
yinwei_computeruser needs check the whole restoration status06:59
yuvalnot sure I understand07:00
yuvalthe Restore object is not per-resource07:00
yinwei_computeryou mean the restore object?07:00
yuvalProtection Service have a /<project_id>/restore REST API route07:00
yuvalyes07:00
yuvalwhich starts a restore and returns a Restore object07:01
yinwei_computerhmm, actually I didn't see any restore object in API07:01
yuvalwould you mind taking a look again? I missed it at first too07:01
yinwei_computerlet's confirm it with chenying07:02
yinwei_computerwe need involve him07:02
yinwei_computerping chenying07:02
chenyingHi07:02
yinwei_computerYuval suggested we store restore status in restore object07:03
yinwei_computerI'm not sure if we already got this restore object model in API layer07:03
chenyingYes we have status field in restores vo.07:04
yuvalI'll be right back (~10 minutes)07:05
yinwei_computerbut restore object will get passed to protection service in restore rpc request?07:05
chenyingBut status is not updated by protect service. It only mark the rpcapi successful called.07:06
chenyingThe whole restores vo have been passed to  protection service.07:07
yinwei_computerwhat does 'restores vo' mean?07:08
chenyingrestores version object.07:08
yinwei_computerok, got it07:08
yinwei_computerso it seems that we need fix this bug07:08
yinwei_computerto have protection service to return status of restore object?07:09
chenyingversion object have its own curd interface.07:09
chenyingto have protection service to return status of restore object? I think so07:09
yinwei_computerbut there's a problem to update the restore status from restoring to restored07:10
yinwei_computerrpc request will return restore vo as restoring if succeeds07:10
yinwei_computerlater when protection service finds the heat stack has finished, it needs update the status to restored.07:11
yinwei_computercurrently we have no way to notify API from protection service.07:11
yinwei_computerwhat do you think?07:11
chenyingI think we don't need to notify API to update.07:12
chenyingcall restore(vo).save() to updata status.07:13
chenyingnotify API to update mean we need call smaugclient in protect service.07:13
chenyingIt make this update more complex.07:14
yinwei_computerthe question is if there's no notification, how to get restore vo status updated?07:14
chenyingHow about saving restore vo in contect? Now Does one contect mean one rpc call?07:17
yinwei_computerping Saggi07:25
yuvalNot sure what is your issue with the Restore API/RPC07:25
yinwei_computerwe need update restore version object from restoring to restored when restore finihsed07:26
yinwei_computerit's not as simple as just return restore obj in rpc call07:26
yuvalthe rpc call should return the restore object when the restore has begun07:27
yinwei_computerthis is np07:27
yinwei_computerbut who will update the restore object status to API service?07:27
yinwei_computerand how?07:27
yuvalabout updating the restore vo: why not do that in create_restoration.py07:27
yinwei_computerthe question is how07:28
yinwei_computerusing smaug client in protection service?07:28
yinwei_computeror using version object API?07:28
yuvalwhy not version object api?07:28
yinwei_computerchenying could tell you more07:28
yinwei_computermy point is that this patch is not an integrated one07:29
yinwei_computerit addresses one issue, but it takes another issue07:29
yinwei_computersince chenying is working on integration test, I suggest we'd better revert this patch for now and report a bug to track the multiple restoration issue.07:30
chenyingyuval: using smaugclient or  version object save API are both  OK.07:30
yuvalchenying can revert this change locally in his environment07:30
yuvalno need to revert on master07:30
yinwei_computerbetter revert on master07:31
chenyingmy environment do not include this patch.07:31
yinwei_computerwe need a CI to guard correctness07:31
yinwei_computernext time to commit this patch, we need check if it comes together with restore object status update07:32
yinwei_computerotherwise, we need refuse patches breaking functionality07:32
yuvalyinwei_computer: this issue should have been dealt with in this patch: https://review.openstack.org/30631107:33
yinwei_computerno07:33
yinwei_computerthis patch updated restore status to checkpoint07:34
yinwei_computersaggi erased restore status from checkpoint07:34
yinwei_computerI understand his point. But his patch will break correctness of restoration.  Or he could fix his patch with updating restore obj status.07:36
yuvalping saggi07:36
yinwei_computer'revert' means postpone to merge it  after CI is ready07:37
yinwei_computerlet's check it when saggi comes.07:39
*** sho__ has joined #openstack-smaug07:48
*** sho__ has left #openstack-smaug07:50
zhongjun_Does anyone could tell me how to install smaug? thanks07:57
saggiping yinwei_computer08:02
chenzengzhongjun:If you install smaug using devstack, just copy the local.cnf from smaug's repository to the devstack dir, and run stack.sh. Maybe you should update the local.cnf as you need.08:03
zhongjun_saggi, chenzeng: ok, I will try it. thanks08:12
*** pzchen has quit IRC08:51
*** pzchen has joined #openstack-smaug08:51
*** pzchen has quit IRC08:53
yinwei_computerping saggi09:07
yuvalyinwei_computer: he will be back later09:08
yinwei_computerok09:08
yinwei_computerI'll go for supper09:33
*** zhongjun_ has quit IRC09:41
*** zhongjun_ has joined #openstack-smaug09:41
*** wangfeng has quit IRC09:47
*** zhongjun_ has quit IRC09:50
*** zhongjun_ has joined #openstack-smaug09:51
saggiyinwei_computer: pong09:59
*** wangfeng has joined #openstack-smaug10:02
*** zhongjun_ has quit IRC10:18
*** zhongjun_ has joined #openstack-smaug10:19
openstackgerritMerged openstack/smaug: Fix minor issues with code formatting  https://review.openstack.org/31967312:17
openstackgerritMerged openstack/smaug: Add operation log endpoints to API document  https://review.openstack.org/29806012:18
openstackgerritMerged openstack/smaug: [API] Add resource endpoint  https://review.openstack.org/30177712:18
xiangxinyonghi guys, I wrote a smaug introduce in the blog.  http://www.cnblogs.com/openstackteam/p/5524661.html12:33
xiangxinyongwelcome to visit it.12:33
gampel xiangxinyong:: very nice12:34
xiangxinyonggampel: thanks. :)12:35
openstackgerritYuval Brik proposed openstack/smaug: Reimplement the Protection workflow for new design  https://review.openstack.org/31038512:45
openstackgerritMerged openstack/smaug: Fix the format of restores parameters  https://review.openstack.org/32019512:46
openstackgerritYuval Brik proposed openstack/smaug: Reimplement the Protection workflow for new design  https://review.openstack.org/31038513:17
openstackgerritOpenStack Proposal Bot proposed openstack/smaug: Updated from global requirements  https://review.openstack.org/31989113:52
*** chenhuayi has quit IRC13:53
*** zhongjun_ has quit IRC14:29
*** yuval has quit IRC14:42
*** yuval has joined #openstack-smaug15:20
*** yuval has quit IRC15:35
*** saggi has quit IRC16:02
*** xavierr has joined #openstack-smaug21:50
*** xavierr has left #openstack-smaug22:06
*** openstackgerrit has quit IRC23:03
*** openstackgerrit has joined #openstack-smaug23:03

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!