| *** zhurong has quit IRC | 00:04 | |
| *** yizhihui has joined #openstack-smaug | 00:28 | |
| *** wanghao_ has joined #openstack-smaug | 01:08 | |
| *** zhurong has joined #openstack-smaug | 01:17 | |
| *** zhonghua-lee has quit IRC | 01:22 | |
| *** zhonghua-lee has joined #openstack-smaug | 01:23 | |
| *** yamamoto has quit IRC | 01:34 | |
| xiangxinyong | yizhihui: hello | 01:53 |
|---|---|---|
| yizhihui | hello | 01:53 |
| xiangxinyong | I see you ask a question about the resources show | 01:54 |
| yizhihui | yes | 01:55 |
| xiangxinyong | when we design the protection and restore, we separete resource plugin with protection plugin | 01:57 |
| xiangxinyong | resource plugin is here: smaug/services/protection/protectable_plugins | 01:58 |
| xiangxinyong | protection plugin is here: smaug/services/protection/protection_plugins | 01:58 |
| xiangxinyong | resouce plugin is in charge of showing resource, listing resources and defining the dependent relationship | 01:59 |
| xiangxinyong | protection plugin is in charge of protecting and restoring. | 02:00 |
| xiangxinyong | at the begining, we think one resource plugin may have more than one protection plugin | 02:01 |
| yizhihui | and ? | 02:02 |
| xiangxinyong | for example, a resource "volume" may have "emc volume backup protection plugin", "emc volume snapshot protection plugin","eisoo volume backup protection plugin","eisoo volume snapshot protection plugin" | 02:03 |
| xiangxinyong | so the resource plugin adn protection plugin are seperated. They have the independent function | 02:04 |
| yizhihui | I mean why the resource plugin base class didn't provide the show_resource method | 02:06 |
| yizhihui | this show_resource method has nothing to do with the protection plugin | 02:06 |
| xiangxinyong | *_* | 02:09 |
| xiangxinyong | so you mean this file has no show_resource method. "smaug\services\protection\protectable_plugin.py" | 02:09 |
| xiangxinyong | ? | 02:09 |
| yizhihui | yes | 02:09 |
| *** yamamoto has joined #openstack-smaug | 02:13 | |
| xiangxinyong | and do you want to invoke the "show_resource" method of "resource plugin base class" in your protection plugin? | 02:14 |
| yizhihui | no, I don't | 02:15 |
| xiangxinyong | :) so I am a little confused with this sentence. "this show_resource method has nothing to do with the protection plugin" | 02:18 |
| yizhihui | I just think show_resource should be an abstract method like other methods in the base class, so when we implement a resource plugin, we know that we should overwrite this show_resource method | 02:18 |
| xiangxinyong | :) I know your meaning now. Thanks. | 02:19 |
| yizhihui | :) you are welcome! | 02:20 |
| xiangxinyong | I agree with you. I will make clear this question with designer, and then reply to you. | 02:21 |
| xiangxinyong | I guess this is a good optimization. | 02:22 |
| yizhihui | Thank you! | 02:27 |
| xiangxinyong | yizhihui: I discuss with smile-luobin. He also think you are right. | 02:29 |
| xiangxinyong | could you file a bug to specify this problem? | 02:29 |
| xiangxinyong | https://bugs.launchpad.net/karbor/+filebug | 02:29 |
| yizhihui | ok | 02:31 |
| xiangxinyong | thanks | 02:31 |
| xiangxinyong | if you finish that, could you paste the bug link here? | 02:34 |
| xiangxinyong | like this one :https://bugs.launchpad.net/karbor/+bug/1560826 | 02:34 |
| openstack | Launchpad bug 1560826 in Karbor "restore design spec" [High,In progress] - Assigned to yinwei (yinweiishere-n) | 02:34 |
| yizhihui | ok | 02:36 |
| yizhihui | https://bugs.launchpad.net/karbor/+bug/1617127 | 02:45 |
| openstack | Launchpad bug 1617127 in Karbor "ProtectablePlugin class design" [Undecided,New] | 02:45 |
| xiangxinyong | yizhihui: thanks | 02:52 |
| xiangxinyong | if you have time, I could submit this patch together | 02:53 |
| xiangxinyong | witg you | 02:53 |
| xiangxinyong | with you | 02:53 |
| xiangxinyong | what about that? | 02:53 |
| yizhihui | ok | 02:54 |
| xiangxinyong | do you have team viewer | 02:54 |
| xiangxinyong | we could do it together | 02:54 |
| yizhihui | yes | 02:55 |
| *** garryfan has joined #openstack-smaug | 02:55 | |
| openstackgerrit | yizhihui proposed openstack/smaug: Add abstract method in ProtectablePlugin base class https://review.openstack.org/360875 | 03:54 |
| *** garryfan has quit IRC | 04:52 | |
| xiangxinyong | yizhihui: I guess we need to modify the codes to solve these problems about your patch. https://etherpad.openstack.org/p/got | 05:03 |
| xiangxinyong | yizhihui: could you do that? | 05:03 |
| yizhihui | yes | 05:07 |
| *** garryfan has joined #openstack-smaug | 05:11 | |
| *** wu_qingyong has joined #openstack-smaug | 05:14 | |
| *** LiChunyu has joined #openstack-smaug | 05:35 | |
| xiangxinyong | yizhihui: Great. I add some commands into here. https://etherpad.openstack.org/p/got | 05:58 |
| yizhihui | ok | 05:59 |
| yizhihui | i will do the work a moment later | 06:00 |
| xiangxinyong | :) | 06:01 |
| *** wu_qingyong_ has joined #openstack-smaug | 06:18 | |
| *** wu_qingyong has quit IRC | 06:21 | |
| *** garryfan has quit IRC | 06:58 | |
| openstackgerrit | yizhihui proposed openstack/smaug: Add abstract method in ProtectablePlugin base class https://review.openstack.org/360875 | 07:11 |
| *** wu_qingyong has joined #openstack-smaug | 07:41 | |
| *** wu_qingyong_ has quit IRC | 07:41 | |
| *** openstackgerrit has quit IRC | 08:18 | |
| *** openstackgerrit has joined #openstack-smaug | 08:18 | |
| *** wu_qingyong_ has joined #openstack-smaug | 08:31 | |
| *** wu_qingyong has quit IRC | 08:31 | |
| openstackgerrit | zhangshuai proposed openstack/python-smaugclient: fix .coveragerc and rename smaug to karbor in setup.cfg https://review.openstack.org/360982 | 08:44 |
| xiangxinyong | yizhihui: hello | 09:10 |
| xiangxinyong | yizhihui: I see you have already rebased your patch. good job. | 09:13 |
| xiangxinyong | yizhihui: the jenkins is +1 now | 09:13 |
| yizhihui | yes, thanks for your help | 09:14 |
| xiangxinyong | yizhihui: you are welcome. | 09:14 |
| openstackgerrit | zhangshuai proposed openstack/python-smaugclient: fix .coveragerc https://review.openstack.org/360982 | 09:44 |
| openstackgerrit | zhangshuai proposed openstack/python-smaugclient: fix .coveragerc https://review.openstack.org/361047 | 09:51 |
| *** yamamoto has quit IRC | 09:52 | |
| *** zhurong has quit IRC | 10:01 | |
| *** wu_qingyong_ has quit IRC | 10:02 | |
| *** LiChunyu has quit IRC | 10:11 | |
| *** yizhihui has quit IRC | 10:11 | |
| *** yamamot__ has joined #openstack-smaug | 11:35 | |
| *** wanghao_ has quit IRC | 11:49 | |
| *** zhurong has joined #openstack-smaug | 13:04 | |
| *** yamamot__ has quit IRC | 14:08 | |
| *** yamamoto has joined #openstack-smaug | 14:30 | |
| *** zhurong has quit IRC | 15:03 | |
| *** yamamoto has quit IRC | 15:55 | |
| *** yamamoto has joined #openstack-smaug | 15:58 | |
| *** yamamoto has quit IRC | 17:10 | |
| *** yamamoto has joined #openstack-smaug | 18:10 | |
| *** yamamoto has quit IRC | 18:15 | |
| *** yamamoto has joined #openstack-smaug | 18:43 | |
| *** yamamoto has quit IRC | 18:49 | |
| *** gouthamr has joined #openstack-smaug | 20:46 | |
| *** gouthamr_ has joined #openstack-smaug | 21:33 | |
| *** gouthamr has quit IRC | 21:36 | |
| *** gouthamr_ is now known as gouthamr | 21:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!