*** dshulyak has joined #openstack-solar | 05:54 | |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Add upstart config for solar-worker https://review.openstack.org/270665 | 07:44 |
---|---|---|
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Implement timelimit mechanism based on tracking of tasks https://review.openstack.org/270766 | 08:23 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Support configurable retries on orchestration layer https://review.openstack.org/272036 | 08:42 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Improve fixtures for functional tests https://review.openstack.org/272065 | 08:42 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Remove duplicated code in orchestration/scheduler https://review.openstack.org/272130 | 08:42 |
*** salmon_ has joined #openstack-solar | 09:19 | |
pigmej | hello dima :) | 09:20 |
dshulyak | hi | 09:28 |
pigmej | dshulyak: so https://review.openstack.org/#/c/271446/4/solar/dblayer/solar_models.py@1238 | 09:30 |
pigmej | first there then I can add comment to code but it will be huge or useless | 09:30 |
dshulyak | :) can you make it small and usefull? | 09:31 |
pigmej | hard | 09:31 |
pigmej | :D | 09:31 |
pigmej | so we need to update because DB knows the missing part | 09:31 |
pigmej | in concurrent env (with siblings enabled) we could have siblings there | 09:31 |
dshulyak | so after save self.lockers wont be updated, even if there is different res[‘lockers’] in response | 09:33 |
pigmej | well, it will be because of conflict resolver | 09:34 |
pigmej | but our dblayer will be unaware of this | 09:35 |
pigmej | so I added this part to fix this problem | 09:35 |
pigmej | because in dblayer we assume that whatever we store => is correct, and will be not altered, which is *not* the case in locking + siblings | 09:35 |
pigmej | because other concurrent process could store some data too, so db returns data may be missing for us | 09:36 |
dshulyak | i would expect that if i save and i have conflict - than my data in dblayer will be concistent with resolved one | 09:36 |
pigmej | yeah, after this save it is | 09:37 |
pigmej | I could later add more pretty solution for that | 09:37 |
pigmej | and somehow make it transparent | 09:38 |
dshulyak | it seems to me that it should be done in conflict_resolver | 09:38 |
pigmej | yup | 09:38 |
*** nihilifer has joined #openstack-solar | 09:38 | |
pigmej | that's what I meant by "more pretty solution" | 09:38 |
pigmej | hey nihilifer :) | 09:38 |
nihilifer | hey pigmej | 09:39 |
salmon_ | dshulyak: how can I test all your changes? Do you have a branch with all changes? | 09:55 |
dshulyak | they should be ordered, but looks like init script is not in tree | 09:58 |
pigmej | dshulyak: they conflict a bit | 09:58 |
dshulyak | hm | 09:58 |
pigmej | timelimit conflict with zerorpc tree | 09:59 |
pigmej | I did manual merge, then some code review only | 09:59 |
pigmej | because we need to merge it asap then fix | 09:59 |
pigmej | because it's already too big :D | 09:59 |
dshulyak | yeah, i messed up the order at some point | 10:00 |
dshulyak | i will do rebases now | 10:00 |
*** dshulyak has quit IRC | 10:01 | |
*** dshulyak has joined #openstack-solar | 10:02 | |
dshulyak | rebased, now you can git checkout -d 272130 (it is the latest patchset), and then start solar-worker in foreground or vagrant provision solar-dev | 10:21 |
dshulyak | oh crap, this one conflicts with one of mine - https://review.openstack.org/#/c/271446/ | 10:22 |
dshulyak | we should merge it probably | 10:22 |
dshulyak | salmon_: pigmej ^ | 10:22 |
pigmej | yeah | 10:26 |
pigmej | now wait for jenkins :D | 10:26 |
openstackgerrit | Merged openstack/solar: Fix locking problems https://review.openstack.org/271446 | 10:29 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Implement timelimit mechanism based on tracking of tasks https://review.openstack.org/270766 | 10:40 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Add implementation of puller with pool of threads and tracking of tasks https://review.openstack.org/270765 | 10:40 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Support configurable retries on orchestration layer https://review.openstack.org/272036 | 10:40 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Improve fixtures for functional tests https://review.openstack.org/272065 | 10:40 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Re-start sqlite session before retry and after succesful acquire https://review.openstack.org/271180 | 10:40 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Add upstart config for solar-worker https://review.openstack.org/270665 | 10:40 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Remove duplicated code in orchestration/scheduler https://review.openstack.org/272130 | 10:40 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Zerorpc worker for orchestration modules https://review.openstack.org/269166 | 10:40 |
dshulyak | pigmej: salmon_ : ok, now there should be no conflicts and everything should work both with sqlite and riak | 10:40 |
salmon_ | dshulyak: ok, thx | 10:40 |
dshulyak | but for jenkins we will need another /etc/default/solar-worker variables | 10:42 |
dshulyak | hm or not | 10:43 |
dshulyak | you have vagrant user there | 10:43 |
salmon_ | yup | 10:44 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Bump version to 0.2.0 https://review.openstack.org/272466 | 10:54 |
pigmej | dshulyak: merge and review | 11:00 |
pigmej | pbr enforces that | 11:00 |
dshulyak | 0.1.1 ? | 11:01 |
dshulyak | i guess it doesnt matter | 11:02 |
pigmej | 0.1.1 would be fix for 0.1 | 11:03 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Support configurable retries on orchestration layer https://review.openstack.org/272036 | 11:21 |
openstackgerrit | Merged openstack/solar: Bump version to 0.2.0 https://review.openstack.org/272466 | 11:38 |
pigmej | dshulyak: https://review.openstack.org/#/c/272036/ still conflicts for me | 11:42 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Improve fixtures for functional tests https://review.openstack.org/272065 | 11:45 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Remove duplicated code in orchestration/scheduler https://review.openstack.org/272130 | 11:45 |
dshulyak | pigmej: please try again | 11:46 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Timeout support for scheduled tasks https://review.openstack.org/272501 | 12:15 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fix incorrect ansible_library path https://review.openstack.org/272543 | 13:57 |
pigmej | salmon_: ^ | 13:58 |
salmon_ | dshulyak: pigmej all examples are working with new worker :) | 14:36 |
dshulyak | cool | 14:37 |
pigmej | yeah :) | 14:38 |
pigmej | dshulyak: we're going to merge it ;) fixes later;D | 14:38 |
pigmej | btw after your recent changes we probably should enhance our hadlers for "progress" capability, isn't iT? | 14:38 |
dshulyak | yeah, now we have more options | 14:41 |
pigmej | :) | 14:41 |
dshulyak | riak ate halt of my memory | 14:45 |
dshulyak | it is only 500 m, but still :) | 14:46 |
pigmej | ? | 14:46 |
pigmej | bitcask ? | 14:46 |
dshulyak | no, leveldb | 14:46 |
dshulyak | basically i already restarted vm + added more memory, so i will debug more next time | 14:47 |
pigmej | hmm, leveldb shouldn't cache that much | 14:52 |
pigmej | but it's configurabel | 14:52 |
pigmej | it's like 30% of all memory by default | 14:52 |
pigmej | :) | 14:52 |
openstackgerrit | Merged openstack/solar: Zerorpc worker for orchestration modules https://review.openstack.org/269166 | 15:00 |
openstackgerrit | Merged openstack/solar: Add upstart config for solar-worker https://review.openstack.org/270665 | 15:01 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Fix simple statistics of a plan execution https://review.openstack.org/272574 | 15:01 |
pigmej | dshulyak: you should start wokring on documentation ;d | 15:04 |
pigmej | working* | 15:04 |
openstackgerrit | Merged openstack/solar: Re-start sqlite session before retry and after succesful acquire https://review.openstack.org/271180 | 15:04 |
*** dshulyak has quit IRC | 15:25 | |
*** dshulyak has joined #openstack-solar | 15:26 | |
openstackgerrit | Tomasz 'Zen' Napierala proposed openstack/solar: Added internal architecture diagram and fixed some doc errors https://review.openstack.org/272588 | 15:26 |
openstackgerrit | Merged openstack/solar: Added internal architecture diagram and fixed some doc errors https://review.openstack.org/272588 | 15:43 |
openstackgerrit | Merged openstack/solar: Add implementation of puller with pool of threads and tracking of tasks https://review.openstack.org/270765 | 15:46 |
openstackgerrit | Merged openstack/solar: Implement timelimit mechanism based on tracking of tasks https://review.openstack.org/270766 | 15:46 |
openstackgerrit | Merged openstack/solar: Support configurable retries on orchestration layer https://review.openstack.org/272036 | 15:46 |
openstackgerrit | Merged openstack/solar: Improve fixtures for functional tests https://review.openstack.org/272065 | 15:47 |
openstackgerrit | Merged openstack/solar: Remove duplicated code in orchestration/scheduler https://review.openstack.org/272130 | 15:47 |
openstackgerrit | Merged openstack/solar: Timeout support for scheduled tasks https://review.openstack.org/272501 | 15:47 |
pigmej | https://review.openstack.org/#/c/272543/ dshulyak please review :) | 16:42 |
*** salmon_ has quit IRC | 17:05 | |
*** salmon_ has joined #openstack-solar | 17:05 | |
*** bogdando has quit IRC | 17:06 | |
dshulyak | wow you merged all my stuff | 17:10 |
openstackgerrit | Merged openstack/solar: Fix incorrect ansible_library path https://review.openstack.org/272543 | 17:15 |
*** openstackgerrit has quit IRC | 17:17 | |
*** openstackgerrit has joined #openstack-solar | 17:17 | |
*** bogdando has joined #openstack-solar | 17:19 | |
pigmej | dshulyak: yeah we did, is it wrong ? | 17:20 |
pigmej | :) | 17:20 |
salmon_ | dshulyak: should we revert it? :P | 17:21 |
pigmej | salmon_: `push -f` :P | 17:21 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Removed global ansible library https://review.openstack.org/272135 | 17:22 |
pigmej | it's rebased salmon_ dshulyak | 17:24 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Clean repository after removing celery https://review.openstack.org/272663 | 17:26 |
dshulyak | -1 for revert | 17:27 |
dshulyak | i was just surprised | 17:27 |
dshulyak | any interesting updates on configdb? | 17:27 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Clean repository after removing celery https://review.openstack.org/272663 | 17:27 |
pigmej | dshulyak: not yet, because they came to office like 5PM | 17:28 |
pigmej | why this https://review.openstack.org/#/c/272574/ waits forever ? | 17:29 |
dshulyak | pigmej: what do you mean? jenkins? | 17:31 |
pigmej | yeah | 17:31 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fix simple statistics of a plan execution https://review.openstack.org/272574 | 17:35 |
pigmej | dshulyak: I rebased your change :) | 17:36 |
dshulyak | you decided to help it | 17:36 |
pigmej | yup | 17:37 |
pigmej | it was not even in queue :P | 17:37 |
*** salmon_ has quit IRC | 17:52 | |
openstackgerrit | Merged openstack/solar: Fix simple statistics of a plan execution https://review.openstack.org/272574 | 17:53 |
*** dshulyak has quit IRC | 19:37 | |
*** angdraug has joined #openstack-solar | 21:12 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!