*** salmon_ has quit IRC | 00:20 | |
*** angdraug has quit IRC | 01:39 | |
*** dshulyak has joined #openstack-solar | 06:15 | |
openstackgerrit | Merged openstack/solar: Removed deprecated ansible handler documentation https://review.openstack.org/274671 | 07:58 |
---|---|---|
openstackgerrit | Merged openstack/solar: Fixed missing texts in docs https://review.openstack.org/274614 | 08:01 |
*** salmon_ has joined #openstack-solar | 08:10 | |
openstackgerrit | Lukasz Oles proposed openstack/solar: Use overlay images, 3 min test speedup https://review.openstack.org/275062 | 08:14 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Use overlay images, 3 min test speedup https://review.openstack.org/275062 | 08:21 |
pigmej | ok I will rewrite this ansible then salmon_ dshulyak :) | 08:54 |
pigmej | I wonder why this api is that weird | 08:54 |
pigmej | dshulyak: https://github.com/openstack/solar/blob/master/solar/orchestration/workers/__init__.py#L15-L17 ? | 09:05 |
dshulyak | ? | 09:05 |
pigmej | what are those imports doing there? | 09:05 |
dshulyak | wo them you cant use modules like this, workers.tasks.Tasks | 09:06 |
dshulyak | workers.scheduler | 09:06 |
pigmej | k | 09:06 |
pigmej | so it's just for that alias ? | 09:06 |
pigmej | I will add them as NOQA because I have no idea how to make it "ok" without NOQA | 09:07 |
dshulyak | hm, what do you mean? | 09:08 |
pigmej | these imports are unsued in that file | 09:08 |
dshulyak | tox didnt raise any errors | 09:09 |
pigmej | because __init__ are in ignore | 09:09 |
dshulyak | ah | 09:09 |
pigmej | I'm removing it | 09:09 |
pigmej | :) | 09:09 |
pigmej | I had it working yesterday, but then we merged your changes ;P | 09:09 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Removed all __init__ files from pep8 ignore https://review.openstack.org/274634 | 09:09 |
pigmej | salmon_, dshulyak rebased pep8 in __init__ | 09:10 |
salmon_ | pigmej: what's h104? | 09:11 |
pigmej | * [H104] Files with no code shouldn’t contain any license header nor comments, and must be left completely empty. | 09:11 |
pigmej | dshulyak: can you please review https://github.com/Mirantis/solar-resources/pull/13 + https://github.com/Mirantis/solar-resources/pull/14 + https://review.openstack.org/#/c/273665/ ? | 09:55 |
salmon_ | please please | 09:55 |
pigmej | salmon_: now it's your time to try "rebase workflow" | 09:55 |
pigmej | :P | 09:55 |
dshulyak | yes, i will add last paraghraph to docs and do review | 09:56 |
salmon_ | everything is rebased | 09:56 |
pigmej | salmon_: for now yeah, but let's wait when we will have other changes; D | 09:56 |
salmon_ | :P | 09:56 |
salmon_ | 2,500 commits in Solar! | 10:03 |
pigmej | oh | 10:04 |
pigmej | :D | 10:04 |
pigmej | salmon_: sadly it belongs to jenkins :( | 10:07 |
pigmej | salmon_: hmm, old tests execution 4m3s, new tests (after speedup) 3m25s | 10:09 |
salmon_ | you have faste disk :P | 10:09 |
salmon_ | faster | 10:09 |
pigmej | https://bpaste.net/show/87988576aee2 | 10:11 |
salmon_ | pff | 10:12 |
dshulyak | where we can host solar deb/rpm packages? | 10:14 |
pigmej | for rpm we could use fedorapeople | 10:15 |
salmon_ | for deb ppa? | 10:15 |
pigmej | but do you want to package deb/rpm now ? | 10:15 |
pigmej | I would wait till we split properly extra stuff from main package | 10:15 |
pigmej | (Computable Inputs, etc) | 10:15 |
pigmej | same for worker | 10:15 |
dshulyak | i just checked fpm doc and it is quite easy to package python library + upstart/systemd | 10:16 |
dshulyak | oneliner | 10:16 |
dshulyak | you want to create separate repos for that stuff? | 10:17 |
*** openstackgerrit has quit IRC | 10:17 | |
*** openstackgerrit has joined #openstack-solar | 10:17 | |
pigmej | dshulyak: I hope not, but having one big python pacakge with solar 'core' + solar worker + solar computable inputs it's kinda nonsense | 10:18 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Introduce documentation related to new worker https://review.openstack.org/274642 | 10:33 |
dshulyak | i merged all patches related to ips | 10:42 |
pigmej | on github too ? :) | 10:50 |
dshulyak | pigmej: 2 on github and jenkins patch | 10:53 |
openstackgerrit | Merged openstack/solar: Allow to use any IPs with fuel-devops https://review.openstack.org/273665 | 10:59 |
*** tzn has joined #openstack-solar | 11:52 | |
openstackgerrit | Yuriy Taraday proposed openstack/solar: Fixes for 'tox -e docs' to run on my machine https://review.openstack.org/275144 | 11:59 |
*** pigmej has quit IRC | 12:36 | |
*** pigmej has joined #openstack-solar | 12:38 | |
openstackgerrit | Yuriy Taraday proposed openstack/solar: Fixes for 'tox -e docs' in some dev environments https://review.openstack.org/275144 | 12:45 |
*** YorikSar has joined #openstack-solar | 12:57 | |
pigmej | YorikSar: hey :) | 12:57 |
YorikSar | Oh, this is the right channel. | 12:57 |
YorikSar | I thought I created a new one again - there's no title here :) | 12:58 |
pigmej | :D | 12:58 |
salmon_ | :) | 12:58 |
YorikSar | So I'm looking at Solar internals for "Python API" that I should consume to provide Config Service API. | 12:59 |
pigmej | cool :) | 13:00 |
YorikSar | It looks like one can only create resources based on definitions in some Repository that is somewhere in fs, right? | 13:00 |
YorikSar | So I cannot provide an API call like "Create resource definition". | 13:01 |
pigmej | OR you can set full path, but yeah basically it's like taht | 13:01 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Preinstall more stuff on an image https://review.openstack.org/275180 | 13:01 |
pigmej | resource definition is resource repository | 13:01 |
pigmej | YorikSar: but what is your question exactly ? | 13:02 |
openstackgerrit | Merged openstack/solar: Added info that our examples require nodes https://review.openstack.org/274713 | 13:02 |
salmon_ | pigmej: with this change hosts example is more than 2x faster from 8minutes to 3 minutes. With overlay patch, hosts example takes 1,5 minute :) | 13:02 |
pigmej | salmon_: but we should install less and less stuff on image:P | 13:03 |
YorikSar | But we can't make plugins install files into some repo, can we? | 13:03 |
pigmej | YorikSar: sure you can | 13:03 |
salmon_ | pigmej: yup, but this change doesn't add anything. It just installs it earlier :P | 13:03 |
pigmej | YorikSar: but also, you can manipulate on inputs later | 13:03 |
salmon_ | YorikSar: see solar repo commands | 13:04 |
pigmej | so we could add generic "empty" resource for DR | 13:04 |
pigmej | or for whatever | 13:04 |
pigmej | https://github.com/openstack/solar/blob/master/solar/core/resource/resource.py#L154 | 13:04 |
salmon_ | YorikSar: what workflow do you need? | 13:04 |
pigmej | https://github.com/openstack/solar/blob/master/solar/core/resource/resource.py#L184 | 13:04 |
pigmej | and btw, you should ignore that your resource will have transports_id and location_id | 13:05 |
YorikSar | Ok, here's what I'm thinking about: user installed Fuel 9.0 with Config Service and Solar as two separate experimental features; now user shouldn't have to go through Solar Repo CLI to add some resource defs, Config Service API should allow user to add resource definitions w/o Solar CLI. | 13:06 |
YorikSar | So I'd like to have resource definitions stored in Solar DB itself somehow... | 13:07 |
pigmej | ok, so we have 2 choices :) | 13:08 |
pigmej | #1 configdb adds some configdb resource repository which will have some "empty" reosurce definition | 13:09 |
pigmej | then you can easily add / remove / change inputs there | 13:09 |
YorikSar | But I'll need to change definitions, not resources themselves. | 13:09 |
pigmej | #2 configdb provides resource definition in resoruce repository for any entity | 13:09 |
pigmej | ? | 13:10 |
pigmej | why do you want to change definitions ? | 13:10 |
YorikSar | E.g. user wants to add new "template" - I need to somehow remember what inputs it had, with types and everything. And then use it for every hierarchy level in every env that uses this "template". | 13:12 |
YorikSar | "template" in terms of Config Service (old one) | 13:12 |
pigmej | so that template == resource definition, which is stored in resource repository, isn't it? | 13:12 |
pigmej | it has some simple version parsing etc | 13:13 |
YorikSar | Remember, we had "createComponent(ResDef[] definitions, Resource env)" on the board? So I want to be able to actually pass resource definition there. | 13:13 |
pigmej | then you should create resource repository content on demand probably | 13:13 |
pigmej | I had an idea of storing repositories in DB at very first | 13:14 |
pigmej | anyway, why ResDef[] can't be ResourceRepositoryNames[] ? | 13:14 |
YorikSar | Oh, right. Config Service can manage its own repo and allow user to CRUD definitions there. | 13:14 |
openstackgerrit | Merged openstack/solar: Fixes for 'tox -e docs' in some dev environments https://review.openstack.org/275144 | 13:14 |
YorikSar | Because I don't want to force client to be near server. | 13:15 |
pigmej | the only problem is that you will need to have this repo installed "everywhere" but it's general problem of current solar + solar repository design | 13:15 |
YorikSar | Yay! I've contributet to Solar! | 13:15 |
pigmej | YorikSar: congrats :) | 13:15 |
YorikSar | *contributed | 13:15 |
pigmej | you're 15th contributor :D | 13:15 |
pigmej | anyway, back to the topic ;) | 13:15 |
pigmej | YorikSar: could you for now assume that you manage your own resource repository ? | 13:16 |
pigmej | even ignoring fact that it's some directory ? | 13:16 |
YorikSar | Yeah. And then I'll provide API to create resdef in it, for example. | 13:16 |
YorikSar | I'll repeat some of Solar CLI then. | 13:17 |
pigmej | sounds pretty reasonable to me, at least for now | 13:17 |
YorikSar | Hm... But for "library" part we'll have to pass just bare strings (specs) as ResDef[]. | 13:18 |
YorikSar | Ok | 13:18 |
pigmej | YorikSar: also, I'm pretty sure that you will find some bugs in repository module :D | 13:21 |
pigmej | feel free to ask / fix / request for help then :) | 13:22 |
pigmej | also, if you prefer to not use repositories at all (you can find it then) you can use https://github.com/openstack/solar/blob/master/solar/dblayer/solar_models.py#L807 which is dblayer part of Resource | 13:23 |
pigmej | it's not aware of *any* repository part | 13:23 |
YorikSar | pigmej: Yeah, but I'd like to be able to let Config Service work in the same context as Solar later, so probably I'll have to use (fix ;)) Repository. | 13:25 |
pigmej | repos are for sure workirng, but there are some places that assume that everything is fine | 13:26 |
pigmej | so in case of fuckups you may need rm -fr /some/path | 13:26 |
pigmej | :) | 13:26 |
YorikSar | Oh, "_REPOS_LOCATION = '/var/lib/solar/repositories'"... It's hardcoded there. | 13:27 |
pigmej | yeah | 13:27 |
YorikSar | So I'll have to just always make sure I use a separate repo in it, right? | 13:27 |
pigmej | yup | 13:27 |
pigmej | like configdb | 13:28 |
pigmej | :) | 13:28 |
pigmej | generally repository is a directory with proper structure | 13:28 |
pigmej | you can add stuff there without using repository module at all | 13:28 |
pigmej | not that I recommend it or so, but .. :) | 13:28 |
YorikSar | BTW, why didn't that idea about storing repos in DB itself didn't fly? | 13:30 |
pigmej | because it would mean that we will somehow store files inside database | 13:31 |
pigmej | like puppet manifests etc, it could be complicated to maintain etc | 13:32 |
YorikSar | Well... Just add a FUSE on top of DB - and it becomes simple! :) (j/k) | 13:33 |
pigmej | yeah I know | 13:34 |
pigmej | ;P | 13:34 |
pigmej | I even wanted to do it :P | 13:37 |
pigmej | YorikSar: just ignore this fact for now, maybe we will figure out something smarter in future :) | 13:37 |
pigmej | dshulyak: https://review.openstack.org/#/c/274634/ review it please :) | 13:39 |
YorikSar | My main consern here is that we need to provide some API that clients should be able to use later. | 13:39 |
pigmej | well, for now soalr is a library | 13:40 |
pigmej | we will have some HTTP API | 13:40 |
pigmej | but yeah, that is my concern too | 13:40 |
*** tzn has quit IRC | 13:44 | |
*** tzn has joined #openstack-solar | 13:47 | |
openstackgerrit | Lukasz Oles proposed openstack/solar: Set StrictHostKeyChecking=no during jenkins tests https://review.openstack.org/275218 | 13:53 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Set StrictHostKeyChecking=no during jenkins tests https://review.openstack.org/275218 | 13:55 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Preinstall more stuff on an image https://review.openstack.org/275180 | 13:56 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Use overlay images, it speedups tests https://review.openstack.org/275062 | 13:56 |
dshulyak | pigmej: are you sure that this is not used anywhere https://review.openstack.org/#/c/274634/3/solar/cli/__init__.py ? | 13:57 |
pigmej | dshulyak: in this file it's not | 13:57 |
pigmej | you mean that session ? | 13:58 |
pigmej | it's not, it's certainly not, it's old, because some time ago just import was enough | 13:58 |
pigmej | then you need still to make_all() | 13:58 |
pigmej | or something like that | 13:58 |
dshulyak | pigmej: yes, session, previously it was called on import? | 13:58 |
pigmej | yup | 13:58 |
dshulyak | ok | 13:58 |
pigmej | like very previously | 13:58 |
pigmej | then we moved some stuff, refactored but this line was still there | 13:59 |
pigmej | I think salmon_ discovered it when he saw that update is not working on sqlite | 13:59 |
pigmej | becasue of session;) | 13:59 |
pigmej | dshulyak: https://review.openstack.org/#/c/274642/ this is ready ? | 14:00 |
salmon_ | yeah, it was nice bug :D | 14:00 |
salmon_ | like just before release | 14:01 |
pigmej | I'm not sure if 'nice' is correct word there :P | 14:01 |
dshulyak | yes, docs patch is ready, maybe i should add ‘How to write extension’ but it is not easy job, so i would prefer to do it a later :) | 14:02 |
salmon_ | I will review it today | 14:02 |
pigmej | dshulyak: lol :D | 14:03 |
pigmej | btw guys I think before 0.2 we should somehow cover more examples or explain inputs connections | 14:03 |
pigmej | because I suppose it's magic for any newcomer | 14:03 |
openstackgerrit | Merged openstack/solar: Removed all __init__ files from pep8 ignore https://review.openstack.org/274634 | 14:03 |
salmon_ | for sure we need cli example | 14:03 |
pigmej | salmon_: you can do it! I believe in you :) | 14:04 |
salmon_ | after jenkins :P | 14:04 |
pigmej | for you everything is 'after jenkins' :P | 14:04 |
salmon_ | "It takes too long" ;) | 14:04 |
pigmej | then speed++ :P | 14:04 |
salmon_ | waiting for gerrit now | 14:05 |
pigmej | salmon_: http://imgs.xkcd.com/comics/compiling.png | 14:06 |
salmon_ | yup | 14:06 |
pigmej | we literaly did it when we were releasing 0.1 ;D | 14:06 |
*** tzn has quit IRC | 14:07 | |
*** tzn has joined #openstack-solar | 14:07 | |
salmon_ | dshulyak: can you workflow +1 here https://review.openstack.org/#/c/275180/2 ? | 14:27 |
openstackgerrit | Merged openstack/solar: Set StrictHostKeyChecking=no during jenkins tests https://review.openstack.org/275218 | 14:28 |
dshulyak | salmon_: added | 14:29 |
openstackgerrit | Merged openstack/solar: Preinstall more stuff on an image https://review.openstack.org/275180 | 14:32 |
YorikSar | Now we have dshulyak's approval on typo in comments :) | 14:33 |
salmon_ | dshulyak: thx | 14:36 |
pigmej | what typo ?:D | 14:38 |
YorikSar | > # pre install solare requirements | 14:44 |
YorikSar | Solare - sounds french :) | 14:45 |
pigmej | it's not even first typo that we commited ;P | 14:45 |
pigmej | not that I'm proud of it... | 14:45 |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: [WIP] Use oslo.config https://review.openstack.org/275241 | 14:48 |
pigmej | dshulyak: does oslo.config support ENV ? | 14:49 |
dshulyak | i will check source a bit later, but i wasnt able to find it in documentation | 14:51 |
pigmej | but it should be possible to add logic for it | 14:51 |
dshulyak | i tried to play around sys.argv :) in order to allow nested parsers and i dont like it completetly | 14:51 |
pigmej | ;D | 14:52 |
dshulyak | it looks like total s.. | 14:52 |
pigmej | hehe ;D | 14:53 |
dshulyak | maybe openstack clients solved it somehow, i need to take a look | 14:53 |
pigmej | btw do we need command line config ? | 14:54 |
dshulyak | it would be good to expose atleast basic options, like config-file | 14:55 |
pigmej | yeah | 14:56 |
pigmej | this one yup | 14:56 |
pigmej | :) | 14:56 |
*** salmon_ has quit IRC | 14:56 | |
*** salmon_ has joined #openstack-solar | 14:59 | |
*** angdraug has joined #openstack-solar | 14:59 | |
openstackgerrit | Lukasz Oles proposed openstack/solar: Do not use archive mode. It copies owner and perms https://review.openstack.org/275273 | 15:36 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Do not use archive mode. It copies owner and perms https://review.openstack.org/275277 | 15:38 |
pigmej | salmon_: you did it again | 15:39 |
salmon_ | what? | 15:39 |
pigmej | https://review.openstack.org/275277 + https://review.openstack.org/275273 | 15:39 |
salmon_ | wuut | 15:40 |
salmon_ | grr | 15:40 |
pigmej | ;D | 15:40 |
salmon_ | pigmej: use this one https://review.openstack.org/#/c/275277/ | 15:40 |
pigmej | you're the master of abanddoned patches | 15:40 |
pigmej | ah, so you abbandoned the one with + from me? | 15:40 |
salmon_ | yup | 15:41 |
pigmej | salmon_: .... :P | 15:41 |
pigmej | suboptimal | 15:41 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Do not use archive mode, it copies owner and perms https://review.openstack.org/275277 | 16:24 |
pigmej | dshulyak: hmmm | 16:43 |
pigmej | Total Delta: -2908862385.56 | 16:43 |
pigmej | Total Time: 8.16077613831 | 16:43 |
pigmej | :D | 16:43 |
dshulyak | pigmej: restart? | 16:43 |
pigmej | nope | 16:44 |
pigmej | loooooooooong time between process and run-once | 16:44 |
dshulyak | it doesnt affect | 16:45 |
pigmej | after all tasks were finished I have had | 16:45 |
pigmej | wrr | 16:45 |
pigmej | Total Delta: 20.3823788166 | 16:45 |
pigmej | Total Time: 11.2949230671 | 16:45 |
pigmej | but in the middle of report I had this weird thingy | 16:45 |
dshulyak | it looks corect | 16:45 |
dshulyak | yeah | 16:45 |
dshulyak | can you create a bug :) ? | 16:45 |
dshulyak | i will take a look when it will be clear whats with that hcf | 16:46 |
pigmej | I can :) | 16:46 |
pigmej | dshulyak: ok | 16:46 |
salmon_ | jenkins is dead? | 17:00 |
pigmej | salmon_: jenkins is lazy | 17:02 |
pigmej | check zuul status | 17:03 |
pigmej | some solar tasks are pending for more than 2h | 17:03 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Ansible 2.0 support in ansible handlers https://review.openstack.org/275325 | 17:03 |
pigmej | it works BUT after we merge this we need https://bugs.launchpad.net/solar/+bug/1541016 | 17:04 |
openstack | Launchpad bug 1541016 in Solar "Share more code between ansible handlers" [Undecided,New] | 17:04 |
pigmej | hmm salmon_ should I remove ansible 1.9 and replace it with 2.0 there ? | 17:05 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Ansible 2.0 support in ansible handlers https://review.openstack.org/275325 | 17:06 |
pigmej | I removed it | 17:06 |
salmon_ | where? | 17:10 |
pigmej | I would show you, but gerrit returns 502 | 17:11 |
pigmej | so you need to believe me | 17:11 |
pigmej | but the url should be like: https://review.openstack.org/#/c/275325/2/requirements.txt | 17:11 |
pigmej | and https://review.openstack.org/#/c/275325/2/bootstrap/playbooks/files/ubuntu-ansible.sh | 17:11 |
salmon_ | ah, it's ok now | 17:16 |
openstackgerrit | Merged openstack/solar: Do not use archive mode, it copies owner and perms https://review.openstack.org/275277 | 17:30 |
pigmej | ok you jenkins... :) | 17:30 |
pigmej | what a surprise at the very end of a workday :D | 17:30 |
pigmej | salmon_: ^ | 17:30 |
*** openstackgerrit has quit IRC | 17:32 | |
*** openstackgerrit has joined #openstack-solar | 17:32 | |
*** salmon_ has quit IRC | 17:43 | |
*** salmon_ has joined #openstack-solar | 17:44 | |
*** tzn has quit IRC | 18:06 | |
*** angdraug has quit IRC | 18:31 | |
*** tzn has joined #openstack-solar | 18:47 | |
*** tzn has quit IRC | 18:48 | |
*** angdraug has joined #openstack-solar | 18:50 | |
*** YorikSar_ has joined #openstack-solar | 19:07 | |
*** YorikSar has quit IRC | 19:12 | |
openstackgerrit | Lukasz Oles proposed openstack/solar: Set correct user for /vagrant/solar-resources dir https://review.openstack.org/275396 | 20:13 |
salmon_ | pigmej: dshulyak ^ ;) | 20:15 |
*** dshulyak has quit IRC | 20:37 | |
openstackgerrit | Merged openstack/solar: Set correct user for /vagrant/solar-resources dir https://review.openstack.org/275396 | 20:45 |
*** salmon_ has quit IRC | 20:55 | |
*** salmon_ has joined #openstack-solar | 20:55 | |
openstackgerrit | Lukasz Oles proposed openstack/solar: Disable host key checking for whole 10.0.0.0 net https://review.openstack.org/275410 | 21:11 |
*** tzn has joined #openstack-solar | 21:16 | |
openstackgerrit | Merged openstack/solar: Disable host key checking for whole 10.0.0.0 net https://review.openstack.org/275410 | 21:31 |
*** tzn has quit IRC | 23:18 | |
*** salmon_ has quit IRC | 23:42 | |
*** tzn has joined #openstack-solar | 23:44 | |
*** tzn has quit IRC | 23:45 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!