| *** tzn has quit IRC | 00:58 | |
| *** angdraug has quit IRC | 01:07 | |
| *** openstackgerrit has quit IRC | 07:47 | |
| *** openstackgerrit has joined #openstack-solar | 07:47 | |
| *** tzn has joined #openstack-solar | 08:00 | |
| *** salmon_ has joined #openstack-solar | 08:19 | |
| pigmej | hello:) | 08:21 |
|---|---|---|
| *** tzn has quit IRC | 08:29 | |
| *** salmon_ has quit IRC | 09:26 | |
| *** salmon_ has joined #openstack-solar | 09:26 | |
| *** tzn has joined #openstack-solar | 09:45 | |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Added waiters instead of sleep in Lock https://review.openstack.org/277915 | 09:57 |
| pigmej | salmon_: ^ | 09:57 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Added waiters instead of sleep in Lock https://review.openstack.org/277915 | 10:28 |
| pigmej | so the problem with composer + jinja2 is | 10:39 |
| evgenyl | pigmej: have no idea what the composer is :) | 10:40 |
| pigmej | that we need python values in block tags and yaml version of all variables when jinja renders it | 10:40 |
| pigmej | evgenyl: composer is new name for virtual resource | 10:40 |
| evgenyl | pigmej: oh, ok. | 10:40 |
| pigmej | it's a yaml file with resource definition that can genreate more resources | 10:40 |
| pigmej | and the problem is that for now, when you let's say do x = None jijna will put it as x: None into yaml | 10:41 |
| pigmej | which then results x = 'None' in resource | 10:41 |
| pigmej | so we need something like jinja autoescape but instead of escaping it should yaml.dump result | 10:41 |
| pigmej | the only way that I know would be monkey patch autoescape from jinja ;D | 10:45 |
| pigmej | salmon_: ok, we left with: | 10:51 |
| pigmej | - ugly hack around jinja2 autoescape feature | 10:51 |
| pigmej | - get rid of jinja2 in flavour of other template engine | 10:51 |
| pigmej | and because we don't use like 95% functions of jinja I tend to second option | 10:52 |
| salmon_ | what other template engine? | 10:53 |
| pigmej | *any* that will have what we need :) | 10:54 |
| salmon_ | is there any? | 10:56 |
| pigmej | I will try to reach mitsuhiko and maybe somehow he will have some news for us | 10:56 |
| salmon_ | ok | 10:56 |
| pigmej | salmon_: I know some, I wrote one :P But I would prefer some already released thingy | 10:56 |
| salmon_ | We need to know it before release | 10:56 |
| pigmej | the problem is that autoescape logic is hardcoded | 10:56 |
| pigmej | we need something like autoescape logic but different | 10:57 |
| pigmej | salmon_: for release I will try to monkeypatch | 10:57 |
| salmon_ | I would prefer to have it ready before :P | 10:59 |
| pigmej | changed templating language ? | 11:00 |
| salmon_ | yup | 11:01 |
| *** tzn has quit IRC | 12:04 | |
| *** tzn has joined #openstack-solar | 12:05 | |
| pigmej | ok I failed with jinja, it's very complicated to work with it on this level | 12:06 |
| pigmej | it seems not well suited for our needs | 12:06 |
| *** tzn has quit IRC | 12:18 | |
| *** tzn has joined #openstack-solar | 12:32 | |
| *** tzn has quit IRC | 12:36 | |
| *** tzn has joined #openstack-solar | 12:36 | |
| mkwiek | hi! just one small thing regarding the docs - vagrant v 1.7 doesn't seem to work with virtualbox 5.x (at least on OSX). Should I file a pull request that will change required vagrant version? | 12:48 |
| pigmej | mkwiek: is it higher ? | 12:50 |
| mkwiek | I tried with vagrant 1.8 and "vagrant up" went much farther than before :D | 12:50 |
| pigmej | hmm, | 12:51 |
| pigmej | (solar)❯ vagrant --version solar/git/master ! | 12:51 |
| pigmej | Vagrant 1.8.1 | 12:51 |
| pigmej | that is possible :P | 12:51 |
| salmon_ | vagrant --version | 12:51 |
| salmon_ | Vagrant 1.7.4 | 12:51 |
| salmon_ | :P | 12:52 |
| pigmej | mkwiek: you can use libvirt backend | 12:52 |
| salmon_ | pigmej: on Mac? | 12:52 |
| pigmej | ah fuck... :d | 12:52 |
| salmon_ | mkwiek: what errod did you get? | 12:52 |
| mkwiek | I had 1.7.2 previously | 12:52 |
| salmon_ | *error | 12:52 |
| pigmej | 1.7.2 is too old afair, 1.7.4 is needed | 12:52 |
| mkwiek | docs say '1.7.x' :D | 12:53 |
| pigmej | docs say a lot of things.... ;P | 12:53 |
| pigmej | but well, we all have linux... | 12:53 |
| mkwiek | should I switch? | 12:54 |
| pigmej | well, it would be cool to have working env on Mac, so if you want to fix some stuff for mac then probably it's good idea to stay with Mac for a while :D | 12:54 |
| pigmej | but yeah, I also wonder what was the error | 12:54 |
| mkwiek | after I updated virtualbox to 5.x (I had 4.3) it just said that vagrant doesn't support virtualbox higher than 4.3 | 12:55 |
| pigmej | but if you want to play with solar (you should want to :D) then linux may be good choice :) If you have ubuntu or fedora it should work | 12:56 |
| pigmej | then I could be right that we need 1.7.4 :D | 12:56 |
| pigmej | mkwiek: you can fill a bug :) | 12:56 |
| salmon_ | and fix it :) | 12:56 |
| mkwiek | well, I usually play with stuff on virtual machines anyway, so I will see if I can stay on OSX, if not - I will switch | 12:56 |
| mkwiek | cool, thanks guys | 12:57 |
| pigmej | yup but remebmer to fill bug :) | 12:57 |
| pigmej | because, it will be better for you to first understand solar then fix some annoying compatibility bugs :P | 12:57 |
| pigmej | salmon_: I'm pretty sure that solar dev env is broken on windows; P | 12:57 |
| *** tzn has quit IRC | 12:58 | |
| salmon_ | no one checked :) | 12:59 |
| salmon_ | mkwiek: OSx should be ok, just no one tested it there :P | 13:00 |
| mkwiek | I can try it on my Windows box at home :D | 13:00 |
| mkwiek | on the second thought - I'd rather not for now | 13:01 |
| pigmej | ;D | 13:02 |
| openstackgerrit | Maciej Kwiek proposed openstack/solar: Fix Vagrant version requirement in docs. https://review.openstack.org/278351 | 13:03 |
| *** tzn has joined #openstack-solar | 13:07 | |
| *** tzn has quit IRC | 13:07 | |
| *** tzn has joined #openstack-solar | 13:07 | |
| pigmej | mkwiek: you don't want to have -1, isn't it ? | 13:13 |
| pigmej | https://github.com/openstack/solar/blob/master/Vagrantfile#L17 | 13:13 |
| mkwiek | thanks! I will fix that in a minute. anyway, don't hesitate to -1 bad patches :D | 13:14 |
| pigmej | not to the first one! | 13:14 |
| openstackgerrit | Maciej Kwiek proposed openstack/solar: Fix Vagrant version requirement in docs. https://review.openstack.org/278351 | 13:15 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Added waiters instead of sleep in Lock https://review.openstack.org/277915 | 13:24 |
| pigmej | salmon_: I had to fix global Semaphore problem | 13:24 |
| pigmej | logic is the same. | 13:24 |
| openstackgerrit | Merged openstack/solar: Fix Vagrant version requirement in docs. https://review.openstack.org/278351 | 13:38 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Added waiters instead of sleep in Lock https://review.openstack.org/277915 | 14:24 |
| salmon_ | mkwiek: welcome in the contributors team :) | 16:02 |
| pigmej | yup ;) | 16:31 |
| pigmej | I don't wanted to give him -1 :P | 16:32 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Added waiters instead of sleep in Lock https://review.openstack.org/277915 | 17:09 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Added waiters instead of sleep in Lock https://review.openstack.org/277915 | 17:50 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fixes issue with types in composer https://review.openstack.org/278552 | 18:11 |
| pigmej | salmon_: treat it as "hacky solution" but keeping template language + having pretty much the same possibilities... it's the less invasive solution | 18:13 |
| salmon_ | ;( | 18:13 |
| pigmej | I had more invasive solution, like 10 jinja monkey patches | 18:14 |
| pigmej | this one is quite ok in fact, aaa_#{x}# works as expected :) | 18:14 |
| pigmej | same for #{a + 1}# where a is string or int | 18:14 |
| pigmej | jinja lacks possibility is modyfing output without hacks (or at least I was unable to find it), and changing template engine *would* help, but it would also increase learning curve | 18:15 |
| salmon_ | this is also a hack :P | 18:16 |
| pigmej | sure it is | 18:16 |
| pigmej | but: | 18:16 |
| pigmej | a) outside jinja | 18:16 |
| pigmej | b) it doesn't modify jinja at all | 18:16 |
| pigmej | c) it's small :D | 18:16 |
| pigmej | and because we're not exactly sure how the Composer 'language' will look like in product state, I would prefer to not swap template language now, we will make it harder for users | 18:17 |
| pigmej | I agree that this hack is ugly | 18:17 |
| pigmej | but it's the less ugly hack from those that I had ;D | 18:17 |
| *** tzn has quit IRC | 18:23 | |
| *** tzn has joined #openstack-solar | 18:26 | |
| *** tzn has quit IRC | 18:26 | |
| *** tzn has joined #openstack-solar | 18:27 | |
| *** _tzn has joined #openstack-solar | 18:29 | |
| *** tzn has quit IRC | 18:29 | |
| *** _tzn has quit IRC | 19:11 | |
| openstackgerrit | Lukasz Oles proposed openstack/solar: Create separate page for development docs https://review.openstack.org/277832 | 19:58 |
| openstackgerrit | Jedrzej Nowak proposed openstack/solar: Fixes issue with types in composer https://review.openstack.org/278552 | 20:05 |
| pigmej | salmon_: I added tests | 20:07 |
| pigmej | I also commetted your PR :) | 20:07 |
| *** angdraug has joined #openstack-solar | 20:39 | |
| *** tzn has joined #openstack-solar | 20:46 | |
| *** tzn has quit IRC | 20:51 | |
| *** tzn has joined #openstack-solar | 20:51 | |
| openstackgerrit | Merged openstack/solar: Added waiters instead of sleep in Lock https://review.openstack.org/277915 | 21:44 |
| openstackgerrit | Merged openstack/solar: Restructure ansible handlers https://review.openstack.org/277443 | 21:45 |
| *** kun_huang has quit IRC | 21:48 | |
| *** mkwiek has quit IRC | 21:48 | |
| *** mkwiek has joined #openstack-solar | 21:56 | |
| *** kun_huang has joined #openstack-solar | 21:59 | |
| *** YorikSar_ has joined #openstack-solar | 22:19 | |
| *** kun_huang_ has joined #openstack-solar | 22:22 | |
| *** YorikSar has quit IRC | 22:22 | |
| *** kun_huang has quit IRC | 22:22 | |
| *** tzn has quit IRC | 22:22 | |
| *** kun_huang_ is now known as kun_huang | 22:24 | |
| *** salmon_ has quit IRC | 22:29 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!